227 Commits

Author SHA1 Message Date
Pranith Kumar K
6307567a26 cli: check for argument presence before accessing
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1543 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1543
2010-09-06 09:38:11 -07:00
Pranith Kumar K
8432a5bf65 cli: prompt user before remove-brick and stop volume
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1538 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1538
2010-09-06 09:38:07 -07:00
Pranith Kumar K
8d64ca70b4 cli: Only admin should run gluster CLI
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1546 (gluster commandline should be available only for super user)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1546
2010-09-06 09:38:04 -07:00
Pranith Kumar K
698ff066c1 cli: Print volume type None as Distribute
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1535 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1535
2010-09-06 09:38:00 -07:00
Pranith Kumar K
84f3595373 cli: stripe/replica count should be greater than 1
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1534 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1534
2010-09-06 09:37:57 -07:00
Pranith Kumar K
c7c5a784c8 cli: In volume create check for presence of bricks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1532 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1532
2010-09-06 09:37:52 -07:00
Pranith Kumar K
e807464de5 cli: print volume info cmd usage in case of parse errors
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1533 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1533
2010-09-06 09:37:48 -07:00
shishir gowda
386ea89d93 Create volume adding transport type option rdma
Adding transport type option to cli volume create command.
This is optional, and defaults to TCP. The other transport
supported is rdma

Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1507 (need to add 'transport <type>' options to create brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1507
2010-09-06 02:21:44 -07:00
shishir gowda
4309c9b0d6 Add brick hostname should not be localhost
Add brick hostname should not be localhost or 127.0.0.1, but valid
 nodeid or ip. This will prevent volfiles being generated at
 respective glusterd's as hostname would be localhost

Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1505 (volume create/add-brick requires ip or hostname for localhost)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1505
2010-09-06 02:21:40 -07:00
shishir gowda
4c87d30724 Volume create hostname should not be localhost
volume create hostname should not be localhost or 127.0.0.1. It
 should be a valid nodeid or ip. This will prevent invalid vol
 files being created on glusterd's when localhost or 127.0.0.1 is
 specified

Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1505 (volume create/add-brick requires ip or hostname for localhost)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1505
2010-09-06 02:21:36 -07:00
Vijay Bellur
1fb0d35691 cli: Display proper message when no volumes are present
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
2010-09-05 22:28:25 -07:00
Vijay Bellur
dba7332557 cli: Add support for GET volume
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
2010-09-05 06:27:24 -07:00
shishir gowda
eef8162e92 Hiding add-brick/remove-brick type option
Currently add-brick and remove-brick type option of replica/stripe
along with count does not change the behaviour. Hiding the usage
options.

Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1528 (Hide type option for add-brick and remove brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1528
2010-09-04 04:17:14 -07:00
Sachidananda
cc8e13e389 cli: Fix clang errors.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1145 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1145
2010-09-03 08:08:09 -07:00
Pranith Kumar K
3e5c243396 cli, mgmt/glusterd: Added replace brick cli response
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1322 (Replace brick should show status of paused and abort states)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1322
2010-09-02 05:17:11 -07:00
Vijay Bellur
ea86a09143 cli: Changes for GET_NEXT volume info
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1255 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1255
2010-09-02 03:28:39 -07:00
shishir gowda
4c5e364c36 Remove brick validation
Added checks for duplicate bricks in cli arguments, valid bricks
for the volume, valid volume name, and prevent removing of incorrect
 pairs for replica.

Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1486 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1486
2010-09-02 03:12:25 -07:00
Amar Tumballi
c9d43f4028 fixes in 'gluster volume rebalance'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1481 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1481
2010-08-31 10:49:45 -07:00
Amar Tumballi
6530488a49 'gluster volume log' feature added
* 'gluster volume log filename <VOLNAME> [BRICK] <path>'
* 'gluster volume log locate <VOLNAME> [BRICK]'
* 'gluster volume log rotate <VOLUME> [BRICK]'

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
2010-08-31 10:49:40 -07:00
Pavan Sondur
1a10524615 mgmt/glusterd: Return replace-brick status
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1322 (Replace brick should show status of paused and abort states)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1322
2010-08-30 22:47:29 -07:00
shishir gowda
baebaab459 Volume Add-brick validation for exports
Added checks for export already in use, duplicate exports in command,
and check whether exports are valid.

Also, cleaned up error handling in glusterd_handle_add_bricks
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1457 (volume add brick validation for export)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1457
2010-08-30 02:52:22 -07:00
Pranith Kumar K
157560b6dc cli, mgmt/glusterd: added volume stop <VOLNAME> force functionality
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1361 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1361
2010-08-28 04:56:11 -07:00
Pranith Kumar K
c971568333 cli, mgmt/glusterd: validate brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
2010-08-27 02:26:22 -07:00
Pranith Kumar K
228d11a9c9 cli: command parse validation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1431 (cli: check if arguments exist before the accessing them)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1431
2010-08-27 02:15:31 -07:00
shishir gowda
af7b57b309 Cli volume create detect dup bricks
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1184 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1184
2010-08-26 07:31:02 -07:00
shishir gowda
fabb7e5e5d Cli volume add-brick validation
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1440 (volume add brick validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1440
2010-08-26 07:30:54 -07:00
shishir gowda
7c7219fd88 Cli volume create validation
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1185 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1185
2010-08-26 00:09:17 -07:00
Pranith Kumar K
c83b6f73f0 cli: print usage message when parsing of cmd fails
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1432 (print usage string in case of command parse errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1432
2010-08-25 02:08:50 -07:00
Pranith Kumar K
606cf3e291 cli: check if the arguments are present before accessing
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1431 (cli: check if arguments exist before the accessing them)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1431
2010-08-25 02:08:47 -07:00
Kaushik BV
a0c874f09e Help Added to the Gluster-CLI for all sub commands (some deletions in the old patch)
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1156 (gluster --help should display all the options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1156
2010-08-25 02:08:43 -07:00
Pranith Kumar K
36ae62ada8 cli: print volume create command usage in-case of parse errors
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1263 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1263
2010-08-25 00:41:54 -07:00
Pranith Kumar K
29a9b19014 cli: validating if the arguments exist before accessing in volume create
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1202 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1202
2010-08-25 00:41:48 -07:00
shishir gowda
c2518242ed Hide cli peer command port option
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1261 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1261
2010-08-21 05:16:57 -07:00
Vijay Bellur
1fd482cae7 cli: Fix issues in non readline mode
Signed-off by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1300 (gluster core dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1300
2010-08-19 11:23:57 -07:00
shishir gowda
82cea51089 Probe should not probe for existing friend
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1331 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1331
2010-08-19 09:50:23 -07:00
shishir gowda
074f03afb2 Probe on localhost not needed
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1216 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1216
2010-08-19 09:50:19 -07:00
Raghavendra Bhat
4cefe9c27b Modify the help message for volume create
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1229 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1229
2010-08-18 06:55:51 -07:00
Pranith Kumar K
c8e411f2c4 changed GNU General Public License to GNU Affero General Public License
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1388 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1388
2010-08-17 11:18:23 -07:00
Vijay Bellur
c0dfd78679 cli: block command hang
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1370 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1370
2010-08-17 11:18:15 -07:00
Raghavendra Bhat
ab72e06f7b volume creation validation
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1267 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1267
2010-08-17 02:24:07 -07:00
Raghavendra Bhat
8bc0ae1621 Do not allow all to be a volume name while creating volume
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1209 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1209
2010-08-17 02:24:03 -07:00
Vijay Bellur
e573754607 cli: Implement help command
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1229 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1229
2010-08-17 02:23:59 -07:00
Pavan Sondur
5065b0824e mgmt/glusterd: cli: Various fixes for replace brick.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1304 (Free state info for replace brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1304
2010-08-16 01:49:04 -07:00
Pavan Sondur
659e2d938f cli: Cleanup replace brick operations.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1304 (Free state info for replace brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1304
2010-08-16 01:49:00 -07:00
Pavan Sondur
fa71c7ff9d cli: Cleanup replace-brick cli call.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1303 (Cleanup replace-brick state info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1303
2010-08-16 01:48:51 -07:00
Amar Tumballi
c87c868f40 'gluster peer *' enhancement
now 'gluster probe' will be 'gluster peer probe' and
'gluster detach' will be 'gluster peer detach'.

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1291 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1291
2010-08-15 11:28:45 -07:00
Amar Tumballi
57af0c92e3 gluster create volume: cli validation added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1267 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1267
2010-08-13 11:25:28 -07:00
Amar Tumballi
b2925e78a5 cli cmd validation
* check buffer/stack overwrite if there is large number of argument to
  gluster command

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1265 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1265
2010-08-13 04:41:28 -07:00
Amar Tumballi
d502952cbe fix in cli notify
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1345 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1345
2010-08-12 23:39:08 -07:00
Vijay Bellur
fe38de5362 cli: Use appropriate conversion for deprobe resp
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1215 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1215
2010-08-11 23:46:53 -07:00