Commit Graph

6 Commits

Author SHA1 Message Date
Emmanuel Dreyfus
5b6be1cdb5 One more missing change :-/
Change-Id: I6eeaee73e7c9124a1959acb2fe47d5cad3a3baac
Reviewed-on: http://review.gluster.com/225
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-08-12 01:31:41 -07:00
Emmanuel Dreyfus
9fa3aeadfe Use bourne shell, fix error in previous commit
Change-Id: Id2a304d5090eb2564c5d56ea260fa53b9b17d0d5
Reviewed-on: http://review.gluster.com/223
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-08-12 01:04:49 -07:00
Emmanuel Dreyfus
cc756d0075 sed -i is available from GNU sed, but is not portable. Output to a new
file and move it to the original one on success instead.

Change-Id: Ib23dd9becd035054e6490dcb4d64b3f9eff89bf4
Reviewed-on: http://review.gluster.com/212
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-08-11 23:43:55 -07:00
Csaba Henk
2c068a98e4 gerrit: add a dry-run mode to rfc script
With DRY_RUN=1, rfc.sh will not perform the git push just display
the push command. This can be useful if one wants to give a final
review for the submitted change list (check for typos, misplaced bug
id-s) or if one is offline.

Change-Id: I90e2016ba78e2a0ecf37044b3db0277a25914f77
BUG: 3234
Reviewed-on: http://review.gluster.com/87
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-07-23 09:09:43 -07:00
Csaba Henk
434da60ba4 gerrit: some fixes for the rfc script
In rebase_changes():

- Using "--all" for git fetch is bogus: the scope of this quantification is not
  over the tracked refs of the upsteam repo (which we do want, but that kind
  of universal quantification is already implied by the notion of "tracking"),
  but over the set of all the registered remotes, which is an annoying side effect.

- $EDITOR is weaker than the git configuration settings. For the purpose of the
  script, we need to override any kind of setting, and that can be done
  via $GIT_EDITOR.

Cf. git-fetch(1), git-commit(1).

Change-Id: Ia91ee5c4d42dce9248f26f7697528e3c97355871
BUG: 3234
Reviewed-on: http://review.gluster.com/86
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-07-23 09:07:58 -07:00
Anand Avati
fbe8cc85a1 s/Patchwork/Gerrit/
Change-Id: I3d2e0c081cce5c69a6a168ddd0d850cdba84f53e
2011-07-18 16:06:59 +05:30