124 Commits

Author SHA1 Message Date
Anand Avati
d41eda762e rpc-clnt: fix merge error of http://review.gluster.com/248
cherrypicked patch did not have the logic to reset port number to
reconnect to glusterd.

Change-Id: I78c903d5a28626f83b5024bd323e77b5f159e374
BUG: 3409
Reviewed-on: http://review.gluster.com/254
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
2011-08-17 23:03:18 -07:00
Anand Avati
cef6d3596f rpc-clnt: perform XDR encoding in unlocked region
Change-Id: Ia11c3ced4bec5959a5f0d8fcd4c6070b2ead220a
BUG: 3409
Reviewed-on: http://review.gluster.com/248
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-08-17 21:01:56 -07:00
Pranith Kumar K
b58dc65f2a Change Copyright current year
Change-Id: I2d10f2be44f518f496427f257988f1858e888084
BUG: 3348
Reviewed-on: http://review.gluster.com/200
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-08-10 10:57:19 -07:00
krishna
1b5a860f15 pass xlator pointer to rpcsvc_init() so that it can init svc->mydata to xlator
Change-Id: Icfd95cc67400c16a951d6a9f922fbdc07f40c5b6
BUG: 3314
Reviewed-on: http://review.gluster.com/180
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
2011-08-09 02:12:03 -07:00
Pranith Kumar K
0cf100b58c LICENSE: s/GNU Affero General Public/GNU General Public/
Change-Id: I3914467611e573cccee0d22df93920cf1b2eb79f
BUG: 3348
Reviewed-on: http://review.gluster.com/182
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-08-06 06:33:52 -07:00
shishir gowda
76acac485b IOBUF: Bring in variable iobuf support
Rebasing Raghavendra's patch to master

Change-Id: Ie7a0c9a7b8e73cfe48c4573a5153460d5126208e
BUG: 2472
Reviewed-on: http://review.gluster.com/12
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-07-31 23:15:15 -07:00
krishna
6c7a89321a RPC unify code change
Change-Id: Ibe18a2a63fd023ac57652c4dfc8ac8a69d983b83
BUG: 3112
Signed-off-by: krishna <krishna@gluster.com>
Reviewed-on: http://review.gluster.com/116
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
2011-07-29 03:37:07 -07:00
Amar Tumballi
58ccea4401 rpc: in client connection init(), return the proper error code
without the proper error code, rpc won't know if transport is successfully
loaded or not.

Change-Id: Idc3ad56d2f47cf1e81ba39f90a7f7b47305d7d9a
BUG: 3260
Reviewed-on: http://review.gluster.com/112
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
2011-07-27 02:14:37 -07:00
shishir gowda
65cc08d80d glusterd: Add bind-insecure xlator-option for glusterd
This is required if the number of connections from the glusterd
increases.

Change-Id: Iff78773f593a8bfae13ec9eec52c5a67ea936ef2
BUG: 3142
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/11
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pavan T C <tcp@gluster.com>
2011-07-24 11:45:14 -07:00
Gaurav
f50e5eb777 Glusterd: IPV6 support for glusterfs.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2456 (IPv6 support for glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2456
2011-07-14 01:31:36 -07:00
Vishwanath
83d1f9642e spelling corrections in glusterfs code
Signed-off-by: Vishwanath S Bhat <vishwanath@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2903 (Last spelling errors in source code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2903
2011-06-23 21:50:20 -07:00
Gaurav
58cf35b353 CLI : Display possible options in proper format.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2598 (Volume access option suceeds with any string value)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2598
2011-06-19 20:41:27 -07:00
Amar Tumballi
0101eb0b64 logging: fill proper domain names at places where it is missing
also changed some error messages where it was not explicit

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
2011-06-16 22:02:13 -07:00
Amar Tumballi
e1aa1e0e20 rdma: fix the excessive logs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
2011-06-16 09:15:39 -07:00
Gaurav
793aba82fa RPC : Valid typecasting for ipv4 and ipv6 in rpcsvc_get_listener_port.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2956 (Invalid typecating for ipv4 and ipv6 in rpcsvc_get_listener_port.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2956
2011-05-31 05:11:14 -07:00
Anand Avati
b0c07f4db5 rpc: NetBSD portability fixes
NetBSD's <dirent.h> does a #defiine d_ino d_fileno. Since glusterfs
declares structs with d_ino members, we must include <dirent.h> early
so that d_ino get preprocessed into d_fileno conssitently.

Also define proper xdr types for NetBSD.

Thanks to: Emmanuel Dreyfus <manu@netbsd.org>

Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
2011-05-30 04:49:03 -07:00
Anand Avati
7f1c2eb4d4 rpc: use AI_ADDRCONFIG selectively
NetBSD does not have AI_ADDRCONFIG. This patch has a side effect: glusterfsd
listens on IPv6 adresses only by default. Option transport.socket.bind-address
in volume server-tcp must be used to listen on an IPv4 address.

Thanks to: Emmanuel Dreyfus <manu@netbsd.org>

Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
2011-05-30 04:48:25 -07:00
Amar Tumballi
dd55755e0c rpc-clnt: consider the (re-)configured port for only one connect() call
this way, if remote_port is set due to queryport, that can fall back
to default port (or 'option remote-port' value) when it disconnects.

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2709 (issues with port (re-)configuration in client protocol)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2709
2011-05-30 02:08:07 -07:00
Venky Shankar
2cd8411a02 cli log level command and per translator log level
Signed-off-by: Venky Shankar <venky@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2714 (implement cli log level command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2714
2011-05-20 11:01:49 -07:00
shishir gowda
357df32e16 Introduce client-allow-insecure xlator-option.
Allows glusterfs clients to bind to any port and does not restrict it
to 1024.

This is a xlator-option only, and is not supported in volume set cmd.
The reason is, few clients may choose this, and few may not. Hence
only supported as a xlator-option during mount time.

For this to work with glusterfs, server.allow-insecure should be set
to on

Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2868 (Add xlator-option to support insecure-bind for clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2868
2011-05-12 09:29:21 -07:00
Csaba Henk
184fba3788 cli: implement "system:: getwd" command
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
2011-04-19 02:30:18 -07:00
Pranith Kumar K
7cf0dbcd30 mgmt/glusterd: Remove excessive INFO logs
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>

BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
2011-04-13 01:04:11 -07:00
Pavan T C
b65f54c9aa Loosen restrictions on hostnames
Signed-off-by: Pavan T C <tcp@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2249 (Problems with hostname validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2249
2011-03-29 04:14:35 -07:00
Pranith K
3f37921807 rpc: Provide an option to allow insecure ports
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
2011-03-26 08:38:55 -07:00
Gaurav
9bd4f25b6b CLI : Validate options farmework.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2064 (NFS options are removed upon glusterd restart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2064
2011-03-23 04:55:29 -07:00
Amar Tumballi
6167c66758 spelling errors fixed across the code base
recieve -> receive
maintainence -> maintenance
verison -> version
commited -> committed

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2262 (Spelling errors in source)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2262
2011-03-22 04:02:10 -07:00
Amar Tumballi
d4aae8327a rpc/rpc-lib : log enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
2011-03-17 11:57:43 -07:00
Amar Tumballi
abc2a6b0b9 glusterfsd: log enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
2011-03-17 11:57:39 -07:00
shishir gowda
3d1fc9ebe2 TOP: cli, rpc/xdr related changes
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2516 (Implement gluster volume top command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2516
2011-03-16 02:35:30 -07:00
Mohammed Junaid Ahmed
8221c3cae1 rpc: QUOTA rpc related changes.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
2011-03-16 00:04:44 -07:00
Pranith K
34bf8de743 mgmt/glusterd: gluster profile implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
2011-03-10 08:09:47 -08:00
Pranith K
d23585307a rpc: Changes for handling unix domain sockets avoid race
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
2011-03-10 08:09:30 -08:00
Gaurav
731f07378b RPC : Sending error reply on decodong failure.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2435 (Not able to send error reply in rpcsvc.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2435
2011-03-01 02:06:00 -08:00
Amar Tumballi
bf73fd2d8d glusterd: separate out cli specific programs and mgmt specific programs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
2011-03-01 02:05:51 -08:00
Raghavendra G
46c69ec62d rpcsvc: Handle more than one payload vectors.
- fops like write can recieve payload data in more than one vector. This can
    happen with write-behind being loaded on client side.

Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2454 (rdma data corruption)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2454
2011-02-28 23:40:36 -08:00
Mohammed Junaid Ahmed
2e81c881f0 gsync: cli support for gsyncd.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
2011-02-10 22:18:06 -08:00
Raghavendra G
ffbbb6a170 rpc/rpc-clnt: don't access rpcreq after putting the struct back into mem-pool.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2335 (Segmentation fault in saved_frames_unwind)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2335
2011-02-07 11:32:57 -08:00
Sachidananda
066b180987 Move hostname, ip address validating functions to libglusterfs.
hostname and ip address validation functions are duplicated in several
source files. Move them to libglusterfs.

Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2249 (Problems with hostname validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2249
2011-01-27 12:18:05 -08:00
Amar Tumballi
11dd59b788 rpc: handle proper 'ref', 'unref' of transport from rpc-clnt
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2250 ([glusterfs-3.1.2qa2]: SegFault in rpc-clnt.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2250
2011-01-26 23:42:28 -08:00
Raghavendra G
aaad9c6f6e rpc: fix format string mismatches in invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
2010-12-12 23:38:43 -08:00
Raghavendra G
40e1d36416 rpcsvc: while handling transport-cleanup event look for listener with transport trans->listener instead of trans.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2208 (transport cleanup event is not sent to programs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2208
2010-12-10 02:51:19 -08:00
Raghavendra G
c56b9967a3 rpc-transport: don't merge payload iobuf and iobuf which holds program header into single iobref.
- io-cache holds a reference on iobref passed from transport layer. Hence,
   two iobufs are accounted instead of one in calculated used cache size.

Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2135 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2135
2010-11-25 00:34:09 -08:00
Amar Tumballi
61a8945649 rpc-clnt: add check for NULL argument for rpc_clnt_start
prevents crash when rpc_clnt_start is called before init

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2122 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2122
2010-11-18 05:55:47 -08:00
Anand Avati
8faf940c00 rpc-clnt: introduce new way of creating rpc-clnt objects
rpc_clnt_new() creates a new passive rpc clnt object.

rpc_clnt_start() triggers the connection/reconnection from the object.

rpc_clnt_init() - the old way - still works.

Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2078 (Volume Migration is not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2078
2010-11-16 06:35:10 -08:00
Anand Avati
15d56782ae rpc-clnt: move rpc_clnt_reconnect() call to rpc_clnt_init
Previously rpc_clnt_reconnect() was called inside rpc_clnt_connection_init
which in turn was called from rpc_clnt_init. This change makes
rpc_clnt_connection_init re-usable for the next patch

Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2078 (Volume Migration is not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2078
2010-11-16 06:35:05 -08:00
Shehjar Tikoo
015b08d64d rpc-lib: Fail auth-unix if more than 16 gids found
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2045 (Write permission denied for non-primary group membership)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
2010-11-16 04:44:10 -08:00
Shehjar Tikoo
36f696c7db rpc-lib: Copy auxiliary GIDs into request from de-XDRed buffer
Fixes a problem where secondary groups are not accounted for in
permission checks.

Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 2045 (Write permission denied for non-primary group membership)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
2010-11-16 04:44:06 -08:00
Raghavendra G
681d7d3aa9 rpc/rpc-lib: don't build libgfrpc as a module.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1427 (libgfrpc.so is not portable)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1427
2010-11-10 20:07:30 -08:00
Pranith K
9c29312628 cli,mgmt/glusterd: fsm log implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 1966 (Unnecessarily verbose logs at the default log level)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1966
2010-10-29 03:42:19 -07:00
noah williamsson
d6a34a08d5 Correct enum declaration of gf_dump_procnum, fixing duplicate symbol error when linking on Mac OS X
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
2010-10-26 22:55:55 -07:00