65cc8cb531
Problem: When posix-aio is enabled to perform aio fd is set with O_DIRECT whenever possible in read, writev fops. Rchecksum does not take this into account. If either offset/size/memory-buf passed to pread in rchecksum fop is not aligned, pread fails with EINVAL. Fix: Before doing pread necessary O_DIRECT manipulation is done when aio is enabled. Memory buffer passed to pread is now page-aligned. Test: 1) Create replica volume with aio enabled. 2) dd if=/dev/urandom of=a bs=1M count=1 3) kill one of the bricks in the replica pair 4) dd if=/dev/urandom of=a bs=1M count=1 5) bring back the brick. Self-heal succeeds after the change. The test above checks both rchecksum, writev fops that were changed in this patch. Change-Id: I186099a2854d4864c5b48086ab7bc5f1a7b27313 BUG: 866459 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/4134 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
45 lines
1.2 KiB
Bash
45 lines
1.2 KiB
Bash
#!/bin/bash
|
|
|
|
. $(dirname $0)/../include.rc
|
|
|
|
cleanup;
|
|
|
|
|
|
## Start and create a volume
|
|
TEST glusterd
|
|
TEST pidof glusterd
|
|
TEST $CLI volume info;
|
|
|
|
## Create and start a volume with aio enabled
|
|
TEST $CLI volume create $V0 replica 2 $H0:$B0/${V0}{1,2};
|
|
TEST $CLI volume set $V0 linux-aio on
|
|
TEST $CLI volume set $V0 background-self-heal-count 0
|
|
TEST $CLI volume set $V0 performance.stat-prefetch off;
|
|
TEST $CLI volume start $V0
|
|
|
|
## Mount FUSE with caching disabled
|
|
TEST glusterfs --entry-timeout=0 --attribute-timeout=0 -s $H0 --volfile-id $V0 $M0;
|
|
|
|
dd of=$M0/a if=/dev/urandom bs=1M count=1 2>&1 > /dev/null
|
|
B0_hiphenated=`echo $B0 | tr '/' '-'`
|
|
## Bring a brick down
|
|
kill -9 `cat /var/lib/glusterd/vols/$V0/run/$H0$B0_hiphenated-${V0}1.pid`
|
|
EXPECT '1' echo `pgrep glusterfsd | wc -l`
|
|
## Rewrite the file
|
|
dd of=$M0/a if=/dev/urandom bs=1M count=1 2>&1 > /dev/null
|
|
TEST $CLI volume start $V0 force
|
|
## Wait for the brick to give CHILD_UP in client protocol
|
|
sleep 5
|
|
md5offile2=`md5sum $B0/${V0}2/a | awk '{print $1}'`
|
|
|
|
##trigger self-heal
|
|
ls -l $M0/a
|
|
|
|
EXPECT "$md5offile2" echo `md5sum $B0/${V0}1/a | awk '{print $1}'`
|
|
|
|
## Finish up
|
|
TEST $CLI volume stop $V0;
|
|
TEST $CLI volume delete $V0;
|
|
|
|
cleanup;
|