glusterfs

History

Krishnan Parthasarathi 79e4c7b2fa stack: use list_head for managing frames

PROBLEM
--------

statedump requests that traverse call frames of all call stacks in
execution may race with a STACK_RESET on a stack.  This could crash the
corresponding glusterfs process. For e.g, recently we observed this in a
regression test case tests/basic/afr/sparse-self-heal.t.

FIX
---

gf_proc_dump_pending_frames takes a (TRY_LOCK) call_pool->lock before
iterating through call frames of all call stacks in progress.  With this
fix, STACK_RESET removes its call frames under the same lock.

Additional info
----------------

This fix makes call_stack_t to use struct list_head in place of custom
doubly-linked list implementation. This makes call_frame_t manipulation
easier to maintain in the context of STACK_WIND et al.

BUG: 1229658
Change-Id: I7e43bccd3994cd9184ab982dba3dbc10618f0d94
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11095
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>

2015-06-22 00:41:43 -07:00

cluster

dht : Error value check before performing rebalance complete

2015-06-19 03:47:00 -07:00

debug

build: do not #include "config.h" in each file

2015-05-29 05:43:17 -07:00

encryption

build: do not #include "config.h" in each file

2015-05-29 05:43:17 -07:00

features

stack: use list_head for managing frames

2015-06-22 00:41:43 -07:00

lib/src

build: do not #include "config.h" in each file

2015-05-29 05:43:17 -07:00