A gf_history_changelog_next_change() calls gf_readline() to fill a buffer without checking buffer size. The size of maxlen is not verified to be less than the lenght of buffer. This could result in the over filling of buffer of maxlen is greater than PATH_MAX. Check the size of maxlen to be less than PATH_MAX and return a fail code as needed. BUG: 1174017 Change-Id: Ic53b1a6e25af69a339bc15fb2d233dc1e457910f Reported-by: Keith Schincke <kschinck@redhat.com> Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: http://review.gluster.org/9275 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Venky Shankar <vshankar@redhat.com> Tested-by: Venky Shankar <vshankar@redhat.com>
For information about contributing to GlusterFS, please follow the below link : Contributing to GlusterFS community
GlusterFS does not follow the GitHub: Fork & pull workflow but use Gerrit for code review.
The development guidelines are detailed in Development Workflow.
For more info, please visit http://www.gluster.org/.
Description
Languages
C
86.6%
Shell
7.5%
Python
3.6%
Perl
0.7%
Makefile
0.4%
Other
0.9%