31e34cfd72
Currently there are quite a slew of logs in Gluster that do not lend themselves to trivial analysis by various tools that help collect and monitor logs, due to the textual nature of the logs. This FEAT is to make this better by giving logs message IDs so that the tools do not have to do complex log parsing to break it down to problem areas and suggest troubleshooting options. With this patch, a new set of logging APIs are introduced that take additionally a message ID and an error number, so as to print the message ID and the descriptive string for the error. New APIs: - gf_msg, gf_msg_debug/trace, gf_msg_nomem, gf_msg_callingfn These APIs follow the functionality of the previous gf_log* counterparts, and hence are 1:1 replacements, with the delta that, gf_msg, gf_msg_callingfn take additional parameters as specified above. Defining the log messages: Each invocation of gf_msg/gf_msg_callingfn, should provide an ID and an errnum (if available). Towards this, a common message id file is provided, which contains defines to various messages and their respective strings. As other messages are changed to the new infrastructure APIs, it is intended that this file is edited to add these messages as well. Framework enhanced: The logging framework is also enhanced to be able to support different logging backends in the future. Hence new configuration options for logging framework and logging formats are introduced. Backward compatibility: Currently the framework supports logging in the traditional format, with the inclusion of an error string based on the errnum passed in. Hence the shift to these new APIs would retain the log file names, locations, and format with the exception of an additional error string where applicable. Testing done: Tested the new APIs with different messages in normal code paths Tested with configurations set to gluster logs (syslog pending) Tested nomem variants, inducing the message in normal code paths Tested ident generation for normal code paths (other paths pending) Tested with sample gfapi program for gfapi messages Test code is stripped from the commit Pending work (not to be addressed in this patch (future)): - Logging framework should be configurable - Logging format should be configurable - Once all messages move to the new APIs deprecate/delete older APIs to prevent misuse/abuse using the same - Repeated log messages should be suppressed (as a configurable option) - Logging framework assumes that only one init is possible, but there is no protection around the same (in existing code) - gf_log_fini is not invoked anywhere and does very little cleanup (in existing code) - DOxygen comments to message id headers for each message Change-Id: Ia043fda99a1c6cf7817517ef9e279bfcf35dcc24 BUG: 1075611 Signed-off-by: ShyamsundarR <srangana@redhat.com> Reviewed-on: http://review.gluster.org/6547 Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Raghavendra G <rgowdapp@redhat.com> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
84 lines
4.2 KiB
C
84 lines
4.2 KiB
C
/*
|
|
Copyright (c) 2013 Red Hat, Inc. <http://www.redhat.com>
|
|
This file is part of GlusterFS.
|
|
|
|
This file is licensed to you under your choice of the GNU Lesser
|
|
General Public License, version 3 or any later version (LGPLv3 or
|
|
later), or the GNU General Public License, version 2 (GPLv2), in all
|
|
cases as published by the Free Software Foundation.
|
|
*/
|
|
|
|
#ifndef _LOGCHECKS_MESSAGES_H_
|
|
#define _LOGCHECKS_MESSAGES_H_
|
|
|
|
#ifndef _CONFIG_H
|
|
#define _CONFIG_H
|
|
#include "config.h"
|
|
#endif
|
|
|
|
#include "glfs-message-id.h"
|
|
|
|
/* NOTE: Rules for message additions
|
|
* 1) Each instance of a message is _better_ left with a unique message ID, even
|
|
* if the message format is the same. Reasoning is that, if the message
|
|
* format needs to change in one instance, the other instances are not
|
|
* impacted or the new change does not change the ID of the instance being
|
|
* modified.
|
|
* 2) Addition of a message,
|
|
* - Should increment the GLFS_NUM_MESSAGES
|
|
* - Append to the list of messages defined, towards the end
|
|
* - Retain macro naming as glfs_msg_X (for redability across developers)
|
|
* NOTE: Rules for message format modifications
|
|
* 3) Check acorss the code if the message ID macro in question is reused
|
|
* anywhere. If reused then then the modifications should ensure correctness
|
|
* everywhere, or needs a new message ID as (1) above was not adhered to. If
|
|
* not used anywhere, proceed with the required modification.
|
|
* NOTE: Rules for message deletion
|
|
* 4) Check (3) and if used anywhere else, then cannot be deleted. If not used
|
|
* anywhere, then can be deleted, but will leave a hole by design, as
|
|
* addition rules specify modification to the end of the list and not filling
|
|
* holes.
|
|
*/
|
|
|
|
#define GLFS_COMP_BASE 1000
|
|
#define GLFS_NUM_MESSAGES 19
|
|
#define GLFS_MSGID_END (GLFS_COMP_BASE + GLFS_NUM_MESSAGES + 1)
|
|
/* Messaged with message IDs */
|
|
#define glfs_msg_start_x GLFS_COMP_BASE, "Invalid: Start of messages"
|
|
/*------------*/
|
|
#define logchecks_msg_1 (GLFS_COMP_BASE + 1), "Informational: Testing logging" \
|
|
" in gluster"
|
|
#define logchecks_msg_2 (GLFS_COMP_BASE + 2), "Informational: Format testing:" \
|
|
" %d:%s:%x"
|
|
#define logchecks_msg_3 (GLFS_COMP_BASE + 3), "Critical: Testing logging" \
|
|
" in gluster"
|
|
#define logchecks_msg_4 (GLFS_COMP_BASE + 4), "Critical: Format testing:" \
|
|
" %d:%s:%x"
|
|
#define logchecks_msg_5 (GLFS_COMP_BASE + 5), "Critical: Rotated the log"
|
|
#define logchecks_msg_6 (GLFS_COMP_BASE + 6), "Critical: Flushed the log"
|
|
#define logchecks_msg_7 (GLFS_COMP_BASE + 7), "Informational: gf_msg_callingfn"
|
|
#define logchecks_msg_8 (GLFS_COMP_BASE + 8), "Informational: " \
|
|
"gf_msg_callingfn: Format testing: %d:%s:%x"
|
|
#define logchecks_msg_9 (GLFS_COMP_BASE + 9), "Critical: gf_msg_callingfn"
|
|
#define logchecks_msg_10 (GLFS_COMP_BASE + 10), "Critical: " \
|
|
"gf_msg_callingfn: Format testing: %d:%s:%x"
|
|
#define logchecks_msg_11 (GLFS_COMP_BASE + 11), "=========================="
|
|
#define logchecks_msg_12 (GLFS_COMP_BASE + 12), "Test 1: Only stderr and" \
|
|
" partial syslog"
|
|
#define logchecks_msg_13 (GLFS_COMP_BASE + 13), "Test 2: Only checklog and" \
|
|
" partial syslog"
|
|
#define logchecks_msg_14 (GLFS_COMP_BASE + 14), "Test 5: Changing to" \
|
|
" traditional format"
|
|
#define logchecks_msg_15 (GLFS_COMP_BASE + 15), "Test 6: Changing log level" \
|
|
" to critical and above"
|
|
#define logchecks_msg_16 (GLFS_COMP_BASE + 16), "Test 7: Only to syslog"
|
|
#define logchecks_msg_17 (GLFS_COMP_BASE + 17), "Test 8: Only to syslog," \
|
|
" traditional format"
|
|
#define logchecks_msg_18 (GLFS_COMP_BASE + 18), "Test 9: Only to syslog," \
|
|
" only critical and above"
|
|
#define logchecks_msg_19 (GLFS_COMP_BASE + 19), "Pre init message, not to be" \
|
|
" seen in logs"
|
|
/*------------*/
|
|
#define glfs_msg_end_x GLFS_MSGID_END, "Invalid: End of messages"
|
|
|
|
#endif /* !_component_MESSAGES_H_ */ |