darktemplar/apt
1
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

rpmpm.cc: fix use after free of temporary std::string object

Browse Source 
According to C++ standard (since C++89), this string is destroyed right
after evaluation of .c_str().
In addition, gcc5 with c++11 ABI mode enabled cleans memory in
basic_string destructor and reuses memory in *next* basic_string
constructor.

This led to the error:
 # apt-get install doxygen -o RPM::PM=external -o Dir::Bin::gpg=false -qq
 Executing RPM (/bin/rpm -U -v --oldpackage)...
 Could not exec /
 E: Sub-process /bin/rpm returned an error code (100)
This commit is contained in:
Gleb Fotengauer-Malinovskiy 2015-05-29 19:57:42 +03:00
parent 85c16e95fb
commit 8c3f1ed576
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apt/apt-pkg/rpm/rpmpm.cc
View File

@ -404,13 +404,14 @@ pkgRPMExtPM::~pkgRPMExtPM()
bool pkgRPMExtPM::ExecRPM(Item::RPMOps op, vector<const char*> &files)
{
const char *Args[10000];
const char *Args[10000];
const char *operation;
unsigned int n = 0;
bool Interactive = _config->FindB("RPM::Interactive",true);
int quiet = _config->FindI("quiet",0);
Args[n++] = _config->Find("Dir::Bin::rpm","rpm").c_str();
string rpmbinary = _config->Find("Dir::Bin::rpm","rpm");
Args[n++] = rpmbinary.c_str();
bool nodeps = false;