gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RevertTransaction() changes parent: assert on m_Transactions.back() first.

Browse Source
This commit is contained in:
Axel Naumann 2015-06-09 10:31:29 +02:00 committed by sftnight
parent 331a71cd2d
commit 1c190f711f
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Interpreter/IncrementalParser.cpp
View File

@ -601,11 +601,6 @@ namespace cling {
TransactionUnloader U(&getCI()->getSema(), m_CodeGen.get());
if (U.RevertTransaction(T))
T->setState(Transaction::kRolledBack);
else
T->setState(Transaction::kRolledBackWithErrors);
if (!T->getParent()) {
// Remove from the queue
assert(T == m_Transactions.back() && "Out of order transaction removal");
@ -613,6 +608,14 @@ namespace cling {
if (!m_Transactions.empty())
m_Transactions.back()->setNext(0);
}
if (U.RevertTransaction(T))
T->setState(Transaction::kRolledBack);
else
T->setState(Transaction::kRolledBackWithErrors);
// Keep T alive: someone else might have grabbed that T and needs to detect
// that it's bad.
//m_TransactionPool->releaseTransaction(T);
}