gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak in cling/lib/Utils/PlatformWin.cpp

Browse Source 
Seems to be, buffer is not released correctly.
I guess, error should be fixed in cling repository first
This commit is contained in:
Sergey Linev 2020-01-30 14:10:16 +01:00 committed by SFT
parent 6e2db073b7
commit 269608a831
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Utils/PlatformWin.cpp
View File

@ -72,6 +72,7 @@ static void GetErrorAsString(DWORD Err, std::string& ErrStr, const char* Prefix)
Strm << ": " << CharStr;
::LocalFree(Message);
ErrStr = llvm::StringRef(Strm.str()).rtrim().str();
delete [] CharStr;
}
}
@ -651,7 +652,7 @@ bool GetSystemLibraryPaths(llvm::SmallVectorImpl<std::string>& Paths) {
}
Paths.push_back(Buf);
Buf[0] = 0; // Reset Buf.
// Generic form of C:\Windows
result = ::SHGetFolderPathA(NULL, CSIDL_FLAG_CREATE | CSIDL_WINDOWS,
NULL, SHGFP_TYPE_CURRENT, Buf);
@ -731,7 +732,7 @@ bool Popen(const std::string& Cmd, llvm::SmallVectorImpl<char>& Buf, bool RdE) {
CloseHandle(hOutputWrite);
if (RdE)
CloseHandle(hErrorWrite);
if (Result != 0) {
DWORD dwRead;
const size_t Chunk = Buf.capacity_in_bytes();