gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use VirtualQuery to check if the memory is valid

Browse Source 
Calling VirtualQuery() is very expansive. For example, the testUnfold5a.C tutorial (interpreted) times out after 3600 seconds, and runs in about 60 seconds without calling VirtualQuery(). So just bypass it and return true for the time being
This commit is contained in:
Bertrand Bellenot 2018-10-03 17:35:38 +02:00 committed by sftnight
parent 818126599b
commit 2fbb8cb0f1
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Utils/PlatformWin.cpp
View File

@ -536,6 +536,11 @@ std::string NormalizePath(const std::string& Path) {
}
bool IsMemoryValid(const void *P) {
// Calling VirtualQuery() is very expansive. For example, the testUnfold5a
// tutorial (interpreted) times out after 3600 seconds, and runs in about
// 60 seconds without calling VirtualQuery(). So just bypass it and return
// true for the time being
return true;
MEMORY_BASIC_INFORMATION MBI;
if (::VirtualQuery(P, &MBI, sizeof(MBI)) == 0) {
ReportLastError("VirtualQuery");