gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip non-regular files to find dylibs:

Browse Source 
To determine the file magic, the file needs to be opened and read.
This is done with *each* file in $LD_LIBRARY_PATH, including ./
If one of them is e.g. a FIFO then reading blocks until someone
writes into the FIFO, which might cause the process to hang. This
was reported a couple of times, such as at https://root-forum.cern.ch/t/compiling-from-source-first-interactive-command-hangs/43997/5

Solution: only check for the file magic of *regular* files.

Sadly, llvm::sys::fs::get_file_type never sets file_not_found but
returns an unspecific status_error.
This commit is contained in:
Axel Naumann 2021-03-17 16:06:59 +01:00 committed by jenkins
parent b38fc1e80c
commit 2fc0a3c5c4
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Interpreter/DynamicLibraryManager.cpp
View File

@ -249,6 +249,15 @@ namespace cling {
bool DynamicLibraryManager::isSharedLibrary(llvm::StringRef libFullPath,
bool* exists /*=0*/) {
using namespace llvm;
auto filetype = sys::fs::get_file_type(libFullPath, /*Follow*/ true);
if (filetype != sys::fs::file_type::regular_file) {
if (exists) {
// get_file_type returns status_error also in case of file_not_found.
*exists = filetype != sys::fs::file_type::status_error;
}
return false;
}
file_magic Magic;
const std::error_code Error = identify_magic(libFullPath, Magic);
if (exists)