gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify addOrReplaceDefinition

Browse Source 
Calling getSymbolAddress will force symbol emission, which is not
needed if the intent is to replace it.
This commit is contained in:
Jonas Hahnfeld 2024-07-02 11:52:54 +02:00 committed by jenkins
parent c201269a09
commit 3e59d62c9c
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Interpreter/IncrementalJIT.cpp
View File

@ -642,12 +642,6 @@ JITTargetAddress
IncrementalJIT::addOrReplaceDefinition(StringRef Name,
JITTargetAddress KnownAddr) {
void* Symbol = getSymbolAddress(Name, /*IncludeFromHost=*/true);
// Nothing to define, we are redefining the same function. FIXME: Diagnose.
if (Symbol && (JITTargetAddress)Symbol == KnownAddr)
return KnownAddr;
// Let's inject it
bool Inserted;
SymbolMap::iterator It;
@ -658,9 +652,7 @@ IncrementalJIT::addOrReplaceDefinition(StringRef Name,
JITDylib& DyLib = Jit->getMainJITDylib();
// We want to replace a symbol with a custom provided one.
if (Symbol && KnownAddr)
// The symbol be in the DyLib or in-process.
llvm::consumeError(DyLib.remove({It->first}));
llvm::consumeError(DyLib.remove({It->first}));
if (Error Err = DyLib.define(absoluteSymbols({*It}))) {
logAllUnhandledErrors(std::move(Err), errs(),