gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add support for null deref checks in indirect calls.

Browse Source
This commit is contained in:
Baozeng Ding 2013-08-21 11:29:28 +02:00 committed by sftnight
parent cc877954ae
commit 715e222957
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Interpreter/NullDerefProtectionTransformer.cpp
View File

@ -153,6 +153,16 @@ namespace cling {
// into the map.
m_NonNullArgIndexs.insert(std::make_pair(FName, ArgIndexs));
}
Stmt* S = FDecl->getBody();
if (S) {
for (Stmt::child_iterator II = S->child_begin(), EE = S->child_end();
II != EE; ++II) {
CallExpr* child = dyn_cast<CallExpr>(*II);
if (child && child->getDirectCallee() != FDecl)
VisitCallExpr(child);
}
}
}
return true; // returning false will abort the in-depth traversal.
}

8
test/NullDeref/NonNullArgCustom.C
View File

@ -1,4 +1,4 @@
// RUN: cat %s | %cling -Xclang -verify
// RUN: cat %s | %cling -Xclang -verify | FileCheck %s
// We must be able to handle cases where, there is a custom function that has
@ -6,7 +6,7 @@
// attribute to a say library function.
// Qualified functions.
#include <stdio.h>
extern "C" int printf(const char* fmt, ...);
namespace custom_namespace {
void standaloneFunc(void* p, int q, float* s) __attribute__((nonnull(1,3))) { // expected-warning {{GCC does not allow nonnull attribute in this position on a function definition}}
if (!p || !s)
@ -19,7 +19,7 @@ namespace custom_namespace {
}
}
// This can be a function defined in a library or somewhere else.
// This can be a function defined in a library or somewhere else. Use printf for example
extern "C" int printf(const char* fmt, ...) __attribute__((nonnull(1)));
int* pNull = 0;
@ -42,7 +42,7 @@ int trampoline() {
}
.rawInput 0
//CHECK-NOT: Must not be called with 0 args.
//trampoline()
trampoline() // expected-warning {{you are about to dereference null ptr, which probably will lead to seg violation. Do you want to proceed?[y/n]}}
//CHECK: (int) 1
.q