gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allocate Expr on a custom address to be able to release memory.

Browse Source 
We now use operator new with placement to memory explicit
allocated in the routine (rather than the ASTContext) so
that we can release this memory at the end of the function.
The memory is allocated via a vector of object large enough
to hold the OpaqueExprRef.
This commit is contained in:
Philippe Canal 2013-08-24 23:19:24 -05:00 committed by sftnight
parent dfc4b7b1c1
commit 7312683eda
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/Interpreter/LookupHelper.cpp
View File

@ -67,6 +67,12 @@ namespace cling {
}
};
///\brief Class to help with the custom allocation of clang::Expr
///
struct ExprAlloc {
char fBuffer[sizeof(clang::OpaqueValueExpr)];
};
// pin *tor here so that we can have clang::Parser defined and be able to call
// the dtor on the OwningPtr
LookupHelper::LookupHelper(clang::Parser* P, Interpreter* interp)
@ -840,9 +846,11 @@ namespace cling {
VK = VK_LValue;
}
clang::QualType NonRefQT(QT.getNonReferenceType());
unsigned int slot = ExprMemory.size();
ExprMemory.resize(slot+1);
Expr* val
= new (Context) OpaqueValueExpr(TSI->getTypeLoc().getLocStart(),
NonRefQT, VK);
= new (&ExprMemory[slot]) OpaqueValueExpr(TSI->getTypeLoc().getLocStart(),
NonRefQT, VK);
GivenArgs.push_back(val);
}
// Type names should be comma separated.
@ -898,9 +906,10 @@ namespace cling {
ParserStateRAII ResetParserState(P);
prepareForParsing(funcProto, llvm::StringRef("func.prototype.file"));
llvm::SmallVector<ExprAlloc, 4> ExprMemory;
llvm::SmallVector<Expr*, 4> GivenArgs;
if (!funcProto.empty()) {
if (!ParseProto(GivenArgs,Context,P,S) ) {
if (!ParseProto(ExprMemory,GivenArgs,Context,P,S) ) {
return 0;
}
}
@ -943,9 +952,10 @@ namespace cling {
ParserStateRAII ResetParserState(P);
prepareForParsing(funcProto, llvm::StringRef("func.prototype.file"));
llvm::SmallVector<ExprAlloc, 4> ExprMemory;
llvm::SmallVector<Expr*, 4> GivenArgs;
if (!funcProto.empty()) {
if (!ParseProto(GivenArgs,Context,P,S) ) {
if (!ParseProto(ExprMemory, GivenArgs,Context,P,S) ) {
return 0;
}
}