gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't test for no_such_file_or_directory to know if a file exists.

Browse Source 
There are many errors (is_a_directory, permission_denied, etc.),.
Any one of which will mean Magic is in an undefined state.
This commit is contained in:
Frederich Munch 2016-09-16 00:01:52 -04:00 committed by sftnight
parent a5c1828daf
commit 8296c01d95
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Interpreter/DynamicLibraryManager.cpp
View File

@ -191,12 +191,11 @@ namespace cling {
static bool isSharedLib(llvm::StringRef LibName, bool* exists = 0) {
using namespace llvm::sys::fs;
file_magic Magic;
std::error_code Error = identify_magic(LibName, Magic);
bool onDisk = (Error != std::errc::no_such_file_or_directory);
const std::error_code Error = identify_magic(LibName, Magic);
if (exists)
*exists = onDisk;
*exists = !Error;
return onDisk &&
return !Error &&
#ifdef __APPLE__
(Magic == file_magic::macho_fixed_virtual_memory_shared_lib
|| Magic == file_magic::macho_dynamically_linked_shared_lib