gamzinav/cling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

EvaluateInternal: capture ValuePrinting request early:

Browse Source 
`RunFunction()` might trigger unloading of `lastT`, so store its setting
for "want value printing" in a local variable before calling RunFunction().

Fixes valgrind complaining about `./stressInterpreter` which is reloading
the "outer" stressInterpreter.cxx from inside `RunFunction()`.
This commit is contained in:
Axel Naumann 2021-11-11 12:49:44 +01:00 committed by jenkins
parent 3afd3b4056
commit a860c891d4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Interpreter/Interpreter.cpp
View File

@ -1409,11 +1409,11 @@ namespace cling {
!lastT->getWrapperFD()) // no wrapper to run
return Interpreter::kSuccess;
else {
bool WantValuePrinting = lastT->getCompilationOpts().ValuePrinting
!= CompilationOptions::VPDisabled;
ExecutionResult res = RunFunction(lastT->getWrapperFD(), V);
if (res < kExeFirstError) {
if (lastT->getCompilationOpts().ValuePrinting
!= CompilationOptions::VPDisabled
&& V->isValid()
if (WantValuePrinting && V->isValid()
// the !V->needsManagedAllocation() case is handled by
// dumpIfNoStorage.
&& V->needsManagedAllocation())