5249 Commits

Author SHA1 Message Date
Axel Naumann
e122c6dcc6 Revert "Disable GlobalISel on AArch64":
This reverts fcab0add4a79379b5087fe786261f4ab0cc9776a which is not
needed anymore since llvm13 / ORCv2 / JITLink.
2023-02-16 17:14:03 +01:00
Jonas Hahnfeld
38154308df Switch back to large code model for macOS on AArch64
It results in relocation targets that are out-of-range.
2023-02-07 08:59:05 +01:00
Vassil Vassilev
bc0a44c2b7 Enable a few modules for Windows. Now we can run hsimple.C. 2023-02-07 08:59:05 +01:00
Vassil Vassilev
727908e8af Adapt the cling-demo to the new cling::Value interface. 2023-02-05 22:59:03 +01:00
Jonas Hahnfeld
1d93ee8d58 Simplify creation of TargetMachine
We know exactly which target triple and features the CompilerInstance
wants, we don't need to (and probably must not) second-guess that. This
brings us closer to upstream clang-repl and also includes the change of
https://reviews.llvm.org/D128853 which is crucial for RISC-V.
2023-02-05 12:59:03 +01:00
Jonas Hahnfeld
1603be8b87 Set up TargetMachine for JITLink
I missed this in commit 3ff7c1e8e2 and it seems to work by chance on
macOS, but this is needed on Linux: Before, CLING_JTLINK=1 on x86_64
complained about "Unspported personality pointer encoding 0x00" and
crashed entirely on RISC-V.
2023-02-05 12:59:03 +01:00
Vassil Vassilev
6ef68e5512 Fix potential pre-existing issue for big endian 2023-02-03 07:29:07 +01:00
Vassil Vassilev
643cfe84ab Improve performance by allowing most of cling::Value to inline.
We introduce an enum which mirrors the type kind and we use it in the getAs and
castAs operations to allow the compiler/interpreter to see all of the functions
and potentially inline them.

This patch brings the performance to similar levels with what we have in the
master.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
afadc28b05 Mark m_Storage as a const ref. 2023-02-03 07:29:07 +01:00
Vassil Vassilev
632aba9c56 Implement a rigorous type checking when we call getX and setX.
These interfaces assume we know the type and we should compare if the underlying
type is the one we expect when using the setters and getters. Unfortunately,
this is not the case and we need to further investigate.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
5add0d7732 Rename simplisticCast to castAs. 2023-02-03 07:29:07 +01:00
Vassil Vassilev
ad78ae2c61 Remove unused constructor 2023-02-03 07:29:07 +01:00
Vassil Vassilev
320d63785f Improve the templated Create interface to capture compile-time types.
This interface allows us to set a value and deduce its corresponding type very
efficiently. This is useful when we use cling::Value to model input arguments
for a function call in the JIT (eg. via TClingCallFunc).

That patch essentially makes cling::Value to hold a value and a type that
correctly models the compiled code.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
07c4469328 Improve consistency in cling::Value.
The improvements are:
  * We provide getX and setX interfaces instead of returning the address for the
    non const methods. This allows us to be more consistent in terms of
    lifetimes as now users cannot take the address of block of memory which can
    be freed by the cling::Value.
  * We remove the storage types and we rely on the clang::Type which we have in
    the cling::Value.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
e18104aa12 Make function file static to reduce includes 2023-02-03 07:29:07 +01:00
Vassil Vassilev
44cac5e3af Implement more robust conversion via getAs in cling::Value.
Here we enumerate most of the builtin types and we the generate template
specializations for all of them which are capable to perform the correct
conversions.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
a55501d540 Add variant to the modulemap to address a cmssw-related issue. 2023-02-02 12:14:04 +01:00
Jonas Hahnfeld
dc6ee2401b Add back basic support for JITLink
The custom memory manager is only needed to avoid freeing the memory
segments; the default InProcessMemoryManager (which is mostly copied)
already does slab allocation to keep all segments together which is
needed for exception handling support.

A limitation of this rudimentary support is that CLING_DEBUG and
CLING_PROFILE do not work, they need to be registered as plugins.
2023-02-01 13:44:06 +01:00
Javier Lopez-Gomez
41c41c26df Add missing const in operator== and operator!=
Add missing `const` in `{DelayCall,MacroDirective}Info::operator==`
and `operator!=`. This fixes the following warnings in C++20
```
interpreter/cling/lib/Interpreter/Transaction.cpp:173:23: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'cling::Transaction::DelayCallInfo' and 'cling::Transaction::DelayCallInfo') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator]
interpreter/cling/lib/Interpreter/Transaction.cpp:218:21: warning: ISO C++20 considers use of overloaded operator '==' (with operand types 'cling::Transaction::MacroDirectiveInfo' and 'cling::Transaction::MacroDirectiveInfo') to be ambiguous despite there being a unique best viable function [-Wambiguous-reversed-operator]
```
2023-02-01 08:29:04 +01:00
Vassil Vassilev
c0cebd2c70 Adjust the modulemap for c++20 2023-02-01 08:29:04 +01:00
Vassil Vassilev
93e72c9d88 Revert "[cling] Add dedicated C++20 stl-modulemap:"
This reverts commit 82f1619a7179088c61bedd2f5d38d158957c7bde.
2023-02-01 08:29:04 +01:00
Axel Naumann
b8edc28315 Add dedicated C++20 stl-modulemap:
The bits/ headers have different include behavior (mostly due to ranges)
that makes it significantly harder to find a configuration working for
C++14, 17, and 20. Instead, create a dedicated modulemap for C++20.
2023-02-01 08:29:04 +01:00
Axel Naumann
f2b325b312 Keep private symbols private:
llvm IR naming of private constants (CodeGenModule::createUnnamedGlobalFrom(),
line 1136) will name private symbols without caring about possible name clashes.
We will create these name clashes by marking such private symbols as weak ones,
re-using previously emitted symbols (e.g. in JITDylib::defineImpl() where they
get added to MUDefsOverridden and thus re-used instead of re-emitted).

Let me see what happens when we keep private symbols private. In principle, the
interpreter should have no means fo accessing them from another transaction -
private symbols seem to be function-local ones.

Fixes https://github.com/root-project/root/pull/12183
2023-01-31 22:59:06 +01:00
Jiang Yi
da57784037 Set history size to ${CLING_HISTSIZE}
It was left unset. Then the default hist size was

static_cast<size_t>(-1), which is practically equivalent to unlimited

history size.
2023-01-30 10:29:07 +01:00
ferdymercury
c3dd723262 fix some more warnings in core 2023-01-30 10:29:07 +01:00
Sergey Linev
f4d11176e6 Use nullptr in core/textinput classes 2023-01-30 10:29:07 +01:00
ferdymercury
a78c5a41eb Implement .help edit (show line editor keybindings)
Co-authored-by: Javier Lopez-Gomez <javier.lopez.gomez@cern.ch>
Co-authored-by: Olivier Couet <Olivier.Couet@cern.ch>
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
401f877780 Do not assign ESC a special meaning on history search mode
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

This change only affects UNIX terminals.

Closes issue #10209.
2023-01-30 10:29:07 +01:00
ferdymercury
0d46b6dead Implement forward history search
Co-authored-by: Javier Lopez-Gomez <javier.lopez.gomez@cern.ch>

Fixes #10137
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
07120b98da Clear undo buffer after taking an input line
The undo buffer should only be kept for the current line (as in GNU readline).

Fixes #10182.
2023-01-30 10:29:07 +01:00
ferdymercury
97166bc3b2 prevent accessing empty vector
Fixes https://github.com/root-project/root/issues/10180
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
a575990cfc Fix implementation of the kCmdWordTo{Lower,Upper} editor commands
These commands, bound respectively to `ESC l` and `ESC u`, should {lower,upper}case
the next word; however, only the first character was changed.

Fixes #10136.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
01ffa06f0a Add a missing new-line after .q if quitting a ROOT session via Ctrl+D (EOF)
Fixes #10135.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
2dd8debdfb Fix implementation of kCmdSwapThisAndLeftThenMoveRight
This editor command (usually binded to Ctrl+T), transposes the character located
at the cursor and the one to its left.
However, its behavior was incorrect if the cursor was at end of the line,
invoking `std::string::operator[]()` passing an index that is out of bounds.

In that case, as per GNU Readline behavior, it should swap the two last
characters.

Closes #10133.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
3914be144e Bind Ctrl+Del to Editor::kCmdCutNextWord (kill next word)
This change is equivalent to the popular GNU Readline keybinding
```
"\e[3;5~": kill-word
```

As a requirement, the `[3;5~` CSI was added in StreamReaderUnix.cpp. No
additional changes required to StreamReaderWin.cpp.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
3a448596c6 Fix [-Winconsistent-missing-override] warnings on Apple's clang 2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
d654717749 Clear the terminal screen on Ctrl+L
Fixes #10057.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
106c95fb1b Add Display::Clear(): clear the terminal screen
Writes the `\033[2J\033[H` sequence to clear the visible part of the screen.
For Windows, this requires to temporarily enable processing of VT control
sequences.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
d077fb1048 Enable Xterm-like movement between words, i.e. using Ctrl+{Left,Right}
Enable fast word movement à la Xterm (using Ctrl+Left and Ctrl+Right). Most
users coming from a GUI (GTK+, Win32, etc.) will find this convenient, but also
Archlinux users, given that the default `inputrc` file for GNU Readline providesthese bindings (see https://wiki.archlinux.org/title/Readline#Fast_word_movement).
2023-01-30 10:29:07 +01:00
Sergey Linev
677d59246c Remove unused variable 2023-01-30 10:29:07 +01:00
Sergey Linev
3c40fef28b Modernize core/thread core/textinput includes
Declare non-implmented constructors as delete;
2023-01-30 10:29:07 +01:00
Sergey Linev
0525bca060 Use nullptr in cling
Avoid warnings when -Wzero-as-null-pointer-constant is specified
2023-01-30 08:29:07 +01:00
ferdymercury
9cdbf1d0eb nullptr use
clingUtils modernize nullptr
2023-01-26 08:59:06 +01:00
Jiang Yi
1d5536fd0b Test cmd history support 2023-01-25 13:59:06 +01:00
Jiang Yi
90a7639461 Support setting cmd history file by ${CLING_HISTFILE} 2023-01-25 13:59:06 +01:00
Jiang Yi
392d5365d5 Set history size to ${CLING_HISTSIZE}
It was left unset. Then the default hist size was

static_cast<size_t>(-1), which is practically equivalent to unlimited

history size.
2023-01-25 13:59:06 +01:00
Jonas Hahnfeld
d47b49c3ee Reset function sections before JITting (#12069)
This makes all functions end up in the same text section, which is
important for TCling on macOS to catch exceptions from constructors:
Stack unwinding requires information about program addresses to find
out which objects to destroy and what code should be called to handle
the exception. These addresses are relocated against a single __text
section when loading the produced MachO binary, which breaks if the
call sites of global constructors end up in a separate init section.

Fixes ROOT-10703 and ROOT-10962

(cherry picked from commit 028fcca0fa76111877751df876cf13968be602f9)
2023-01-24 10:29:05 +01:00
Vassil Vassilev
2949bf96b7 Bump clad version to v1.1.
This new release includes some improvements:
  * Improvements in the array handling in the Error Estimation Framework
  * Fixed numerical stability of the pow pushforward
  * Fixed handling of for-loop conditions in reverse mode
  * LLVM15 Support

See more at: https://github.com/vgvassilev/clad/blob/v1.1/docs/internalDocs/ReleaseNotes.md
2023-01-23 19:59:07 +01:00
Jonas Hahnfeld
2f48c65752 Explicitly create FunctionDecl in DeclExtractor
The function EnforceInitOrder() was using ImplicitlyDefineFunction()
as a shortcut to define a function returning an int. Future upgrades
of LLVM will add an assert in that function because it is not allowed
to be used when compiling C++, which Cling obviously does.
2023-01-23 18:44:07 +01:00
Vassil Vassilev
2129e96274 Do not register LLVMSupport as a library when it should be a component (#11703)
Do not register LLVMSupport as a library when it should be a component

LLVM component must be registered as LLVM_LINK_COMPONENTS to be
compatible with LLVM Dylib. Otherwise they are loaded twice in the final
binary, once through LLVM Dylmib and once through individual component,
and this results in some options being registered twice.

Fix root-project/cling#440
2023-01-20 16:59:05 +01:00