Commit Graph

4275 Commits

Author SHA1 Message Date
Vassil Vassilev
d9babce973 Forward declare the class in the correct namespace. 2018-01-29 15:29:26 +01:00
Vassil Vassilev
3a82a25051 Do not rely on getSpecializations.
The getSpecialization interface now deserializes lazily template
specializations. While unloading we trigger creation of new specializations
which does not make sense.
2018-01-21 09:14:46 +01:00
Houkime
51acb456a1 Add "language" field to kernel.json 2018-01-15 17:14:05 +01:00
Axel Naumann
3848d29556 Fix exception if cling is not found.
See https://stackoverflow.com/questions/48244332/c-jupyter-kernel-death
2018-01-15 15:59:58 +01:00
Dheepak Krishnamurthy
bf88ee12d3 Get correct path for cling
Required for Mac with `brew install cling`
2018-01-15 12:59:47 +01:00
Dheepak Krishnamurthy
f9db95721e Check in libexec folder as well
Required for Mac brew install
2018-01-15 12:59:47 +01:00
Axel Naumann
b302a6bcfe Silence cling test error until after the break. 2017-12-21 10:48:27 +01:00
Guilherme Amadio
50a795610f Match declarations of at_quick_exit and __cxa_atexit symbols for libc++ and C++17
On Linux, the same adjustments are needed as for libstdc++ and libc++,
so turn the condition into just #ifdef __linux__. However, since the
__cxa_atexit function is declared as extern "C" in libc++, we cannot
add "noexcept" to it, as is done for libstdc++.
2017-12-09 11:59:37 +01:00
Axel Naumann
9168e7d9ab Move enum attributes after "enum class X: int" (ROOT-9114).
With the attribute after "enum" and before the name, the name itself gets annotated
and subsequent lookups fail to identify the front-end token.
By moving the attribute behind the decl, the identifier is unmodified.
2017-12-07 17:00:35 +01:00
Axel Naumann
1193463c6f Revert "Address ROOT-9114 (Issues with dictionary's enum forward decl)"
This reverts commit 59c69dc2ce449eff8cabcf73405b04b07aaf9eb3.
Let's try to find the underlying issue...
2017-12-07 17:00:35 +01:00
Axel Naumann
2264e8c66f Mark compiler include paths as -cxx-isystem (ROOT-8991). 2017-12-06 15:29:30 +01:00
Axel Naumann
b55066ffea Claim #include <auto-parse-hdr> to remember the full path (ROOT-8863). 2017-12-06 05:59:06 +01:00
Axel Naumann
88edc07e65 Adjust after increased fp precision. 2017-12-05 15:40:37 +01:00
Axel Naumann
56b0e8e184 Print float with number of signif digits, double with 8. 2017-12-05 15:40:37 +01:00
Axel Naumann
1ac9f65512 Update to new output format. Use CHECK-NEXT. 2017-12-05 15:40:37 +01:00
Axel Naumann
25849d68c4 Update ref to include <invalid memory address> 2017-12-05 15:40:37 +01:00
Axel Naumann
a662db9c4c Adapt to new=old value printer: "1.000000" for a double 1 instead of "1".
Revert "Adapt to format changes in floating point value printing."

This reverts commit a15ef54fb4c5152eeff740cc1f3be6249ede26e6.
2017-12-05 15:40:37 +01:00
Axel Naumann
582af5e250 Print "1.000000" for a double 1 instead of "1", as in 6.10.
Uses the # modifier to printf using the "alternate form".
2017-12-05 15:40:37 +01:00
Vassil Vassilev
fdca86db1d Set the SourceManager flag to enable -fmodules-embed-all-files.
This marks all files in the PCH/PCM transient. This allows clang to
stream them back within the zip in the PCH rather than requiring the
files to be physically present on disk.

This should resolve an introduced regression which materializes if
the files are moved/deleted after the generation of the PCH.
2017-11-30 14:52:08 +01:00
Bertrand Bellenot
92213e719a Switch object format from ELF to COFF and fix symbols lookup
- Switch object format from ELF (Linux) to COFF (Windows)
- Fix mangled symbols lookup on Windows: remove leading '_' and use malloc to simulate __imp_ variables (that are indirection pointers)
2017-11-29 22:30:07 +01:00
vagrant
54dbb830b3 Disable module file validation.
We need to disable the validation of PCM files because rootcling
serializes what it sees. For instance, we even serialize in the PCM
file some temporary lookup buffers and the contents of the module maps.

We disable the PCH validation but that is not sufficient for PCM. The
TCling code `fInterpreter->getCI()->getPreprocessorOpts().DisablePCHValidation = true`
is not enough because we rely more on the clang driver to setup correctly
our modules-aware interpreter.

This patch just uses the correct flag when setting up cling.

A proper fix to this issue is thoroughly described in RE-0003 (rootcling
refactor proposal).
2017-11-20 17:14:55 +01:00
Philippe Canal
8ca438b0d1 Address ROOT-9114 (Issues with dictionary's enum forward decl)
For now, do not decorate enums, this leads to some errors, likely
due to incorrect merging.  See https://sft.its.cern.ch/jira/browse/ROOT-9114

Note: that passing the set of forward declare and then actual declaration
to clang (both official and ROOT's custom version), there is no problem
seen.
2017-11-18 01:06:27 +01:00
Vassil Vassilev
c513776350 Fix typo, we want to suppress diag not enable it. 2017-11-14 04:13:43 +01:00
Vassil Vassilev
5abbe64ffd Work around an issue being resolved in PR1306. 2017-11-12 14:31:56 +01:00
Axel Naumann
315dfad70e Adapt to new default opt level.
As the default opt level decides which user-set opt levels cling will complain about, "control flow" changes were needed for the tests.
2017-11-07 19:44:33 +01:00
Axel Naumann
a9808afd40 Adapt to format changes in floating point value printing. 2017-11-07 19:44:33 +01:00
Raphael Isemann
c41a49dabb Multiplex the ExternalASTSource in cling
We need to respect the existing ExternalASTSource when setting up the
interpreter. Otherwise the ASTReader (which is the existing source)
doesn't receive the required callbacks to properly load C++ modules.

This patch now creates a multiplexer that contains our new
ASTSource and the existing one if it's necessary. We also
no longer attach the existing sema source which seemingly
was only a workaround that only works for the special case
were the external sema source and the external AST source
are the same object.
2017-11-07 05:39:07 +01:00
Raphael Isemann
62eac4d1d2 Fix formatting of the TLS commit 2017-11-07 03:57:48 +01:00
Raphael Isemann
89c6351e3a Fix thread local storage in the cling JIT
TLS is currently not suppored in the JIT on some platforms.

However, it's possible to enable emulated TLS support in LLVM
which means that we now support TLS across many architectures.
The performance downsides of this are the overhead of accessing
the variable due to the additional indirection by the emulation.

However, this overhead is minimal and shouldn't affect most
programs. It also can be easily worked around from the user side.
This can be donefFor example by wrapping TLS variables into a single
TLS struct variable that then contains the other variables. Or just
minimizing referencing the TLS variable and use a normal copy of
the variable instead and write it back later.

Patch created with a lot of help from Lang Hames and Pavel Labath!
2017-11-07 03:57:48 +01:00
Axel Naumann
3bf7bc1a48 Use %g instead of %f, to preserve precision. 2017-11-06 21:20:19 +01:00
Vassil Vassilev
c912c9437d Switch back to O0.
We have a suboptimal behavior in the way cling optimizes code in O2 mode.
Disable it until the issue is understood and fixed.
2017-11-03 16:19:32 +01:00
Axel Naumann
3256a1dc1f Spelling. 2017-11-02 20:14:18 +01:00
Vassil Vassilev
e488ba8466 Rely on Azog to allocate the memory in an exception-aware manner. 2017-11-02 17:59:25 +01:00
Vassil Vassilev
985b2c8740 LLVM 5.0 comes with special library lookup ordering options.
Force using the old behavior and explain why it is not so good idea.
2017-11-02 17:59:25 +01:00
Vassil Vassilev
d6fe62edaf Return 0 if we cannot find an address.
Add an llvm_unreachable to handle potential errors.
2017-11-02 17:59:25 +01:00
Vassil Vassilev
5f3494f950 Do not forget to return from the function.
This was probably due to non-proprely merged conflict.
2017-11-02 17:59:25 +01:00
Vassil Vassilev
3959f528b7 Bump the last known good llvm revision to point to release 5.0 2017-11-02 17:59:25 +01:00
Vassil Vassilev
dfc5cf657d The annotation token became a special one.
We can only consume it with calling a special interface or calling ConsumeAnyToken.
2017-11-02 17:59:25 +01:00
Vassil Vassilev
8bfa1b52c6 Make this code path unreachable.
If we cannot return an address we should assert and handle the diags.
2017-11-02 17:59:25 +01:00
Vassil Vassilev
88c3d07bb9 Follow recent LLVM changes.
The orc jit API evolved as follows:
  * Use better error handling via llvm::Error and llvm::Expected<>
  * Switch back to the single llvm::Module concept as opposed to sets.
  * Use more expressive ownership model: extensive use of smart ptrs.
2017-11-02 17:59:25 +01:00
Vassil Vassilev
6e1865dafb Do not prevent copy elision. 2017-11-02 17:59:24 +01:00
Vassil Vassilev
97f45536c3 Use the setter. 2017-11-02 17:59:24 +01:00
Vassil Vassilev
16c99f41f6 Follow recent changes in the OptTable.
LLVM 5.0 introduces a field to describe possible allowed option values. This
aids the auto completion machanisms.
2017-11-02 17:59:24 +01:00
Vassil Vassilev
1a35776759 file_magic went into its own header file. 2017-11-02 17:59:24 +01:00
Vassil Vassilev
628c1fbc86 BBVectorize flag was unused and went away in LLVM 5.0 2017-11-02 17:59:24 +01:00
Vassil Vassilev
8d0f2c4e1e Bump version to 0.6~dev. 2017-11-02 17:44:11 +01:00
Vassil Vassilev
0f1d6d24d4 Prepare for releasing cling v0.5. 2017-11-02 17:29:12 +01:00
Raphael Isemann
00a59858a5 Manually initialize the module manager before callbacks.
Initializing the module manager overwrites the external Sema/AST sources
with the ASTReader.

As we are using our own sources in cling, we should manually initalize
the module manager when we are in the module mode before we set our
own custom sources (which respect any existing sources like the ones
created by the module manager).
2017-11-02 10:10:48 +01:00
Raphael Isemann
016eaa7620 Prepone callback initialization in cling.
We should setup our callbacks for ExternalASTSource/ExternalSemaSource
before we parse *any* code to prevent that any part of the code
stores a reference to a non-cling external sources. If this happens,
then the clang data structures such redecl chain could go out of
sync if they reference different sources and produce errors like failing
to merge declarations correctly or creating invalid redecl chains.

To fix this, we move this initalization before the initalization of
the incremental parser which is the first part that can generate
any AST nodes. We only do this for the modules case because in
the non-modules case the clang PCH overwrites our callback
in the ExternalASTSource and therefore would destroy our external
source.
2017-11-02 10:10:48 +01:00
Raphael Isemann
d411ed7885 Enable interpreter callbacks again
We actually need those callbacks as they are responsible for
loading decls from unresolved identifiers, which then actually
triggers the loading of the specific header (or in our case
the specific C++ modules).

For now we need this as long as the modules are based on the
rootmap mechanism.
2017-11-02 10:10:48 +01:00