2021-06-09 20:53:16 +03:00
// Copyright 2021 The Gitea Authors. All rights reserved.
2022-11-27 21:20:29 +03:00
// SPDX-License-Identifier: MIT
2021-06-09 20:53:16 +03:00
package auth
import (
"net/http"
2022-03-28 07:46:28 +03:00
"strings"
2021-06-09 20:53:16 +03:00
2021-11-24 12:49:20 +03:00
user_model "code.gitea.io/gitea/models/user"
2021-06-09 20:53:16 +03:00
)
// Ensure the struct implements the interface.
var (
2023-06-18 10:59:09 +03:00
_ Method = & Group { }
2021-06-09 20:53:16 +03:00
)
// Group implements the Auth interface with serval Auth.
type Group struct {
2021-07-24 13:16:34 +03:00
methods [ ] Method
2021-06-09 20:53:16 +03:00
}
// NewGroup creates a new auth group
2021-07-24 13:16:34 +03:00
func NewGroup ( methods ... Method ) * Group {
2021-06-09 20:53:16 +03:00
return & Group {
methods : methods ,
}
}
2022-03-28 07:46:28 +03:00
// Add adds a new method to group
func ( b * Group ) Add ( method Method ) {
b . methods = append ( b . methods , method )
}
// Name returns group's methods name
func ( b * Group ) Name ( ) string {
names := make ( [ ] string , 0 , len ( b . methods ) )
for _ , m := range b . methods {
2023-09-05 18:58:30 +03:00
names = append ( names , m . Name ( ) )
2022-03-28 07:46:28 +03:00
}
return strings . Join ( names , "," )
}
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.
There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.
Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.
This will fix #20563
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 08:53:28 +03:00
func ( b * Group ) Verify ( req * http . Request , w http . ResponseWriter , store DataStore , sess SessionStore ) ( * user_model . User , error ) {
2021-06-09 20:53:16 +03:00
// Try to sign in with each of the enabled plugins
2023-07-11 05:04:28 +03:00
var retErr error
2023-09-05 18:58:30 +03:00
for _ , m := range b . methods {
user , err := m . Verify ( req , w , store , sess )
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.
There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.
Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.
This will fix #20563
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 08:53:28 +03:00
if err != nil {
2023-07-11 05:04:28 +03:00
if retErr == nil {
retErr = err
}
// Try other methods if this one failed.
// Some methods may share the same protocol to detect if they are matched.
// For example, OAuth2 and conan.Auth both read token from "Authorization: Bearer <token>" header,
// If OAuth2 returns error, we should give conan.Auth a chance to try.
continue
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.
There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.
Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.
This will fix #20563
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 08:53:28 +03:00
}
2023-07-11 05:04:28 +03:00
// If any method returns a user, we can stop trying.
// Return the user and ignore any error returned by previous methods.
2021-06-09 20:53:16 +03:00
if user != nil {
if store . GetData ( ) [ "AuthedMethod" ] == nil {
2023-09-05 18:58:30 +03:00
store . GetData ( ) [ "AuthedMethod" ] = m . Name ( )
2021-06-09 20:53:16 +03:00
}
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.
There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.
Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.
This will fix #20563
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 08:53:28 +03:00
return user , nil
2021-06-09 20:53:16 +03:00
}
}
2023-07-11 05:04:28 +03:00
// If no method returns a user, return the error returned by the first method.
return nil , retErr
2021-06-09 20:53:16 +03:00
}