Various improvements to pages: notifications and subscriptions

- fix rounding on /notifications/subscriptions
- add navigation interconnectivity between notifications and subscriptions
- use modern style for tabs
- clearing notificatons: hide the whole form instead of div. It doesn't seem like its changed via JS?
- replace issue-title-buttons and edit-buttons with universal top-right-buttons, get rid of tw-mr-0 helpers
- repo issues: fix misalignments on mobile view

templates/repo/issue/view_title.tmpl

@@ -12,16 +12,16 @@
 				<input value="{{.Issue.Title}}" maxlength="255" autocomplete="off">
 			</div>
 		</h1>
-		<div class="issue-title-buttons">
+		<div class="top-right-buttons">
 			{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
-				<button id="edit-title" class="ui small basic button edit-button not-in-edit tw-mr-0">{{ctx.Locale.Tr "repo.issues.edit"}}</button>
+				<button id="edit-title" class="ui small basic button edit-button not-in-edit">{{ctx.Locale.Tr "repo.issues.edit"}}</button>
 			{{end}}
 			{{if not .Issue.IsPull}}
-				<a role="button" class="ui small primary button new-issue-button tw-mr-0" href="{{.RepoLink}}/issues/new{{if .NewIssueChooseTemplate}}/choose{{end}}">{{ctx.Locale.Tr "repo.issues.new"}}</a>
+				<a role="button" class="ui small primary button new-issue-button" href="{{.RepoLink}}/issues/new{{if .NewIssueChooseTemplate}}/choose{{end}}">{{ctx.Locale.Tr "repo.issues.new"}}</a>
 			{{end}}
 		</div>
 		{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
-			<div class="edit-buttons">
+			<div class="top-right-buttons">
 				<button id="cancel-edit-title" class="ui small basic button in-edit tw-hidden">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
 				<button id="save-edit-title" class="ui small primary button in-edit tw-hidden tw-mr-0" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/title" {{if .Issue.IsPull}}data-target-update-url="{{$.RepoLink}}/pull/{{.Issue.Index}}/target_branch"{{end}}>{{ctx.Locale.Tr "repo.issues.save"}}</button>
 			</div>

templates/user/notification/notification_div.tmpl

@@ -1,8 +1,8 @@
 <div role="main" aria-label="{{.Title}}" class="page-content user notification" id="notification_div" data-sequence-number="{{.SequenceNumber}}">
 	<div class="ui container">
 		{{$notificationUnreadCount := call .NotificationUnreadCount}}
-		<div class="tw-flex tw-items-center tw-justify-between tw-mb-[--page-spacing]">
-			<div class="small-menu-items ui compact tiny menu">
+		<div class="tw-flex tw-items-center tw-justify-between tw-mb-4">
+			<div class="ui secondary partial menu">
 				<a class="{{if eq .Status 1}}active {{end}}item" href="{{AppSubUrl}}/notifications?q=unread">
 					{{ctx.Locale.Tr "notification.unread"}}
 					<div class="notifications-unread-count ui label {{if not $notificationUnreadCount}}tw-hidden{{end}}">{{$notificationUnreadCount}}</div>
@@ -11,10 +11,14 @@
 					{{ctx.Locale.Tr "notification.read"}}
 				</a>
 			</div>
+			<div class="tw-flex top-right-buttons">
+				<a class="ui tiny button" href="{{AppSubUrl}}/notifications/subscriptions">
+					{{ctx.Locale.Tr "notification.subscriptions"}}
+				</a>
 				{{if and (eq .Status 1)}}
-				<form action="{{AppSubUrl}}/notifications/purge" method="post">
+					<form class="{{if not $notificationUnreadCount}}tw-hidden{{end}}" action="{{AppSubUrl}}/notifications/purge" method="post">
 						{{$.CsrfTokenHtml}}
-					<div class="{{if not $notificationUnreadCount}}tw-hidden{{end}}">
+						<div>
 							<button class="ui mini button primary tw-mr-0" title="{{ctx.Locale.Tr "notification.mark_all_as_read"}}">
 								{{svg "octicon-checklist"}}
 							</button>
@@ -22,6 +26,7 @@
 					</form>
 				{{end}}
 			</div>
+		</div>
 		<div class="tw-p-0">
 			<div id="notification_table">
 				{{if not .Notifications}}

templates/user/notification/notification_subscriptions.tmpl

@@ -1,7 +1,8 @@
 {{template "base/head" .}}
 <div role="main" aria-label="{{.Title}}" class="page-content user notification">
 	<div class="ui container">
-		<div class="ui top attached tabular menu">
+		<div class="tw-flex tw-items-center tw-justify-between tw-mb-4">
+			<div class="ui secondary partial menu">
 				<a href="{{AppSubUrl}}/notifications/subscriptions" class="{{if eq .Status 1}}active {{end}}item">
 					{{ctx.Locale.Tr "notification.subscriptions"}}
 				</a>
@@ -9,7 +10,11 @@
 					{{ctx.Locale.Tr "notification.watching"}}
 				</a>
 			</div>
-		<div class="ui bottom attached active tab segment">
+			<a class="ui tiny button" href="{{AppSubUrl}}/notifications">
+				{{ctx.Locale.Tr "notifications"}}
+			</a>
+		</div>
+		<div class="ui bottom active tab segment">
 			{{if eq .Status 1}}
 				<div class="tw-flex tw-justify-between">
 					<div class="tw-flex">

web_src/css/base.css

@@ -246,6 +246,18 @@ h1.error-code {
   user-select: none;
 }
 
+.top-right-buttons {
+  gap: 0.5rem;
+}
+
+.top-right-buttons .ui.button {
+  margin-right: 0;
+}
+
+.ui.partial.secondary.menu {
+  margin-bottom: 0;
+}
+
 a {
   color: var(--color-primary);
   cursor: pointer;

web_src/css/repo.css

@@ -595,26 +595,18 @@ td .commit-summary {
   align-items: center;
 }
 
-.repository.view.issue .issue-title-buttons,
-.repository.view.issue .edit-buttons {
+.repository.view.issue .top-right-buttons {
   display: flex;
 }
 
-.issue-title-buttons {
-  gap: 0.5rem;
-}
-
 @media (max-width: 767.98px) {
   .repository.view.issue .issue-title {
     flex-direction: column;
   }
-  .repository.view.issue .issue-title-buttons,
-  .repository.view.issue .edit-buttons {
+  .repository.view.issue .top-right-buttons {
     width: 100%;
-    justify-content: space-between;
-  }
-  .repository.view.issue .edit-buttons {
     margin-top: .5rem;
+    justify-content: space-between;
   }
   .comment.form .issue-content-left .avatar {
     display: none;
@@ -628,6 +620,10 @@ td .commit-summary {
   .comment.form .content .form::after {
     display: none;
   }
+
+  .repository.view.issue .issue-title.edit-active h1 {
+    padding-right: 0;
+  }
 }
 
 .repository.view.issue .issue-title {
@@ -645,7 +641,7 @@ td .commit-summary {
   font-size: 32px;
   line-height: 40px;
   margin: 0;
-  padding-right: 0.25rem;
+  padding-right: 0.5rem;
   min-height: var(--repo-header-issue-min-height);
 }