gamzinav/forgejo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove jQuery class from the notification count (#30172)

Browse Source 
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the notification count and it works as before

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 56ac5f18e8022242316d86c8f3091bce554faebb)
This commit is contained in:
Yarden Shoham 2024-03-29 20:17:21 +03:00 committed by Gergely Nagy
parent 811c14b8ba
commit 6d164224e9
No known key found for this signature in database
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web_src/js/features/notification.js
View File

@ -1,5 +1,6 @@
import $ from 'jquery'; import $ from 'jquery';
import {GET} from '../modules/fetch.js'; import {GET} from '../modules/fetch.js';
import {toggleElem} from '../utils/dom.js';
const {appSubUrl, notificationSettings, assetVersionEncoded} = window.config; const {appSubUrl, notificationSettings, assetVersionEncoded} = window.config;
let notificationSequenceNumber = 0; let notificationSequenceNumber = 0;
@ -177,14 +178,11 @@ async function updateNotificationCount() {
const data = await response.json(); const data = await response.json();
const $notificationCount = $('.notification_count'); toggleElem('.notification_count', data.new !== 0);
if (data.new === 0) {
$notificationCount.addClass('tw-hidden');
} else {
$notificationCount.removeClass('tw-hidden');
}
$notificationCount.text(`${data.new}`); for (const el of document.getElementsByClassName('notification_count')) {
el.textContent = `${data.new}`;
}
return `${data.new}`; return `${data.new}`;
} catch (error) { } catch (error) {