forgejo

Author SHA1 Message Date

Author	SHA1	Message	Date
wxiaoguang	c18d8d6968	Remove legacy `+build:` constraint (#19582 ) Go 1.17 and later use modern `//go:build` constraints, the old `// +build:` constraints should be removed.	2022-05-02 23:22:45 +08:00
wxiaoguang	124b072f0b	Remove `git.Command.Run` and `git.Command.RunInDir` (#19280 ) Follows #19266, #8553, Close #18553, now there are only three `Run..(&RunOpts{})` functions. before: `stdout, err := RunInDir(path)` * now: `stdout, _, err := RunStdString(&git.RunOpts{Dir:path})`	2022-04-01 10:55:30 +08:00
wxiaoguang	b877504b03	Refactor `git.Command.Run`, introduce `RunWithContextString` and `RunWithContextBytes` (#19266 ) This follows https://github.com/go-gitea/gitea/issues/18553 Introduce `RunWithContextString` and `RunWithContextBytes` to help the refactoring. Add related unit tests. They keep the same behavior to save stderr into err.Error() as `RunInXxx` before. Remove `RunInDirTimeoutPipeline` `RunInDirTimeoutFullPipeline` `RunInDirTimeout` `RunInDirTimeoutEnv` `RunInDirPipeline` `RunInDirFullPipeline` `RunTimeout`, `RunInDirTimeoutEnvPipeline`, `RunInDirTimeoutEnvFullPipeline`, `RunInDirTimeoutEnvFullPipelineFunc`. Then remaining `RunInDir` `RunInDirBytes` `RunInDirWithEnv` can be easily refactored in next PR with a simple search & replace: * before: `stdout, err := RunInDir(path)` * next: `stdout, _, err := RunWithContextString(&git.RunContext{Dir:path})` Other changes: 1. When `timeout <= 0`, use default. Because `timeout==0` is meaningless and could cause bugs. And now many functions becomes more simple, eg: `GitGcRepos` 9 lines to 1 line. `Fsck` 6 lines to 1 line. 2. Only set defaultCommandExecutionTimeout when the option `setting.Git.Timeout.Default > 0`	2022-03-31 13:56:22 +02:00

wxiaoguang

c18d8d6968

Remove legacy +build: constraint (#19582 )

Go 1.17 and later use modern `//go:build` constraints, the old `// +build:` constraints should be removed.

2022-05-02 23:22:45 +08:00

wxiaoguang

124b072f0b

Remove git.Command.Run and git.Command.RunInDir* (#19280 )

Follows #19266, #8553, Close #18553, now there are only three `Run..(&RunOpts{})` functions.
 * before: `stdout, err := RunInDir(path)`
 * now: `stdout, _, err := RunStdString(&git.RunOpts{Dir:path})`

2022-04-01 10:55:30 +08:00

wxiaoguang

b877504b03

Refactor git.Command.Run*, introduce RunWithContextString and RunWithContextBytes (#19266 )

This follows 
* https://github.com/go-gitea/gitea/issues/18553

Introduce `RunWithContextString` and `RunWithContextBytes` to help the refactoring. Add related unit tests. They keep the same behavior to save stderr into err.Error() as `RunInXxx` before.

Remove `RunInDirTimeoutPipeline` `RunInDirTimeoutFullPipeline` `RunInDirTimeout` `RunInDirTimeoutEnv`  `RunInDirPipeline`  `RunInDirFullPipeline`  `RunTimeout`, `RunInDirTimeoutEnvPipeline`, `RunInDirTimeoutEnvFullPipeline`, `RunInDirTimeoutEnvFullPipelineFunc`.

Then remaining `RunInDir` `RunInDirBytes` `RunInDirWithEnv` can be easily refactored in next PR with a simple search & replace:
* before: `stdout, err := RunInDir(path)`
* next: `stdout, _, err := RunWithContextString(&git.RunContext{Dir:path})`

Other changes:
1. When `timeout <= 0`, use default. Because `timeout==0` is meaningless and could cause bugs. And now many functions becomes more simple, eg: `GitGcRepos` 9 lines to 1 line. `Fsck` 6 lines to 1 line.
2. Only set defaultCommandExecutionTimeout when the option `setting.Git.Timeout.Default > 0`

2022-03-31 13:56:22 +02:00

3 Commits