gamzinav/forgejo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
0801518f5d
forgejo/models/actions
History
Emmanuel BENOÎT 0801518f5d fix(actions): prevent deleted records' UUID from colliding with new records (#3830) 
This commit changes the code that deletes a runner so it updates the UUID before deleting the record. The new UUID is set to 8 0xff bytes followed by a little endian version of the record's numeric ID. Such UUIDs cannot be created from tokens when registering runners, as the first 16 bytes of the token are in the `[0-9a-f]` range. This should prevent deleted runners from colliding with new records if the tokens share the same first 16 characters.

It is a possible solution to issue #3828

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3830
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Emmanuel BENOÎT <tseeker@nocternity.net>
Co-committed-by: Emmanuel BENOÎT <tseeker@nocternity.net>
2024-05-19 10:46:15 +00:00
..
artifact.go Artifact deletion in actions ui (#27172) 2024-02-23 09:06:14 +01:00
forgejo_test.go [CLI] implement forgejo-cli 2024-02-05 13:33:58 +01:00
forgejo.go [CLI] implement forgejo-cli 2024-02-05 13:33:58 +01:00
main_test.go fix(actions): prevent deleted records' UUID from colliding with new records (#3830) 2024-05-19 10:46:15 +00:00
run_job_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
run_job.go Replace util.SliceXxx with slices.Xxx (#26958) 2023-09-07 09:37:47 +00:00
run_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
run.go Interpolate runs-on with variables when scheduling tasks (#30640) 2024-04-28 15:39:00 +02:00
runner_list.go Refactor more filterslice (gitea#30370) 2024-04-16 11:51:00 +02:00
runner_test.go fix(actions): prevent deleted records' UUID from colliding with new records (#3830) 2024-05-19 10:46:15 +00:00
runner_token_test.go Add unit tests for action runner token (#27670) 2023-10-19 07:24:24 +00:00
runner_token.go Fix typo "GetLatestRunnerToken" (#27680) 2023-10-18 15:52:44 +00:00
runner.go fix(actions): prevent deleted records' UUID from colliding with new records (#3830) 2024-05-19 10:46:15 +00:00
schedule_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
schedule_spec_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
schedule_spec.go chore(actions): support cron schedule task (#26655) 2023-08-24 03:06:51 +00:00
schedule.go Cancel previous runs of the same PR automatically (#29961) 2024-03-26 16:51:56 +01:00
status.go Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
task_list.go Add container.FilterSlice function (gitea#30339) 2024-04-16 11:49:44 +02:00
task_output.go Fix no ActionTaskOutput table waring (#28149) 2023-11-21 08:02:51 +00:00
task_step.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
task.go Fix ambiguous id when fetch Actions tasks (#30382) 2024-04-15 20:01:35 +02:00
tasks_version.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
utils_test.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
utils.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
variable.go Interpolate runs-on with variables when scheduling tasks (#30640) 2024-04-28 15:39:00 +02:00