gamzinav/forgejo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
88f835192d
forgejo/services/webhook
History
Jason Song 174213530d
Fix Permission in API returned repository struct (#25388) 
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
2023-06-22 13:08:08 +00:00
..
deliver_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
deliver.go Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
dingtalk_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
dingtalk.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
discord_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
discord.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
feishu_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
feishu.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
general_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
general.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
main_test.go Merge setting.InitXXX into one function with options (#24389) 2023-05-04 11:55:35 +08:00
matrix_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
matrix.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
msteams_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
msteams.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
notifier.go Fix Permission in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
packagist_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
packagist.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
payloader.go New webhook trigger for receiving Pull Request review requests (#24481) 2023-05-24 22:06:27 -04:00
slack_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
slack.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
telegram_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
telegram.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
webhook_test.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
webhook.go Rewrite queue (#24505) 2023-05-08 19:49:59 +08:00
wechatwork.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00