CONTRIB: move some dev-specific tools to dev/

The following directories were moved from contrib/ to dev/ to make their
use case a bit clearer. In short, only developers are expected to ever
go there. The makefile was updated to build and clean from these ones.

base64/  flags/  hpack/  plug_qdisc/  poll/  tcploop/  trace/

.github/workflows/contrib.yml

@@ -13,12 +13,12 @@ jobs:
     - name: Compile contrib/halog/halog
       run: |
         make contrib/halog/halog
-    - name: Compile contrib/debug/flags
+    - name: Compile dev/flags/flags
       run: |
-        make contrib/debug/flags
+        make dev/flags/flags
-    - name: Compile contrib/poll/poll
+    - name: Compile dev/poll/poll
       run: |
-        make contrib/poll/poll
+        make dev/poll/poll
-    - name: Compile contrib/hpack
+    - name: Compile dev/hpack
       run: |
-        make -C contrib/hpack
+        make -C dev/hpack

.gitignore

@@ -20,6 +20,7 @@
 !/VERDATE
 !/VERSION
 !/contrib
+!/dev
 !/doc
 !/ebtree
 !/examples
@@ -37,18 +38,18 @@
 *.orig
 *.bak
 # And reject some specific files
-/contrib/base64/base64rev
 /contrib/halog/halog
 /contrib/ip6range/ip6range
 /contrib/iprange/iprange
 /contrib/systemd/haproxy.service
 /contrib/spoa_example/spoa
-contrib/debug/flags
+dev/base64/base64rev-gen
-contrib/poll/poll
+dev/flags/flags
+dev/poll/poll
+dev/tcploop/tcploop
+dev/hpack/decode
+dev/hpack/gen-rht
 contrib/mod_defender/defender
 contrib/modsecurity/modsecurity
-contrib/hpack/decode
-contrib/hpack/gen-rht
-contrib/tcploop/tcploop
 /src/dlmalloc.c
 /tests/test_hashes

Makefile

@@ -929,14 +929,14 @@ objsize: haproxy
 contrib/halog/halog:
 	$(Q)$(MAKE) -C contrib/halog halog CC='$(cmd_CC)' OPTIMIZE='$(COPTS)'
 
-contrib/debug/flags:
+dev/flags/flags: dev/flags/flags.o
-	$(Q)$(MAKE) -C contrib/debug flags CC='$(cmd_CC)' OPTIMIZE='$(COPTS)'
+	$(cmd_LD) $(LDFLAGS) -o $@ $^ $(LDOPTS)
 
-contrib/debug/poll:
+dev/poll/poll:
-	$(Q)$(MAKE) -C contrib/debug poll CC='$(cmd_CC)' OPTIMIZE='$(COPTS)'
+	$(Q)$(MAKE) -C dev/poll poll CC='$(cmd_CC)' OPTIMIZE='$(COPTS)'
 
-contrib/tcploop/tcploop:
+dev/tcploop/tcploop:
-	$(Q)$(MAKE) -C contrib/tcploop tcploop CC='$(cmd_CC)' OPTIMIZE='$(COPTS)'
+	$(Q)$(MAKE) -C dev/tcploop tcploop CC='$(cmd_CC)' OPTIMIZE='$(COPTS)'
 
 # rebuild it every time
 .PHONY: src/version.c
@@ -991,11 +991,11 @@ uninstall:
 
 clean:
 	$(Q)rm -f *.[oas] src/*.[oas] haproxy test .build_opts .build_opts.new
-	$(Q)for dir in . src include/* doc; do rm -f $$dir/*~ $$dir/*.rej $$dir/core; done
+	$(Q)for dir in . src dev/* include/* doc; do rm -f $$dir/*~ $$dir/*.rej $$dir/core; done
 	$(Q)rm -f haproxy-$(VERSION).tar.gz haproxy-$(VERSION)$(SUBVERS)$(EXTRAVERSION).tar.gz
 	$(Q)rm -f haproxy-$(VERSION) haproxy-$(VERSION)$(SUBVERS)$(EXTRAVERSION) nohup.out gmon.out
-	$(Q)rm -f contrib/*/*.[oas] contrib/*/*/*.[oas] contrib/*/*/*/*.[oas]
+	$(Q)rm -f {dev,contrib}/*/*.[oas] {dev,contrib}/*/*/*.[oas] {dev,contrib}/*/*/*/*.[oas]
-	$(Q)rm -f contrib/halog/halog contrib/debug/flags contrib/poll/poll contrib/tcploop/tcploop
+	$(Q)rm -f contrib/halog/halog dev/flags/flags dev/poll/poll dev/tcploop/tcploop
 
 tags:
 	$(Q)find src include \( -name '*.c' -o -name '*.h' \) -print0 | \

dev/hpack/decode.c

@@ -2,7 +2,7 @@
  * HPACK stream decoder. Takes a series of hex codes on stdin using one line
  * per HEADERS frame. Spaces, tabs, CR, '-' and ',' are silently skipped.
  * e.g. :
- *   echo 82864188f439ce75c875fa5784 | contrib/hpack/decode
+ *   echo 82864188f439ce75c875fa5784 | dev/hpack/decode
  *
  * The DHT size may optionally be changed in argv[1].
  *

src/hpack-huff.c

@@ -304,7 +304,7 @@ static const struct huff ht[257] = {
 };
 
 
-/* Reversed huffman codes, generated by contrib/h2/gen-rht.c from the table
+/* Reversed huffman codes, generated by dev/hpack/gen-rht.c from the table
  * above.
  *
  * The codes are aligned on the MSB since that's how they appear in the stream.