gamzinav/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: mux-h2: Fix possible null pointer deref on h2c in _h2_trace_header()

Browse Source 
As reported by Coverity, this function may be called with no h2c. Thus, the
pointer must always be checked before any access. One test was missing in
TRACE_PRINTF_LOC().

This patch should fix the issue #2015. No backport needed, except if the
commit 11e8a8c2a ("MEDIUM: mux-h2/trace: add tracing support for headers")
is backported.

(cherry picked from commit c254516c53)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit b899aabd7aa8cf1daff519169fab3993a952812f)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
This commit is contained in:
Christopher Faulet 2023-01-30 08:26:09 +01:00
parent 17089e72d2
commit cf68c1918a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_h2.c
View File

@ -1033,7 +1033,7 @@ void _h2_trace_header(const struct ist hn, const struct ist hv,
chunk_appendf(&trash, " (... +%ld)", (long)(hv.len - v_ist.len));
TRACE_PRINTF_LOC(TRACE_LEVEL_USER, mask, trc_loc, func,
h2c->conn, 0, 0, 0,
(h2c ? h2c->conn : 0), 0, 0, 0,
"%s%s%s %s: %s", c_str, s_str,
(mask & H2_EV_TX_HDR) ? "sndh" : "rcvh",
n_ist.ptr, v_ist.ptr);