gamzinav/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MEDIUM: spoe: Be sure to create a SPOE applet if none on the current thread

Browse Source 
When a message is queued, waiting to be processed by a SPOE applet, there
are some heuristic to know if a new applet must be created or not. There are
2 conditions to skip the applet creation:

  1 - if there are enough idle applets on the current thread, or,

  2 - if the processing rate on the current thread is high enough to handle
      this new message

In the 2nd case, there is a flaw when the number of processed messages falls
to zero while the processing rate is still greater than zero. In that case,
we will skip the SPOE applet creation without taking care to check there is
at least one applet on the current thread.

So now, the conditions above to skip the SPOE applet creation are only
evaluated if there is at least one applet on the current thread.

This patch must be backported to every stable versions.

(cherry picked from commit 5e84f13a0b3b915990a4e25ec9448fdbef3c1a14)
Signed-off-by: Willy Tarreau <w@1wt.eu>
This commit is contained in:
Christopher Faulet 2024-07-09 08:24:05 +02:00 committed by Willy Tarreau
parent 276c0ce8e0
commit d13428f750
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flt_spoe.c
View File

@ -2090,8 +2090,9 @@ spoe_queue_context(struct spoe_context *ctx)
struct spoe_appctx *spoe_appctx;
/* Check if we need to create a new SPOE applet or not. */
if (agent->rt[tid].processing < agent->rt[tid].idles ||
agent->rt[tid].processing < read_freq_ctr(&agent->rt[tid].processing_per_sec))
if (!LIST_ISEMPTY(&agent->rt[tid].applets) &&
(agent->rt[tid].processing < agent->rt[tid].idles ||
agent->rt[tid].processing < read_freq_ctr(&agent->rt[tid].processing_per_sec)))
goto end;
SPOE_PRINTF(stderr, "%d.%06d [SPOE/%-15s] %s: stream=%p"