gamzinav/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: proto_tcp: delete fd from fdtab if listen() fails

Browse Source 
If listen() fails, fd should be deleted from fdtab, not just closed. Otherwise,
sock_inet_bind_receiver(), which is called in loop for each receiver, will
obtain the same fd via socket() for the next receiver, registered in the
receivers list. Then, it will bind it again and it will try to re-insert it in
fdtab, and fd_insert() will trigger the BUG_ON(fdtab[fd].owner != NULL) check.

When tcp_bind_listener() code was implemented, the use of fd_delete() was
not generalized and this one remained overlooked.

This can be backported to all stable versions.

(cherry picked from commit 308c6881c03b6302afd5cc48781d73a11ef994d4)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
This commit is contained in:
Valentine Krasnobaeva 2024-08-07 19:31:09 +02:00 committed by Christopher Faulet
parent be0d95414c
commit de397e2e97
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/proto_tcp.c
View File

@ -686,7 +686,7 @@ int tcp_bind_listener(struct listener *listener, char *errmsg, int errlen)
tcp_close_return:
free_trash_chunk(msg);
msg = NULL;
close(fd);
fd_delete(fd);
tcp_return:
if (msg && errlen && msg->data) {
char pn[INET6_ADDRSTRLEN];