glebfm/strace
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix readlink result display - was printing bogus "..." semi-randomly

Browse Source 
* file.c (decode_readlink): Use printstr() instead of printpathn().

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2012-01-27 17:24:26 +01:00
parent c76ae4352e
commit 3449ae83c2
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
file.c
View File

@ -2048,7 +2048,14 @@ decode_readlink(struct tcb *tcp, int offset)
if (syserror(tcp))
tprintf("%#lx", tcp->u_arg[offset + 1]);
else
printpathn(tcp, tcp->u_arg[offset + 1], tcp->u_rval);
/* Used to use printpathn(), but readlink
* neither includes NUL in the returned count,
* nor actually writes it into memory.
* printpathn() would decide on printing
* "..." continuation based on garbage
* past return buffer's end.
*/
printstr(tcp, tcp->u_arg[offset + 1], tcp->u_rval);
tprintf(", %lu", tcp->u_arg[offset + 2]);
}
return 0;