glebfm/strace
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fcntl: replace combinations of xlookup and printxval with printxvals

Browse Source 
After all, that's what printxvals for.

* fcntl.c (SYS_FUNC(fcntl), SYS_FUNC(fcntl64)): Use printxvals for
printing value with multiple xlat tables as constant sources.
This commit is contained in:
Eugene Syromyatnikov 2018-04-04 14:12:08 +02:00 committed by Dmitry V. Levin
parent eaabf55ad2
commit 39530d489a
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
fcntl.c
View File

@ -198,17 +198,13 @@ SYS_FUNC(fcntl)
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
const unsigned int cmd = tcp->u_arg[1];
const char *str = xlookup(fcntlcmds, cmd);
if (str) {
tprints(str);
} else {
/*
* fcntl syscall does not recognize these
* constants, but we would like to show them
* for better debugging experience.
*/
printxval(fcntl64cmds, cmd, "F_???");
}
/*
* fcntl syscall does not recognize fcntl64 command constants,
* but we would like to show them for better debugging
* experience.
*/
printxvals(cmd, "F_???", fcntlcmds, fcntl64cmds, NULL);
}
return print_fcntl(tcp);
}
@ -219,12 +215,7 @@ SYS_FUNC(fcntl64)
if (entering(tcp)) {
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
const char *str = xlookup(fcntl64cmds, cmd);
if (str) {
tprints(str);
} else {
printxval(fcntlcmds, cmd, "F_???");
}
printxvals(cmd, "F_???", fcntl64cmds, fcntlcmds, NULL);
}
switch (cmd) {
case F_SETLK64: