glebfm/strace
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

decode_select: fix potential use of an uninitialized variable

Browse Source 
A pointer to fd_set was used uninitialized when nfds == 0.

* desc.c (decode_select): Initialize fds.

Reported-by: Zubin Mithra <zubin.mithra@gmail.com>
This commit is contained in:
Дмитрий Левин 2014-09-09 22:42:12 +00:00
parent b7dd5e63bf
commit 6522f132ba
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
desc.c
View File

@ -314,7 +314,7 @@ decode_select(struct tcb *tcp, long *args, enum bitness_t bitness)
{
int i, j;
int nfds, fdsize;
fd_set *fds;
fd_set *fds = NULL;
const char *sep;
long arg;
@ -322,10 +322,9 @@ decode_select(struct tcb *tcp, long *args, enum bitness_t bitness)
nfds = (int) args[0];
/* Kernel rejects negative nfds, so we don't parse it either. */
if (nfds < 0) {
if (nfds < 0)
nfds = 0;
fds = NULL;
}
/* Beware of select(2^31-1, NULL, NULL, NULL) and similar... */
if (nfds > 1024*1024)
nfds = 1024*1024;