glebfm/strace
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove unused version of sys_lseek

Browse Source 
It is buggy: it returns RVAL_LUDECIMAL, which means the return value
is in tcp->u_lrval. But tcp->u_lrval is never set
(on Linux - it used to be set on other OSes).

* file.c (sys_lseek): Remove a version of this function which is
supposed to be used if off_t is long long. It appears to be buggy
and unused.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2012-03-18 04:13:14 +01:00
parent 8677913953
commit 88c63f21b1
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
file.c
View File

@ -520,25 +520,6 @@ sys_lseek(struct tcb *tcp)
return RVAL_UDECIMAL;
}
# endif
#else /* HAVE_LONG_LONG_OFF_T */
/*
* ??? Any arch using it? I386 doesn't...
*/
int
sys_lseek(struct tcb *tcp)
{
if (entering(tcp)) {
int argn;
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
if (tcp->u_arg[3] == SEEK_SET)
argn = printllval(tcp, "%llu, ", 1);
else
argn = printllval(tcp, "%lld, ", 1);
printxval(whence, tcp->u_arg[argn], "SEEK_???");
}
return RVAL_LUDECIMAL;
}
#endif
int