2004-03-01 Roland McGrath <roland@redhat.com>

* strace.c (main): Avoid potential buffer overruns from ludicrous
	arguments or PATH values.
This commit is contained in:
Roland McGrath 2004-03-02 06:50:04 +00:00
parent 801bf1ff33
commit bdb09df186

View File

@ -417,8 +417,14 @@ char *argv[];
char pathname[MAXPATHLEN];
filename = argv[optind];
if (strchr(filename, '/'))
if (strchr(filename, '/')) {
if (strlen(filename) > sizeof pathname - 1) {
errno = ENAMETOOLONG;
perror("strace: exec");
exit(1);
}
strcpy(pathname, filename);
}
#ifdef USE_DEBUGGING_EXEC
/*
* Debuggers customarily check the current directory
@ -443,6 +449,8 @@ char *argv[];
getcwd(pathname, MAXPATHLEN);
len = strlen(pathname);
}
else if (n > sizeof pathname - 1)
continue;
else {
strncpy(pathname, path, n);
len = n;