glebfm/strace
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tests: fix potential errno clobbering in netlink_kobject_uevent.test

Browse Source 
* tests/netlink_kobject_uevent.c (errstr): New variable.
(sys_send): New function.
(main): Use them.
This commit is contained in:
Дмитрий Левин 2018-04-04 12:24:19 +00:00
parent 54fab3cd0c
commit d453156784
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/netlink_kobject_uevent.c
View File

@ -31,12 +31,21 @@
#include <sys/socket.h> #include <sys/socket.h>
#include "netlink.h" #include "netlink.h"
static const char *errstr;
static ssize_t
sys_send(const int fd, const void *const buf, const size_t len)
{
const ssize_t rc = sendto(fd, buf, len, MSG_DONTWAIT, NULL, 0);
errstr = sprintrc(rc);
return rc;
}
int int
main(void) main(void)
{ {
skip_if_unavailable("/proc/self/fd/"); skip_if_unavailable("/proc/self/fd/");
long rc;
int fd = create_nl_socket(NETLINK_KOBJECT_UEVENT); int fd = create_nl_socket(NETLINK_KOBJECT_UEVENT);
/* test using data that looks like a zero-length C string */ /* test using data that looks like a zero-length C string */
@ -44,17 +53,17 @@ main(void)
buf[0] = '='; buf[0] = '=';
fill_memory_ex(buf + 1, DEFAULT_STRLEN, 0, DEFAULT_STRLEN); fill_memory_ex(buf + 1, DEFAULT_STRLEN, 0, DEFAULT_STRLEN);
rc = sendto(fd, buf + 1, DEFAULT_STRLEN, MSG_DONTWAIT, NULL, 0); sys_send(fd, buf + 1, DEFAULT_STRLEN);
printf("sendto(%d, ", fd); printf("sendto(%d, ", fd);
print_quoted_memory(buf + 1, DEFAULT_STRLEN); print_quoted_memory(buf + 1, DEFAULT_STRLEN);
printf(", %u, MSG_DONTWAIT, NULL, 0) = %s\n", printf(", %u, MSG_DONTWAIT, NULL, 0) = %s\n",
DEFAULT_STRLEN, sprintrc(rc)); DEFAULT_STRLEN, errstr);
rc = sendto(fd, buf, DEFAULT_STRLEN + 1, MSG_DONTWAIT, NULL, 0); sys_send(fd, buf, DEFAULT_STRLEN + 1);
printf("sendto(%d, ", fd); printf("sendto(%d, ", fd);
print_quoted_memory(buf, DEFAULT_STRLEN); print_quoted_memory(buf, DEFAULT_STRLEN);
printf("..., %u, MSG_DONTWAIT, NULL, 0) = %s\n", printf("..., %u, MSG_DONTWAIT, NULL, 0) = %s\n",
DEFAULT_STRLEN + 1, sprintrc(rc)); DEFAULT_STRLEN + 1, errstr);
puts("+++ exited with 0 +++"); puts("+++ exited with 0 +++");
return 0; return 0;