2 Commits

Author	SHA1	Message	Date
Eugene Syromyatnikov	4c9ed3f146	Implement injection of negative return values ... Extend the range of injected return value to the maximum, print warnings if negative injection value can be clipped in compat personality or can inadvertently turn into a fault injection. * defs.h (INJECT_F_ERROR): New macro. * filter_qualify.c (parse_inject_token): Revert type of intval local variable back to int, check INJECT_F_ERROR along with INJECT_F_RETVAL, use strtoull to parse retval argument, print warnings in case of retval clipping and inadvertent fault injection. (qualify_inject_common): Set INJECT_F_ERROR instead of INJECT_F_RETVAL. * syscall.c (tamper_with_syscall_exiting): Check inject_data.flags to determine whether a fault injection or retval injection has to be performed. (syscall_exiting_trace) <case RVAL_DECIMAL>: Explicitly print tcp->u_rval as int if current_klongsize < sizeof(tcp->u_rval). * tests/inject-nf.c (main): Update. * tests/inject-nf.test: Test injection of negative return values. * tests/qual_inject-syntax.test: Remove retval=-1 check as it is now allowed, add checks for invalid retval parameters. Co-Authored-by: Dmitry V. Levin <ldv@altlinux.org>	2018-03-29 01:30:09 +00:00
Eugene Syromyatnikov	58598cd7f6	tests: check injection of return values into a "never fails" syscall ... * tests/inject-nf.c: New file. * tests/inject-nf.test: New test. * tests/.gitignore: Add inject-nf. * tests/Makefile.am (check_PROGRAMS): Likewise. (MISC_TESTS): Add inject-nf.test. Co-Authored-by: Dmitry V. Levin <ldv@altlinux.org>	2018-03-23 13:43:13 +00:00