strace/uid.c
Dmitry V. Levin 5e9944df2c Fix corner cases of getgroups and setgroups syscall decoders
* uid.c (print_groups): New function.
(SYS_FUNC(setgroups), SYS_FUNC(getgroups)): Use it.
Print first syscall argument using %u format.
* tests/getgroups.c: New file.
* tests/getgroups.test: New test.
* tests/getgroups32.c: New file.
* tests/getgroups32.test: New test.
* tests/setgroups.c: New file.
* tests/setgroups.test: New test.
* tests/setgroups32.c: New file.
* tests/setgroups32.test: New test.
* tests/.gitignore: Add getgroups, getgroups32, setgroups,
and setgroups32.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add getgroups.test, getgroups32.test,
setgroups.test, and setgroups32.test.
2016-04-20 01:08:13 +00:00

223 lines
5.2 KiB
C

/*
* Copyright (c) 1991, 1992 Paul Kranenburg <pk@cs.few.eur.nl>
* Copyright (c) 1993 Branko Lankester <branko@hacktic.nl>
* Copyright (c) 1993-1996 Rick Sladkey <jrs@world.std.com>
* Copyright (c) 1996-1999 Wichert Akkerman <wichert@cistron.nl>
* Copyright (c) 2003-2016 Dmitry V. Levin <ldv@altlinux.org>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. The name of the author may not be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#ifdef STRACE_UID_SIZE
# if STRACE_UID_SIZE != 16
# error invalid STRACE_UID_SIZE
# endif
# define SIZEIFY(x) SIZEIFY_(x,STRACE_UID_SIZE)
# define SIZEIFY_(x,size) SIZEIFY__(x,size)
# define SIZEIFY__(x,size) x ## size
# define printuid SIZEIFY(printuid)
# define sys_chown SIZEIFY(sys_chown)
# define sys_fchown SIZEIFY(sys_fchown)
# define sys_getgroups SIZEIFY(sys_getgroups)
# define sys_getresuid SIZEIFY(sys_getresuid)
# define sys_getuid SIZEIFY(sys_getuid)
# define sys_setfsuid SIZEIFY(sys_setfsuid)
# define sys_setgroups SIZEIFY(sys_setgroups)
# define sys_setresuid SIZEIFY(sys_setresuid)
# define sys_setreuid SIZEIFY(sys_setreuid)
# define sys_setuid SIZEIFY(sys_setuid)
#endif /* STRACE_UID_SIZE */
#include "defs.h"
#ifdef STRACE_UID_SIZE
# if !NEED_UID16_PARSERS
# undef STRACE_UID_SIZE
# endif
#else
# define STRACE_UID_SIZE 32
#endif
#ifdef STRACE_UID_SIZE
# undef uid_t
# define uid_t uid_t_(STRACE_UID_SIZE)
# define uid_t_(size) uid_t__(size)
# define uid_t__(size) uint ## size ## _t
SYS_FUNC(getuid)
{
return RVAL_UDECIMAL | RVAL_DECODED;
}
SYS_FUNC(setfsuid)
{
tprintf("%u", (uid_t) tcp->u_arg[0]);
return RVAL_UDECIMAL | RVAL_DECODED;
}
SYS_FUNC(setuid)
{
printuid("", tcp->u_arg[0]);
return RVAL_DECODED;
}
static void
get_print_uid(struct tcb *tcp, const char *prefix, const long addr)
{
uid_t uid;
tprints(prefix);
if (!umove_or_printaddr(tcp, addr, &uid))
tprintf("[%u]", uid);
}
SYS_FUNC(getresuid)
{
if (entering(tcp))
return 0;
get_print_uid(tcp, "", tcp->u_arg[0]);
get_print_uid(tcp, ", ", tcp->u_arg[1]);
get_print_uid(tcp, ", ", tcp->u_arg[2]);
return 0;
}
SYS_FUNC(setreuid)
{
printuid("", tcp->u_arg[0]);
printuid(", ", tcp->u_arg[1]);
return RVAL_DECODED;
}
SYS_FUNC(setresuid)
{
printuid("", tcp->u_arg[0]);
printuid(", ", tcp->u_arg[1]);
printuid(", ", tcp->u_arg[2]);
return RVAL_DECODED;
}
SYS_FUNC(chown)
{
printpath(tcp, tcp->u_arg[0]);
printuid(", ", tcp->u_arg[1]);
printuid(", ", tcp->u_arg[2]);
return RVAL_DECODED;
}
SYS_FUNC(fchown)
{
printfd(tcp, tcp->u_arg[0]);
printuid(", ", tcp->u_arg[1]);
printuid(", ", tcp->u_arg[2]);
return RVAL_DECODED;
}
void
printuid(const char *text, const unsigned int uid)
{
if ((uid_t) -1U == (uid_t) uid)
tprintf("%s-1", text);
else
tprintf("%s%u", text, (uid_t) uid);
}
static void
print_groups(struct tcb *tcp, const unsigned int len, const unsigned long addr)
{
static unsigned long ngroups_max;
if (!ngroups_max)
ngroups_max = sysconf(_SC_NGROUPS_MAX);
const unsigned int size = len * sizeof(uid_t);
const unsigned long end = addr + size;
if (!addr || !verbose(tcp) || size / sizeof(uid_t) != len
|| len > ngroups_max || end < addr) {
printaddr(addr);
return;
}
if (len == 0) {
tprints("[]");
return;
}
const unsigned long abbrev_end =
(abbrev(tcp) && max_strlen < len) ?
addr + max_strlen * sizeof(uid_t) : end;
unsigned long cur;
for (cur = addr; cur < end; cur += sizeof(uid_t)) {
if (cur != addr)
tprints(", ");
uid_t gid;
if (umove_or_printaddr(tcp, cur, &gid))
break;
if (cur == addr)
tprints("[");
if (cur >= abbrev_end) {
tprints("...");
cur = end;
break;
}
tprintf("%u", (unsigned int) gid);
}
if (cur != addr)
tprints("]");
}
SYS_FUNC(setgroups)
{
const unsigned int len = tcp->u_arg[0];
tprintf("%u, ", len);
print_groups(tcp, len, tcp->u_arg[1]);
return RVAL_DECODED;
}
SYS_FUNC(getgroups)
{
if (entering(tcp))
tprintf("%u, ", (unsigned int) tcp->u_arg[0]);
else
print_groups(tcp, tcp->u_rval, tcp->u_arg[1]);
return 0;
}
#endif /* STRACE_UID_SIZE */