Dmitry V. Levin
d54388e1ce
When umoven_func invocation fails to fetch data, it prints the faulty address. If this happens to a subsequent umoven_func invocation, the printed address may be undistinguishable from a valid data printed by print_func, e.g. when the data is printed in a numeric form like [0x1, 0x2, 0x3, 0xdefaced]. Fix this source of confusion by moving the printing of the faulty address from umoven_func to print_array itself. This change renames umoven_func to tfetch_mem_func and changes its semantics, so that - tfetch_mem_func never prints anything; - tfetch_mem_func returns true if the fetch succeeded, and false otherwise. * defs.h (print_array): Replace umoven_func argument with tfetch_mem_func. * util.c (print_array): Replace umoven_func argument with tfetch_mem_func, document expected tfetch_mem_func return value semantics. When tfetch_mem_func returns false, print either addr or "... /* addr */" depending on the context (inside the array or not). * bpf.c (print_ebpf_prog, print_bpf_prog_info, BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. * bpf_filter.c (print_bpf_fprog): Likewise. * btrfs.c (btrfs_print_logical_ino_container, btrfs_print_ino_path_container, btrfs_print_qgroup_inherit, btrfs_ioctl): Likewise. * dm.c (dm_decode_dm_target_deps): Likewise. * epoll.c (epoll_wait_common): Likewise. * file_ioctl.c (file_ioctl): Likewise. * ipc_sem.c (tprint_sembuf_array): Likewise. * kexec.c (print_kexec_segments): Likewise. * mem.c (SYS_FUNC(subpage_prot)): Likewise. * net.c (print_getsockopt): Likewise. * netlink.c (decode_nlmsgerr_attr_cookie): Likewise. * netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise. * netlink_packet_diag.c (decode_packet_diag_mclist): Likewise. * netlink_unix_diag.c (decode_unix_diag_inode): Likewise. * nlattr.c (decode_nla_meminfo): Likewise. * numa.c (print_nodemask, SYS_FUNC(move_pages), * perf_ioctl.c (perf_ioctl_query_bpf): Likewise. * poll.c (decode_poll_entering): Likewise. * printsiginfo.c (print_siginfo_array): Likewise. * rtnl_tc.c (decode_tca_stab_data): Likewise. * sock.c (decode_ifconf): Likewise. * uid.c (print_groups): Likewise. * io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename to fetch_struct_mmsghdr_for_print, do not print address, return bool. (decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr with fetch_struct_mmsghdr_for_print. * tests/aio.c (main): Update expected output. * tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise. * tests/ioctl_perf-success.c (main): Likewise. * tests/ioctl_v4l2.c (main): Update expected output. * tests/kexec_load.c (main): Likewise. * tests/mmsg_name.c (test_mmsg_name): Update expected output. * tests/move_pages.c (print_page_array, print_node_array): Likewise. * tests/poll.c (print_pollfd_array_entering): Likewise. * tests/preadv-pwritev.c (main): Likewise. * tests/preadv2-pwritev2.c (dumpio): Likewise. * tests/process_vm_readv_writev.c (print_iov): Likewise. * tests/pwritev.c (print_iovec): Likewise. * tests/readv.c (main): Likewise. * tests/seccomp-filter-v.c * tests/semop.c (main): Likewise. * tests/set_mempolicy.c (print_nodes): Likewise. * tests/setgroups.c (main): Likewise. * tests/test_nlattr.h (print_nlattr) Likewise. Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
178 lines
5.1 KiB
C
178 lines
5.1 KiB
C
/*
|
|
* Copyright (c) 2016 Fabien Siron <fabien.siron@epita.fr>
|
|
* Copyright (c) 2017 JingPiao Chen <chenjingpiao@gmail.com>
|
|
* Copyright (c) 2017-2018 The strace developers.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "defs.h"
|
|
#include "netlink.h"
|
|
#include "netlink_sock_diag.h"
|
|
#include "nlattr.h"
|
|
#include "print_fields.h"
|
|
|
|
#include <linux/sock_diag.h>
|
|
#include <linux/unix_diag.h>
|
|
|
|
#include "xlat/unix_diag_attrs.h"
|
|
#include "xlat/unix_diag_show.h"
|
|
|
|
DECL_NETLINK_DIAG_DECODER(decode_unix_diag_req)
|
|
{
|
|
struct unix_diag_req req = { .sdiag_family = family };
|
|
const size_t offset = sizeof(req.sdiag_family);
|
|
|
|
PRINT_FIELD_XVAL("{", req, sdiag_family, addrfams, "AF_???");
|
|
tprints(", ");
|
|
if (len >= sizeof(req)) {
|
|
if (!umoven_or_printaddr(tcp, addr + offset,
|
|
sizeof(req) - offset,
|
|
(char *) &req + offset)) {
|
|
PRINT_FIELD_U("", req, sdiag_protocol);
|
|
PRINT_FIELD_FLAGS(", ", req, udiag_states,
|
|
tcp_state_flags, "1<<TCP_???");
|
|
PRINT_FIELD_U(", ", req, udiag_ino);
|
|
PRINT_FIELD_FLAGS(", ", req, udiag_show,
|
|
unix_diag_show, "UDIAG_SHOW_???");
|
|
PRINT_FIELD_COOKIE(", ", req, udiag_cookie);
|
|
}
|
|
} else
|
|
tprints("...");
|
|
tprints("}");
|
|
}
|
|
|
|
static bool
|
|
decode_unix_diag_vfs(struct tcb *const tcp,
|
|
const kernel_ulong_t addr,
|
|
const unsigned int len,
|
|
const void *const opaque_data)
|
|
{
|
|
struct unix_diag_vfs uv;
|
|
|
|
if (len < sizeof(uv))
|
|
return false;
|
|
if (umove_or_printaddr(tcp, addr, &uv))
|
|
return true;
|
|
|
|
PRINT_FIELD_DEV("{", uv, udiag_vfs_dev);
|
|
PRINT_FIELD_U(", ", uv, udiag_vfs_ino);
|
|
tprints("}");
|
|
|
|
return true;
|
|
}
|
|
|
|
static bool
|
|
print_inode(struct tcb *const tcp,
|
|
void *const elem_buf,
|
|
const size_t elem_size,
|
|
void *const opaque_data)
|
|
{
|
|
tprintf("%" PRIu32, *(uint32_t *) elem_buf);
|
|
|
|
return true;
|
|
}
|
|
|
|
static bool
|
|
decode_unix_diag_inode(struct tcb *const tcp,
|
|
const kernel_ulong_t addr,
|
|
const unsigned int len,
|
|
const void *const opaque_data)
|
|
{
|
|
uint32_t inode;
|
|
const size_t nmemb = len / sizeof(inode);
|
|
|
|
if (!nmemb)
|
|
return false;
|
|
|
|
print_array(tcp, addr, nmemb, &inode, sizeof(inode),
|
|
tfetch_mem, print_inode, 0);
|
|
|
|
return true;
|
|
}
|
|
|
|
static bool
|
|
decode_unix_diag_rqlen(struct tcb *const tcp,
|
|
const kernel_ulong_t addr,
|
|
const unsigned int len,
|
|
const void *const opaque_data)
|
|
{
|
|
struct unix_diag_rqlen rql;
|
|
|
|
if (len < sizeof(rql))
|
|
return false;
|
|
if (umove_or_printaddr(tcp, addr, &rql))
|
|
return true;
|
|
|
|
PRINT_FIELD_U("{", rql, udiag_rqueue);
|
|
PRINT_FIELD_U(", ", rql, udiag_wqueue);
|
|
tprints("}");
|
|
|
|
return true;
|
|
}
|
|
|
|
static const nla_decoder_t unix_diag_msg_nla_decoders[] = {
|
|
[UNIX_DIAG_NAME] = decode_nla_str,
|
|
[UNIX_DIAG_VFS] = decode_unix_diag_vfs,
|
|
[UNIX_DIAG_PEER] = decode_nla_u32,
|
|
[UNIX_DIAG_ICONS] = decode_unix_diag_inode,
|
|
[UNIX_DIAG_RQLEN] = decode_unix_diag_rqlen,
|
|
[UNIX_DIAG_MEMINFO] = decode_nla_meminfo,
|
|
[UNIX_DIAG_SHUTDOWN] = decode_nla_u8
|
|
};
|
|
|
|
DECL_NETLINK_DIAG_DECODER(decode_unix_diag_msg)
|
|
{
|
|
struct unix_diag_msg msg = { .udiag_family = family };
|
|
size_t offset = sizeof(msg.udiag_family);
|
|
bool decode_nla = false;
|
|
|
|
PRINT_FIELD_XVAL("{", msg, udiag_family, addrfams, "AF_???");
|
|
tprints(", ");
|
|
if (len >= sizeof(msg)) {
|
|
if (!umoven_or_printaddr(tcp, addr + offset,
|
|
sizeof(msg) - offset,
|
|
(char *) &msg + offset)) {
|
|
PRINT_FIELD_XVAL("", msg, udiag_type,
|
|
socktypes, "SOCK_???");
|
|
PRINT_FIELD_XVAL(", ", msg, udiag_state,
|
|
tcp_states, "TCP_???");
|
|
PRINT_FIELD_U(", ", msg, udiag_ino);
|
|
PRINT_FIELD_COOKIE(", ", msg, udiag_cookie);
|
|
decode_nla = true;
|
|
}
|
|
} else
|
|
tprints("...");
|
|
tprints("}");
|
|
|
|
offset = NLMSG_ALIGN(sizeof(msg));
|
|
if (decode_nla && len > offset) {
|
|
tprints(", ");
|
|
decode_nlattr(tcp, addr + offset, len - offset,
|
|
unix_diag_attrs, "UNIX_DIAG_???",
|
|
unix_diag_msg_nla_decoders,
|
|
ARRAY_SIZE(unix_diag_msg_nla_decoders), NULL);
|
|
}
|
|
}
|