Dmitry V. Levin
d54388e1ce
When umoven_func invocation fails to fetch data, it prints the faulty address. If this happens to a subsequent umoven_func invocation, the printed address may be undistinguishable from a valid data printed by print_func, e.g. when the data is printed in a numeric form like [0x1, 0x2, 0x3, 0xdefaced]. Fix this source of confusion by moving the printing of the faulty address from umoven_func to print_array itself. This change renames umoven_func to tfetch_mem_func and changes its semantics, so that - tfetch_mem_func never prints anything; - tfetch_mem_func returns true if the fetch succeeded, and false otherwise. * defs.h (print_array): Replace umoven_func argument with tfetch_mem_func. * util.c (print_array): Replace umoven_func argument with tfetch_mem_func, document expected tfetch_mem_func return value semantics. When tfetch_mem_func returns false, print either addr or "... /* addr */" depending on the context (inside the array or not). * bpf.c (print_ebpf_prog, print_bpf_prog_info, BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. * bpf_filter.c (print_bpf_fprog): Likewise. * btrfs.c (btrfs_print_logical_ino_container, btrfs_print_ino_path_container, btrfs_print_qgroup_inherit, btrfs_ioctl): Likewise. * dm.c (dm_decode_dm_target_deps): Likewise. * epoll.c (epoll_wait_common): Likewise. * file_ioctl.c (file_ioctl): Likewise. * ipc_sem.c (tprint_sembuf_array): Likewise. * kexec.c (print_kexec_segments): Likewise. * mem.c (SYS_FUNC(subpage_prot)): Likewise. * net.c (print_getsockopt): Likewise. * netlink.c (decode_nlmsgerr_attr_cookie): Likewise. * netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise. * netlink_packet_diag.c (decode_packet_diag_mclist): Likewise. * netlink_unix_diag.c (decode_unix_diag_inode): Likewise. * nlattr.c (decode_nla_meminfo): Likewise. * numa.c (print_nodemask, SYS_FUNC(move_pages), * perf_ioctl.c (perf_ioctl_query_bpf): Likewise. * poll.c (decode_poll_entering): Likewise. * printsiginfo.c (print_siginfo_array): Likewise. * rtnl_tc.c (decode_tca_stab_data): Likewise. * sock.c (decode_ifconf): Likewise. * uid.c (print_groups): Likewise. * io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename to fetch_struct_mmsghdr_for_print, do not print address, return bool. (decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr with fetch_struct_mmsghdr_for_print. * tests/aio.c (main): Update expected output. * tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise. * tests/ioctl_perf-success.c (main): Likewise. * tests/ioctl_v4l2.c (main): Update expected output. * tests/kexec_load.c (main): Likewise. * tests/mmsg_name.c (test_mmsg_name): Update expected output. * tests/move_pages.c (print_page_array, print_node_array): Likewise. * tests/poll.c (print_pollfd_array_entering): Likewise. * tests/preadv-pwritev.c (main): Likewise. * tests/preadv2-pwritev2.c (dumpio): Likewise. * tests/process_vm_readv_writev.c (print_iov): Likewise. * tests/pwritev.c (print_iovec): Likewise. * tests/readv.c (main): Likewise. * tests/seccomp-filter-v.c * tests/semop.c (main): Likewise. * tests/set_mempolicy.c (print_nodes): Likewise. * tests/setgroups.c (main): Likewise. * tests/test_nlattr.h (print_nlattr) Likewise. Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
166 lines
5.2 KiB
C
166 lines
5.2 KiB
C
/*
|
|
* Check decoding of successful PERF_EVENT_IOC_{ID,QUERY_BPF} ioctls.
|
|
*
|
|
* Copyright (c) 2018 The strace developers.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "tests.h"
|
|
|
|
#ifdef HAVE_LINUX_PERF_EVENT_H
|
|
|
|
# include <assert.h>
|
|
# include <inttypes.h>
|
|
# include <stdio.h>
|
|
# include <stdlib.h>
|
|
# include <string.h>
|
|
# include <sys/ioctl.h>
|
|
# include <linux/perf_event.h>
|
|
|
|
# ifndef PERF_EVENT_IOC_ID
|
|
# define PERF_EVENT_IOC_ID _IOR('$', 7, void *)
|
|
# endif
|
|
|
|
# ifndef PERF_EVENT_IOC_QUERY_BPF
|
|
# define PERF_EVENT_IOC_QUERY_BPF _IOWR('$', 10, void *)
|
|
|
|
struct perf_event_query_bpf {
|
|
uint32_t ids_len;
|
|
uint32_t prog_cnt;
|
|
uint32_t ids[0];
|
|
};
|
|
# endif
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
static const uint64_t magic64 = 0xfacefeeddeadc0deULL;
|
|
|
|
TAIL_ALLOC_OBJECT_CONST_PTR(uint64_t, u64_ptr);
|
|
uint64_t *const u64_efault = u64_ptr + 1;
|
|
uint32_t *const u32_arr = tail_alloc(sizeof(uint32_t) * 4);
|
|
uint32_t *const u32_efault = u32_arr + 4;
|
|
|
|
unsigned long num_skip;
|
|
long inject_retval;
|
|
bool locked = false;
|
|
|
|
*u64_ptr = magic64;
|
|
|
|
if (argc == 1)
|
|
return 0;
|
|
|
|
if (argc < 3)
|
|
error_msg_and_fail("Usage: %s NUM_SKIP INJECT_RETVAL", argv[0]);
|
|
|
|
num_skip = strtoul(argv[1], NULL, 0);
|
|
inject_retval = strtol(argv[2], NULL, 0);
|
|
|
|
if (inject_retval < 0)
|
|
error_msg_and_fail("Expected non-negative INJECT_RETVAL, "
|
|
"but got %ld", inject_retval);
|
|
|
|
for (unsigned long i = 0; i < num_skip; i++) {
|
|
long ret = ioctl(-1, PERF_EVENT_IOC_ID, NULL);
|
|
|
|
printf("ioctl(-1, PERF_EVENT_IOC_ID, NULL) = %s%s\n",
|
|
sprintrc(ret),
|
|
ret == inject_retval ? " (INJECTED)" : "");
|
|
|
|
if (ret != inject_retval)
|
|
continue;
|
|
|
|
locked = true;
|
|
break;
|
|
}
|
|
|
|
if (!locked)
|
|
error_msg_and_fail("Hasn't locked on ioctl(-1"
|
|
", PERF_EVENT_IOC_ID, NULL) returning %lu",
|
|
inject_retval);
|
|
|
|
/* PERF_EVENT_IOC_ID */
|
|
assert(ioctl(-1, PERF_EVENT_IOC_ID, NULL) == inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_ID, NULL) = %ld (INJECTED)\n",
|
|
inject_retval);
|
|
|
|
assert(ioctl(-1, PERF_EVENT_IOC_ID, u64_efault) == inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_ID, %p) = %ld (INJECTED)\n",
|
|
u64_efault, inject_retval);
|
|
|
|
assert(ioctl(-1, PERF_EVENT_IOC_ID, u64_ptr) == inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_ID, [%" PRIu64 "]) = %ld (INJECTED)\n",
|
|
magic64, inject_retval);
|
|
|
|
/* PERF_EVENT_IOC_QUERY_BPF */
|
|
assert(ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, NULL) == inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, NULL) = %ld (INJECTED)\n",
|
|
inject_retval);
|
|
|
|
assert(ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, u32_efault)
|
|
== inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, %p) = %ld (INJECTED)\n",
|
|
u32_efault, inject_retval);
|
|
|
|
u32_arr[3] = 0xdeadbeef;
|
|
assert(ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, u32_arr + 3)
|
|
== inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, {ids_len=3735928559, ...}) "
|
|
"= %ld (INJECTED)\n",
|
|
inject_retval);
|
|
|
|
u32_arr[2] = 0xdecaffed;
|
|
assert(ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, u32_arr + 2)
|
|
== inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, {ids_len=3737845741"
|
|
", prog_cnt=3735928559, ids=%p})"
|
|
" = %ld (INJECTED)\n",
|
|
u32_efault, inject_retval);
|
|
|
|
u32_arr[0] = 0xbadc0ded;
|
|
u32_arr[1] = 5;
|
|
assert(ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, u32_arr) == inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, {ids_len=3134983661"
|
|
", prog_cnt=5, ids=[3737845741, 3735928559, ... /* %p */]})"
|
|
" = %ld (INJECTED)\n",
|
|
u32_efault, inject_retval);
|
|
|
|
u32_arr[1] = 2;
|
|
assert(ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, u32_arr) == inject_retval);
|
|
printf("ioctl(-1, PERF_EVENT_IOC_QUERY_BPF, {ids_len=3134983661"
|
|
", prog_cnt=2, ids=[3737845741, 3735928559]})"
|
|
" = %ld (INJECTED)\n",
|
|
inject_retval);
|
|
|
|
puts("+++ exited with 0 +++");
|
|
return 0;
|
|
}
|
|
|
|
#else
|
|
|
|
SKIP_MAIN_UNDEFINED("HAVE_LINUX_PERF_EVENT_H");
|
|
|
|
#endif
|