strace/tests/mmsg_name.c
Dmitry V. Levin d54388e1ce print_array: enhance printing of unfetchable object addresses
When umoven_func invocation fails to fetch data, it prints the faulty
address.  If this happens to a subsequent umoven_func invocation,
the printed address may be undistinguishable from a valid data printed
by print_func, e.g. when the data is printed in a numeric form like
[0x1, 0x2, 0x3, 0xdefaced].

Fix this source of confusion by moving the printing of the faulty
address from umoven_func to print_array itself.  This change renames
umoven_func to tfetch_mem_func and changes its semantics, so that
 - tfetch_mem_func never prints anything;
 - tfetch_mem_func returns true if the fetch succeeded,
   and false otherwise.

* defs.h (print_array): Replace umoven_func argument with
tfetch_mem_func.
* util.c (print_array): Replace umoven_func argument with
tfetch_mem_func, document expected tfetch_mem_func return value
semantics.  When tfetch_mem_func returns false, print either addr
or "... /* addr */" depending on the context (inside the array or not).
* bpf.c (print_ebpf_prog, print_bpf_prog_info,
BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr
argument of print_array with tfetch_mem.
* bpf_filter.c (print_bpf_fprog): Likewise.
* btrfs.c (btrfs_print_logical_ino_container,
btrfs_print_ino_path_container, btrfs_print_qgroup_inherit,
btrfs_ioctl): Likewise.
* dm.c (dm_decode_dm_target_deps): Likewise.
* epoll.c (epoll_wait_common): Likewise.
* file_ioctl.c (file_ioctl): Likewise.
* ipc_sem.c (tprint_sembuf_array): Likewise.
* kexec.c (print_kexec_segments): Likewise.
* mem.c (SYS_FUNC(subpage_prot)): Likewise.
* net.c (print_getsockopt): Likewise.
* netlink.c (decode_nlmsgerr_attr_cookie): Likewise.
* netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise.
* netlink_packet_diag.c (decode_packet_diag_mclist): Likewise.
* netlink_unix_diag.c (decode_unix_diag_inode): Likewise.
* nlattr.c (decode_nla_meminfo): Likewise.
* numa.c (print_nodemask, SYS_FUNC(move_pages),
* perf_ioctl.c (perf_ioctl_query_bpf): Likewise.
* poll.c (decode_poll_entering): Likewise.
* printsiginfo.c (print_siginfo_array): Likewise.
* rtnl_tc.c (decode_tca_stab_data): Likewise.
* sock.c (decode_ifconf): Likewise.
* uid.c (print_groups): Likewise.
* io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace
umoven_or_printaddr argument of print_array with tfetch_mem.
(tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror
with tfetch_mem_ignore_syserror.
* v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument
of print_array with tfetch_mem.
(print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror
with tfetch_mem_ignore_syserror.
* mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename
to fetch_struct_mmsghdr_for_print, do not print address, return bool.
(decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr
with fetch_struct_mmsghdr_for_print.
* tests/aio.c (main): Update expected output.
* tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise.
* tests/ioctl_perf-success.c (main): Likewise.
* tests/ioctl_v4l2.c (main): Update expected output.
* tests/kexec_load.c (main): Likewise.
* tests/mmsg_name.c (test_mmsg_name): Update expected output.
* tests/move_pages.c (print_page_array, print_node_array): Likewise.
* tests/poll.c (print_pollfd_array_entering): Likewise.
* tests/preadv-pwritev.c (main): Likewise.
* tests/preadv2-pwritev2.c (dumpio): Likewise.
* tests/process_vm_readv_writev.c (print_iov): Likewise.
* tests/pwritev.c (print_iovec): Likewise.
* tests/readv.c (main): Likewise.
* tests/seccomp-filter-v.c
* tests/semop.c (main): Likewise.
* tests/set_mempolicy.c (print_nodes): Likewise.
* tests/setgroups.c (main): Likewise.
* tests/test_nlattr.h (print_nlattr) Likewise.

Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
2018-05-29 09:58:10 +00:00

242 lines
7.0 KiB
C

/*
* Check decoding of msg_name* fields of struct msghdr array argument
* of sendmmsg and recvmmsg syscalls.
*
* Copyright (c) 2016 Dmitry V. Levin <ldv@altlinux.org>
* Copyright (c) 2016-2017 The strace developers.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. The name of the author may not be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "tests.h"
#include <errno.h>
#include <limits.h>
#include <stddef.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <sys/un.h>
#include "msghdr.h"
#define IOV_MAX1 (IOV_MAX + 1)
#ifndef TEST_NAME
# define TEST_NAME "mmsg_name"
#endif
static void
print_msghdr(const struct msghdr *const msg, const int user_msg_namelen)
{
const struct sockaddr_un *const un = msg->msg_name;
const int offsetof_sun_path = offsetof(struct sockaddr_un, sun_path);
printf("{msg_name=");
if (!un)
printf("NULL");
else if (user_msg_namelen < offsetof_sun_path) {
printf("%p", un);
} else {
printf("{sa_family=AF_UNIX");
if (user_msg_namelen > offsetof_sun_path) {
int len = user_msg_namelen < (int) msg->msg_namelen ?
user_msg_namelen : (int) msg->msg_namelen;
len -= offsetof_sun_path;
if (len > (int) sizeof(un->sun_path))
len = sizeof(un->sun_path);
printf(", sun_path=\"%.*s\"", len, un->sun_path);
}
printf("}");
}
printf(", msg_namelen=");
if (user_msg_namelen != (int) msg->msg_namelen) {
printf("%d->", user_msg_namelen);
}
printf("%d, msg_iov=[{iov_base=\"%c\", iov_len=1}]"
", msg_iovlen=1, msg_controllen=0, msg_flags=0}",
(int) msg->msg_namelen, *(char *) msg->msg_iov[0].iov_base);
}
static void
test_mmsg_name(const int send_fd, const int recv_fd)
{
struct sockaddr_un *const send_addr =
tail_alloc(sizeof(*send_addr) * IOV_MAX1);
char *const send_buf = tail_alloc(sizeof(*send_buf) * IOV_MAX1);
struct iovec *const send_iov = tail_alloc(sizeof(*send_iov) * IOV_MAX1);
struct mmsghdr *const send_mh = tail_alloc(sizeof(*send_mh) * IOV_MAX1);
int i, rc;
for (i = 0; i < IOV_MAX1; ++i) {
int sun_len = i + 1 > (int) sizeof(send_addr[i].sun_path)
? (int) sizeof(send_addr[i].sun_path)
: i + 1;
send_addr[i].sun_family = AF_UNIX;
memset(send_addr[i].sun_path, 'a' + i % 26, sun_len);
send_buf[i] = '0' + i % 10;
send_iov[i].iov_base = &send_buf[i];
send_iov[i].iov_len = sizeof(*send_buf);
send_mh[i].msg_hdr.msg_iov = &send_iov[i];
send_mh[i].msg_hdr.msg_iovlen = 1;
send_mh[i].msg_hdr.msg_name = &send_addr[i];
send_mh[i].msg_hdr.msg_namelen = i + 1;
send_mh[i].msg_hdr.msg_control = 0;
send_mh[i].msg_hdr.msg_controllen = 0;
send_mh[i].msg_hdr.msg_flags = 0;
}
rc = send_mmsg(send_fd, send_mh, IOV_MAX1, MSG_DONTWAIT);
int saved_errno = errno;
printf("sendmmsg(%d, [", send_fd);
for (i = 0; i < IOV_MAX1; ++i) {
if (i)
printf(", ");
if (i >= IOV_MAX
# if !VERBOSE
|| i >= DEFAULT_STRLEN
# endif
) {
printf("...");
break;
}
printf("{msg_hdr=");
print_msghdr(&send_mh[i].msg_hdr, i + 1);
printf("}");
}
errno = saved_errno;
printf("], %u, MSG_DONTWAIT) = %d %s (%m)\n",
IOV_MAX1, rc, errno2name());
for (i = 0; i < IOV_MAX1; ++i) {
send_mh[i].msg_hdr.msg_name = 0;
send_mh[i].msg_hdr.msg_namelen = 0;
}
/*
* When recvmmsg is called with a valid descriptor
* but inaccessible memory, it causes segfaults on some architectures.
* As in these cases we test decoding of failed recvmmsg calls,
* it's ok to fail recvmmsg with any reason as long as
* it doesn't read that inaccessible memory.
*/
rc = send_mmsg(-1, &send_mh[IOV_MAX], 2, MSG_DONTWAIT);
saved_errno = errno;
printf("sendmmsg(-1, [{msg_hdr=");
print_msghdr(&send_mh[IOV_MAX].msg_hdr, 0);
errno = saved_errno;
printf("}, ... /* %p */], %u, MSG_DONTWAIT) = %d %s (%m)\n",
&send_mh[IOV_MAX1], 2, rc, errno2name());
rc = send_mmsg(send_fd, send_mh, IOV_MAX1, MSG_DONTWAIT);
if (rc < 0)
perror_msg_and_skip("sendmmsg");
printf("sendmmsg(%d, [", send_fd);
for (i = 0; i < IOV_MAX1; ++i) {
if (i)
printf(", ");
if (i >= IOV_MAX
#if !VERBOSE
|| i >= DEFAULT_STRLEN
#endif
) {
printf("...");
break;
}
printf("{msg_hdr=");
print_msghdr(&send_mh[i].msg_hdr, 0);
printf("%s}", i < rc ? ", msg_len=1" : "");
}
printf("], %u, MSG_DONTWAIT) = %d\n", IOV_MAX1, rc);
struct sockaddr_un *const recv_addr =
tail_alloc(sizeof(*recv_addr) * IOV_MAX1);
char *const recv_buf = tail_alloc(sizeof(*recv_buf) * IOV_MAX1);
struct iovec *const recv_iov = tail_alloc(sizeof(*recv_iov) * IOV_MAX1);
struct mmsghdr *const recv_mh = tail_alloc(sizeof(*recv_mh) * IOV_MAX1);
for (i = 0; i < IOV_MAX1; ++i) {
recv_iov[i].iov_base = &recv_buf[i];
recv_iov[i].iov_len = sizeof(*recv_buf);
recv_mh[i].msg_hdr.msg_name = &recv_addr[i];
recv_mh[i].msg_hdr.msg_namelen = i;
recv_mh[i].msg_hdr.msg_iov = &recv_iov[i];
recv_mh[i].msg_hdr.msg_iovlen = 1;
recv_mh[i].msg_hdr.msg_control = 0;
recv_mh[i].msg_hdr.msg_controllen = 0;
recv_mh[i].msg_hdr.msg_flags = 0;
}
rc = recv_mmsg(recv_fd, recv_mh, IOV_MAX1, MSG_DONTWAIT, 0);
if (rc < 0)
perror_msg_and_skip("recvmmsg");
printf("recvmmsg(%d, [", recv_fd);
for (i = 0; i < rc; ++i) {
if (i)
printf(", ");
#if !VERBOSE
if (i >= DEFAULT_STRLEN) {
printf("...");
break;
}
#endif
printf("{msg_hdr=");
print_msghdr(&recv_mh[i].msg_hdr, i);
printf(", msg_len=1}");
}
printf("], %u, MSG_DONTWAIT, NULL) = %d\n", IOV_MAX1, rc);
}
int
main(void)
{
int fds[2];
if (socketpair(AF_UNIX, SOCK_STREAM, 0, fds))
perror_msg_and_skip("socketpair");
const struct sockaddr_un un = {
.sun_family = AF_UNIX,
.sun_path = TEST_NAME "-recvmmsg.test.send.socket"
};
(void) unlink(un.sun_path);
if (bind(fds[1], (const void *) &un, sizeof(un)))
perror_msg_and_skip("bind");
(void) unlink(un.sun_path);
test_mmsg_name(fds[1], fds[0]);
puts("+++ exited with 0 +++");
return 0;
}