When umoven_func invocation fails to fetch data, it prints the faulty address. If this happens to a subsequent umoven_func invocation, the printed address may be undistinguishable from a valid data printed by print_func, e.g. when the data is printed in a numeric form like [0x1, 0x2, 0x3, 0xdefaced]. Fix this source of confusion by moving the printing of the faulty address from umoven_func to print_array itself. This change renames umoven_func to tfetch_mem_func and changes its semantics, so that - tfetch_mem_func never prints anything; - tfetch_mem_func returns true if the fetch succeeded, and false otherwise. * defs.h (print_array): Replace umoven_func argument with tfetch_mem_func. * util.c (print_array): Replace umoven_func argument with tfetch_mem_func, document expected tfetch_mem_func return value semantics. When tfetch_mem_func returns false, print either addr or "... /* addr */" depending on the context (inside the array or not). * bpf.c (print_ebpf_prog, print_bpf_prog_info, BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. * bpf_filter.c (print_bpf_fprog): Likewise. * btrfs.c (btrfs_print_logical_ino_container, btrfs_print_ino_path_container, btrfs_print_qgroup_inherit, btrfs_ioctl): Likewise. * dm.c (dm_decode_dm_target_deps): Likewise. * epoll.c (epoll_wait_common): Likewise. * file_ioctl.c (file_ioctl): Likewise. * ipc_sem.c (tprint_sembuf_array): Likewise. * kexec.c (print_kexec_segments): Likewise. * mem.c (SYS_FUNC(subpage_prot)): Likewise. * net.c (print_getsockopt): Likewise. * netlink.c (decode_nlmsgerr_attr_cookie): Likewise. * netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise. * netlink_packet_diag.c (decode_packet_diag_mclist): Likewise. * netlink_unix_diag.c (decode_unix_diag_inode): Likewise. * nlattr.c (decode_nla_meminfo): Likewise. * numa.c (print_nodemask, SYS_FUNC(move_pages), * perf_ioctl.c (perf_ioctl_query_bpf): Likewise. * poll.c (decode_poll_entering): Likewise. * printsiginfo.c (print_siginfo_array): Likewise. * rtnl_tc.c (decode_tca_stab_data): Likewise. * sock.c (decode_ifconf): Likewise. * uid.c (print_groups): Likewise. * io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename to fetch_struct_mmsghdr_for_print, do not print address, return bool. (decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr with fetch_struct_mmsghdr_for_print. * tests/aio.c (main): Update expected output. * tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise. * tests/ioctl_perf-success.c (main): Likewise. * tests/ioctl_v4l2.c (main): Update expected output. * tests/kexec_load.c (main): Likewise. * tests/mmsg_name.c (test_mmsg_name): Update expected output. * tests/move_pages.c (print_page_array, print_node_array): Likewise. * tests/poll.c (print_pollfd_array_entering): Likewise. * tests/preadv-pwritev.c (main): Likewise. * tests/preadv2-pwritev2.c (dumpio): Likewise. * tests/process_vm_readv_writev.c (print_iov): Likewise. * tests/pwritev.c (print_iovec): Likewise. * tests/readv.c (main): Likewise. * tests/seccomp-filter-v.c * tests/semop.c (main): Likewise. * tests/set_mempolicy.c (print_nodes): Likewise. * tests/setgroups.c (main): Likewise. * tests/test_nlattr.h (print_nlattr) Likewise. Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
185 lines
5.6 KiB
C
185 lines
5.6 KiB
C
/*
|
|
* Check decoding of preadv and pwritev syscalls.
|
|
*
|
|
* Copyright (c) 2016 Dmitry V. Levin <ldv@altlinux.org>
|
|
* Copyright (c) 2016-2017 The strace developers.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "tests.h"
|
|
|
|
#if defined HAVE_PREADV && defined HAVE_PWRITEV
|
|
|
|
# include <fcntl.h>
|
|
# include <stdio.h>
|
|
# include <sys/uio.h>
|
|
# include <unistd.h>
|
|
|
|
int
|
|
main(void)
|
|
{
|
|
tprintf("%s", "");
|
|
|
|
static char tmp[] = "preadv-pwritev-tmpfile";
|
|
if (open(tmp, O_CREAT|O_RDONLY|O_TRUNC, 0600) != 0)
|
|
perror_msg_and_fail("creat: %s", tmp);
|
|
if (open(tmp, O_WRONLY) != 1)
|
|
perror_msg_and_fail("open: %s", tmp);
|
|
if (unlink(tmp))
|
|
perror_msg_and_fail("unlink: %s", tmp);
|
|
|
|
static const char w0_c[] = "012";
|
|
const char *w0_d = hexdump_strdup(w0_c);
|
|
void *w0 = tail_memdup(w0_c, LENGTH_OF(w0_c));
|
|
|
|
const void *efault = w0 + LENGTH_OF(w0_c);
|
|
|
|
static const char w1_c[] = "34567";
|
|
const char *w1_d = hexdump_strdup(w1_c);
|
|
void *w1 = tail_memdup(w1_c, LENGTH_OF(w1_c));
|
|
|
|
static const char w2_c[] = "89abcde";
|
|
const char *w2_d = hexdump_strdup(w2_c);
|
|
void *w2 = tail_memdup(w2_c, LENGTH_OF(w2_c));
|
|
|
|
long rc;
|
|
|
|
rc = pwritev(1, efault, 42, 0);
|
|
tprintf("pwritev(1, %p, 42, 0) = %ld %s (%m)\n",
|
|
efault, rc, errno2name());
|
|
|
|
rc = preadv(0, efault, 42, 0);
|
|
tprintf("preadv(0, %p, 42, 0) = %ld %s (%m)\n",
|
|
efault, rc, errno2name());
|
|
|
|
static const char r0_c[] = "01234567";
|
|
const char *r0_d = hexdump_strdup(r0_c);
|
|
static const char r1_c[] = "89abcde";
|
|
const char *r1_d = hexdump_strdup(r1_c);
|
|
|
|
const struct iovec w_iov_[] = {
|
|
{
|
|
.iov_base = w0,
|
|
.iov_len = LENGTH_OF(w0_c)
|
|
}, {
|
|
.iov_base = w1,
|
|
.iov_len = LENGTH_OF(w1_c)
|
|
}, {
|
|
.iov_base = w2,
|
|
.iov_len = LENGTH_OF(w2_c)
|
|
}
|
|
};
|
|
const struct iovec *w_iov = tail_memdup(w_iov_, sizeof(w_iov_));
|
|
|
|
rc = pwritev(1, w_iov, 0, 0);
|
|
if (rc)
|
|
perror_msg_and_fail("pwritev: expected 0, returned %ld", rc);
|
|
tprintf("pwritev(1, [], 0, 0) = 0\n");
|
|
|
|
rc = pwritev(1, w_iov + ARRAY_SIZE(w_iov_) - 1, 2, 0);
|
|
tprintf("pwritev(1, [{iov_base=\"%s\", iov_len=%u}, ... /* %p */], 2, 0)"
|
|
" = %ld %s (%m)\n",
|
|
w2_c, LENGTH_OF(w2_c), w_iov + ARRAY_SIZE(w_iov_),
|
|
rc, errno2name());
|
|
|
|
const unsigned int w_len =
|
|
LENGTH_OF(w0_c) + LENGTH_OF(w1_c) + LENGTH_OF(w2_c);
|
|
|
|
rc = pwritev(1, w_iov, ARRAY_SIZE(w_iov_), 0);
|
|
if (rc != (int) w_len)
|
|
perror_msg_and_fail("pwritev: expected %u, returned %ld",
|
|
w_len, rc);
|
|
close(1);
|
|
tprintf("pwritev(1, [{iov_base=\"%s\", iov_len=%u}"
|
|
", {iov_base=\"%s\", iov_len=%u}"
|
|
", {iov_base=\"%s\", iov_len=%u}], %u, 0) = %u\n"
|
|
" * %u bytes in buffer 0\n"
|
|
" | 00000 %-49s %-16s |\n"
|
|
" * %u bytes in buffer 1\n"
|
|
" | 00000 %-49s %-16s |\n"
|
|
" * %u bytes in buffer 2\n"
|
|
" | 00000 %-49s %-16s |\n",
|
|
w0_c, LENGTH_OF(w0_c), w1_c, LENGTH_OF(w1_c),
|
|
w2_c, LENGTH_OF(w2_c), (unsigned int) ARRAY_SIZE(w_iov_), w_len,
|
|
LENGTH_OF(w0_c), w0_d, w0_c,
|
|
LENGTH_OF(w1_c), w1_d, w1_c, LENGTH_OF(w2_c), w2_d, w2_c);
|
|
|
|
const unsigned int r_len = (w_len + 1) / 2;
|
|
void *r0 = tail_alloc(r_len);
|
|
const struct iovec r0_iov_[] = {
|
|
{
|
|
.iov_base = r0,
|
|
.iov_len = r_len
|
|
}
|
|
};
|
|
const struct iovec *r_iov = tail_memdup(r0_iov_, sizeof(r0_iov_));
|
|
|
|
rc = preadv(0, r_iov, ARRAY_SIZE(r0_iov_), 0);
|
|
if (rc != (int) r_len)
|
|
perror_msg_and_fail("preadv: expected %u, returned %ld",
|
|
r_len, rc);
|
|
tprintf("preadv(0, [{iov_base=\"%s\", iov_len=%u}], %u, 0) = %u\n"
|
|
" * %u bytes in buffer 0\n"
|
|
" | 00000 %-49s %-16s |\n",
|
|
r0_c, r_len, (unsigned int) ARRAY_SIZE(r0_iov_),
|
|
r_len, r_len, r0_d, r0_c);
|
|
|
|
void *r1 = tail_alloc(r_len);
|
|
void *r2 = tail_alloc(w_len);
|
|
const struct iovec r1_iov_[] = {
|
|
{
|
|
.iov_base = r1,
|
|
.iov_len = r_len
|
|
},
|
|
{
|
|
.iov_base = r2,
|
|
.iov_len = w_len
|
|
}
|
|
};
|
|
r_iov = tail_memdup(r1_iov_, sizeof(r1_iov_));
|
|
|
|
rc = preadv(0, r_iov, ARRAY_SIZE(r1_iov_), r_len);
|
|
if (rc != (int) w_len - (int) r_len)
|
|
perror_msg_and_fail("preadv: expected %d, returned %ld",
|
|
(int) w_len - r_len, rc);
|
|
tprintf("preadv(0, [{iov_base=\"%s\", iov_len=%u}"
|
|
", {iov_base=\"\", iov_len=%u}], %u, %u) = %u\n"
|
|
" * %u bytes in buffer 0\n"
|
|
" | 00000 %-49s %-16s |\n",
|
|
r1_c, r_len, w_len, (unsigned int) ARRAY_SIZE(r1_iov_),
|
|
r_len, w_len - r_len,
|
|
w_len - r_len, r1_d, r1_c);
|
|
close(0);
|
|
|
|
tprintf("+++ exited with 0 +++\n");
|
|
return 0;
|
|
}
|
|
|
|
#else
|
|
|
|
SKIP_MAIN_UNDEFINED("HAVE_PREADV && HAVE_PWRITEV")
|
|
|
|
#endif
|