strace/tests/kexec_load.c
Dmitry V. Levin d54388e1ce print_array: enhance printing of unfetchable object addresses
When umoven_func invocation fails to fetch data, it prints the faulty
address.  If this happens to a subsequent umoven_func invocation,
the printed address may be undistinguishable from a valid data printed
by print_func, e.g. when the data is printed in a numeric form like
[0x1, 0x2, 0x3, 0xdefaced].

Fix this source of confusion by moving the printing of the faulty
address from umoven_func to print_array itself.  This change renames
umoven_func to tfetch_mem_func and changes its semantics, so that
 - tfetch_mem_func never prints anything;
 - tfetch_mem_func returns true if the fetch succeeded,
   and false otherwise.

* defs.h (print_array): Replace umoven_func argument with
tfetch_mem_func.
* util.c (print_array): Replace umoven_func argument with
tfetch_mem_func, document expected tfetch_mem_func return value
semantics.  When tfetch_mem_func returns false, print either addr
or "... /* addr */" depending on the context (inside the array or not).
* bpf.c (print_ebpf_prog, print_bpf_prog_info,
BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr
argument of print_array with tfetch_mem.
* bpf_filter.c (print_bpf_fprog): Likewise.
* btrfs.c (btrfs_print_logical_ino_container,
btrfs_print_ino_path_container, btrfs_print_qgroup_inherit,
btrfs_ioctl): Likewise.
* dm.c (dm_decode_dm_target_deps): Likewise.
* epoll.c (epoll_wait_common): Likewise.
* file_ioctl.c (file_ioctl): Likewise.
* ipc_sem.c (tprint_sembuf_array): Likewise.
* kexec.c (print_kexec_segments): Likewise.
* mem.c (SYS_FUNC(subpage_prot)): Likewise.
* net.c (print_getsockopt): Likewise.
* netlink.c (decode_nlmsgerr_attr_cookie): Likewise.
* netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise.
* netlink_packet_diag.c (decode_packet_diag_mclist): Likewise.
* netlink_unix_diag.c (decode_unix_diag_inode): Likewise.
* nlattr.c (decode_nla_meminfo): Likewise.
* numa.c (print_nodemask, SYS_FUNC(move_pages),
* perf_ioctl.c (perf_ioctl_query_bpf): Likewise.
* poll.c (decode_poll_entering): Likewise.
* printsiginfo.c (print_siginfo_array): Likewise.
* rtnl_tc.c (decode_tca_stab_data): Likewise.
* sock.c (decode_ifconf): Likewise.
* uid.c (print_groups): Likewise.
* io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace
umoven_or_printaddr argument of print_array with tfetch_mem.
(tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror
with tfetch_mem_ignore_syserror.
* v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument
of print_array with tfetch_mem.
(print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror
with tfetch_mem_ignore_syserror.
* mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename
to fetch_struct_mmsghdr_for_print, do not print address, return bool.
(decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr
with fetch_struct_mmsghdr_for_print.
* tests/aio.c (main): Update expected output.
* tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise.
* tests/ioctl_perf-success.c (main): Likewise.
* tests/ioctl_v4l2.c (main): Update expected output.
* tests/kexec_load.c (main): Likewise.
* tests/mmsg_name.c (test_mmsg_name): Update expected output.
* tests/move_pages.c (print_page_array, print_node_array): Likewise.
* tests/poll.c (print_pollfd_array_entering): Likewise.
* tests/preadv-pwritev.c (main): Likewise.
* tests/preadv2-pwritev2.c (dumpio): Likewise.
* tests/process_vm_readv_writev.c (print_iov): Likewise.
* tests/pwritev.c (print_iovec): Likewise.
* tests/readv.c (main): Likewise.
* tests/seccomp-filter-v.c
* tests/semop.c (main): Likewise.
* tests/set_mempolicy.c (print_nodes): Likewise.
* tests/setgroups.c (main): Likewise.
* tests/test_nlattr.h (print_nlattr) Likewise.

Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
2018-05-29 09:58:10 +00:00

171 lines
5.8 KiB
C

/*
* Check decoding of kexec_load syscall.
*
* Copyright (c) 2016 Eugene Syromyatnikov <evgsyr@gmail.com>
* Copyright (c) 2016-2017 The strace developers.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. The name of the author may not be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "tests.h"
#include <asm/unistd.h>
#ifdef __NR_kexec_load
# include <stdio.h>
# include <unistd.h>
struct strval {
kernel_ulong_t val;
const char *str64;
const char *str32;
const char *str;
};
struct segm {
void *buf;
size_t bufsz;
void *mem;
size_t memsz;
};
int
main(void)
{
enum {
NUM_SEGMS = 17,
NUM_SEGMS_UNCUT = 5,
NUM_SEGMS_UNCUT_MAX = 9,
NUM_SEGMS_CUT = 12,
SEGMS_ARRAY_SIZE = sizeof(struct segm) * NUM_SEGMS,
};
static const kernel_ulong_t bogus_zero =
sizeof(long) < sizeof(kernel_long_t) ? F8ILL_KULONG_MASK : 0;
static const kernel_ulong_t bogus_entry =
(kernel_ulong_t) 0xdeadca57badda7a1ULL;
static const kernel_ulong_t bogus_nsegs =
(kernel_ulong_t) 0xdec0ded1defaced2ULL;
static const struct strval flags[] = {
{ (kernel_ulong_t) 0xbadc0dedda7a1054ULL,
"0xda7a0000 /* KEXEC_ARCH_??? */|0xbadc0ded0000",
"0xda7a0000 /* KEXEC_ARCH_??? */|0x",
"1054 /* KEXEC_??? */" },
{ 0, "", "", "KEXEC_ARCH_DEFAULT" },
{ 0x2a0003, "", "",
"KEXEC_ARCH_SH|KEXEC_ON_CRASH|KEXEC_PRESERVE_CONTEXT" },
{ 0xdead0000, "", "", "0xdead0000 /* KEXEC_ARCH_??? */" },
};
const char *errstr;
long rc;
struct segm *segms = tail_alloc(SEGMS_ARRAY_SIZE);
unsigned int i;
fill_memory(segms, SEGMS_ARRAY_SIZE);
segms[0].buf = segms[0].mem = NULL;
rc = syscall(__NR_kexec_load, bogus_zero, bogus_zero, bogus_zero,
flags[0].val);
printf("kexec_load(NULL, 0, NULL, %s%s) = %s\n",
sizeof(long) == 8 ? flags[0].str64 : flags[0].str32,
flags[0].str, sprintrc(rc));
rc = syscall(__NR_kexec_load, bogus_entry, bogus_nsegs,
segms + SEGMS_ARRAY_SIZE, flags[1].val);
printf("kexec_load(%#lx, %lu, %p, %s) = %s\n",
(unsigned long) bogus_entry, (unsigned long) bogus_nsegs,
segms + SEGMS_ARRAY_SIZE, flags[1].str, sprintrc(rc));
rc = syscall(__NR_kexec_load, bogus_entry, NUM_SEGMS,
segms, flags[2].val);
printf("kexec_load(%#lx, %lu, %p, %s) = %s\n",
(unsigned long) bogus_entry, (unsigned long) NUM_SEGMS,
segms, flags[2].str, sprintrc(rc));
rc = syscall(__NR_kexec_load, bogus_entry, NUM_SEGMS_CUT,
segms, flags[3].val);
errstr = sprintrc(rc);
printf("kexec_load(%#lx, %lu, [{buf=NULL, bufsz=%zu, mem=NULL, "
"memsz=%zu}, ",
(unsigned long) bogus_entry, (unsigned long) NUM_SEGMS_CUT,
segms[0].bufsz, segms[0].memsz);
for (i = 1; i < NUM_SEGMS_UNCUT_MAX; i++)
printf("{buf=%p, bufsz=%zu, mem=%p, memsz=%zu}, ",
segms[i].buf, segms[i].bufsz,
segms[i].mem, segms[i].memsz);
printf("...], %s) = %s\n", flags[3].str, errstr);
rc = syscall(__NR_kexec_load, bogus_entry, NUM_SEGMS_CUT,
segms + (NUM_SEGMS - NUM_SEGMS_UNCUT_MAX),
flags[0].val);
errstr = sprintrc(rc);
printf("kexec_load(%#lx, %lu, [",
(unsigned long) bogus_entry, (unsigned long) NUM_SEGMS_CUT);
for (i = NUM_SEGMS - NUM_SEGMS_UNCUT_MAX; i < NUM_SEGMS; i++)
printf("{buf=%p, bufsz=%zu, mem=%p, memsz=%zu}, ",
segms[i].buf, segms[i].bufsz,
segms[i].mem, segms[i].memsz);
printf("... /* %p */], %s%s) = %s\n",
segms + NUM_SEGMS,
sizeof(long) == 8 ? flags[0].str64 : flags[0].str32,
flags[0].str, errstr);
rc = syscall(__NR_kexec_load, bogus_entry, NUM_SEGMS_UNCUT,
segms + (NUM_SEGMS - NUM_SEGMS_UNCUT),
flags[1].val);
errstr = sprintrc(rc);
printf("kexec_load(%#lx, %lu, [",
(unsigned long) bogus_entry, (unsigned long) NUM_SEGMS_UNCUT);
for (i = NUM_SEGMS - NUM_SEGMS_UNCUT; i < NUM_SEGMS; i++)
printf("{buf=%p, bufsz=%zu, mem=%p, memsz=%zu}%s",
segms[i].buf, segms[i].bufsz,
segms[i].mem, segms[i].memsz,
(i == NUM_SEGMS - 1) ? "" : ", ");
printf("], %s) = %s\n", flags[1].str, errstr);
rc = syscall(__NR_kexec_load, bogus_entry, NUM_SEGMS_CUT,
segms + 1, flags[2].val);
errstr = sprintrc(rc);
printf("kexec_load(%#lx, %lu, [",
(unsigned long) bogus_entry, (unsigned long) NUM_SEGMS_CUT);
for (i = 1; i < NUM_SEGMS_UNCUT_MAX + 1; i++)
printf("{buf=%p, bufsz=%zu, mem=%p, memsz=%zu}, ",
segms[i].buf, segms[i].bufsz,
segms[i].mem, segms[i].memsz);
printf("...], %s) = %s\n", flags[2].str, errstr);
puts("+++ exited with 0 +++");
return 0;
}
#else
SKIP_MAIN_UNDEFINED("__NR_kexec_load");
#endif