Dmitry V. Levin
3ed5d02183
* configure.ac (gl_WARN_ADD): Add -Wsign-compare. * defs.h (struct tcb): Change 'currpers' type to unsigned. (struct xlat): Change 'val' type to unsigned (signame): Add 'const' qualifier to its argument. (xlookup, printxval): Add 'const' qualifier to the 2nd argument and change its type to unsigned. (printpathn): Change the 3rd argument type to unsigned. (ioctl_lookup): Change 1st argument type to unsigned. * count.c (call_summary_pers, call_summary): Change 'i' type to unsigned. * file.c (print_xattr_list): Fix comparisons between signed and unsigned long values. * ioctl.c (compare): Fix cast. (ioctl_lookup): Change 1st argument type to to unsigned. (ioctl_next_match): Change 'code' type to unsigned. * mem.c (sys_move_pages): Change 'i' type to unsigned. * mtd.c (mtd_ioctl): Change 'i' and 'j' types to unsigned. Print 'i' using %u format string. * process.c (sys_prctl): Change 'i' type to unsigned. (printargv): Change 'n' type to unsigned. (sys_ptrace): Change 'addr' type to unsigned. * scsi.c (print_sg_io_buffer): Add 'const' qualifier to 'len' argument and change its type to unsigned. Change 'i' and 'allocated' types to unsigned. * signal.c (signame): Add 'const' qualifier to its argument. Fix comparisons between signed and unsigned values. (sprintsigmask_n, printsiginfo): Fix comparisons between signed and unsigned values. * sock.c (sock_ioctl): Change 'i' and 'nifra' types to unsigned. * strace.c (expand_tcbtab, alloctcb): Change 'i' type to unsigned. (detach): Change 'sig' type to unsigned. (startup_attach): Change 'tcbi' type to unsigned. (startup_child): Change 'm', 'n', and 'len' types to unsigned. (init): Use new variable to iterate 'tcbtab'. (pid2tcb): Change 'i' type to unsigned. (cleanup): Change 'i' and 'sig' types to unsigned. * syscall.c (update_personality): Change 'personality' argument type to unsigned. (struct qual_options): Change 'bitflag' type to unsigned. (reallocate_qual): Add 'const' qualifier to its argument and change its type to unsigned. (qualify_one): Change 'n' and 'bitflag' arguments types to unsigned. Add 'const' qualifier to 'n', 'not', and 'pers' arguments. Change 'p' type to signed int. (qual_syscall): Change 'bitflag' argument type to unsigned. Add 'const' qualifier to 'bitflag' and 'not' arguments. Change 'p' type to signed int. (qual_signal): Change 'bitflag' argument type to unsigned. Add 'const' qualifier to 'bitflag' and 'not' arguments. Change 'i' type to unsigned. (qual_desc): Change 'bitflag' argument type to unsigned. Add 'const' qualifier to 'bitflag' and 'not' arguments. (qualify): Change 'i' type to unsigned. (get_scno): Change 'currpers' type to unsigned. Fix a comparison between signed and unsigned values. * system.c (sys_sysctl): Change 'cnt' and 'max_cnt' types to unsigned. Fix comparisons between signed and unsigned values. * util.c (xlookup, printxval): Add 'const' qualifier to 'val' argument and change its type to unsigned. (printuid): Fix a comparison between signed and unsigned values. (printpathn): Change 'n' argument type to unsigned. (printstr): Change 'size' type to unsigned. Fix a comparison between signed and unsigned values. (setbpt): Change 'i' type to unsigned. * net.c (printsock): Silence a compilation warning. * reboot.c (sys_reboot): Likewise.
138 lines
4.2 KiB
C
138 lines
4.2 KiB
C
/*
|
|
* Copyright (c) 2007 Vladimir Nadvornik <nadvornik@suse.cz>
|
|
* Copyright (c) 2007 Dmitry V. Levin <ldv@altlinux.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "defs.h"
|
|
|
|
#ifdef HAVE_SCSI_SG_H
|
|
|
|
# include <sys/ioctl.h>
|
|
# include <scsi/sg.h>
|
|
|
|
#include "xlat/sg_io_dxfer_direction.h"
|
|
|
|
static void
|
|
print_sg_io_buffer(struct tcb *tcp, unsigned char *addr, const unsigned int len)
|
|
{
|
|
unsigned char *buf = NULL;
|
|
unsigned int allocated, i;
|
|
|
|
if (len == 0)
|
|
return;
|
|
allocated = (len > max_strlen) ? max_strlen : len;
|
|
if ((buf = malloc(allocated)) == NULL ||
|
|
umoven(tcp, (unsigned long) addr, allocated, (char *) buf) < 0) {
|
|
tprintf("%p", addr);
|
|
free(buf);
|
|
return;
|
|
}
|
|
tprintf("%02x", buf[0]);
|
|
for (i = 1; i < allocated; ++i)
|
|
tprintf(", %02x", buf[i]);
|
|
free(buf);
|
|
if (allocated != len)
|
|
tprints(", ...");
|
|
}
|
|
|
|
static void
|
|
print_sg_io_req(struct tcb *tcp, struct sg_io_hdr *sg_io)
|
|
{
|
|
tprintf("{'%c', ", sg_io->interface_id);
|
|
printxval(sg_io_dxfer_direction, sg_io->dxfer_direction,
|
|
"SG_DXFER_???");
|
|
tprintf(", cmd[%u]=[", sg_io->cmd_len);
|
|
print_sg_io_buffer(tcp, sg_io->cmdp, sg_io->cmd_len);
|
|
tprintf("], mx_sb_len=%d, ", sg_io->mx_sb_len);
|
|
tprintf("iovec_count=%d, ", sg_io->iovec_count);
|
|
tprintf("dxfer_len=%u, ", sg_io->dxfer_len);
|
|
tprintf("timeout=%u, ", sg_io->timeout);
|
|
tprintf("flags=%#x", sg_io->flags);
|
|
|
|
if (sg_io->dxfer_direction == SG_DXFER_TO_DEV ||
|
|
sg_io->dxfer_direction == SG_DXFER_TO_FROM_DEV) {
|
|
tprintf(", data[%u]=[", sg_io->dxfer_len);
|
|
printstr(tcp, (unsigned long) sg_io->dxferp,
|
|
sg_io->dxfer_len);
|
|
tprints("]");
|
|
}
|
|
}
|
|
|
|
static void
|
|
print_sg_io_res(struct tcb *tcp, struct sg_io_hdr *sg_io)
|
|
{
|
|
if (sg_io->dxfer_direction == SG_DXFER_FROM_DEV ||
|
|
sg_io->dxfer_direction == SG_DXFER_TO_FROM_DEV) {
|
|
tprintf(", data[%u]=[", sg_io->dxfer_len);
|
|
printstr(tcp, (unsigned long) sg_io->dxferp,
|
|
sg_io->dxfer_len);
|
|
tprints("]");
|
|
}
|
|
tprintf(", status=%02x, ", sg_io->status);
|
|
tprintf("masked_status=%02x, ", sg_io->masked_status);
|
|
tprintf("sb[%u]=[", sg_io->sb_len_wr);
|
|
print_sg_io_buffer(tcp, sg_io->sbp, sg_io->sb_len_wr);
|
|
tprintf("], host_status=%#x, ", sg_io->host_status);
|
|
tprintf("driver_status=%#x, ", sg_io->driver_status);
|
|
tprintf("resid=%d, ", sg_io->resid);
|
|
tprintf("duration=%d, ", sg_io->duration);
|
|
tprintf("info=%#x}", sg_io->info);
|
|
}
|
|
|
|
int
|
|
scsi_ioctl(struct tcb *tcp, long code, long arg)
|
|
{
|
|
switch (code) {
|
|
case SG_IO:
|
|
if (entering(tcp)) {
|
|
struct sg_io_hdr sg_io;
|
|
|
|
if (umove(tcp, arg, &sg_io) < 0)
|
|
tprintf(", %#lx", arg);
|
|
else {
|
|
tprints(", ");
|
|
print_sg_io_req(tcp, &sg_io);
|
|
}
|
|
}
|
|
if (exiting(tcp)) {
|
|
struct sg_io_hdr sg_io;
|
|
|
|
if (!syserror(tcp) && umove(tcp, arg, &sg_io) >= 0)
|
|
print_sg_io_res(tcp, &sg_io);
|
|
else
|
|
tprints("}");
|
|
}
|
|
break;
|
|
default:
|
|
if (entering(tcp))
|
|
tprintf(", %#lx", arg);
|
|
break;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
#endif /* HAVE_SCSI_SG_H */
|