strace/unwind-libdw.c
Masatake YAMATO 840bb0acb5 unwind-libdw: use the mmap_notify subsystem
The unwind subsystem uses the mmap_cache subsystem even it uses
unwind-libdw as backend. unwind-libdw doesn't need the full set of the
mmap_cache subsystem; libdw has a feature for caching a memory
mapping.

This commit does three things.

(1) Make the unwind subsystem not use the mmap_cache subsystem.
The unwind subsystem never concern the memory mapping of the target.
It becomes a thin layer.

(2) Make unwind-libunwind use the mmap_cache subsystem directly.

(3) Make unwind-libdw use the mmap_notify subsystem to know when it
should call dwfl_linux_proc_report/dwfl_report_end for updating the
cache.

Here is a subsystem structure that this patch
introduces:

	+-------------------------------------+
	|            unwind subsys            |
	+------------------+------------------+
	| unwind-libunwind |   unwind-libdw   |
	+------------------+------------------+
	|    mmap_cache    |                  |
	+------------------+                  |
	|               mmap_notify           |
	+-------------------------------------+
	|                syscall              |
	+-------------------------------------+
               mmap/munmap/mprotect/brk...

* unwind.c: Don't include "mmap_cache.h".
(unwind_init): Don't call mmap_cache_enable.
(unwind_tcb_print, unwind_tcb_capture): Don't call mmap_cache related
functions, just invoke unwinder.tcb_walk.
* unwind.h (struct unwind_unwinder_t): Remove tcb_flush_cache field.

* unwind-libdw.c: Include "mmap_notify.h" instead of "mmap_cache.h".
(struct ctx): Add last_proc_updating field to record the generation
of memory mapping that is cached by dwfl_linux_proc_report
and dwfl_report_end.
(mapping_generation): A variable counting how many times the memory
mapping of targets has been changed.
(updating_mapping_generation): New utility function for updating
mapping_generation.
(init): New function for registering updating_mapping_generation
in the mmap_notify subsystem as a callback function.
(tcb_init): Initialize ctx::last_proc_updating.
(tcb_flush_cache): Rename to flush_cache_maybe.  Rebuild the cache data
only if the data is stale.
(tcb_walk): Call flush_cache_maybe for avoiding referring staled cache data.
(unwinder): Set init function, remove tcb_flush_cache field.
* unwind-libunwind.c (init): Enable the mmap_cache subsystem.
(tcb_walk): Call mmap_cache_rebuild_if_invalid and unw_flush_cache for
updating the cache of the memory mapping before walking the stack.
(tcb_walk): Rename to walk.
(unwinder): Remove tcb_flush_cache field.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2018-05-03 22:01:30 +00:00

212 lines
5.5 KiB
C

/*
* This file is based on a patch submitted by Mark Wielaard <mjw@redhat.com>
* to ltrace project:
* https://anonscm.debian.org/cgit/collab-maint/ltrace.git/commit/?id=dfefa9f057857735a073ea655f5cb34351032c8e
*
* It was re-licensed for strace by the original author:
* https://lists.strace.io/pipermail/strace-devel/2018-March/008063.html
*
* Copyright (c) 2014-2018 Mark Wielaard <mjw@redhat.com>
* Copyright (c) 2018 Masatake YAMATO <yamato@redhat.com>
* Copyright (c) 2018 The strace developers.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. The name of the author may not be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "defs.h"
#include "unwind.h"
#include "mmap_notify.h"
#include <elfutils/libdwfl.h>
struct ctx {
Dwfl *dwfl;
unsigned int last_proc_updating;
};
static unsigned int mapping_generation;
static void
update_mapping_generation(struct tcb *tcp, void *unused)
{
mapping_generation++;
}
static void
init(void)
{
mmap_notify_register_client(update_mapping_generation, NULL);
}
static void *
tcb_init(struct tcb *tcp)
{
static const Dwfl_Callbacks proc_callbacks = {
.find_elf = dwfl_linux_proc_find_elf,
.find_debuginfo = dwfl_standard_find_debuginfo
};
Dwfl *dwfl = dwfl_begin(&proc_callbacks);
if (dwfl == NULL) {
error_msg("dwfl_begin: %s", dwfl_errmsg(-1));
return NULL;
}
int r = dwfl_linux_proc_attach(dwfl, tcp->pid, true);
if (r) {
const char *msg = NULL;
if (r < 0)
msg = dwfl_errmsg(-1);
else if (r > 0)
msg = strerror(r);
error_msg("dwfl_linux_proc_attach returned an error"
" for process %d: %s", tcp->pid, msg);
dwfl_end(dwfl);
return NULL;
}
struct ctx *ctx = xmalloc(sizeof(*ctx));
ctx->dwfl = dwfl;
ctx->last_proc_updating = 0;
return ctx;
}
static void
tcb_fin(struct tcb *tcp)
{
struct ctx *ctx = tcp->unwind_ctx;
if (ctx) {
dwfl_end(ctx->dwfl);
free(ctx);
}
}
static void
flush_cache_maybe(struct tcb *tcp)
{
struct ctx *ctx = tcp->unwind_ctx;
if (!ctx)
return;
if (ctx->last_proc_updating == mapping_generation)
return;
int r = dwfl_linux_proc_report(ctx->dwfl, tcp->pid);
if (r < 0)
error_msg("dwfl_linux_proc_report returned an error"
" for pid %d: %s", tcp->pid, dwfl_errmsg(-1));
else if (r > 0)
error_msg("dwfl_linux_proc_report returned an error"
" for pid %d", tcp->pid);
else if (dwfl_report_end(ctx->dwfl, NULL, NULL) != 0)
error_msg("dwfl_report_end returned an error"
" for pid %d: %s", tcp->pid, dwfl_errmsg(-1));
ctx->last_proc_updating = mapping_generation;
}
struct frame_user_data {
unwind_call_action_fn call_action;
unwind_error_action_fn error_action;
void *data;
int stack_depth;
};
static int
frame_callback(Dwfl_Frame *state, void *arg)
{
struct frame_user_data *user_data = arg;
Dwarf_Addr pc;
bool isactivation;
if (!dwfl_frame_pc(state, &pc, &isactivation)) {
/* Propagate the error to the caller. */
return -1;
}
if (!isactivation)
pc--;
Dwfl *dwfl = dwfl_thread_dwfl(dwfl_frame_thread(state));
Dwfl_Module *mod = dwfl_addrmodule(dwfl, pc);
GElf_Off off = 0;
if (mod != NULL) {
const char *modname = NULL;
const char *symname = NULL;
GElf_Sym sym;
Dwarf_Addr true_offset = pc;
modname = dwfl_module_info(mod, NULL, NULL, NULL, NULL,
NULL, NULL, NULL);
symname = dwfl_module_addrinfo(mod, pc, &off, &sym,
NULL, NULL, NULL);
dwfl_module_relocate_address(mod, &true_offset);
user_data->call_action(user_data->data, modname, symname,
off, true_offset);
}
/* Max number of frames to print reached? */
if (user_data->stack_depth-- == 0)
return DWARF_CB_ABORT;
return DWARF_CB_OK;
}
static void
tcb_walk(struct tcb *tcp,
unwind_call_action_fn call_action,
unwind_error_action_fn error_action,
void *data)
{
struct ctx *ctx = tcp->unwind_ctx;
if (!ctx)
return;
struct frame_user_data user_data = {
.call_action = call_action,
.error_action = error_action,
.data = data,
.stack_depth = 256,
};
flush_cache_maybe(tcp);
int r = dwfl_getthread_frames(ctx->dwfl, tcp->pid, frame_callback,
&user_data);
if (r)
error_action(data,
r < 0 ? dwfl_errmsg(-1) : "too many stack frames",
0);
}
const struct unwind_unwinder_t unwinder = {
.name = "libdw",
.init = init,
.tcb_init = tcb_init,
.tcb_fin = tcb_fin,
.tcb_walk = tcb_walk,
};