strace/tests/move_pages.c
Dmitry V. Levin d54388e1ce print_array: enhance printing of unfetchable object addresses
When umoven_func invocation fails to fetch data, it prints the faulty
address.  If this happens to a subsequent umoven_func invocation,
the printed address may be undistinguishable from a valid data printed
by print_func, e.g. when the data is printed in a numeric form like
[0x1, 0x2, 0x3, 0xdefaced].

Fix this source of confusion by moving the printing of the faulty
address from umoven_func to print_array itself.  This change renames
umoven_func to tfetch_mem_func and changes its semantics, so that
 - tfetch_mem_func never prints anything;
 - tfetch_mem_func returns true if the fetch succeeded,
   and false otherwise.

* defs.h (print_array): Replace umoven_func argument with
tfetch_mem_func.
* util.c (print_array): Replace umoven_func argument with
tfetch_mem_func, document expected tfetch_mem_func return value
semantics.  When tfetch_mem_func returns false, print either addr
or "... /* addr */" depending on the context (inside the array or not).
* bpf.c (print_ebpf_prog, print_bpf_prog_info,
BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr
argument of print_array with tfetch_mem.
* bpf_filter.c (print_bpf_fprog): Likewise.
* btrfs.c (btrfs_print_logical_ino_container,
btrfs_print_ino_path_container, btrfs_print_qgroup_inherit,
btrfs_ioctl): Likewise.
* dm.c (dm_decode_dm_target_deps): Likewise.
* epoll.c (epoll_wait_common): Likewise.
* file_ioctl.c (file_ioctl): Likewise.
* ipc_sem.c (tprint_sembuf_array): Likewise.
* kexec.c (print_kexec_segments): Likewise.
* mem.c (SYS_FUNC(subpage_prot)): Likewise.
* net.c (print_getsockopt): Likewise.
* netlink.c (decode_nlmsgerr_attr_cookie): Likewise.
* netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise.
* netlink_packet_diag.c (decode_packet_diag_mclist): Likewise.
* netlink_unix_diag.c (decode_unix_diag_inode): Likewise.
* nlattr.c (decode_nla_meminfo): Likewise.
* numa.c (print_nodemask, SYS_FUNC(move_pages),
* perf_ioctl.c (perf_ioctl_query_bpf): Likewise.
* poll.c (decode_poll_entering): Likewise.
* printsiginfo.c (print_siginfo_array): Likewise.
* rtnl_tc.c (decode_tca_stab_data): Likewise.
* sock.c (decode_ifconf): Likewise.
* uid.c (print_groups): Likewise.
* io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace
umoven_or_printaddr argument of print_array with tfetch_mem.
(tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror
with tfetch_mem_ignore_syserror.
* v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument
of print_array with tfetch_mem.
(print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror
with tfetch_mem_ignore_syserror.
* mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename
to fetch_struct_mmsghdr_for_print, do not print address, return bool.
(decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr
with fetch_struct_mmsghdr_for_print.
* tests/aio.c (main): Update expected output.
* tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise.
* tests/ioctl_perf-success.c (main): Likewise.
* tests/ioctl_v4l2.c (main): Update expected output.
* tests/kexec_load.c (main): Likewise.
* tests/mmsg_name.c (test_mmsg_name): Update expected output.
* tests/move_pages.c (print_page_array, print_node_array): Likewise.
* tests/poll.c (print_pollfd_array_entering): Likewise.
* tests/preadv-pwritev.c (main): Likewise.
* tests/preadv2-pwritev2.c (dumpio): Likewise.
* tests/process_vm_readv_writev.c (print_iov): Likewise.
* tests/pwritev.c (print_iovec): Likewise.
* tests/readv.c (main): Likewise.
* tests/seccomp-filter-v.c
* tests/semop.c (main): Likewise.
* tests/set_mempolicy.c (print_nodes): Likewise.
* tests/setgroups.c (main): Likewise.
* tests/test_nlattr.h (print_nlattr) Likewise.

Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
2018-05-29 09:58:10 +00:00

241 lines
6.0 KiB
C

/*
* Check decoding of move_pages syscall.
*
* Copyright (c) 2016 Dmitry V. Levin <ldv@altlinux.org>
* Copyright (c) 2016-2017 The strace developers.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. The name of the author may not be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "tests.h"
#include <asm/unistd.h>
#ifdef __NR_move_pages
# include <errno.h>
# include <stdio.h>
# include <unistd.h>
# define MAX_STRLEN 3
static void
print_page_array(const void **const pages,
const unsigned long count,
const unsigned int offset)
{
if (!count) {
printf("%s", pages ? "[]" : "NULL");
return;
}
if (count <= offset) {
printf("%p", pages);
return;
}
printf("[");
unsigned long i;
for (i = 0; i < count; ++i) {
if (i)
printf(", ");
if (i + offset < count) {
if (i >= MAX_STRLEN) {
printf("...");
break;
}
} else {
printf("... /* %p */", pages + i);
break;
}
const void *const addr = pages[i];
if (addr)
printf("%p", addr);
else
printf("NULL");
}
printf("]");
}
static void
print_node_array(const int *const nodes,
const unsigned long count,
const unsigned int offset)
{
if (!count) {
printf("%s", nodes ? "[]" : "NULL");
return;
}
if (count <= offset) {
printf("%p", nodes);
return;
}
printf("[");
unsigned long i;
for (i = 0; i < count; ++i) {
if (i)
printf(", ");
if (i + offset < count) {
if (i >= MAX_STRLEN) {
printf("...");
break;
}
} else {
printf("... /* %p */", nodes + i);
break;
}
printf("%d", nodes[i]);
}
printf("]");
}
static void
print_status_array(const int *const status, const unsigned long count)
{
if (!count) {
printf("%s", status ? "[]" : "NULL");
return;
}
printf("[");
unsigned long i;
for (i = 0; i < count; ++i) {
if (i)
printf(", ");
if (i >= MAX_STRLEN) {
printf("...");
break;
}
if (status[i] >= 0) {
printf("%d", status[i]);
} else {
errno = -status[i];
printf("-%s", errno2name());
}
}
printf("]");
}
static void
print_stat_pages(const unsigned long pid, const unsigned long count,
const void **const pages, int *const status)
{
const unsigned long flags = (unsigned long) 0xfacefeed00000002ULL;
long rc = syscall(__NR_move_pages,
pid, count, pages, NULL, status, flags);
const char *errstr = sprintrc(rc);
printf("move_pages(%d, %lu, ", (int) pid, count);
print_page_array(pages, count, 0);
printf(", NULL, ");
if (rc) {
if (count)
printf("%p", status);
else
printf("[]");
} else {
print_status_array(status, count);
}
printf(", MPOL_MF_MOVE) = %s\n", errstr);
}
static void
print_move_pages(const unsigned long pid,
unsigned long count,
const unsigned int offset,
const void **const pages,
int *const nodes,
int *const status)
{
const unsigned long flags = (unsigned long) 0xfacefeed00000004ULL;
count += offset;
long rc = syscall(__NR_move_pages,
pid, count, pages, nodes, status, flags);
const char *errstr = sprintrc(rc);
printf("move_pages(%d, %lu, ", (int) pid, count);
print_page_array(pages, count, offset);
printf(", ");
print_node_array(nodes, count, offset);
printf(", ");
if (count)
printf("%p", status);
else
printf("[]");
printf(", MPOL_MF_MOVE_ALL) = %s\n", errstr);
}
int
main(void)
{
const unsigned long pid =
(unsigned long) 0xfacefeed00000000ULL | getpid();
unsigned long count = 1;
const unsigned page_size = get_page_size();
const void *const page = tail_alloc(page_size);
const void *const efault = page + page_size;
TAIL_ALLOC_OBJECT_VAR_PTR(const void *, pages);
TAIL_ALLOC_OBJECT_VAR_PTR(int, nodes);
TAIL_ALLOC_OBJECT_VAR_PTR(int, status);
print_stat_pages(pid, 0, pages, status);
print_move_pages(pid, 0, 0, pages, nodes, status);
print_move_pages(pid, 0, 1, pages + 1, nodes + 1, status + 1);
*pages = page;
print_stat_pages(pid, count, pages, status);
*nodes = 0xdeadbee1;
print_move_pages(pid, count, 0, pages, nodes, status);
print_move_pages(pid, count, 1, pages, nodes, status);
++count;
--status;
*(--pages) = efault;
print_stat_pages(pid, count, pages, status);
*(--nodes) = 0xdeadbee2;
print_move_pages(pid, count, 0, pages, nodes, status);
print_move_pages(pid, count, 1, pages, nodes, status);
++count;
--status;
*(--pages) = nodes;
print_stat_pages(pid, count, pages, status);
*(--nodes) = 0xdeadbee3;
print_move_pages(pid, count, 0, pages, nodes, status);
print_move_pages(pid, count, 1, pages, nodes, status);
++count;
--status;
*(--pages) = status;
print_stat_pages(pid, count, pages, status);
*(--nodes) = 0xdeadbee4;
print_move_pages(pid, count, 0, pages, nodes, status);
print_move_pages(pid, count, 1, pages, nodes, status);
puts("+++ exited with 0 +++");
return 0;
}
#else
SKIP_MAIN_UNDEFINED("__NR_move_pages")
#endif