Dmitry V. Levin
d54388e1ce
When umoven_func invocation fails to fetch data, it prints the faulty address. If this happens to a subsequent umoven_func invocation, the printed address may be undistinguishable from a valid data printed by print_func, e.g. when the data is printed in a numeric form like [0x1, 0x2, 0x3, 0xdefaced]. Fix this source of confusion by moving the printing of the faulty address from umoven_func to print_array itself. This change renames umoven_func to tfetch_mem_func and changes its semantics, so that - tfetch_mem_func never prints anything; - tfetch_mem_func returns true if the fetch succeeded, and false otherwise. * defs.h (print_array): Replace umoven_func argument with tfetch_mem_func. * util.c (print_array): Replace umoven_func argument with tfetch_mem_func, document expected tfetch_mem_func return value semantics. When tfetch_mem_func returns false, print either addr or "... /* addr */" depending on the context (inside the array or not). * bpf.c (print_ebpf_prog, print_bpf_prog_info, BEGIN_BPF_CMD_DECODER(BPF_PROG_QUERY)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. * bpf_filter.c (print_bpf_fprog): Likewise. * btrfs.c (btrfs_print_logical_ino_container, btrfs_print_ino_path_container, btrfs_print_qgroup_inherit, btrfs_ioctl): Likewise. * dm.c (dm_decode_dm_target_deps): Likewise. * epoll.c (epoll_wait_common): Likewise. * file_ioctl.c (file_ioctl): Likewise. * ipc_sem.c (tprint_sembuf_array): Likewise. * kexec.c (print_kexec_segments): Likewise. * mem.c (SYS_FUNC(subpage_prot)): Likewise. * net.c (print_getsockopt): Likewise. * netlink.c (decode_nlmsgerr_attr_cookie): Likewise. * netlink_netlink_diag.c (decode_netlink_diag_groups): Likewise. * netlink_packet_diag.c (decode_packet_diag_mclist): Likewise. * netlink_unix_diag.c (decode_unix_diag_inode): Likewise. * nlattr.c (decode_nla_meminfo): Likewise. * numa.c (print_nodemask, SYS_FUNC(move_pages), * perf_ioctl.c (perf_ioctl_query_bpf): Likewise. * poll.c (decode_poll_entering): Likewise. * printsiginfo.c (print_siginfo_array): Likewise. * rtnl_tc.c (decode_tca_stab_data): Likewise. * sock.c (decode_ifconf): Likewise. * uid.c (print_groups): Likewise. * io.c (SYS_FUNC(io_submit), SYS_FUNC(io_getevents)): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (tprint_iov_upto): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * v4l2.c (print_v4l2_format_fmt): Replace umoven_or_printaddr argument of print_array with tfetch_mem. (print_v4l2_ext_controls): Replace umoven_or_printaddr_ignore_syserror with tfetch_mem_ignore_syserror. * mmsghdr.c (fetch_struct_mmsghdr_or_printaddr): Rename to fetch_struct_mmsghdr_for_print, do not print address, return bool. (decode_mmsgvec): Replace fetch_struct_mmsghdr_or_printaddr with fetch_struct_mmsghdr_for_print. * tests/aio.c (main): Update expected output. * tests/bpf.c (print_BPF_PROG_QUERY_attr5): Likewise. * tests/ioctl_perf-success.c (main): Likewise. * tests/ioctl_v4l2.c (main): Update expected output. * tests/kexec_load.c (main): Likewise. * tests/mmsg_name.c (test_mmsg_name): Update expected output. * tests/move_pages.c (print_page_array, print_node_array): Likewise. * tests/poll.c (print_pollfd_array_entering): Likewise. * tests/preadv-pwritev.c (main): Likewise. * tests/preadv2-pwritev2.c (dumpio): Likewise. * tests/process_vm_readv_writev.c (print_iov): Likewise. * tests/pwritev.c (print_iovec): Likewise. * tests/readv.c (main): Likewise. * tests/seccomp-filter-v.c * tests/semop.c (main): Likewise. * tests/set_mempolicy.c (print_nodes): Likewise. * tests/setgroups.c (main): Likewise. * tests/test_nlattr.h (print_nlattr) Likewise. Co-Authored-by: Eugene Syromyatnikov <evgsyr@gmail.com>
148 lines
3.9 KiB
C
148 lines
3.9 KiB
C
/*
|
|
* Copyright (c) 2014-2016 Dmitry V. Levin <ldv@altlinux.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "tests.h"
|
|
|
|
#ifdef HAVE_PWRITEV
|
|
|
|
# include <fcntl.h>
|
|
# include <stdio.h>
|
|
# include <sys/uio.h>
|
|
# include <unistd.h>
|
|
|
|
# define LEN 8
|
|
# define LIM (LEN - 1)
|
|
|
|
static void
|
|
print_iov(const struct iovec *iov)
|
|
{
|
|
unsigned int i;
|
|
unsigned char *buf = iov->iov_base;
|
|
|
|
fputs("{iov_base=\"", stdout);
|
|
for (i = 0; i < iov->iov_len; ++i) {
|
|
if (i < LIM)
|
|
printf("\\%d", (int) buf[i]);
|
|
}
|
|
printf("\"%s, iov_len=%u}",
|
|
i > LIM ? "..." : "", (unsigned) iov->iov_len);
|
|
}
|
|
|
|
static void
|
|
print_iovec(const struct iovec *iov, unsigned int cnt, unsigned int size)
|
|
{
|
|
if (!size) {
|
|
printf("%p", iov);
|
|
return;
|
|
}
|
|
unsigned int i;
|
|
putchar('[');
|
|
for (i = 0; i < cnt; ++i) {
|
|
if (i)
|
|
fputs(", ", stdout);
|
|
if (i == size) {
|
|
printf("... /* %p */", &iov[i]);
|
|
break;
|
|
}
|
|
if (i == LIM) {
|
|
fputs("...", stdout);
|
|
break;
|
|
}
|
|
print_iov(&iov[i]);
|
|
}
|
|
putchar(']');
|
|
}
|
|
|
|
int
|
|
main(void)
|
|
{
|
|
(void) close(0);
|
|
if (open("/dev/null", O_WRONLY))
|
|
perror_msg_and_fail("open");
|
|
|
|
char *buf = tail_alloc(LEN);
|
|
unsigned i;
|
|
for (i = 0; i < LEN; ++i)
|
|
buf[i] = i;
|
|
|
|
struct iovec *iov = tail_alloc(sizeof(*iov) * LEN);
|
|
for (i = 0; i < LEN; ++i) {
|
|
buf[i] = i;
|
|
iov[i].iov_base = &buf[i];
|
|
iov[i].iov_len = LEN - i;
|
|
}
|
|
|
|
const off_t offset = 0xdefaceddeadbeefLL;
|
|
long rc;
|
|
int written = 0;
|
|
for (i = 0; i < LEN; ++i) {
|
|
written += iov[i].iov_len;
|
|
if (pwritev(0, iov, i + 1, offset + i) != written)
|
|
perror_msg_and_fail("pwritev");
|
|
fputs("pwritev(0, ", stdout);
|
|
print_iovec(iov, i + 1, LEN);
|
|
printf(", %u, %lld) = %d\n",
|
|
i + 1, (long long) offset + i, written);
|
|
}
|
|
|
|
for (i = 0; i <= LEN; ++i) {
|
|
unsigned int n = LEN + 1 - i;
|
|
fputs("pwritev(0, ", stdout);
|
|
print_iovec(iov + i, n, LEN - i);
|
|
rc = pwritev(0, iov + i, n, offset + LEN + i);
|
|
printf(", %u, %lld) = %ld %s (%m)\n",
|
|
n, (long long) offset + LEN + i, rc, errno2name());
|
|
}
|
|
|
|
iov->iov_base = iov + LEN * 2;
|
|
rc = pwritev(0, iov, 1, -1);
|
|
printf("pwritev(0, [{iov_base=%p, iov_len=%d}], 1, -1) = %ld %s (%m)\n",
|
|
iov->iov_base, LEN, rc, errno2name());
|
|
|
|
iov += LEN;
|
|
rc = pwritev(0, iov, 42, -2);
|
|
printf("pwritev(0, %p, 42, -2) = %ld %s (%m)\n",
|
|
iov, rc, errno2name());
|
|
|
|
rc = pwritev(0, NULL, 1, -3);
|
|
printf("pwritev(0, NULL, 1, -3) = %ld %s (%m)\n",
|
|
rc, errno2name());
|
|
|
|
rc = pwritev(0, iov, 0, -4);
|
|
printf("pwritev(0, [], 0, -4) = %ld %s (%m)\n",
|
|
rc, errno2name());
|
|
|
|
puts("+++ exited with 0 +++");
|
|
return 0;
|
|
}
|
|
|
|
#else
|
|
|
|
SKIP_MAIN_UNDEFINED("HAVE_PWRITEV")
|
|
|
|
#endif
|