2011-01-20 19:38:33 +03:00
/* 32-bit compatibility syscall for 64-bit systems
2005-04-17 02:20:36 +04:00
*
[PATCH] Keys: Make request-key create an authorisation key
The attached patch makes the following changes:
(1) There's a new special key type called ".request_key_auth".
This is an authorisation key for when one process requests a key and
another process is started to construct it. This type of key cannot be
created by the user; nor can it be requested by kernel services.
Authorisation keys hold two references:
(a) Each refers to a key being constructed. When the key being
constructed is instantiated the authorisation key is revoked,
rendering it of no further use.
(b) The "authorising process". This is either:
(i) the process that called request_key(), or:
(ii) if the process that called request_key() itself had an
authorisation key in its session keyring, then the authorising
process referred to by that authorisation key will also be
referred to by the new authorisation key.
This means that the process that initiated a chain of key requests
will authorise the lot of them, and will, by default, wind up with
the keys obtained from them in its keyrings.
(2) request_key() creates an authorisation key which is then passed to
/sbin/request-key in as part of a new session keyring.
(3) When request_key() is searching for a key to hand back to the caller, if
it comes across an authorisation key in the session keyring of the
calling process, it will also search the keyrings of the process
specified therein and it will use the specified process's credentials
(fsuid, fsgid, groups) to do that rather than the calling process's
credentials.
This allows a process started by /sbin/request-key to find keys belonging
to the authorising process.
(4) A key can be read, even if the process executing KEYCTL_READ doesn't have
direct read or search permission if that key is contained within the
keyrings of a process specified by an authorisation key found within the
calling process's session keyring, and is searchable using the
credentials of the authorising process.
This allows a process started by /sbin/request-key to read keys belonging
to the authorising process.
(5) The magic KEY_SPEC_*_KEYRING key IDs when passed to KEYCTL_INSTANTIATE or
KEYCTL_NEGATE will specify a keyring of the authorising process, rather
than the process doing the instantiation.
(6) One of the process keyrings can be nominated as the default to which
request_key() should attach new keys if not otherwise specified. This is
done with KEYCTL_SET_REQKEY_KEYRING and one of the KEY_REQKEY_DEFL_*
constants. The current setting can also be read using this call.
(7) request_key() is partially interruptible. If it is waiting for another
process to finish constructing a key, it can be interrupted. This permits
a request-key cycle to be broken without recourse to rebooting.
Signed-Off-By: David Howells <dhowells@redhat.com>
Signed-Off-By: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-06-24 09:00:56 +04:00
* Copyright ( C ) 2004 - 5 Red Hat , Inc . All Rights Reserved .
2005-04-17 02:20:36 +04:00
* Written by David Howells ( dhowells @ redhat . com )
*
* This program is free software ; you can redistribute it and / or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation ; either version
* 2 of the License , or ( at your option ) any later version .
*/
# include <linux/syscalls.h>
# include <linux/keyctl.h>
# include <linux/compat.h>
2011-03-07 18:06:20 +03:00
# include <linux/slab.h>
2005-04-17 02:20:36 +04:00
# include "internal.h"
2011-03-07 18:06:20 +03:00
/*
* Instantiate a key with the specified compatibility multipart payload and
* link the key into the destination keyring if one is given .
*
* The caller must have the appropriate instantiation permit set for this to
* work ( see keyctl_assume_authority ) . No other permissions are required .
*
* If successful , 0 will be returned .
*/
2012-05-21 15:32:13 +04:00
static long compat_keyctl_instantiate_key_iov (
2011-03-07 18:06:20 +03:00
key_serial_t id ,
const struct compat_iovec __user * _payload_iov ,
unsigned ioc ,
key_serial_t ringid )
{
struct iovec iovstack [ UIO_FASTIOV ] , * iov = iovstack ;
long ret ;
2012-05-21 15:32:13 +04:00
if ( ! _payload_iov | | ! ioc )
2011-03-07 18:06:20 +03:00
goto no_payload ;
ret = compat_rw_copy_check_uvector ( WRITE , _payload_iov , ioc ,
ARRAY_SIZE ( iovstack ) ,
2012-06-01 03:26:42 +04:00
iovstack , & iov ) ;
2011-03-07 18:06:20 +03:00
if ( ret < 0 )
Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys
Looking at mm/process_vm_access.c:process_vm_rw() and comparing it to
compat_process_vm_rw() shows that the compatibility code requires an
explicit "access_ok()" check before calling
compat_rw_copy_check_uvector(). The same difference seems to appear when
we compare fs/read_write.c:do_readv_writev() to
fs/compat.c:compat_do_readv_writev().
This subtle difference between the compat and non-compat requirements
should probably be debated, as it seems to be error-prone. In fact,
there are two others sites that use this function in the Linux kernel,
and they both seem to get it wrong:
Now shifting our attention to fs/aio.c, we see that aio_setup_iocb()
also ends up calling compat_rw_copy_check_uvector() through
aio_setup_vectored_rw(). Unfortunately, the access_ok() check appears to
be missing. Same situation for
security/keys/compat.c:compat_keyctl_instantiate_key_iov().
I propose that we add the access_ok() check directly into
compat_rw_copy_check_uvector(), so callers don't have to worry about it,
and it therefore makes the compat call code similar to its non-compat
counterpart. Place the access_ok() check in the same location where
copy_from_user() can trigger a -EFAULT error in the non-compat code, so
the ABI behaviors are alike on both compat and non-compat.
While we are here, fix compat_do_readv_writev() so it checks for
compat_rw_copy_check_uvector() negative return values.
And also, fix a memory leak in compat_keyctl_instantiate_key_iov() error
handling.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-25 19:20:36 +04:00
goto err ;
2011-03-07 18:06:20 +03:00
if ( ret = = 0 )
goto no_payload_free ;
ret = keyctl_instantiate_key_common ( id , iov , ioc , ret , ringid ) ;
Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys
Looking at mm/process_vm_access.c:process_vm_rw() and comparing it to
compat_process_vm_rw() shows that the compatibility code requires an
explicit "access_ok()" check before calling
compat_rw_copy_check_uvector(). The same difference seems to appear when
we compare fs/read_write.c:do_readv_writev() to
fs/compat.c:compat_do_readv_writev().
This subtle difference between the compat and non-compat requirements
should probably be debated, as it seems to be error-prone. In fact,
there are two others sites that use this function in the Linux kernel,
and they both seem to get it wrong:
Now shifting our attention to fs/aio.c, we see that aio_setup_iocb()
also ends up calling compat_rw_copy_check_uvector() through
aio_setup_vectored_rw(). Unfortunately, the access_ok() check appears to
be missing. Same situation for
security/keys/compat.c:compat_keyctl_instantiate_key_iov().
I propose that we add the access_ok() check directly into
compat_rw_copy_check_uvector(), so callers don't have to worry about it,
and it therefore makes the compat call code similar to its non-compat
counterpart. Place the access_ok() check in the same location where
copy_from_user() can trigger a -EFAULT error in the non-compat code, so
the ABI behaviors are alike on both compat and non-compat.
While we are here, fix compat_do_readv_writev() so it checks for
compat_rw_copy_check_uvector() negative return values.
And also, fix a memory leak in compat_keyctl_instantiate_key_iov() error
handling.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-25 19:20:36 +04:00
err :
2011-03-07 18:06:20 +03:00
if ( iov ! = iovstack )
kfree ( iov ) ;
return ret ;
no_payload_free :
if ( iov ! = iovstack )
kfree ( iov ) ;
no_payload :
return keyctl_instantiate_key_common ( id , NULL , 0 , 0 , ringid ) ;
}
2005-04-17 02:20:36 +04:00
/*
2011-01-20 19:38:33 +03:00
* The key control system call , 32 - bit compatibility version for 64 - bit archs
*
* This should only be called if the 64 - bit arch uses weird pointers in 32 - bit
* mode or doesn ' t guarantee that the top 32 - bits of the argument registers on
* taking a 32 - bit syscall are zero . If you can , you should call sys_keyctl ( )
* directly .
2005-04-17 02:20:36 +04:00
*/
2014-03-03 19:34:41 +04:00
COMPAT_SYSCALL_DEFINE5 ( keyctl , u32 , option ,
u32 , arg2 , u32 , arg3 , u32 , arg4 , u32 , arg5 )
2005-04-17 02:20:36 +04:00
{
switch ( option ) {
case KEYCTL_GET_KEYRING_ID :
return keyctl_get_keyring_ID ( arg2 , arg3 ) ;
case KEYCTL_JOIN_SESSION_KEYRING :
return keyctl_join_session_keyring ( compat_ptr ( arg2 ) ) ;
case KEYCTL_UPDATE :
return keyctl_update_key ( arg2 , compat_ptr ( arg3 ) , arg4 ) ;
case KEYCTL_REVOKE :
return keyctl_revoke_key ( arg2 ) ;
case KEYCTL_DESCRIBE :
return keyctl_describe_key ( arg2 , compat_ptr ( arg3 ) , arg4 ) ;
case KEYCTL_CLEAR :
return keyctl_keyring_clear ( arg2 ) ;
case KEYCTL_LINK :
return keyctl_keyring_link ( arg2 , arg3 ) ;
case KEYCTL_UNLINK :
return keyctl_keyring_unlink ( arg2 , arg3 ) ;
case KEYCTL_SEARCH :
return keyctl_keyring_search ( arg2 , compat_ptr ( arg3 ) ,
compat_ptr ( arg4 ) , arg5 ) ;
case KEYCTL_READ :
return keyctl_read_key ( arg2 , compat_ptr ( arg3 ) , arg4 ) ;
case KEYCTL_CHOWN :
return keyctl_chown_key ( arg2 , arg3 , arg4 ) ;
case KEYCTL_SETPERM :
return keyctl_setperm_key ( arg2 , arg3 ) ;
case KEYCTL_INSTANTIATE :
return keyctl_instantiate_key ( arg2 , compat_ptr ( arg3 ) , arg4 ,
arg5 ) ;
case KEYCTL_NEGATE :
return keyctl_negate_key ( arg2 , arg3 , arg4 ) ;
[PATCH] Keys: Make request-key create an authorisation key
The attached patch makes the following changes:
(1) There's a new special key type called ".request_key_auth".
This is an authorisation key for when one process requests a key and
another process is started to construct it. This type of key cannot be
created by the user; nor can it be requested by kernel services.
Authorisation keys hold two references:
(a) Each refers to a key being constructed. When the key being
constructed is instantiated the authorisation key is revoked,
rendering it of no further use.
(b) The "authorising process". This is either:
(i) the process that called request_key(), or:
(ii) if the process that called request_key() itself had an
authorisation key in its session keyring, then the authorising
process referred to by that authorisation key will also be
referred to by the new authorisation key.
This means that the process that initiated a chain of key requests
will authorise the lot of them, and will, by default, wind up with
the keys obtained from them in its keyrings.
(2) request_key() creates an authorisation key which is then passed to
/sbin/request-key in as part of a new session keyring.
(3) When request_key() is searching for a key to hand back to the caller, if
it comes across an authorisation key in the session keyring of the
calling process, it will also search the keyrings of the process
specified therein and it will use the specified process's credentials
(fsuid, fsgid, groups) to do that rather than the calling process's
credentials.
This allows a process started by /sbin/request-key to find keys belonging
to the authorising process.
(4) A key can be read, even if the process executing KEYCTL_READ doesn't have
direct read or search permission if that key is contained within the
keyrings of a process specified by an authorisation key found within the
calling process's session keyring, and is searchable using the
credentials of the authorising process.
This allows a process started by /sbin/request-key to read keys belonging
to the authorising process.
(5) The magic KEY_SPEC_*_KEYRING key IDs when passed to KEYCTL_INSTANTIATE or
KEYCTL_NEGATE will specify a keyring of the authorising process, rather
than the process doing the instantiation.
(6) One of the process keyrings can be nominated as the default to which
request_key() should attach new keys if not otherwise specified. This is
done with KEYCTL_SET_REQKEY_KEYRING and one of the KEY_REQKEY_DEFL_*
constants. The current setting can also be read using this call.
(7) request_key() is partially interruptible. If it is waiting for another
process to finish constructing a key, it can be interrupted. This permits
a request-key cycle to be broken without recourse to rebooting.
Signed-Off-By: David Howells <dhowells@redhat.com>
Signed-Off-By: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-06-24 09:00:56 +04:00
case KEYCTL_SET_REQKEY_KEYRING :
return keyctl_set_reqkey_keyring ( arg2 ) ;
2006-01-08 12:02:43 +03:00
case KEYCTL_SET_TIMEOUT :
return keyctl_set_timeout ( arg2 , arg3 ) ;
2006-01-08 12:02:47 +03:00
case KEYCTL_ASSUME_AUTHORITY :
return keyctl_assume_authority ( arg2 ) ;
2008-04-29 12:01:26 +04:00
case KEYCTL_GET_SECURITY :
return keyctl_get_security ( arg2 , compat_ptr ( arg3 ) , arg4 ) ;
KEYS: Add a keyctl to install a process's session keyring on its parent [try #6]
Add a keyctl to install a process's session keyring onto its parent. This
replaces the parent's session keyring. Because the COW credential code does
not permit one process to change another process's credentials directly, the
change is deferred until userspace next starts executing again. Normally this
will be after a wait*() syscall.
To support this, three new security hooks have been provided:
cred_alloc_blank() to allocate unset security creds, cred_transfer() to fill in
the blank security creds and key_session_to_parent() - which asks the LSM if
the process may replace its parent's session keyring.
The replacement may only happen if the process has the same ownership details
as its parent, and the process has LINK permission on the session keyring, and
the session keyring is owned by the process, and the LSM permits it.
Note that this requires alteration to each architecture's notify_resume path.
This has been done for all arches barring blackfin, m68k* and xtensa, all of
which need assembly alteration to support TIF_NOTIFY_RESUME. This allows the
replacement to be performed at the point the parent process resumes userspace
execution.
This allows the userspace AFS pioctl emulation to fully emulate newpag() and
the VIOCSETTOK and VIOCSETTOK2 pioctls, all of which require the ability to
alter the parent process's PAG membership. However, since kAFS doesn't use
PAGs per se, but rather dumps the keys into the session keyring, the session
keyring of the parent must be replaced if, for example, VIOCSETTOK is passed
the newpag flag.
This can be tested with the following program:
#include <stdio.h>
#include <stdlib.h>
#include <keyutils.h>
#define KEYCTL_SESSION_TO_PARENT 18
#define OSERROR(X, S) do { if ((long)(X) == -1) { perror(S); exit(1); } } while(0)
int main(int argc, char **argv)
{
key_serial_t keyring, key;
long ret;
keyring = keyctl_join_session_keyring(argv[1]);
OSERROR(keyring, "keyctl_join_session_keyring");
key = add_key("user", "a", "b", 1, keyring);
OSERROR(key, "add_key");
ret = keyctl(KEYCTL_SESSION_TO_PARENT);
OSERROR(ret, "KEYCTL_SESSION_TO_PARENT");
return 0;
}
Compiled and linked with -lkeyutils, you should see something like:
[dhowells@andromeda ~]$ keyctl show
Session Keyring
-3 --alswrv 4043 4043 keyring: _ses
355907932 --alswrv 4043 -1 \_ keyring: _uid.4043
[dhowells@andromeda ~]$ /tmp/newpag
[dhowells@andromeda ~]$ keyctl show
Session Keyring
-3 --alswrv 4043 4043 keyring: _ses
1055658746 --alswrv 4043 4043 \_ user: a
[dhowells@andromeda ~]$ /tmp/newpag hello
[dhowells@andromeda ~]$ keyctl show
Session Keyring
-3 --alswrv 4043 4043 keyring: hello
340417692 --alswrv 4043 4043 \_ user: a
Where the test program creates a new session keyring, sticks a user key named
'a' into it and then installs it on its parent.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
2009-09-02 12:14:21 +04:00
case KEYCTL_SESSION_TO_PARENT :
return keyctl_session_to_parent ( ) ;
2011-03-07 18:06:09 +03:00
case KEYCTL_REJECT :
return keyctl_reject_key ( arg2 , arg3 , arg4 , arg5 ) ;
2011-03-07 18:06:20 +03:00
case KEYCTL_INSTANTIATE_IOV :
return compat_keyctl_instantiate_key_iov (
arg2 , compat_ptr ( arg3 ) , arg4 , arg5 ) ;
2012-05-11 13:56:56 +04:00
case KEYCTL_INVALIDATE :
return keyctl_invalidate_key ( arg2 ) ;
2013-09-24 13:35:19 +04:00
case KEYCTL_GET_PERSISTENT :
return keyctl_get_persistent ( arg2 , arg3 ) ;
2005-04-17 02:20:36 +04:00
default :
return - EOPNOTSUPP ;
}
2011-01-20 19:38:27 +03:00
}