2019-05-27 09:55:01 +03:00
// SPDX-License-Identifier: GPL-2.0-or-later
2005-04-25 07:10:16 +04:00
/*
2014-11-05 22:51:51 +03:00
* net / sched / act_simple . c Simple example of an action
2005-04-25 07:10:16 +04:00
*
2008-05-05 11:22:35 +04:00
* Authors : Jamal Hadi Salim ( 2005 - 8 )
2005-04-25 07:10:16 +04:00
*/
2005-04-25 23:15:01 +04:00
# include <linux/module.h>
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 11:04:11 +03:00
# include <linux/slab.h>
2005-04-25 23:15:01 +04:00
# include <linux/init.h>
2005-04-25 07:10:16 +04:00
# include <linux/kernel.h>
# include <linux/skbuff.h>
# include <linux/rtnetlink.h>
2007-03-26 10:06:12 +04:00
# include <net/netlink.h>
2005-04-25 07:10:16 +04:00
# include <net/pkt_sched.h>
2019-03-20 17:00:10 +03:00
# include <net/pkt_cls.h>
2022-12-06 16:55:12 +03:00
# include <net/tc_wrapper.h>
2005-04-25 07:10:16 +04:00
# include <linux/tc_act/tc_defact.h>
# include <net/tc_act/tc_defact.h>
2016-07-26 02:09:41 +03:00
static struct tc_action_ops act_simp_ops ;
2016-02-23 02:57:53 +03:00
2008-05-05 11:22:35 +04:00
# define SIMP_MAX_DATA 32
2022-12-06 16:55:12 +03:00
TC_INDIRECT_SCOPE int tcf_simp_act ( struct sk_buff * skb ,
const struct tc_action * a ,
struct tcf_result * res )
2005-04-25 07:10:16 +04:00
{
2016-07-26 02:09:41 +03:00
struct tcf_defact * d = to_defact ( a ) ;
2005-04-25 07:10:16 +04:00
2006-08-22 10:54:55 +04:00
spin_lock ( & d - > tcf_lock ) ;
2016-06-06 13:32:53 +03:00
tcf_lastuse_update ( & d - > tcf_tm ) ;
2011-01-09 11:30:54 +03:00
bstats_update ( & d - > tcf_bstats , skb ) ;
2005-04-25 07:10:16 +04:00
2007-02-09 17:25:16 +03:00
/* print policy string followed by _ then packet count
* Example if this was the 3 rd packet and the string was " hello "
* then it would look like " hello_3 " ( without quotes )
2011-01-19 22:26:56 +03:00
*/
2019-11-05 06:13:14 +03:00
pr_info ( " simple: %s_%llu \n " ,
2021-10-16 11:49:09 +03:00
( char * ) d - > tcfd_defdata ,
u64_stats_read ( & d - > tcf_bstats . packets ) ) ;
2006-08-22 10:54:55 +04:00
spin_unlock ( & d - > tcf_lock ) ;
return d - > tcf_action ;
}
2017-12-05 23:53:07 +03:00
static void tcf_simp_release ( struct tc_action * a )
2006-08-22 10:54:55 +04:00
{
2014-02-12 05:07:31 +04:00
struct tcf_defact * d = to_defact ( a ) ;
2014-02-12 05:07:32 +04:00
kfree ( d - > tcfd_defdata ) ;
2006-08-22 10:54:55 +04:00
}
2018-06-08 06:02:31 +03:00
static int alloc_defdata ( struct tcf_defact * d , const struct nlattr * defdata )
2006-08-22 10:54:55 +04:00
{
2010-07-15 04:56:37 +04:00
d - > tcfd_defdata = kzalloc ( SIMP_MAX_DATA , GFP_KERNEL ) ;
2006-08-22 10:54:55 +04:00
if ( unlikely ( ! d - > tcfd_defdata ) )
return - ENOMEM ;
2020-11-15 20:08:06 +03:00
nla_strscpy ( d - > tcfd_defdata , defdata , SIMP_MAX_DATA ) ;
2006-08-22 10:54:55 +04:00
return 0 ;
}
2019-03-20 17:00:10 +03:00
static int reset_policy ( struct tc_action * a , const struct nlattr * defdata ,
struct tc_defact * p , struct tcf_proto * tp ,
struct netlink_ext_ack * extack )
2006-08-22 10:54:55 +04:00
{
2019-03-20 17:00:10 +03:00
struct tcf_chain * goto_ch = NULL ;
struct tcf_defact * d ;
int err ;
err = tcf_action_check_ctrlact ( p - > action , tp , & goto_ch , extack ) ;
if ( err < 0 )
return err ;
d = to_defact ( a ) ;
2008-05-06 11:10:24 +04:00
spin_lock_bh ( & d - > tcf_lock ) ;
2019-03-20 17:00:10 +03:00
goto_ch = tcf_action_set_ctrlact ( a , p - > action , goto_ch ) ;
2008-05-06 11:10:24 +04:00
memset ( d - > tcfd_defdata , 0 , SIMP_MAX_DATA ) ;
2020-11-15 20:08:06 +03:00
nla_strscpy ( d - > tcfd_defdata , defdata , SIMP_MAX_DATA ) ;
2008-05-06 11:10:24 +04:00
spin_unlock_bh ( & d - > tcf_lock ) ;
2019-03-20 17:00:10 +03:00
if ( goto_ch )
tcf_chain_put_by_act ( goto_ch ) ;
return 0 ;
2006-08-22 10:54:55 +04:00
}
2008-01-24 07:36:30 +03:00
static const struct nla_policy simple_policy [ TCA_DEF_MAX + 1 ] = {
[ TCA_DEF_PARMS ] = { . len = sizeof ( struct tc_defact ) } ,
2008-05-05 11:22:35 +04:00
[ TCA_DEF_DATA ] = { . type = NLA_STRING , . len = SIMP_MAX_DATA } ,
2008-01-24 07:36:30 +03:00
} ;
2013-01-14 09:15:39 +04:00
static int tcf_simp_init ( struct net * net , struct nlattr * nla ,
2016-07-26 02:09:41 +03:00
struct nlattr * est , struct tc_action * * a ,
2019-10-30 17:09:05 +03:00
struct tcf_proto * tp , u32 flags ,
struct netlink_ext_ack * extack )
2006-08-22 10:54:55 +04:00
{
2022-09-08 07:14:33 +03:00
struct tc_action_net * tn = net_generic ( net , act_simp_ops . net_id ) ;
2021-07-30 02:12:14 +03:00
bool bind = flags & TCA_ACT_FLAGS_BIND ;
2008-01-23 09:11:50 +03:00
struct nlattr * tb [ TCA_DEF_MAX + 1 ] ;
2019-03-20 17:00:10 +03:00
struct tcf_chain * goto_ch = NULL ;
2006-08-22 10:54:55 +04:00
struct tc_defact * parm ;
struct tcf_defact * d ;
2016-06-13 23:46:28 +03:00
bool exists = false ;
int ret = 0 , err ;
2019-08-01 16:02:51 +03:00
u32 index ;
2006-08-22 10:54:55 +04:00
2008-01-24 07:33:32 +03:00
if ( nla = = NULL )
2006-08-22 10:54:55 +04:00
return - EINVAL ;
netlink: make validation more configurable for future strictness
We currently have two levels of strict validation:
1) liberal (default)
- undefined (type >= max) & NLA_UNSPEC attributes accepted
- attribute length >= expected accepted
- garbage at end of message accepted
2) strict (opt-in)
- NLA_UNSPEC attributes accepted
- attribute length >= expected accepted
Split out parsing strictness into four different options:
* TRAILING - check that there's no trailing data after parsing
attributes (in message or nested)
* MAXTYPE - reject attrs > max known type
* UNSPEC - reject attributes with NLA_UNSPEC policy entries
* STRICT_ATTRS - strictly validate attribute size
The default for future things should be *everything*.
The current *_strict() is a combination of TRAILING and MAXTYPE,
and is renamed to _deprecated_strict().
The current regular parsing has none of this, and is renamed to
*_parse_deprecated().
Additionally it allows us to selectively set one of the new flags
even on old policies. Notably, the UNSPEC flag could be useful in
this case, since it can be arranged (by filling in the policy) to
not be an incompatible userspace ABI change, but would then going
forward prevent forgetting attribute entries. Similar can apply
to the POLICY flag.
We end up with the following renames:
* nla_parse -> nla_parse_deprecated
* nla_parse_strict -> nla_parse_deprecated_strict
* nlmsg_parse -> nlmsg_parse_deprecated
* nlmsg_parse_strict -> nlmsg_parse_deprecated_strict
* nla_parse_nested -> nla_parse_nested_deprecated
* nla_validate_nested -> nla_validate_nested_deprecated
Using spatch, of course:
@@
expression TB, MAX, HEAD, LEN, POL, EXT;
@@
-nla_parse(TB, MAX, HEAD, LEN, POL, EXT)
+nla_parse_deprecated(TB, MAX, HEAD, LEN, POL, EXT)
@@
expression NLH, HDRLEN, TB, MAX, POL, EXT;
@@
-nlmsg_parse(NLH, HDRLEN, TB, MAX, POL, EXT)
+nlmsg_parse_deprecated(NLH, HDRLEN, TB, MAX, POL, EXT)
@@
expression NLH, HDRLEN, TB, MAX, POL, EXT;
@@
-nlmsg_parse_strict(NLH, HDRLEN, TB, MAX, POL, EXT)
+nlmsg_parse_deprecated_strict(NLH, HDRLEN, TB, MAX, POL, EXT)
@@
expression TB, MAX, NLA, POL, EXT;
@@
-nla_parse_nested(TB, MAX, NLA, POL, EXT)
+nla_parse_nested_deprecated(TB, MAX, NLA, POL, EXT)
@@
expression START, MAX, POL, EXT;
@@
-nla_validate_nested(START, MAX, POL, EXT)
+nla_validate_nested_deprecated(START, MAX, POL, EXT)
@@
expression NLH, HDRLEN, MAX, POL, EXT;
@@
-nlmsg_validate(NLH, HDRLEN, MAX, POL, EXT)
+nlmsg_validate_deprecated(NLH, HDRLEN, MAX, POL, EXT)
For this patch, don't actually add the strict, non-renamed versions
yet so that it breaks compile if I get it wrong.
Also, while at it, make nla_validate and nla_parse go down to a
common __nla_validate_parse() function to avoid code duplication.
Ultimately, this allows us to have very strict validation for every
new caller of nla_parse()/nlmsg_parse() etc as re-introduced in the
next patch, while existing things will continue to work as is.
In effect then, this adds fully strict validation for any new command.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-04-26 15:07:28 +03:00
err = nla_parse_nested_deprecated ( tb , TCA_DEF_MAX , nla , simple_policy ,
NULL ) ;
2008-01-24 07:33:32 +03:00
if ( err < 0 )
return err ;
2008-01-24 07:36:30 +03:00
if ( tb [ TCA_DEF_PARMS ] = = NULL )
2006-08-22 10:54:55 +04:00
return - EINVAL ;
2008-05-05 11:22:35 +04:00
parm = nla_data ( tb [ TCA_DEF_PARMS ] ) ;
2019-08-01 16:02:51 +03:00
index = parm - > index ;
err = tcf_idr_check_alloc ( tn , & index , a , bind ) ;
2018-07-05 17:24:32 +03:00
if ( err < 0 )
return err ;
exists = err ;
2016-05-10 23:49:29 +03:00
if ( exists & & bind )
return 0 ;
if ( tb [ TCA_DEF_DATA ] = = NULL ) {
if ( exists )
2017-08-30 09:31:59 +03:00
tcf_idr_release ( * a , bind ) ;
2018-07-05 17:24:32 +03:00
else
2019-08-01 16:02:51 +03:00
tcf_idr_cleanup ( tn , index ) ;
2016-05-10 23:49:29 +03:00
return - EINVAL ;
}
if ( ! exists ) {
2019-08-01 16:02:51 +03:00
ret = tcf_idr_create ( tn , index , est , a ,
2021-12-17 21:16:17 +03:00
& act_simp_ops , bind , false , flags ) ;
2018-07-05 17:24:32 +03:00
if ( ret ) {
2019-08-01 16:02:51 +03:00
tcf_idr_cleanup ( tn , index ) ;
2014-02-12 05:07:31 +04:00
return ret ;
2018-07-05 17:24:32 +03:00
}
2006-08-22 10:54:55 +04:00
2016-07-26 02:09:41 +03:00
d = to_defact ( * a ) ;
2019-03-20 17:00:10 +03:00
err = tcf_action_check_ctrlact ( parm - > action , tp , & goto_ch ,
extack ) ;
if ( err < 0 )
goto release_idr ;
err = alloc_defdata ( d , tb [ TCA_DEF_DATA ] ) ;
if ( err < 0 )
goto put_chain ;
tcf_action_set_ctrlact ( * a , parm - > action , goto_ch ) ;
2006-08-22 10:54:55 +04:00
ret = ACT_P_CREATED ;
} else {
2021-07-30 02:12:14 +03:00
if ( ! ( flags & TCA_ACT_FLAGS_REPLACE ) ) {
2019-03-20 17:00:10 +03:00
err = - EEXIST ;
goto release_idr ;
2018-07-05 17:24:30 +03:00
}
2013-12-23 17:02:11 +04:00
2019-03-20 17:00:10 +03:00
err = reset_policy ( * a , tb [ TCA_DEF_DATA ] , parm , tp , extack ) ;
if ( err )
goto release_idr ;
2006-08-22 10:54:55 +04:00
}
return ret ;
2019-03-20 17:00:10 +03:00
put_chain :
if ( goto_ch )
tcf_chain_put_by_act ( goto_ch ) ;
release_idr :
tcf_idr_release ( * a , bind ) ;
return err ;
2006-08-22 10:54:55 +04:00
}
2011-01-19 22:26:56 +03:00
static int tcf_simp_dump ( struct sk_buff * skb , struct tc_action * a ,
int bind , int ref )
2006-08-22 10:54:55 +04:00
{
2007-04-20 07:29:13 +04:00
unsigned char * b = skb_tail_pointer ( skb ) ;
2016-07-26 02:09:41 +03:00
struct tcf_defact * d = to_defact ( a ) ;
2010-08-17 00:04:22 +04:00
struct tc_defact opt = {
. index = d - > tcf_index ,
2018-07-05 17:24:24 +03:00
. refcnt = refcount_read ( & d - > tcf_refcnt ) - ref ,
. bindcnt = atomic_read ( & d - > tcf_bindcnt ) - bind ,
2010-08-17 00:04:22 +04:00
} ;
2006-08-22 10:54:55 +04:00
struct tcf_t t ;
2018-08-10 20:51:48 +03:00
spin_lock_bh ( & d - > tcf_lock ) ;
opt . action = d - > tcf_action ;
2012-03-29 13:11:39 +04:00
if ( nla_put ( skb , TCA_DEF_PARMS , sizeof ( opt ) , & opt ) | |
nla_put_string ( skb , TCA_DEF_DATA , d - > tcfd_defdata ) )
goto nla_put_failure ;
2016-06-06 13:32:55 +03:00
tcf_tm_dump ( & t , & d - > tcf_tm ) ;
2016-04-26 11:06:18 +03:00
if ( nla_put_64bit ( skb , TCA_DEF_TM , sizeof ( t ) , & t , TCA_DEF_PAD ) )
2012-03-29 13:11:39 +04:00
goto nla_put_failure ;
2018-08-10 20:51:48 +03:00
spin_unlock_bh ( & d - > tcf_lock ) ;
2006-08-22 10:54:55 +04:00
return skb - > len ;
2008-01-23 09:11:50 +03:00
nla_put_failure :
2018-08-10 20:51:48 +03:00
spin_unlock_bh ( & d - > tcf_lock ) ;
2007-03-26 10:06:12 +04:00
nlmsg_trim ( skb , b ) ;
2006-08-22 10:54:55 +04:00
return - 1 ;
2005-04-25 07:10:16 +04:00
}
static struct tc_action_ops act_simp_ops = {
2006-08-22 10:54:55 +04:00
. kind = " simple " ,
2019-02-10 15:25:00 +03:00
. id = TCA_ID_SIMP ,
2006-08-22 10:54:55 +04:00
. owner = THIS_MODULE ,
2018-08-12 16:34:57 +03:00
. act = tcf_simp_act ,
2006-08-22 10:54:55 +04:00
. dump = tcf_simp_dump ,
2014-02-12 05:07:31 +04:00
. cleanup = tcf_simp_release ,
2006-08-22 10:54:55 +04:00
. init = tcf_simp_init ,
2016-07-26 02:09:41 +03:00
. size = sizeof ( struct tcf_defact ) ,
2016-02-23 02:57:53 +03:00
} ;
static __net_init int simp_init_net ( struct net * net )
{
2022-09-08 07:14:33 +03:00
struct tc_action_net * tn = net_generic ( net , act_simp_ops . net_id ) ;
2016-02-23 02:57:53 +03:00
2019-08-25 20:01:32 +03:00
return tc_action_net_init ( net , tn , & act_simp_ops ) ;
2016-02-23 02:57:53 +03:00
}
2017-12-12 02:35:03 +03:00
static void __net_exit simp_exit_net ( struct list_head * net_list )
2016-02-23 02:57:53 +03:00
{
2022-09-08 07:14:33 +03:00
tc_action_net_exit ( net_list , act_simp_ops . net_id ) ;
2016-02-23 02:57:53 +03:00
}
static struct pernet_operations simp_net_ops = {
. init = simp_init_net ,
2017-12-12 02:35:03 +03:00
. exit_batch = simp_exit_net ,
2022-09-08 07:14:33 +03:00
. id = & act_simp_ops . net_id ,
2016-02-23 02:57:53 +03:00
. size = sizeof ( struct tc_action_net ) ,
2005-04-25 07:10:16 +04:00
} ;
MODULE_AUTHOR ( " Jamal Hadi Salim(2005) " ) ;
MODULE_DESCRIPTION ( " Simple example action " ) ;
MODULE_LICENSE ( " GPL " ) ;
static int __init simp_init_module ( void )
{
2016-02-23 02:57:53 +03:00
int ret = tcf_register_action ( & act_simp_ops , & simp_net_ops ) ;
2005-04-25 07:10:16 +04:00
if ( ! ret )
2010-05-12 10:37:05 +04:00
pr_info ( " Simple TC action Loaded \n " ) ;
2005-04-25 07:10:16 +04:00
return ret ;
}
static void __exit simp_cleanup_module ( void )
{
2016-02-23 02:57:53 +03:00
tcf_unregister_action ( & act_simp_ops , & simp_net_ops ) ;
2005-04-25 07:10:16 +04:00
}
module_init ( simp_init_module ) ;
module_exit ( simp_cleanup_module ) ;