2012-04-13 15:10:24 +04:00
/*
* OMAP DMAengine support
*
* This program is free software ; you can redistribute it and / or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation .
*/
2013-11-02 21:07:09 +04:00
# include <linux/delay.h>
2012-04-13 15:10:24 +04:00
# include <linux/dmaengine.h>
# include <linux/dma-mapping.h>
# include <linux/err.h>
# include <linux/init.h>
# include <linux/interrupt.h>
# include <linux/list.h>
# include <linux/module.h>
# include <linux/omap-dma.h>
# include <linux/platform_device.h>
# include <linux/slab.h>
# include <linux/spinlock.h>
2013-02-26 22:27:24 +04:00
# include <linux/of_dma.h>
# include <linux/of_device.h>
2012-04-13 15:10:24 +04:00
# include "virt-dma.h"
2012-08-28 04:43:01 +04:00
2015-04-09 12:35:50 +03:00
# define OMAP_SDMA_REQUESTS 127
# define OMAP_SDMA_CHANNELS 32
2012-04-13 15:10:24 +04:00
struct omap_dmadev {
struct dma_device ddev ;
spinlock_t lock ;
2013-12-10 15:08:01 +04:00
void __iomem * base ;
const struct omap_dma_reg * reg_map ;
2013-11-02 17:00:03 +04:00
struct omap_system_dma_plat_info * plat ;
2013-12-10 23:05:50 +04:00
bool legacy ;
2015-04-09 12:35:51 +03:00
unsigned dma_requests ;
2013-12-10 23:05:50 +04:00
spinlock_t irq_lock ;
uint32_t irq_enable_mask ;
2015-04-09 12:35:50 +03:00
struct omap_chan * lch_map [ OMAP_SDMA_CHANNELS ] ;
2012-04-13 15:10:24 +04:00
} ;
struct omap_chan {
struct virt_dma_chan vc ;
2013-12-10 15:08:01 +04:00
void __iomem * channel_base ;
const struct omap_dma_reg * reg_map ;
2014-01-15 03:58:10 +04:00
uint32_t ccr ;
2012-04-13 15:10:24 +04:00
struct dma_slave_config cfg ;
unsigned dma_sig ;
2012-06-21 13:40:15 +04:00
bool cyclic ;
2012-09-14 16:05:45 +04:00
bool paused ;
2016-04-05 15:20:20 +03:00
bool running ;
2012-04-13 15:10:24 +04:00
int dma_ch ;
struct omap_desc * desc ;
unsigned sgidx ;
} ;
struct omap_sg {
dma_addr_t addr ;
uint32_t en ; /* number of elements (24-bit) */
uint32_t fn ; /* number of frames (16-bit) */
} ;
struct omap_desc {
struct virt_dma_desc vd ;
enum dma_transfer_direction dir ;
dma_addr_t dev_addr ;
2012-06-18 19:45:19 +04:00
int16_t fi ; /* for OMAP_DMA_SYNC_PACKET */
2013-11-02 23:57:06 +04:00
uint8_t es ; /* CSDP_DATA_TYPE_xxx */
2013-11-02 23:16:09 +04:00
uint32_t ccr ; /* CCR value */
2013-11-06 21:12:30 +04:00
uint16_t clnk_ctrl ; /* CLNK_CTRL value */
2013-11-02 21:07:09 +04:00
uint16_t cicr ; /* CICR value */
2013-11-02 22:51:53 +04:00
uint32_t csdp ; /* CSDP value */
2012-04-13 15:10:24 +04:00
unsigned sglen ;
struct omap_sg sg [ 0 ] ;
} ;
2013-11-02 23:57:06 +04:00
enum {
CCR_FS = BIT ( 5 ) ,
CCR_READ_PRIORITY = BIT ( 6 ) ,
CCR_ENABLE = BIT ( 7 ) ,
CCR_AUTO_INIT = BIT ( 8 ) , /* OMAP1 only */
CCR_REPEAT = BIT ( 9 ) , /* OMAP1 only */
CCR_OMAP31_DISABLE = BIT ( 10 ) , /* OMAP1 only */
CCR_SUSPEND_SENSITIVE = BIT ( 8 ) , /* OMAP2+ only */
CCR_RD_ACTIVE = BIT ( 9 ) , /* OMAP2+ only */
CCR_WR_ACTIVE = BIT ( 10 ) , /* OMAP2+ only */
CCR_SRC_AMODE_CONSTANT = 0 < < 12 ,
CCR_SRC_AMODE_POSTINC = 1 < < 12 ,
CCR_SRC_AMODE_SGLIDX = 2 < < 12 ,
CCR_SRC_AMODE_DBLIDX = 3 < < 12 ,
CCR_DST_AMODE_CONSTANT = 0 < < 14 ,
CCR_DST_AMODE_POSTINC = 1 < < 14 ,
CCR_DST_AMODE_SGLIDX = 2 < < 14 ,
CCR_DST_AMODE_DBLIDX = 3 < < 14 ,
CCR_CONSTANT_FILL = BIT ( 16 ) ,
CCR_TRANSPARENT_COPY = BIT ( 17 ) ,
CCR_BS = BIT ( 18 ) ,
CCR_SUPERVISOR = BIT ( 22 ) ,
CCR_PREFETCH = BIT ( 23 ) ,
CCR_TRIGGER_SRC = BIT ( 24 ) ,
CCR_BUFFERING_DISABLE = BIT ( 25 ) ,
CCR_WRITE_PRIORITY = BIT ( 26 ) ,
CCR_SYNC_ELEMENT = 0 ,
CCR_SYNC_FRAME = CCR_FS ,
CCR_SYNC_BLOCK = CCR_BS ,
CCR_SYNC_PACKET = CCR_BS | CCR_FS ,
CSDP_DATA_TYPE_8 = 0 ,
CSDP_DATA_TYPE_16 = 1 ,
CSDP_DATA_TYPE_32 = 2 ,
CSDP_SRC_PORT_EMIFF = 0 < < 2 , /* OMAP1 only */
CSDP_SRC_PORT_EMIFS = 1 < < 2 , /* OMAP1 only */
CSDP_SRC_PORT_OCP_T1 = 2 < < 2 , /* OMAP1 only */
CSDP_SRC_PORT_TIPB = 3 < < 2 , /* OMAP1 only */
CSDP_SRC_PORT_OCP_T2 = 4 < < 2 , /* OMAP1 only */
CSDP_SRC_PORT_MPUI = 5 < < 2 , /* OMAP1 only */
CSDP_SRC_PACKED = BIT ( 6 ) ,
CSDP_SRC_BURST_1 = 0 < < 7 ,
CSDP_SRC_BURST_16 = 1 < < 7 ,
CSDP_SRC_BURST_32 = 2 < < 7 ,
CSDP_SRC_BURST_64 = 3 < < 7 ,
CSDP_DST_PORT_EMIFF = 0 < < 9 , /* OMAP1 only */
CSDP_DST_PORT_EMIFS = 1 < < 9 , /* OMAP1 only */
CSDP_DST_PORT_OCP_T1 = 2 < < 9 , /* OMAP1 only */
CSDP_DST_PORT_TIPB = 3 < < 9 , /* OMAP1 only */
CSDP_DST_PORT_OCP_T2 = 4 < < 9 , /* OMAP1 only */
CSDP_DST_PORT_MPUI = 5 < < 9 , /* OMAP1 only */
CSDP_DST_PACKED = BIT ( 13 ) ,
CSDP_DST_BURST_1 = 0 < < 14 ,
CSDP_DST_BURST_16 = 1 < < 14 ,
CSDP_DST_BURST_32 = 2 < < 14 ,
CSDP_DST_BURST_64 = 3 < < 14 ,
CICR_TOUT_IE = BIT ( 0 ) , /* OMAP1 only */
CICR_DROP_IE = BIT ( 1 ) ,
CICR_HALF_IE = BIT ( 2 ) ,
CICR_FRAME_IE = BIT ( 3 ) ,
CICR_LAST_IE = BIT ( 4 ) ,
CICR_BLOCK_IE = BIT ( 5 ) ,
CICR_PKT_IE = BIT ( 7 ) , /* OMAP2+ only */
CICR_TRANS_ERR_IE = BIT ( 8 ) , /* OMAP2+ only */
CICR_SUPERVISOR_ERR_IE = BIT ( 10 ) , /* OMAP2+ only */
CICR_MISALIGNED_ERR_IE = BIT ( 11 ) , /* OMAP2+ only */
CICR_DRAIN_IE = BIT ( 12 ) , /* OMAP2+ only */
CICR_SUPER_BLOCK_IE = BIT ( 14 ) , /* OMAP2+ only */
CLNK_CTRL_ENABLE_LNK = BIT ( 15 ) ,
} ;
2012-04-13 15:10:24 +04:00
static const unsigned es_bytes [ ] = {
2013-11-02 23:57:06 +04:00
[ CSDP_DATA_TYPE_8 ] = 1 ,
[ CSDP_DATA_TYPE_16 ] = 2 ,
[ CSDP_DATA_TYPE_32 ] = 4 ,
2012-04-13 15:10:24 +04:00
} ;
2013-02-26 22:27:24 +04:00
static struct of_dma_filter_info omap_dma_info = {
. filter_fn = omap_dma_filter_fn ,
} ;
2012-04-13 15:10:24 +04:00
static inline struct omap_dmadev * to_omap_dma_dev ( struct dma_device * d )
{
return container_of ( d , struct omap_dmadev , ddev ) ;
}
static inline struct omap_chan * to_omap_dma_chan ( struct dma_chan * c )
{
return container_of ( c , struct omap_chan , vc . chan ) ;
}
static inline struct omap_desc * to_omap_dma_desc ( struct dma_async_tx_descriptor * t )
{
return container_of ( t , struct omap_desc , vd . tx ) ;
}
static void omap_dma_desc_free ( struct virt_dma_desc * vd )
{
kfree ( container_of ( vd , struct omap_desc , vd ) ) ;
}
2013-12-10 15:08:01 +04:00
static void omap_dma_write ( uint32_t val , unsigned type , void __iomem * addr )
{
switch ( type ) {
case OMAP_DMA_REG_16BIT :
writew_relaxed ( val , addr ) ;
break ;
case OMAP_DMA_REG_2X16BIT :
writew_relaxed ( val , addr ) ;
writew_relaxed ( val > > 16 , addr + 2 ) ;
break ;
case OMAP_DMA_REG_32BIT :
writel_relaxed ( val , addr ) ;
break ;
default :
WARN_ON ( 1 ) ;
}
}
static unsigned omap_dma_read ( unsigned type , void __iomem * addr )
{
unsigned val ;
switch ( type ) {
case OMAP_DMA_REG_16BIT :
val = readw_relaxed ( addr ) ;
break ;
case OMAP_DMA_REG_2X16BIT :
val = readw_relaxed ( addr ) ;
val | = readw_relaxed ( addr + 2 ) < < 16 ;
break ;
case OMAP_DMA_REG_32BIT :
val = readl_relaxed ( addr ) ;
break ;
default :
WARN_ON ( 1 ) ;
val = 0 ;
}
return val ;
}
2013-11-06 21:33:09 +04:00
static void omap_dma_glbl_write ( struct omap_dmadev * od , unsigned reg , unsigned val )
{
2013-12-10 15:08:01 +04:00
const struct omap_dma_reg * r = od - > reg_map + reg ;
WARN_ON ( r - > stride ) ;
omap_dma_write ( val , r - > type , od - > base + r - > offset ) ;
2013-11-06 21:33:09 +04:00
}
static unsigned omap_dma_glbl_read ( struct omap_dmadev * od , unsigned reg )
{
2013-12-10 15:08:01 +04:00
const struct omap_dma_reg * r = od - > reg_map + reg ;
WARN_ON ( r - > stride ) ;
return omap_dma_read ( r - > type , od - > base + r - > offset ) ;
2013-11-06 21:33:09 +04:00
}
static void omap_dma_chan_write ( struct omap_chan * c , unsigned reg , unsigned val )
{
2013-12-10 15:08:01 +04:00
const struct omap_dma_reg * r = c - > reg_map + reg ;
omap_dma_write ( val , r - > type , c - > channel_base + r - > offset ) ;
2013-11-06 21:33:09 +04:00
}
static unsigned omap_dma_chan_read ( struct omap_chan * c , unsigned reg )
{
2013-12-10 15:08:01 +04:00
const struct omap_dma_reg * r = c - > reg_map + reg ;
return omap_dma_read ( r - > type , c - > channel_base + r - > offset ) ;
2013-11-06 21:33:09 +04:00
}
2013-11-03 01:23:06 +04:00
static void omap_dma_clear_csr ( struct omap_chan * c )
{
if ( dma_omap1 ( ) )
2013-11-06 21:33:09 +04:00
omap_dma_chan_read ( c , CSR ) ;
2013-11-03 01:23:06 +04:00
else
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CSR , ~ 0 ) ;
2013-11-03 01:23:06 +04:00
}
2013-12-10 23:05:50 +04:00
static unsigned omap_dma_get_csr ( struct omap_chan * c )
{
unsigned val = omap_dma_chan_read ( c , CSR ) ;
if ( ! dma_omap1 ( ) )
omap_dma_chan_write ( c , CSR , val ) ;
return val ;
}
2013-12-10 15:08:01 +04:00
static void omap_dma_assign ( struct omap_dmadev * od , struct omap_chan * c ,
unsigned lch )
{
c - > channel_base = od - > base + od - > plat - > channel_stride * lch ;
2013-12-10 23:05:50 +04:00
od - > lch_map [ lch ] = c ;
2013-12-10 15:08:01 +04:00
}
2013-11-02 21:07:09 +04:00
static void omap_dma_start ( struct omap_chan * c , struct omap_desc * d )
{
struct omap_dmadev * od = to_omap_dma_dev ( c - > vc . chan . device ) ;
if ( __dma_omap15xx ( od - > plat - > dma_attr ) )
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CPC , 0 ) ;
2013-11-02 21:07:09 +04:00
else
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CDAC , 0 ) ;
2013-11-02 21:07:09 +04:00
2013-11-03 01:23:06 +04:00
omap_dma_clear_csr ( c ) ;
2013-11-02 21:07:09 +04:00
/* Enable interrupts */
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CICR , d - > cicr ) ;
2013-11-02 21:07:09 +04:00
2013-11-06 21:18:42 +04:00
/* Enable channel */
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CCR , d - > ccr | CCR_ENABLE ) ;
2016-04-05 15:20:20 +03:00
c - > running = true ;
2013-11-02 21:07:09 +04:00
}
static void omap_dma_stop ( struct omap_chan * c )
{
struct omap_dmadev * od = to_omap_dma_dev ( c - > vc . chan . device ) ;
uint32_t val ;
/* disable irq */
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CICR , 0 ) ;
2013-11-02 21:07:09 +04:00
2013-11-03 01:23:06 +04:00
omap_dma_clear_csr ( c ) ;
2013-11-02 21:07:09 +04:00
2013-11-06 21:33:09 +04:00
val = omap_dma_chan_read ( c , CCR ) ;
2013-11-02 23:57:06 +04:00
if ( od - > plat - > errata & DMA_ERRATA_i541 & & val & CCR_TRIGGER_SRC ) {
2013-11-02 21:07:09 +04:00
uint32_t sysconfig ;
unsigned i ;
2013-11-06 21:33:09 +04:00
sysconfig = omap_dma_glbl_read ( od , OCP_SYSCONFIG ) ;
2013-11-02 21:07:09 +04:00
val = sysconfig & ~ DMA_SYSCONFIG_MIDLEMODE_MASK ;
val | = DMA_SYSCONFIG_MIDLEMODE ( DMA_IDLEMODE_NO_IDLE ) ;
2013-11-06 21:33:09 +04:00
omap_dma_glbl_write ( od , OCP_SYSCONFIG , val ) ;
2013-11-02 21:07:09 +04:00
2013-11-06 21:33:09 +04:00
val = omap_dma_chan_read ( c , CCR ) ;
2013-11-02 23:57:06 +04:00
val & = ~ CCR_ENABLE ;
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CCR , val ) ;
2013-11-02 21:07:09 +04:00
/* Wait for sDMA FIFO to drain */
for ( i = 0 ; ; i + + ) {
2013-11-06 21:33:09 +04:00
val = omap_dma_chan_read ( c , CCR ) ;
2013-11-02 23:57:06 +04:00
if ( ! ( val & ( CCR_RD_ACTIVE | CCR_WR_ACTIVE ) ) )
2013-11-02 21:07:09 +04:00
break ;
if ( i > 100 )
break ;
udelay ( 5 ) ;
}
2013-11-02 23:57:06 +04:00
if ( val & ( CCR_RD_ACTIVE | CCR_WR_ACTIVE ) )
2013-11-02 21:07:09 +04:00
dev_err ( c - > vc . chan . device - > dev ,
" DMA drain did not complete on lch %d \n " ,
c - > dma_ch ) ;
2013-11-06 21:33:09 +04:00
omap_dma_glbl_write ( od , OCP_SYSCONFIG , sysconfig ) ;
2013-11-02 21:07:09 +04:00
} else {
2013-11-02 23:57:06 +04:00
val & = ~ CCR_ENABLE ;
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CCR , val ) ;
2013-11-02 21:07:09 +04:00
}
mb ( ) ;
if ( ! __dma_omap15xx ( od - > plat - > dma_attr ) & & c - > cyclic ) {
2013-11-06 21:33:09 +04:00
val = omap_dma_chan_read ( c , CLNK_CTRL ) ;
2013-11-02 21:07:09 +04:00
if ( dma_omap1 ( ) )
val | = 1 < < 14 ; /* set the STOP_LNK bit */
else
2013-11-02 23:57:06 +04:00
val & = ~ CLNK_CTRL_ENABLE_LNK ;
2013-11-02 21:07:09 +04:00
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CLNK_CTRL , val ) ;
2013-11-02 21:07:09 +04:00
}
2016-04-05 15:20:20 +03:00
c - > running = false ;
2013-11-02 21:07:09 +04:00
}
2012-04-13 15:10:24 +04:00
static void omap_dma_start_sg ( struct omap_chan * c , struct omap_desc * d ,
unsigned idx )
{
struct omap_sg * sg = d - > sg + idx ;
2013-11-03 15:17:11 +04:00
unsigned cxsa , cxei , cxfi ;
2013-11-02 18:41:42 +04:00
2015-04-22 10:34:29 +03:00
if ( d - > dir = = DMA_DEV_TO_MEM | | d - > dir = = DMA_MEM_TO_MEM ) {
2013-11-03 15:17:11 +04:00
cxsa = CDSA ;
cxei = CDEI ;
cxfi = CDFI ;
2013-11-02 18:41:42 +04:00
} else {
2013-11-03 15:17:11 +04:00
cxsa = CSSA ;
cxei = CSEI ;
cxfi = CSFI ;
2013-11-02 18:41:42 +04:00
}
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , cxsa , sg - > addr ) ;
omap_dma_chan_write ( c , cxei , 0 ) ;
omap_dma_chan_write ( c , cxfi , 0 ) ;
omap_dma_chan_write ( c , CEN , sg - > en ) ;
omap_dma_chan_write ( c , CFN , sg - > fn ) ;
2013-11-02 18:41:42 +04:00
2013-11-02 21:07:09 +04:00
omap_dma_start ( c , d ) ;
2013-11-02 18:41:42 +04:00
}
static void omap_dma_start_desc ( struct omap_chan * c )
{
struct virt_dma_desc * vd = vchan_next_desc ( & c - > vc ) ;
struct omap_desc * d ;
2013-11-03 15:17:11 +04:00
unsigned cxsa , cxei , cxfi ;
2013-11-02 17:26:57 +04:00
2013-11-02 18:41:42 +04:00
if ( ! vd ) {
c - > desc = NULL ;
return ;
}
list_del ( & vd - > node ) ;
c - > desc = d = to_omap_dma_desc ( & vd - > tx ) ;
c - > sgidx = 0 ;
2013-11-06 21:15:16 +04:00
/*
* This provides the necessary barrier to ensure data held in
* DMA coherent memory is visible to the DMA engine prior to
* the transfer starting .
*/
mb ( ) ;
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CCR , d - > ccr ) ;
2013-11-02 23:16:09 +04:00
if ( dma_omap1 ( ) )
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , CCR2 , d - > ccr > > 16 ) ;
2013-11-02 17:26:57 +04:00
2015-04-22 10:34:29 +03:00
if ( d - > dir = = DMA_DEV_TO_MEM | | d - > dir = = DMA_MEM_TO_MEM ) {
2013-11-03 15:17:11 +04:00
cxsa = CSSA ;
cxei = CSEI ;
cxfi = CSFI ;
2013-11-02 17:26:57 +04:00
} else {
2013-11-03 15:17:11 +04:00
cxsa = CDSA ;
cxei = CDEI ;
cxfi = CDFI ;
2013-11-02 17:26:57 +04:00
}
2013-11-06 21:33:09 +04:00
omap_dma_chan_write ( c , cxsa , d - > dev_addr ) ;
omap_dma_chan_write ( c , cxei , 0 ) ;
omap_dma_chan_write ( c , cxfi , d - > fi ) ;
omap_dma_chan_write ( c , CSDP , d - > csdp ) ;
omap_dma_chan_write ( c , CLNK_CTRL , d - > clnk_ctrl ) ;
2013-11-02 17:26:57 +04:00
2012-04-13 15:10:24 +04:00
omap_dma_start_sg ( c , d , 0 ) ;
}
static void omap_dma_callback ( int ch , u16 status , void * data )
{
struct omap_chan * c = data ;
struct omap_desc * d ;
unsigned long flags ;
spin_lock_irqsave ( & c - > vc . lock , flags ) ;
d = c - > desc ;
if ( d ) {
2012-06-21 13:40:15 +04:00
if ( ! c - > cyclic ) {
if ( + + c - > sgidx < d - > sglen ) {
omap_dma_start_sg ( c , d , c - > sgidx ) ;
} else {
omap_dma_start_desc ( c ) ;
vchan_cookie_complete ( & d - > vd ) ;
}
2012-04-13 15:10:24 +04:00
} else {
2012-06-21 13:40:15 +04:00
vchan_cyclic_callback ( & d - > vd ) ;
2012-04-13 15:10:24 +04:00
}
}
spin_unlock_irqrestore ( & c - > vc . lock , flags ) ;
}
2013-12-10 23:05:50 +04:00
static irqreturn_t omap_dma_irq ( int irq , void * devid )
{
struct omap_dmadev * od = devid ;
unsigned status , channel ;
spin_lock ( & od - > irq_lock ) ;
status = omap_dma_glbl_read ( od , IRQSTATUS_L1 ) ;
status & = od - > irq_enable_mask ;
if ( status = = 0 ) {
spin_unlock ( & od - > irq_lock ) ;
return IRQ_NONE ;
}
while ( ( channel = ffs ( status ) ) ! = 0 ) {
unsigned mask , csr ;
struct omap_chan * c ;
channel - = 1 ;
mask = BIT ( channel ) ;
status & = ~ mask ;
c = od - > lch_map [ channel ] ;
if ( c = = NULL ) {
/* This should never happen */
dev_err ( od - > ddev . dev , " invalid channel %u \n " , channel ) ;
continue ;
}
csr = omap_dma_get_csr ( c ) ;
omap_dma_glbl_write ( od , IRQSTATUS_L1 , mask ) ;
omap_dma_callback ( channel , csr , c ) ;
}
spin_unlock ( & od - > irq_lock ) ;
return IRQ_HANDLED ;
}
2012-04-13 15:10:24 +04:00
static int omap_dma_alloc_chan_resources ( struct dma_chan * chan )
{
2013-12-10 15:08:01 +04:00
struct omap_dmadev * od = to_omap_dma_dev ( chan - > device ) ;
2012-04-13 15:10:24 +04:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
2013-12-10 15:08:01 +04:00
int ret ;
2013-12-10 23:05:50 +04:00
if ( od - > legacy ) {
ret = omap_request_dma ( c - > dma_sig , " DMA engine " ,
omap_dma_callback , c , & c - > dma_ch ) ;
} else {
ret = omap_request_dma ( c - > dma_sig , " DMA engine " , NULL , NULL ,
& c - > dma_ch ) ;
}
2012-04-13 15:10:24 +04:00
2013-12-10 23:05:50 +04:00
dev_dbg ( od - > ddev . dev , " allocating channel %u for %u \n " ,
c - > dma_ch , c - > dma_sig ) ;
2012-04-13 15:10:24 +04:00
2013-12-10 23:05:50 +04:00
if ( ret > = 0 ) {
2013-12-10 15:08:01 +04:00
omap_dma_assign ( od , c , c - > dma_ch ) ;
2013-12-10 23:05:50 +04:00
if ( ! od - > legacy ) {
unsigned val ;
spin_lock_irq ( & od - > irq_lock ) ;
val = BIT ( c - > dma_ch ) ;
omap_dma_glbl_write ( od , IRQSTATUS_L1 , val ) ;
od - > irq_enable_mask | = val ;
omap_dma_glbl_write ( od , IRQENABLE_L1 , od - > irq_enable_mask ) ;
val = omap_dma_glbl_read ( od , IRQENABLE_L0 ) ;
val & = ~ BIT ( c - > dma_ch ) ;
omap_dma_glbl_write ( od , IRQENABLE_L0 , val ) ;
spin_unlock_irq ( & od - > irq_lock ) ;
}
}
2014-01-15 03:58:10 +04:00
if ( dma_omap1 ( ) ) {
if ( __dma_omap16xx ( od - > plat - > dma_attr ) ) {
c - > ccr = CCR_OMAP31_DISABLE ;
/* Duplicate what plat-omap/dma.c does */
c - > ccr | = c - > dma_ch + 1 ;
} else {
c - > ccr = c - > dma_sig & 0x1f ;
}
} else {
c - > ccr = c - > dma_sig & 0x1f ;
c - > ccr | = ( c - > dma_sig & ~ 0x1f ) < < 14 ;
}
if ( od - > plat - > errata & DMA_ERRATA_IFRAME_BUFFERING )
c - > ccr | = CCR_BUFFERING_DISABLE ;
2013-12-10 15:08:01 +04:00
return ret ;
2012-04-13 15:10:24 +04:00
}
static void omap_dma_free_chan_resources ( struct dma_chan * chan )
{
2013-12-10 23:05:50 +04:00
struct omap_dmadev * od = to_omap_dma_dev ( chan - > device ) ;
2012-04-13 15:10:24 +04:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
2013-12-10 23:05:50 +04:00
if ( ! od - > legacy ) {
spin_lock_irq ( & od - > irq_lock ) ;
od - > irq_enable_mask & = ~ BIT ( c - > dma_ch ) ;
omap_dma_glbl_write ( od , IRQENABLE_L1 , od - > irq_enable_mask ) ;
spin_unlock_irq ( & od - > irq_lock ) ;
}
2013-12-10 15:08:01 +04:00
c - > channel_base = NULL ;
2013-12-10 23:05:50 +04:00
od - > lch_map [ c - > dma_ch ] = NULL ;
2012-04-13 15:10:24 +04:00
vchan_free_chan_resources ( & c - > vc ) ;
omap_free_dma ( c - > dma_ch ) ;
2013-12-10 23:05:50 +04:00
dev_dbg ( od - > ddev . dev , " freeing channel for %u \n " , c - > dma_sig ) ;
2015-04-09 12:35:52 +03:00
c - > dma_sig = 0 ;
2012-04-13 15:10:24 +04:00
}
2012-06-21 13:37:35 +04:00
static size_t omap_dma_sg_size ( struct omap_sg * sg )
{
return sg - > en * sg - > fn ;
}
static size_t omap_dma_desc_size ( struct omap_desc * d )
{
unsigned i ;
size_t size ;
for ( size = i = 0 ; i < d - > sglen ; i + + )
size + = omap_dma_sg_size ( & d - > sg [ i ] ) ;
return size * es_bytes [ d - > es ] ;
}
static size_t omap_dma_desc_size_pos ( struct omap_desc * d , dma_addr_t addr )
{
unsigned i ;
size_t size , es_size = es_bytes [ d - > es ] ;
for ( size = i = 0 ; i < d - > sglen ; i + + ) {
size_t this_size = omap_dma_sg_size ( & d - > sg [ i ] ) * es_size ;
if ( size )
size + = this_size ;
else if ( addr > = d - > sg [ i ] . addr & &
addr < d - > sg [ i ] . addr + this_size )
size + = d - > sg [ i ] . addr + this_size - addr ;
}
return size ;
}
2013-11-06 23:26:45 +04:00
/*
* OMAP 3.2 / 3.3 erratum : sometimes 0 is returned if CSAC / CDAC is
* read before the DMA controller finished disabling the channel .
*/
static uint32_t omap_dma_chan_read_3_3 ( struct omap_chan * c , unsigned reg )
{
struct omap_dmadev * od = to_omap_dma_dev ( c - > vc . chan . device ) ;
uint32_t val ;
val = omap_dma_chan_read ( c , reg ) ;
if ( val = = 0 & & od - > plat - > errata & DMA_ERRATA_3_3 )
val = omap_dma_chan_read ( c , reg ) ;
return val ;
}
2013-11-02 22:04:17 +04:00
static dma_addr_t omap_dma_get_src_pos ( struct omap_chan * c )
{
struct omap_dmadev * od = to_omap_dma_dev ( c - > vc . chan . device ) ;
2013-11-06 23:26:45 +04:00
dma_addr_t addr , cdac ;
2013-11-02 22:04:17 +04:00
2013-11-06 23:26:45 +04:00
if ( __dma_omap15xx ( od - > plat - > dma_attr ) ) {
2013-11-06 21:33:09 +04:00
addr = omap_dma_chan_read ( c , CPC ) ;
2013-11-06 23:26:45 +04:00
} else {
addr = omap_dma_chan_read_3_3 ( c , CSAC ) ;
cdac = omap_dma_chan_read_3_3 ( c , CDAC ) ;
2013-11-02 22:04:17 +04:00
/*
* CDAC = = 0 indicates that the DMA transfer on the channel has
* not been started ( no data has been transferred so far ) .
* Return the programmed source start address in this case .
*/
2013-11-06 23:26:45 +04:00
if ( cdac = = 0 )
2013-11-06 21:33:09 +04:00
addr = omap_dma_chan_read ( c , CSSA ) ;
2013-11-02 22:04:17 +04:00
}
if ( dma_omap1 ( ) )
2013-11-06 21:33:09 +04:00
addr | = omap_dma_chan_read ( c , CSSA ) & 0xffff0000 ;
2013-11-02 22:04:17 +04:00
return addr ;
}
static dma_addr_t omap_dma_get_dst_pos ( struct omap_chan * c )
{
struct omap_dmadev * od = to_omap_dma_dev ( c - > vc . chan . device ) ;
dma_addr_t addr ;
2013-11-06 23:26:45 +04:00
if ( __dma_omap15xx ( od - > plat - > dma_attr ) ) {
2013-11-06 21:33:09 +04:00
addr = omap_dma_chan_read ( c , CPC ) ;
2013-11-06 23:26:45 +04:00
} else {
addr = omap_dma_chan_read_3_3 ( c , CDAC ) ;
2013-11-02 22:04:17 +04:00
/*
2013-11-06 23:26:45 +04:00
* CDAC = = 0 indicates that the DMA transfer on the channel
* has not been started ( no data has been transferred so
* far ) . Return the programmed destination start address in
* this case .
2013-11-02 22:04:17 +04:00
*/
if ( addr = = 0 )
2013-11-06 21:33:09 +04:00
addr = omap_dma_chan_read ( c , CDSA ) ;
2013-11-02 22:04:17 +04:00
}
if ( dma_omap1 ( ) )
2013-11-06 21:33:09 +04:00
addr | = omap_dma_chan_read ( c , CDSA ) & 0xffff0000 ;
2013-11-02 22:04:17 +04:00
return addr ;
}
2012-04-13 15:10:24 +04:00
static enum dma_status omap_dma_tx_status ( struct dma_chan * chan ,
dma_cookie_t cookie , struct dma_tx_state * txstate )
{
2012-06-21 13:37:35 +04:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
struct virt_dma_desc * vd ;
enum dma_status ret ;
unsigned long flags ;
ret = dma_cookie_status ( chan , cookie , txstate ) ;
2016-04-05 15:20:20 +03:00
if ( ! c - > paused & & c - > running ) {
uint32_t ccr = omap_dma_chan_read ( c , CCR ) ;
/*
* The channel is no longer active , set the return value
* accordingly
*/
if ( ! ( ccr & CCR_ENABLE ) )
ret = DMA_COMPLETE ;
}
2013-10-16 19:21:54 +04:00
if ( ret = = DMA_COMPLETE | | ! txstate )
2012-06-21 13:37:35 +04:00
return ret ;
spin_lock_irqsave ( & c - > vc . lock , flags ) ;
vd = vchan_find_desc ( & c - > vc , cookie ) ;
if ( vd ) {
txstate - > residue = omap_dma_desc_size ( to_omap_dma_desc ( & vd - > tx ) ) ;
} else if ( c - > desc & & c - > desc - > vd . tx . cookie = = cookie ) {
struct omap_desc * d = c - > desc ;
dma_addr_t pos ;
if ( d - > dir = = DMA_MEM_TO_DEV )
2013-11-02 22:04:17 +04:00
pos = omap_dma_get_src_pos ( c ) ;
2015-11-11 13:37:55 +03:00
else if ( d - > dir = = DMA_DEV_TO_MEM | | d - > dir = = DMA_MEM_TO_MEM )
2013-11-02 22:04:17 +04:00
pos = omap_dma_get_dst_pos ( c ) ;
2012-06-21 13:37:35 +04:00
else
pos = 0 ;
txstate - > residue = omap_dma_desc_size_pos ( d , pos ) ;
} else {
txstate - > residue = 0 ;
}
spin_unlock_irqrestore ( & c - > vc . lock , flags ) ;
return ret ;
2012-04-13 15:10:24 +04:00
}
static void omap_dma_issue_pending ( struct dma_chan * chan )
{
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
unsigned long flags ;
spin_lock_irqsave ( & c - > vc . lock , flags ) ;
dmaengine: omap-dma: Remove tasklet to start the transfers
The use of tasklet to actually start the DMA transfer slightly decreases the
DMA throughput since it adds small scheduling delay when the transfer is
started. In normal use, even with high I/O load the tasklet would start
one transaction at a time, however running the DMAtest for memcpy on all
available channels will cause the tasklet to start about 15 transfers.
The performance numbers on OMAP4 PandaBoard-es (test_buf_size = 6553):
With the tasklet:
dmatest: dma0chan30-copy: summary 5000 tests, 0 failures 186 iops 593 KB/s (0)
dmatest: dma0chan8-copy0: summary 5000 tests, 0 failures 184 iops 584 KB/s (0)
dmatest: dma0chan13-copy: summary 5000 tests, 0 failures 184 iops 585 KB/s (0)
dmatest: dma0chan12-copy: summary 5000 tests, 0 failures 184 iops 585 KB/s (0)
dmatest: dma0chan7-copy0: summary 5000 tests, 0 failures 183 iops 581 KB/s (0)
With this patch (no tasklet):
dmatest: dma0chan4-copy0: summary 5000 tests, 0 failures 199 iops 644 KB/s (0)
dmatest: dma0chan5-copy0: summary 5000 tests, 0 failures 199 iops 645 KB/s (0)
dmatest: dma0chan6-copy0: summary 5000 tests, 0 failures 199 iops 637 KB/s (0)
dmatest: dma0chan24-copy: summary 5000 tests, 0 failures 199 iops 638 KB/s (0)
dmatest: dma0chan16-copy: summary 5000 tests, 0 failures 199 iops 638 KB/s (0)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2015-11-11 13:37:57 +03:00
if ( vchan_issue_pending ( & c - > vc ) & & ! c - > desc )
omap_dma_start_desc ( c ) ;
2012-04-13 15:10:24 +04:00
spin_unlock_irqrestore ( & c - > vc . lock , flags ) ;
}
static struct dma_async_tx_descriptor * omap_dma_prep_slave_sg (
struct dma_chan * chan , struct scatterlist * sgl , unsigned sglen ,
enum dma_transfer_direction dir , unsigned long tx_flags , void * context )
{
2013-11-03 01:09:18 +04:00
struct omap_dmadev * od = to_omap_dma_dev ( chan - > device ) ;
2012-04-13 15:10:24 +04:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
enum dma_slave_buswidth dev_width ;
struct scatterlist * sgent ;
struct omap_desc * d ;
dma_addr_t dev_addr ;
2015-11-11 13:37:56 +03:00
unsigned i , es , en , frame_bytes ;
2012-04-13 15:10:24 +04:00
u32 burst ;
if ( dir = = DMA_DEV_TO_MEM ) {
dev_addr = c - > cfg . src_addr ;
dev_width = c - > cfg . src_addr_width ;
burst = c - > cfg . src_maxburst ;
} else if ( dir = = DMA_MEM_TO_DEV ) {
dev_addr = c - > cfg . dst_addr ;
dev_width = c - > cfg . dst_addr_width ;
burst = c - > cfg . dst_maxburst ;
} else {
dev_err ( chan - > device - > dev , " %s: bad direction? \n " , __func__ ) ;
return NULL ;
}
/* Bus width translates to the element size (ES) */
switch ( dev_width ) {
case DMA_SLAVE_BUSWIDTH_1_BYTE :
2013-11-02 23:57:06 +04:00
es = CSDP_DATA_TYPE_8 ;
2012-04-13 15:10:24 +04:00
break ;
case DMA_SLAVE_BUSWIDTH_2_BYTES :
2013-11-02 23:57:06 +04:00
es = CSDP_DATA_TYPE_16 ;
2012-04-13 15:10:24 +04:00
break ;
case DMA_SLAVE_BUSWIDTH_4_BYTES :
2013-11-02 23:57:06 +04:00
es = CSDP_DATA_TYPE_32 ;
2012-04-13 15:10:24 +04:00
break ;
default : /* not reached */
return NULL ;
}
/* Now allocate and setup the descriptor. */
d = kzalloc ( sizeof ( * d ) + sglen * sizeof ( d - > sg [ 0 ] ) , GFP_ATOMIC ) ;
if ( ! d )
return NULL ;
d - > dir = dir ;
d - > dev_addr = dev_addr ;
d - > es = es ;
2013-11-02 23:16:09 +04:00
2014-01-15 03:58:10 +04:00
d - > ccr = c - > ccr | CCR_SYNC_FRAME ;
2013-11-02 23:16:09 +04:00
if ( dir = = DMA_DEV_TO_MEM )
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_DST_AMODE_POSTINC | CCR_SRC_AMODE_CONSTANT ;
2013-11-02 23:16:09 +04:00
else
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_DST_AMODE_CONSTANT | CCR_SRC_AMODE_POSTINC ;
2013-11-02 23:16:09 +04:00
2013-11-02 23:57:06 +04:00
d - > cicr = CICR_DROP_IE | CICR_BLOCK_IE ;
2013-11-02 22:51:53 +04:00
d - > csdp = es ;
2013-11-02 21:07:09 +04:00
2013-11-02 22:51:53 +04:00
if ( dma_omap1 ( ) ) {
2013-11-02 23:57:06 +04:00
d - > cicr | = CICR_TOUT_IE ;
2013-11-02 22:51:53 +04:00
if ( dir = = DMA_DEV_TO_MEM )
2013-11-02 23:57:06 +04:00
d - > csdp | = CSDP_DST_PORT_EMIFF | CSDP_SRC_PORT_TIPB ;
2013-11-02 22:51:53 +04:00
else
2013-11-02 23:57:06 +04:00
d - > csdp | = CSDP_DST_PORT_TIPB | CSDP_SRC_PORT_EMIFF ;
2013-11-02 22:51:53 +04:00
} else {
2013-11-02 23:16:09 +04:00
if ( dir = = DMA_DEV_TO_MEM )
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_TRIGGER_SRC ;
2013-11-02 23:16:09 +04:00
2013-11-02 23:57:06 +04:00
d - > cicr | = CICR_MISALIGNED_ERR_IE | CICR_TRANS_ERR_IE ;
2013-11-02 22:51:53 +04:00
}
2013-11-06 21:12:30 +04:00
if ( od - > plat - > errata & DMA_ERRATA_PARALLEL_CHANNELS )
d - > clnk_ctrl = c - > dma_ch ;
2012-04-13 15:10:24 +04:00
/*
* Build our scatterlist entries : each contains the address ,
* the number of elements ( EN ) in each frame , and the number of
* frames ( FN ) . Number of bytes for this entry = ES * EN * FN .
*
* Burst size translates to number of elements with frame sync .
* Note : DMA engine defines burst to be the number of dev - width
* transfers .
*/
en = burst ;
frame_bytes = es_bytes [ es ] * en ;
for_each_sg ( sgl , sgent , sglen , i ) {
2015-11-11 13:37:56 +03:00
d - > sg [ i ] . addr = sg_dma_address ( sgent ) ;
d - > sg [ i ] . en = en ;
d - > sg [ i ] . fn = sg_dma_len ( sgent ) / frame_bytes ;
2012-04-13 15:10:24 +04:00
}
2015-11-11 13:37:56 +03:00
d - > sglen = sglen ;
2012-04-13 15:10:24 +04:00
return vchan_tx_prep ( & c - > vc , & d - > vd , tx_flags ) ;
}
2012-06-21 13:40:15 +04:00
static struct dma_async_tx_descriptor * omap_dma_prep_dma_cyclic (
struct dma_chan * chan , dma_addr_t buf_addr , size_t buf_len ,
2014-08-01 14:20:10 +04:00
size_t period_len , enum dma_transfer_direction dir , unsigned long flags )
2012-06-21 13:40:15 +04:00
{
2013-11-02 21:07:09 +04:00
struct omap_dmadev * od = to_omap_dma_dev ( chan - > device ) ;
2012-06-21 13:40:15 +04:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
enum dma_slave_buswidth dev_width ;
struct omap_desc * d ;
dma_addr_t dev_addr ;
2013-11-02 23:16:09 +04:00
unsigned es ;
2012-06-21 13:40:15 +04:00
u32 burst ;
if ( dir = = DMA_DEV_TO_MEM ) {
dev_addr = c - > cfg . src_addr ;
dev_width = c - > cfg . src_addr_width ;
burst = c - > cfg . src_maxburst ;
} else if ( dir = = DMA_MEM_TO_DEV ) {
dev_addr = c - > cfg . dst_addr ;
dev_width = c - > cfg . dst_addr_width ;
burst = c - > cfg . dst_maxburst ;
} else {
dev_err ( chan - > device - > dev , " %s: bad direction? \n " , __func__ ) ;
return NULL ;
}
/* Bus width translates to the element size (ES) */
switch ( dev_width ) {
case DMA_SLAVE_BUSWIDTH_1_BYTE :
2013-11-02 23:57:06 +04:00
es = CSDP_DATA_TYPE_8 ;
2012-06-21 13:40:15 +04:00
break ;
case DMA_SLAVE_BUSWIDTH_2_BYTES :
2013-11-02 23:57:06 +04:00
es = CSDP_DATA_TYPE_16 ;
2012-06-21 13:40:15 +04:00
break ;
case DMA_SLAVE_BUSWIDTH_4_BYTES :
2013-11-02 23:57:06 +04:00
es = CSDP_DATA_TYPE_32 ;
2012-06-21 13:40:15 +04:00
break ;
default : /* not reached */
return NULL ;
}
/* Now allocate and setup the descriptor. */
d = kzalloc ( sizeof ( * d ) + sizeof ( d - > sg [ 0 ] ) , GFP_ATOMIC ) ;
if ( ! d )
return NULL ;
d - > dir = dir ;
d - > dev_addr = dev_addr ;
d - > fi = burst ;
d - > es = es ;
d - > sg [ 0 ] . addr = buf_addr ;
d - > sg [ 0 ] . en = period_len / es_bytes [ es ] ;
d - > sg [ 0 ] . fn = buf_len / period_len ;
d - > sglen = 1 ;
2013-11-02 23:16:09 +04:00
2014-01-15 03:58:10 +04:00
d - > ccr = c - > ccr ;
2013-11-02 23:16:09 +04:00
if ( dir = = DMA_DEV_TO_MEM )
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_DST_AMODE_POSTINC | CCR_SRC_AMODE_CONSTANT ;
2013-11-02 23:16:09 +04:00
else
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_DST_AMODE_CONSTANT | CCR_SRC_AMODE_POSTINC ;
2013-11-02 23:16:09 +04:00
2013-11-02 23:57:06 +04:00
d - > cicr = CICR_DROP_IE ;
2013-11-02 21:07:09 +04:00
if ( flags & DMA_PREP_INTERRUPT )
2013-11-02 23:57:06 +04:00
d - > cicr | = CICR_FRAME_IE ;
2013-11-02 21:07:09 +04:00
2013-11-02 22:51:53 +04:00
d - > csdp = es ;
if ( dma_omap1 ( ) ) {
2013-11-02 23:57:06 +04:00
d - > cicr | = CICR_TOUT_IE ;
2013-11-02 22:51:53 +04:00
if ( dir = = DMA_DEV_TO_MEM )
2013-11-02 23:57:06 +04:00
d - > csdp | = CSDP_DST_PORT_EMIFF | CSDP_SRC_PORT_MPUI ;
2013-11-02 22:51:53 +04:00
else
2013-11-02 23:57:06 +04:00
d - > csdp | = CSDP_DST_PORT_MPUI | CSDP_SRC_PORT_EMIFF ;
2013-11-02 22:51:53 +04:00
} else {
2013-11-02 23:16:09 +04:00
if ( burst )
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_SYNC_PACKET ;
else
d - > ccr | = CCR_SYNC_ELEMENT ;
2013-11-02 23:16:09 +04:00
dmaengine: omap-dma: Enable packed accesses for cyclic transfers
The L3 throughput can be higher than expected when packed access
is not enabled. The ratio depends on the number of bytes in a
transaction and the EMIF interface width.
The throughput was measured for the following settings/cases:
* Case 1: Burst size of 64 bytes, packed access disabled
* Case 2: Burst size of 64 bytes, packed access enabled
* Case 3: Burst disabled, packed access disabled
Throughput measurements were done during McASP-based audio
playback on the Jacinto6 EVM using the omapconf tool [1]:
$ omapconf trace bw -m sdma_rd
---------------------------------------------------------
Throughput (MB/s)
Audio parameters Case 1 Case 2 Case 3
---------------------------------------------------------
44.1kHz, 16-bits, stereo 1.41 0.18 1.41
44.1kHz, 32-bits, stereo 1.41 0.35 1.41
44.1kHz, 16-bits, 4-chan 2.82 0.35 2.82
44.1kHz, 16-bits, 6-chan 4.23 0.53 4.23
44.1kHz, 16-bits, 8-chan 5.64 0.71 5.64
---------------------------------------------------------
From above measurements, case 2 is the only one that delivers
the expected throughput for the given audio parameters. For
that reason, the packed accesses are now enabled.
It's worth to mention that packed accesses cannot be enabled
for all addressing modes. In cyclic transfers, it can be
enabled in the source for MEM_TO_DEV and in dest for DEV_TO_MEM,
as they use post-increment mode which supports packed accesses.
Peter Ujfalusi:
From the TRM regarding to this:
"NOTE: Except in the constant addressing mode, the source or
destination must be specified as packed for burst transactions
to occur."
So w/o the packed setting the burst on the MEM side was not
enabled, this explains the numbers.
[1] https://github.com/omapconf/omapconf
Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2015-09-14 15:31:05 +03:00
if ( dir = = DMA_DEV_TO_MEM ) {
2013-11-02 23:57:06 +04:00
d - > ccr | = CCR_TRIGGER_SRC ;
dmaengine: omap-dma: Enable packed accesses for cyclic transfers
The L3 throughput can be higher than expected when packed access
is not enabled. The ratio depends on the number of bytes in a
transaction and the EMIF interface width.
The throughput was measured for the following settings/cases:
* Case 1: Burst size of 64 bytes, packed access disabled
* Case 2: Burst size of 64 bytes, packed access enabled
* Case 3: Burst disabled, packed access disabled
Throughput measurements were done during McASP-based audio
playback on the Jacinto6 EVM using the omapconf tool [1]:
$ omapconf trace bw -m sdma_rd
---------------------------------------------------------
Throughput (MB/s)
Audio parameters Case 1 Case 2 Case 3
---------------------------------------------------------
44.1kHz, 16-bits, stereo 1.41 0.18 1.41
44.1kHz, 32-bits, stereo 1.41 0.35 1.41
44.1kHz, 16-bits, 4-chan 2.82 0.35 2.82
44.1kHz, 16-bits, 6-chan 4.23 0.53 4.23
44.1kHz, 16-bits, 8-chan 5.64 0.71 5.64
---------------------------------------------------------
From above measurements, case 2 is the only one that delivers
the expected throughput for the given audio parameters. For
that reason, the packed accesses are now enabled.
It's worth to mention that packed accesses cannot be enabled
for all addressing modes. In cyclic transfers, it can be
enabled in the source for MEM_TO_DEV and in dest for DEV_TO_MEM,
as they use post-increment mode which supports packed accesses.
Peter Ujfalusi:
From the TRM regarding to this:
"NOTE: Except in the constant addressing mode, the source or
destination must be specified as packed for burst transactions
to occur."
So w/o the packed setting the burst on the MEM side was not
enabled, this explains the numbers.
[1] https://github.com/omapconf/omapconf
Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2015-09-14 15:31:05 +03:00
d - > csdp | = CSDP_DST_PACKED ;
} else {
d - > csdp | = CSDP_SRC_PACKED ;
}
2013-11-02 23:16:09 +04:00
2013-11-02 23:57:06 +04:00
d - > cicr | = CICR_MISALIGNED_ERR_IE | CICR_TRANS_ERR_IE ;
2012-06-21 13:40:15 +04:00
2013-11-02 23:57:06 +04:00
d - > csdp | = CSDP_DST_BURST_64 | CSDP_SRC_BURST_64 ;
2013-11-02 22:51:53 +04:00
}
2013-11-06 21:12:30 +04:00
if ( __dma_omap15xx ( od - > plat - > dma_attr ) )
d - > ccr | = CCR_AUTO_INIT | CCR_REPEAT ;
else
d - > clnk_ctrl = c - > dma_ch | CLNK_CTRL_ENABLE_LNK ;
2013-11-02 23:16:09 +04:00
c - > cyclic = true ;
2012-06-21 13:40:15 +04:00
2012-09-14 16:05:48 +04:00
return vchan_tx_prep ( & c - > vc , & d - > vd , flags ) ;
2012-06-21 13:40:15 +04:00
}
2015-04-22 10:34:29 +03:00
static struct dma_async_tx_descriptor * omap_dma_prep_dma_memcpy (
struct dma_chan * chan , dma_addr_t dest , dma_addr_t src ,
size_t len , unsigned long tx_flags )
{
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
struct omap_desc * d ;
uint8_t data_type ;
d = kzalloc ( sizeof ( * d ) + sizeof ( d - > sg [ 0 ] ) , GFP_ATOMIC ) ;
if ( ! d )
return NULL ;
data_type = __ffs ( ( src | dest | len ) ) ;
if ( data_type > CSDP_DATA_TYPE_32 )
data_type = CSDP_DATA_TYPE_32 ;
d - > dir = DMA_MEM_TO_MEM ;
d - > dev_addr = src ;
d - > fi = 0 ;
d - > es = data_type ;
d - > sg [ 0 ] . en = len / BIT ( data_type ) ;
d - > sg [ 0 ] . fn = 1 ;
d - > sg [ 0 ] . addr = dest ;
d - > sglen = 1 ;
d - > ccr = c - > ccr ;
d - > ccr | = CCR_DST_AMODE_POSTINC | CCR_SRC_AMODE_POSTINC ;
2016-04-05 15:20:21 +03:00
d - > cicr = CICR_DROP_IE | CICR_FRAME_IE ;
2015-04-22 10:34:29 +03:00
d - > csdp = data_type ;
if ( dma_omap1 ( ) ) {
d - > cicr | = CICR_TOUT_IE ;
d - > csdp | = CSDP_DST_PORT_EMIFF | CSDP_SRC_PORT_EMIFF ;
} else {
d - > csdp | = CSDP_DST_PACKED | CSDP_SRC_PACKED ;
d - > cicr | = CICR_MISALIGNED_ERR_IE | CICR_TRANS_ERR_IE ;
d - > csdp | = CSDP_DST_BURST_64 | CSDP_SRC_BURST_64 ;
}
return vchan_tx_prep ( & c - > vc , & d - > vd , tx_flags ) ;
}
2014-11-17 16:42:28 +03:00
static int omap_dma_slave_config ( struct dma_chan * chan , struct dma_slave_config * cfg )
2012-04-13 15:10:24 +04:00
{
2014-11-17 16:42:28 +03:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
2012-04-13 15:10:24 +04:00
if ( cfg - > src_addr_width = = DMA_SLAVE_BUSWIDTH_8_BYTES | |
cfg - > dst_addr_width = = DMA_SLAVE_BUSWIDTH_8_BYTES )
return - EINVAL ;
memcpy ( & c - > cfg , cfg , sizeof ( c - > cfg ) ) ;
return 0 ;
}
2014-11-17 16:42:28 +03:00
static int omap_dma_terminate_all ( struct dma_chan * chan )
2012-04-13 15:10:24 +04:00
{
2014-11-17 16:42:28 +03:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
2012-04-13 15:10:24 +04:00
unsigned long flags ;
LIST_HEAD ( head ) ;
spin_lock_irqsave ( & c - > vc . lock , flags ) ;
/*
* Stop DMA activity : we assume the callback will not be called
2013-11-02 21:07:09 +04:00
* after omap_dma_stop ( ) returns ( even if it does , it will see
2012-04-13 15:10:24 +04:00
* c - > desc is NULL and exit . )
*/
if ( c - > desc ) {
2015-03-27 14:35:52 +03:00
omap_dma_desc_free ( & c - > desc - > vd ) ;
2012-04-13 15:10:24 +04:00
c - > desc = NULL ;
2012-09-14 16:05:45 +04:00
/* Avoid stopping the dma twice */
if ( ! c - > paused )
2013-11-02 21:07:09 +04:00
omap_dma_stop ( c ) ;
2012-04-13 15:10:24 +04:00
}
2012-06-21 13:40:15 +04:00
if ( c - > cyclic ) {
c - > cyclic = false ;
2012-09-14 16:05:45 +04:00
c - > paused = false ;
2012-06-21 13:40:15 +04:00
}
2012-04-13 15:10:24 +04:00
vchan_get_all_descriptors ( & c - > vc , & head ) ;
spin_unlock_irqrestore ( & c - > vc . lock , flags ) ;
vchan_dma_desc_free_list ( & c - > vc , & head ) ;
return 0 ;
}
2016-02-11 12:08:34 +03:00
static void omap_dma_synchronize ( struct dma_chan * chan )
{
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
vchan_synchronize ( & c - > vc ) ;
}
2014-11-17 16:42:28 +03:00
static int omap_dma_pause ( struct dma_chan * chan )
2012-04-13 15:10:24 +04:00
{
2014-11-17 16:42:28 +03:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
2012-09-14 16:05:45 +04:00
/* Pause/Resume only allowed with cyclic mode */
if ( ! c - > cyclic )
return - EINVAL ;
if ( ! c - > paused ) {
2013-11-02 21:07:09 +04:00
omap_dma_stop ( c ) ;
2012-09-14 16:05:45 +04:00
c - > paused = true ;
}
return 0 ;
2012-04-13 15:10:24 +04:00
}
2014-11-17 16:42:28 +03:00
static int omap_dma_resume ( struct dma_chan * chan )
2012-04-13 15:10:24 +04:00
{
2014-11-17 16:42:28 +03:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
2012-09-14 16:05:45 +04:00
/* Pause/Resume only allowed with cyclic mode */
if ( ! c - > cyclic )
return - EINVAL ;
if ( c - > paused ) {
2014-09-16 23:45:56 +04:00
mb ( ) ;
2014-09-16 23:45:57 +04:00
/* Restore channel link register */
omap_dma_chan_write ( c , CLNK_CTRL , c - > desc - > clnk_ctrl ) ;
2013-11-02 21:07:09 +04:00
omap_dma_start ( c , c - > desc ) ;
2012-09-14 16:05:45 +04:00
c - > paused = false ;
}
return 0 ;
2012-04-13 15:10:24 +04:00
}
2015-04-09 12:35:52 +03:00
static int omap_dma_chan_init ( struct omap_dmadev * od )
2012-04-13 15:10:24 +04:00
{
struct omap_chan * c ;
c = kzalloc ( sizeof ( * c ) , GFP_KERNEL ) ;
if ( ! c )
return - ENOMEM ;
2013-12-10 15:08:01 +04:00
c - > reg_map = od - > reg_map ;
2012-04-13 15:10:24 +04:00
c - > vc . desc_free = omap_dma_desc_free ;
vchan_init ( & c - > vc , & od - > ddev ) ;
return 0 ;
}
static void omap_dma_free ( struct omap_dmadev * od )
{
while ( ! list_empty ( & od - > ddev . channels ) ) {
struct omap_chan * c = list_first_entry ( & od - > ddev . channels ,
struct omap_chan , vc . chan . device_node ) ;
list_del ( & c - > vc . chan . device_node ) ;
tasklet_kill ( & c - > vc . task ) ;
kfree ( c ) ;
}
}
2014-03-29 17:33:30 +04:00
# define OMAP_DMA_BUSWIDTHS (BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | \
BIT ( DMA_SLAVE_BUSWIDTH_2_BYTES ) | \
BIT ( DMA_SLAVE_BUSWIDTH_4_BYTES ) )
2012-04-13 15:10:24 +04:00
static int omap_dma_probe ( struct platform_device * pdev )
{
struct omap_dmadev * od ;
2013-12-10 15:08:01 +04:00
struct resource * res ;
2013-12-10 23:05:50 +04:00
int rc , i , irq ;
2012-04-13 15:10:24 +04:00
2013-11-02 16:58:29 +04:00
od = devm_kzalloc ( & pdev - > dev , sizeof ( * od ) , GFP_KERNEL ) ;
2012-04-13 15:10:24 +04:00
if ( ! od )
return - ENOMEM ;
2013-12-10 15:08:01 +04:00
res = platform_get_resource ( pdev , IORESOURCE_MEM , 0 ) ;
od - > base = devm_ioremap_resource ( & pdev - > dev , res ) ;
if ( IS_ERR ( od - > base ) )
return PTR_ERR ( od - > base ) ;
2013-11-02 17:00:03 +04:00
od - > plat = omap_get_plat_info ( ) ;
if ( ! od - > plat )
return - EPROBE_DEFER ;
2013-12-10 15:08:01 +04:00
od - > reg_map = od - > plat - > reg_map ;
2012-04-13 15:10:24 +04:00
dma_cap_set ( DMA_SLAVE , od - > ddev . cap_mask ) ;
2012-06-21 13:40:15 +04:00
dma_cap_set ( DMA_CYCLIC , od - > ddev . cap_mask ) ;
2015-04-22 10:34:29 +03:00
dma_cap_set ( DMA_MEMCPY , od - > ddev . cap_mask ) ;
2012-04-13 15:10:24 +04:00
od - > ddev . device_alloc_chan_resources = omap_dma_alloc_chan_resources ;
od - > ddev . device_free_chan_resources = omap_dma_free_chan_resources ;
od - > ddev . device_tx_status = omap_dma_tx_status ;
od - > ddev . device_issue_pending = omap_dma_issue_pending ;
od - > ddev . device_prep_slave_sg = omap_dma_prep_slave_sg ;
2012-06-21 13:40:15 +04:00
od - > ddev . device_prep_dma_cyclic = omap_dma_prep_dma_cyclic ;
2015-04-22 10:34:29 +03:00
od - > ddev . device_prep_dma_memcpy = omap_dma_prep_dma_memcpy ;
2014-12-07 20:42:31 +03:00
od - > ddev . device_config = omap_dma_slave_config ;
2014-11-17 16:42:28 +03:00
od - > ddev . device_pause = omap_dma_pause ;
od - > ddev . device_resume = omap_dma_resume ;
od - > ddev . device_terminate_all = omap_dma_terminate_all ;
2016-02-11 12:08:34 +03:00
od - > ddev . device_synchronize = omap_dma_synchronize ;
2014-11-17 16:42:49 +03:00
od - > ddev . src_addr_widths = OMAP_DMA_BUSWIDTHS ;
od - > ddev . dst_addr_widths = OMAP_DMA_BUSWIDTHS ;
od - > ddev . directions = BIT ( DMA_DEV_TO_MEM ) | BIT ( DMA_MEM_TO_DEV ) ;
od - > ddev . residue_granularity = DMA_RESIDUE_GRANULARITY_BURST ;
2012-04-13 15:10:24 +04:00
od - > ddev . dev = & pdev - > dev ;
INIT_LIST_HEAD ( & od - > ddev . channels ) ;
spin_lock_init ( & od - > lock ) ;
2013-12-10 23:05:50 +04:00
spin_lock_init ( & od - > irq_lock ) ;
2012-04-13 15:10:24 +04:00
2015-04-09 12:35:51 +03:00
od - > dma_requests = OMAP_SDMA_REQUESTS ;
if ( pdev - > dev . of_node & & of_property_read_u32 ( pdev - > dev . of_node ,
" dma-requests " ,
& od - > dma_requests ) ) {
dev_info ( & pdev - > dev ,
" Missing dma-requests property, using %u. \n " ,
OMAP_SDMA_REQUESTS ) ;
}
2015-04-09 12:35:53 +03:00
for ( i = 0 ; i < OMAP_SDMA_CHANNELS ; i + + ) {
2015-04-09 12:35:52 +03:00
rc = omap_dma_chan_init ( od ) ;
2012-04-13 15:10:24 +04:00
if ( rc ) {
omap_dma_free ( od ) ;
return rc ;
}
}
2013-12-10 23:05:50 +04:00
irq = platform_get_irq ( pdev , 1 ) ;
if ( irq < = 0 ) {
dev_info ( & pdev - > dev , " failed to get L1 IRQ: %d \n " , irq ) ;
od - > legacy = true ;
} else {
/* Disable all interrupts */
od - > irq_enable_mask = 0 ;
omap_dma_glbl_write ( od , IRQENABLE_L1 , 0 ) ;
rc = devm_request_irq ( & pdev - > dev , irq , omap_dma_irq ,
IRQF_SHARED , " omap-dma-engine " , od ) ;
if ( rc )
return rc ;
}
2015-12-14 23:47:42 +03:00
od - > ddev . filter . map = od - > plat - > slave_map ;
od - > ddev . filter . mapcnt = od - > plat - > slavecnt ;
od - > ddev . filter . fn = omap_dma_filter_fn ;
2012-04-13 15:10:24 +04:00
rc = dma_async_device_register ( & od - > ddev ) ;
if ( rc ) {
pr_warn ( " OMAP-DMA: failed to register slave DMA engine device: %d \n " ,
rc ) ;
omap_dma_free ( od ) ;
2013-02-26 22:27:24 +04:00
return rc ;
}
platform_set_drvdata ( pdev , od ) ;
if ( pdev - > dev . of_node ) {
omap_dma_info . dma_cap = od - > ddev . cap_mask ;
/* Device-tree DMA controller registration */
rc = of_dma_controller_register ( pdev - > dev . of_node ,
of_dma_simple_xlate , & omap_dma_info ) ;
if ( rc ) {
pr_warn ( " OMAP-DMA: failed to register DMA controller \n " ) ;
dma_async_device_unregister ( & od - > ddev ) ;
omap_dma_free ( od ) ;
}
2012-04-13 15:10:24 +04:00
}
dev_info ( & pdev - > dev , " OMAP DMA engine driver \n " ) ;
return rc ;
}
static int omap_dma_remove ( struct platform_device * pdev )
{
struct omap_dmadev * od = platform_get_drvdata ( pdev ) ;
2013-02-26 22:27:24 +04:00
if ( pdev - > dev . of_node )
of_dma_controller_free ( pdev - > dev . of_node ) ;
2012-04-13 15:10:24 +04:00
dma_async_device_unregister ( & od - > ddev ) ;
2013-12-10 23:05:50 +04:00
if ( ! od - > legacy ) {
/* Disable all interrupts */
omap_dma_glbl_write ( od , IRQENABLE_L0 , 0 ) ;
}
2012-04-13 15:10:24 +04:00
omap_dma_free ( od ) ;
return 0 ;
}
2013-02-26 22:27:24 +04:00
static const struct of_device_id omap_dma_match [ ] = {
{ . compatible = " ti,omap2420-sdma " , } ,
{ . compatible = " ti,omap2430-sdma " , } ,
{ . compatible = " ti,omap3430-sdma " , } ,
{ . compatible = " ti,omap3630-sdma " , } ,
{ . compatible = " ti,omap4430-sdma " , } ,
{ } ,
} ;
MODULE_DEVICE_TABLE ( of , omap_dma_match ) ;
2012-04-13 15:10:24 +04:00
static struct platform_driver omap_dma_driver = {
. probe = omap_dma_probe ,
. remove = omap_dma_remove ,
. driver = {
. name = " omap-dma-engine " ,
2013-02-26 22:27:24 +04:00
. of_match_table = of_match_ptr ( omap_dma_match ) ,
2012-04-13 15:10:24 +04:00
} ,
} ;
bool omap_dma_filter_fn ( struct dma_chan * chan , void * param )
{
if ( chan - > device - > dev - > driver = = & omap_dma_driver . driver ) {
2015-04-09 12:35:52 +03:00
struct omap_dmadev * od = to_omap_dma_dev ( chan - > device ) ;
2012-04-13 15:10:24 +04:00
struct omap_chan * c = to_omap_dma_chan ( chan ) ;
unsigned req = * ( unsigned * ) param ;
2015-04-09 12:35:52 +03:00
if ( req < = od - > dma_requests ) {
c - > dma_sig = req ;
return true ;
}
2012-04-13 15:10:24 +04:00
}
return false ;
}
EXPORT_SYMBOL_GPL ( omap_dma_filter_fn ) ;
static int omap_dma_init ( void )
{
2013-01-11 23:24:19 +04:00
return platform_driver_register ( & omap_dma_driver ) ;
2012-04-13 15:10:24 +04:00
}
subsys_initcall ( omap_dma_init ) ;
static void __exit omap_dma_exit ( void )
{
platform_driver_unregister ( & omap_dma_driver ) ;
}
module_exit ( omap_dma_exit ) ;
MODULE_AUTHOR ( " Russell King " ) ;
MODULE_LICENSE ( " GPL " ) ;