2008-07-31 13:08:25 +04:00
/*
* Algorithm testing framework and tests .
*
* Copyright ( c ) 2002 James Morris < jmorris @ intercode . com . au >
* Copyright ( c ) 2002 Jean - Francois Dive < jef @ linuxbe . org >
* Copyright ( c ) 2007 Nokia Siemens Networks
* Copyright ( c ) 2008 Herbert Xu < herbert @ gondor . apana . org . au >
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
* Copyright ( c ) 2019 Google LLC
2008-07-31 13:08:25 +04:00
*
2010-11-04 22:02:04 +03:00
* Updated RFC4106 AES - GCM testing .
* Authors : Aidan O ' Mahony ( aidan . o . mahony @ intel . com )
* Adrian Hoban < adrian . hoban @ intel . com >
* Gabriele Paoloni < gabriele . paoloni @ intel . com >
* Tadeusz Struk ( tadeusz . struk @ intel . com )
* Copyright ( c ) 2010 , Intel Corporation .
*
2008-07-31 13:08:25 +04:00
* This program is free software ; you can redistribute it and / or modify it
* under the terms of the GNU General Public License as published by the Free
* Software Foundation ; either version 2 of the License , or ( at your option )
* any later version .
*
*/
2015-04-22 10:06:31 +03:00
# include <crypto/aead.h>
2008-07-31 13:08:25 +04:00
# include <crypto/hash.h>
2015-08-20 10:21:46 +03:00
# include <crypto/skcipher.h>
2008-07-31 13:08:25 +04:00
# include <linux/err.h>
2015-04-22 08:25:58 +03:00
# include <linux/fips.h>
2008-07-31 13:08:25 +04:00
# include <linux/module.h>
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
# include <linux/once.h>
2019-02-01 10:51:45 +03:00
# include <linux/random.h>
2008-07-31 13:08:25 +04:00
# include <linux/scatterlist.h>
# include <linux/slab.h>
# include <linux/string.h>
2009-05-04 15:44:50 +04:00
# include <crypto/rng.h>
2014-05-31 19:25:36 +04:00
# include <crypto/drbg.h>
2015-06-16 20:31:06 +03:00
# include <crypto/akcipher.h>
2016-06-22 19:49:14 +03:00
# include <crypto/kpp.h>
2016-10-21 15:19:54 +03:00
# include <crypto/acompress.h>
2019-03-13 08:12:47 +03:00
# include <crypto/internal/simd.h>
2008-07-31 13:08:25 +04:00
# include "internal.h"
2010-06-03 14:53:43 +04:00
2016-05-03 12:00:17 +03:00
static bool notests ;
module_param ( notests , bool , 0644 ) ;
MODULE_PARM_DESC ( notests , " disable crypto self-tests " ) ;
2019-03-31 23:09:14 +03:00
static bool panic_on_fail ;
module_param ( panic_on_fail , bool , 0444 ) ;
2019-02-01 10:51:44 +03:00
# ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
static bool noextratests ;
module_param ( noextratests , bool , 0644 ) ;
MODULE_PARM_DESC ( noextratests , " disable expensive crypto self-tests " ) ;
static unsigned int fuzz_iterations = 100 ;
module_param ( fuzz_iterations , uint , 0644 ) ;
MODULE_PARM_DESC ( fuzz_iterations , " number of fuzz test iterations " ) ;
2019-03-13 08:12:47 +03:00
DEFINE_PER_CPU ( bool , crypto_simd_disabled_for_test ) ;
EXPORT_PER_CPU_SYMBOL_GPL ( crypto_simd_disabled_for_test ) ;
2019-02-01 10:51:44 +03:00
# endif
2010-08-06 05:40:28 +04:00
# ifdef CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
2010-06-03 14:53:43 +04:00
/* a perfect nop */
int alg_test ( const char * driver , const char * alg , u32 type , u32 mask )
{
return 0 ;
}
# else
2008-07-31 13:08:25 +04:00
# include "testmgr.h"
/*
* Need slab memory for testing ( size in number of pages ) .
*/
# define XBUFSIZE 8
/*
* Used by test_cipher ( )
*/
# define ENCRYPT 1
# define DECRYPT 0
struct aead_test_suite {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
const struct aead_testvec * vecs ;
unsigned int count ;
2008-07-31 13:08:25 +04:00
} ;
struct cipher_test_suite {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
const struct cipher_testvec * vecs ;
unsigned int count ;
2008-07-31 13:08:25 +04:00
} ;
struct comp_test_suite {
struct {
2017-02-25 02:46:59 +03:00
const struct comp_testvec * vecs ;
2008-07-31 13:08:25 +04:00
unsigned int count ;
} comp , decomp ;
} ;
struct hash_test_suite {
2017-02-25 02:46:59 +03:00
const struct hash_testvec * vecs ;
2008-07-31 13:08:25 +04:00
unsigned int count ;
} ;
2009-05-04 15:44:50 +04:00
struct cprng_test_suite {
2017-02-25 02:46:59 +03:00
const struct cprng_testvec * vecs ;
2009-05-04 15:44:50 +04:00
unsigned int count ;
} ;
2014-05-31 19:25:36 +04:00
struct drbg_test_suite {
2017-02-25 02:46:59 +03:00
const struct drbg_testvec * vecs ;
2014-05-31 19:25:36 +04:00
unsigned int count ;
} ;
2015-06-16 20:31:06 +03:00
struct akcipher_test_suite {
2017-02-25 02:46:59 +03:00
const struct akcipher_testvec * vecs ;
2015-06-16 20:31:06 +03:00
unsigned int count ;
} ;
2016-06-22 19:49:14 +03:00
struct kpp_test_suite {
2017-02-25 02:46:59 +03:00
const struct kpp_testvec * vecs ;
2016-06-22 19:49:14 +03:00
unsigned int count ;
} ;
2008-07-31 13:08:25 +04:00
struct alg_test_desc {
const char * alg ;
int ( * test ) ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask ) ;
2009-05-15 09:16:03 +04:00
int fips_allowed ; /* set if alg is allowed in fips mode */
2008-07-31 13:08:25 +04:00
union {
struct aead_test_suite aead ;
struct cipher_test_suite cipher ;
struct comp_test_suite comp ;
struct hash_test_suite hash ;
2009-05-04 15:44:50 +04:00
struct cprng_test_suite cprng ;
2014-05-31 19:25:36 +04:00
struct drbg_test_suite drbg ;
2015-06-16 20:31:06 +03:00
struct akcipher_test_suite akcipher ;
2016-06-22 19:49:14 +03:00
struct kpp_test_suite kpp ;
2008-07-31 13:08:25 +04:00
} suite ;
} ;
static void hexdump ( unsigned char * buf , unsigned int len )
{
print_hex_dump ( KERN_CONT , " " , DUMP_PREFIX_OFFSET ,
16 , 1 ,
buf , len , false ) ;
}
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
static int __testmgr_alloc_buf ( char * buf [ XBUFSIZE ] , int order )
2009-05-06 10:15:47 +04:00
{
int i ;
for ( i = 0 ; i < XBUFSIZE ; i + + ) {
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
buf [ i ] = ( char * ) __get_free_pages ( GFP_KERNEL , order ) ;
2009-05-06 10:15:47 +04:00
if ( ! buf [ i ] )
goto err_free_buf ;
}
return 0 ;
err_free_buf :
while ( i - - > 0 )
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
free_pages ( ( unsigned long ) buf [ i ] , order ) ;
2009-05-06 10:15:47 +04:00
return - ENOMEM ;
}
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
static int testmgr_alloc_buf ( char * buf [ XBUFSIZE ] )
{
return __testmgr_alloc_buf ( buf , 0 ) ;
}
static void __testmgr_free_buf ( char * buf [ XBUFSIZE ] , int order )
2009-05-06 10:15:47 +04:00
{
int i ;
for ( i = 0 ; i < XBUFSIZE ; i + + )
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
free_pages ( ( unsigned long ) buf [ i ] , order ) ;
}
static void testmgr_free_buf ( char * buf [ XBUFSIZE ] )
{
__testmgr_free_buf ( buf , 0 ) ;
}
# define TESTMGR_POISON_BYTE 0xfe
# define TESTMGR_POISON_LEN 16
static inline void testmgr_poison ( void * addr , size_t len )
{
memset ( addr , TESTMGR_POISON_BYTE , len ) ;
}
/* Is the memory region still fully poisoned? */
static inline bool testmgr_is_poison ( const void * addr , size_t len )
{
return memchr_inv ( addr , TESTMGR_POISON_BYTE , len ) = = NULL ;
}
/* flush type for hash algorithms */
enum flush_type {
/* merge with update of previous buffer(s) */
FLUSH_TYPE_NONE = 0 ,
/* update with previous buffer(s) before doing this one */
FLUSH_TYPE_FLUSH ,
/* likewise, but also export and re-import the intermediate state */
FLUSH_TYPE_REIMPORT ,
} ;
/* finalization function for hash algorithms */
enum finalization_type {
FINALIZATION_TYPE_FINAL , /* use final() */
FINALIZATION_TYPE_FINUP , /* use finup() */
FINALIZATION_TYPE_DIGEST , /* use digest() */
} ;
# define TEST_SG_TOTAL 10000
/**
* struct test_sg_division - description of a scatterlist entry
*
* This struct describes one entry of a scatterlist being constructed to check a
* crypto test vector .
*
* @ proportion_of_total : length of this chunk relative to the total length ,
* given as a proportion out of TEST_SG_TOTAL so that it
* scales to fit any test vector
* @ offset : byte offset into a 2 - page buffer at which this chunk will start
* @ offset_relative_to_alignmask : if true , add the algorithm ' s alignmask to the
* @ offset
* @ flush_type : for hashes , whether an update ( ) should be done now vs .
* continuing to accumulate data
2019-03-13 08:12:52 +03:00
* @ nosimd : if doing the pending update ( ) , do it with SIMD disabled ?
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
*/
struct test_sg_division {
unsigned int proportion_of_total ;
unsigned int offset ;
bool offset_relative_to_alignmask ;
enum flush_type flush_type ;
2019-03-13 08:12:52 +03:00
bool nosimd ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
} ;
/**
* struct testvec_config - configuration for testing a crypto test vector
*
* This struct describes the data layout and other parameters with which each
* crypto test vector can be tested .
*
* @ name : name of this config , logged for debugging purposes if a test fails
* @ inplace : operate on the data in - place , if applicable for the algorithm type ?
* @ req_flags : extra request_flags , e . g . CRYPTO_TFM_REQ_MAY_SLEEP
* @ src_divs : description of how to arrange the source scatterlist
* @ dst_divs : description of how to arrange the dst scatterlist , if applicable
* for the algorithm type . Defaults to @ src_divs if unset .
* @ iv_offset : misalignment of the IV in the range [ 0. . MAX_ALGAPI_ALIGNMASK + 1 ] ,
* where 0 is aligned to a 2 * ( MAX_ALGAPI_ALIGNMASK + 1 ) byte boundary
* @ iv_offset_relative_to_alignmask : if true , add the algorithm ' s alignmask to
* the @ iv_offset
* @ finalization_type : what finalization function to use for hashes
2019-03-13 08:12:52 +03:00
* @ nosimd : execute with SIMD disabled ? Requires ! CRYPTO_TFM_REQ_MAY_SLEEP .
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
*/
struct testvec_config {
const char * name ;
bool inplace ;
u32 req_flags ;
struct test_sg_division src_divs [ XBUFSIZE ] ;
struct test_sg_division dst_divs [ XBUFSIZE ] ;
unsigned int iv_offset ;
bool iv_offset_relative_to_alignmask ;
enum finalization_type finalization_type ;
2019-03-13 08:12:52 +03:00
bool nosimd ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
} ;
# define TESTVEC_CONFIG_NAMELEN 192
2019-02-01 10:51:46 +03:00
/*
* The following are the lists of testvec_configs to test for each algorithm
* type when the basic crypto self - tests are enabled , i . e . when
* CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is unset . They aim to provide good test
* coverage , while keeping the test time much shorter than the full fuzz tests
* so that the basic tests can be enabled in a wider range of circumstances .
*/
/* Configs for skciphers and aeads */
static const struct testvec_config default_cipher_testvec_configs [ ] = {
{
. name = " in-place " ,
. inplace = true ,
. src_divs = { { . proportion_of_total = 10000 } } ,
} , {
. name = " out-of-place " ,
. src_divs = { { . proportion_of_total = 10000 } } ,
} , {
. name = " unaligned buffer, offset=1 " ,
. src_divs = { { . proportion_of_total = 10000 , . offset = 1 } } ,
. iv_offset = 1 ,
} , {
. name = " buffer aligned only to alignmask " ,
. src_divs = {
{
. proportion_of_total = 10000 ,
. offset = 1 ,
. offset_relative_to_alignmask = true ,
} ,
} ,
. iv_offset = 1 ,
. iv_offset_relative_to_alignmask = true ,
} , {
. name = " two even aligned splits " ,
. src_divs = {
{ . proportion_of_total = 5000 } ,
{ . proportion_of_total = 5000 } ,
} ,
} , {
. name = " uneven misaligned splits, may sleep " ,
. req_flags = CRYPTO_TFM_REQ_MAY_SLEEP ,
. src_divs = {
{ . proportion_of_total = 1900 , . offset = 33 } ,
{ . proportion_of_total = 3300 , . offset = 7 } ,
{ . proportion_of_total = 4800 , . offset = 18 } ,
} ,
. iv_offset = 3 ,
} , {
. name = " misaligned splits crossing pages, inplace " ,
. inplace = true ,
. src_divs = {
{
. proportion_of_total = 7500 ,
. offset = PAGE_SIZE - 32
} , {
. proportion_of_total = 2500 ,
. offset = PAGE_SIZE - 7
} ,
} ,
}
} ;
2019-02-01 10:51:48 +03:00
static const struct testvec_config default_hash_testvec_configs [ ] = {
{
. name = " init+update+final aligned buffer " ,
. src_divs = { { . proportion_of_total = 10000 } } ,
. finalization_type = FINALIZATION_TYPE_FINAL ,
} , {
. name = " init+finup aligned buffer " ,
. src_divs = { { . proportion_of_total = 10000 } } ,
. finalization_type = FINALIZATION_TYPE_FINUP ,
} , {
. name = " digest aligned buffer " ,
. src_divs = { { . proportion_of_total = 10000 } } ,
. finalization_type = FINALIZATION_TYPE_DIGEST ,
} , {
. name = " init+update+final misaligned buffer " ,
. src_divs = { { . proportion_of_total = 10000 , . offset = 1 } } ,
. finalization_type = FINALIZATION_TYPE_FINAL ,
} , {
. name = " digest buffer aligned only to alignmask " ,
. src_divs = {
{
. proportion_of_total = 10000 ,
. offset = 1 ,
. offset_relative_to_alignmask = true ,
} ,
} ,
. finalization_type = FINALIZATION_TYPE_DIGEST ,
} , {
. name = " init+update+update+final two even splits " ,
. src_divs = {
{ . proportion_of_total = 5000 } ,
{
. proportion_of_total = 5000 ,
. flush_type = FLUSH_TYPE_FLUSH ,
} ,
} ,
. finalization_type = FINALIZATION_TYPE_FINAL ,
} , {
. name = " digest uneven misaligned splits, may sleep " ,
. req_flags = CRYPTO_TFM_REQ_MAY_SLEEP ,
. src_divs = {
{ . proportion_of_total = 1900 , . offset = 33 } ,
{ . proportion_of_total = 3300 , . offset = 7 } ,
{ . proportion_of_total = 4800 , . offset = 18 } ,
} ,
. finalization_type = FINALIZATION_TYPE_DIGEST ,
} , {
. name = " digest misaligned splits crossing pages " ,
. src_divs = {
{
. proportion_of_total = 7500 ,
. offset = PAGE_SIZE - 32 ,
} , {
. proportion_of_total = 2500 ,
. offset = PAGE_SIZE - 7 ,
} ,
} ,
. finalization_type = FINALIZATION_TYPE_DIGEST ,
} , {
. name = " import/export " ,
. src_divs = {
{
. proportion_of_total = 6500 ,
. flush_type = FLUSH_TYPE_REIMPORT ,
} , {
. proportion_of_total = 3500 ,
. flush_type = FLUSH_TYPE_REIMPORT ,
} ,
} ,
. finalization_type = FINALIZATION_TYPE_FINAL ,
}
} ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
static unsigned int count_test_sg_divisions ( const struct test_sg_division * divs )
{
unsigned int remaining = TEST_SG_TOTAL ;
unsigned int ndivs = 0 ;
do {
remaining - = divs [ ndivs + + ] . proportion_of_total ;
} while ( remaining ) ;
return ndivs ;
}
2019-03-13 08:12:52 +03:00
# define SGDIVS_HAVE_FLUSHES BIT(0)
# define SGDIVS_HAVE_NOSIMD BIT(1)
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
static bool valid_sg_divisions ( const struct test_sg_division * divs ,
2019-03-13 08:12:52 +03:00
unsigned int count , int * flags_ret )
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
{
unsigned int total = 0 ;
unsigned int i ;
for ( i = 0 ; i < count & & total ! = TEST_SG_TOTAL ; i + + ) {
if ( divs [ i ] . proportion_of_total < = 0 | |
divs [ i ] . proportion_of_total > TEST_SG_TOTAL - total )
return false ;
total + = divs [ i ] . proportion_of_total ;
if ( divs [ i ] . flush_type ! = FLUSH_TYPE_NONE )
2019-03-13 08:12:52 +03:00
* flags_ret | = SGDIVS_HAVE_FLUSHES ;
if ( divs [ i ] . nosimd )
* flags_ret | = SGDIVS_HAVE_NOSIMD ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
}
return total = = TEST_SG_TOTAL & &
memchr_inv ( & divs [ i ] , 0 , ( count - i ) * sizeof ( divs [ 0 ] ) ) = = NULL ;
}
/*
* Check whether the given testvec_config is valid . This isn ' t strictly needed
* since every testvec_config should be valid , but check anyway so that people
* don ' t unknowingly add broken configs that don ' t do what they wanted .
*/
static bool valid_testvec_config ( const struct testvec_config * cfg )
{
2019-03-13 08:12:52 +03:00
int flags = 0 ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
if ( cfg - > name = = NULL )
return false ;
if ( ! valid_sg_divisions ( cfg - > src_divs , ARRAY_SIZE ( cfg - > src_divs ) ,
2019-03-13 08:12:52 +03:00
& flags ) )
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
return false ;
if ( cfg - > dst_divs [ 0 ] . proportion_of_total ) {
if ( ! valid_sg_divisions ( cfg - > dst_divs ,
2019-03-13 08:12:52 +03:00
ARRAY_SIZE ( cfg - > dst_divs ) , & flags ) )
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
return false ;
} else {
if ( memchr_inv ( cfg - > dst_divs , 0 , sizeof ( cfg - > dst_divs ) ) )
return false ;
/* defaults to dst_divs=src_divs */
}
if ( cfg - > iv_offset +
( cfg - > iv_offset_relative_to_alignmask ? MAX_ALGAPI_ALIGNMASK : 0 ) >
MAX_ALGAPI_ALIGNMASK + 1 )
return false ;
2019-03-13 08:12:52 +03:00
if ( ( flags & ( SGDIVS_HAVE_FLUSHES | SGDIVS_HAVE_NOSIMD ) ) & &
cfg - > finalization_type = = FINALIZATION_TYPE_DIGEST )
return false ;
if ( ( cfg - > nosimd | | ( flags & SGDIVS_HAVE_NOSIMD ) ) & &
( cfg - > req_flags & CRYPTO_TFM_REQ_MAY_SLEEP ) )
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
return false ;
return true ;
}
struct test_sglist {
char * bufs [ XBUFSIZE ] ;
struct scatterlist sgl [ XBUFSIZE ] ;
struct scatterlist sgl_saved [ XBUFSIZE ] ;
struct scatterlist * sgl_ptr ;
unsigned int nents ;
} ;
static int init_test_sglist ( struct test_sglist * tsgl )
{
return __testmgr_alloc_buf ( tsgl - > bufs , 1 /* two pages per buffer */ ) ;
}
static void destroy_test_sglist ( struct test_sglist * tsgl )
{
return __testmgr_free_buf ( tsgl - > bufs , 1 /* two pages per buffer */ ) ;
}
/**
* build_test_sglist ( ) - build a scatterlist for a crypto test
*
* @ tsgl : the scatterlist to build . @ tsgl - > bufs [ ] contains an array of 2 - page
* buffers which the scatterlist @ tsgl - > sgl [ ] will be made to point into .
* @ divs : the layout specification on which the scatterlist will be based
* @ alignmask : the algorithm ' s alignmask
* @ total_len : the total length of the scatterlist to build in bytes
* @ data : if non - NULL , the buffers will be filled with this data until it ends .
* Otherwise the buffers will be poisoned . In both cases , some bytes
* past the end of each buffer will be poisoned to help detect overruns .
* @ out_divs : if non - NULL , the test_sg_division to which each scatterlist entry
* corresponds will be returned here . This will match @ divs except
* that divisions resolving to a length of 0 are omitted as they are
* not included in the scatterlist .
*
* Return : 0 or a - errno value
*/
static int build_test_sglist ( struct test_sglist * tsgl ,
const struct test_sg_division * divs ,
const unsigned int alignmask ,
const unsigned int total_len ,
struct iov_iter * data ,
const struct test_sg_division * out_divs [ XBUFSIZE ] )
{
struct {
const struct test_sg_division * div ;
size_t length ;
} partitions [ XBUFSIZE ] ;
const unsigned int ndivs = count_test_sg_divisions ( divs ) ;
unsigned int len_remaining = total_len ;
unsigned int i ;
BUILD_BUG_ON ( ARRAY_SIZE ( partitions ) ! = ARRAY_SIZE ( tsgl - > sgl ) ) ;
if ( WARN_ON ( ndivs > ARRAY_SIZE ( partitions ) ) )
return - EINVAL ;
/* Calculate the (div, length) pairs */
tsgl - > nents = 0 ;
for ( i = 0 ; i < ndivs ; i + + ) {
unsigned int len_this_sg =
min ( len_remaining ,
( total_len * divs [ i ] . proportion_of_total +
TEST_SG_TOTAL / 2 ) / TEST_SG_TOTAL ) ;
if ( len_this_sg ! = 0 ) {
partitions [ tsgl - > nents ] . div = & divs [ i ] ;
partitions [ tsgl - > nents ] . length = len_this_sg ;
tsgl - > nents + + ;
len_remaining - = len_this_sg ;
}
}
if ( tsgl - > nents = = 0 ) {
partitions [ tsgl - > nents ] . div = & divs [ 0 ] ;
partitions [ tsgl - > nents ] . length = 0 ;
tsgl - > nents + + ;
}
partitions [ tsgl - > nents - 1 ] . length + = len_remaining ;
/* Set up the sgl entries and fill the data or poison */
sg_init_table ( tsgl - > sgl , tsgl - > nents ) ;
for ( i = 0 ; i < tsgl - > nents ; i + + ) {
unsigned int offset = partitions [ i ] . div - > offset ;
void * addr ;
if ( partitions [ i ] . div - > offset_relative_to_alignmask )
offset + = alignmask ;
while ( offset + partitions [ i ] . length + TESTMGR_POISON_LEN >
2 * PAGE_SIZE ) {
if ( WARN_ON ( offset < = 0 ) )
return - EINVAL ;
offset / = 2 ;
}
addr = & tsgl - > bufs [ i ] [ offset ] ;
sg_set_buf ( & tsgl - > sgl [ i ] , addr , partitions [ i ] . length ) ;
if ( out_divs )
out_divs [ i ] = partitions [ i ] . div ;
if ( data ) {
size_t copy_len , copied ;
copy_len = min ( partitions [ i ] . length , data - > count ) ;
copied = copy_from_iter ( addr , copy_len , data ) ;
if ( WARN_ON ( copied ! = copy_len ) )
return - EINVAL ;
testmgr_poison ( addr + copy_len , partitions [ i ] . length +
TESTMGR_POISON_LEN - copy_len ) ;
} else {
testmgr_poison ( addr , partitions [ i ] . length +
TESTMGR_POISON_LEN ) ;
}
}
sg_mark_end ( & tsgl - > sgl [ tsgl - > nents - 1 ] ) ;
tsgl - > sgl_ptr = tsgl - > sgl ;
memcpy ( tsgl - > sgl_saved , tsgl - > sgl , tsgl - > nents * sizeof ( tsgl - > sgl [ 0 ] ) ) ;
return 0 ;
}
/*
* Verify that a scatterlist crypto operation produced the correct output .
*
* @ tsgl : scatterlist containing the actual output
* @ expected_output : buffer containing the expected output
* @ len_to_check : length of @ expected_output in bytes
* @ unchecked_prefix_len : number of ignored bytes in @ tsgl prior to real result
* @ check_poison : verify that the poison bytes after each chunk are intact ?
*
* Return : 0 if correct , - EINVAL if incorrect , - EOVERFLOW if buffer overrun .
*/
static int verify_correct_output ( const struct test_sglist * tsgl ,
const char * expected_output ,
unsigned int len_to_check ,
unsigned int unchecked_prefix_len ,
bool check_poison )
{
unsigned int i ;
for ( i = 0 ; i < tsgl - > nents ; i + + ) {
struct scatterlist * sg = & tsgl - > sgl_ptr [ i ] ;
unsigned int len = sg - > length ;
unsigned int offset = sg - > offset ;
const char * actual_output ;
if ( unchecked_prefix_len ) {
if ( unchecked_prefix_len > = len ) {
unchecked_prefix_len - = len ;
continue ;
}
offset + = unchecked_prefix_len ;
len - = unchecked_prefix_len ;
unchecked_prefix_len = 0 ;
}
len = min ( len , len_to_check ) ;
actual_output = page_address ( sg_page ( sg ) ) + offset ;
if ( memcmp ( expected_output , actual_output , len ) ! = 0 )
return - EINVAL ;
if ( check_poison & &
! testmgr_is_poison ( actual_output + len , TESTMGR_POISON_LEN ) )
return - EOVERFLOW ;
len_to_check - = len ;
expected_output + = len ;
}
if ( WARN_ON ( len_to_check ! = 0 ) )
return - EINVAL ;
return 0 ;
}
static bool is_test_sglist_corrupted ( const struct test_sglist * tsgl )
{
unsigned int i ;
for ( i = 0 ; i < tsgl - > nents ; i + + ) {
if ( tsgl - > sgl [ i ] . page_link ! = tsgl - > sgl_saved [ i ] . page_link )
return true ;
if ( tsgl - > sgl [ i ] . offset ! = tsgl - > sgl_saved [ i ] . offset )
return true ;
if ( tsgl - > sgl [ i ] . length ! = tsgl - > sgl_saved [ i ] . length )
return true ;
}
return false ;
}
struct cipher_test_sglists {
struct test_sglist src ;
struct test_sglist dst ;
} ;
static struct cipher_test_sglists * alloc_cipher_test_sglists ( void )
{
struct cipher_test_sglists * tsgls ;
tsgls = kmalloc ( sizeof ( * tsgls ) , GFP_KERNEL ) ;
if ( ! tsgls )
return NULL ;
if ( init_test_sglist ( & tsgls - > src ) ! = 0 )
goto fail_kfree ;
if ( init_test_sglist ( & tsgls - > dst ) ! = 0 )
goto fail_destroy_src ;
return tsgls ;
fail_destroy_src :
destroy_test_sglist ( & tsgls - > src ) ;
fail_kfree :
kfree ( tsgls ) ;
return NULL ;
}
static void free_cipher_test_sglists ( struct cipher_test_sglists * tsgls )
{
if ( tsgls ) {
destroy_test_sglist ( & tsgls - > src ) ;
destroy_test_sglist ( & tsgls - > dst ) ;
kfree ( tsgls ) ;
}
}
/* Build the src and dst scatterlists for an skcipher or AEAD test */
static int build_cipher_test_sglists ( struct cipher_test_sglists * tsgls ,
const struct testvec_config * cfg ,
unsigned int alignmask ,
unsigned int src_total_len ,
unsigned int dst_total_len ,
const struct kvec * inputs ,
unsigned int nr_inputs )
{
struct iov_iter input ;
int err ;
iov_iter_kvec ( & input , WRITE , inputs , nr_inputs , src_total_len ) ;
err = build_test_sglist ( & tsgls - > src , cfg - > src_divs , alignmask ,
cfg - > inplace ?
max ( dst_total_len , src_total_len ) :
src_total_len ,
& input , NULL ) ;
if ( err )
return err ;
if ( cfg - > inplace ) {
tsgls - > dst . sgl_ptr = tsgls - > src . sgl ;
tsgls - > dst . nents = tsgls - > src . nents ;
return 0 ;
}
return build_test_sglist ( & tsgls - > dst ,
cfg - > dst_divs [ 0 ] . proportion_of_total ?
cfg - > dst_divs : cfg - > src_divs ,
alignmask , dst_total_len , NULL , NULL ) ;
2009-05-06 10:15:47 +04:00
}
2019-02-01 10:51:45 +03:00
# ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
static char * generate_random_sgl_divisions ( struct test_sg_division * divs ,
size_t max_divs , char * p , char * end ,
2019-03-13 08:12:52 +03:00
bool gen_flushes , u32 req_flags )
2019-02-01 10:51:45 +03:00
{
struct test_sg_division * div = divs ;
unsigned int remaining = TEST_SG_TOTAL ;
do {
unsigned int this_len ;
2019-03-13 08:12:52 +03:00
const char * flushtype_str ;
2019-02-01 10:51:45 +03:00
if ( div = = & divs [ max_divs - 1 ] | | prandom_u32 ( ) % 2 = = 0 )
this_len = remaining ;
else
this_len = 1 + ( prandom_u32 ( ) % remaining ) ;
div - > proportion_of_total = this_len ;
if ( prandom_u32 ( ) % 4 = = 0 )
div - > offset = ( PAGE_SIZE - 128 ) + ( prandom_u32 ( ) % 128 ) ;
else if ( prandom_u32 ( ) % 2 = = 0 )
div - > offset = prandom_u32 ( ) % 32 ;
else
div - > offset = prandom_u32 ( ) % PAGE_SIZE ;
if ( prandom_u32 ( ) % 8 = = 0 )
div - > offset_relative_to_alignmask = true ;
div - > flush_type = FLUSH_TYPE_NONE ;
if ( gen_flushes ) {
switch ( prandom_u32 ( ) % 4 ) {
case 0 :
div - > flush_type = FLUSH_TYPE_REIMPORT ;
break ;
case 1 :
div - > flush_type = FLUSH_TYPE_FLUSH ;
break ;
}
}
2019-03-13 08:12:52 +03:00
if ( div - > flush_type ! = FLUSH_TYPE_NONE & &
! ( req_flags & CRYPTO_TFM_REQ_MAY_SLEEP ) & &
prandom_u32 ( ) % 2 = = 0 )
div - > nosimd = true ;
switch ( div - > flush_type ) {
case FLUSH_TYPE_FLUSH :
if ( div - > nosimd )
flushtype_str = " <flush,nosimd> " ;
else
flushtype_str = " <flush> " ;
break ;
case FLUSH_TYPE_REIMPORT :
if ( div - > nosimd )
flushtype_str = " <reimport,nosimd> " ;
else
flushtype_str = " <reimport> " ;
break ;
default :
flushtype_str = " " ;
break ;
}
2019-02-01 10:51:45 +03:00
BUILD_BUG_ON ( TEST_SG_TOTAL ! = 10000 ) ; /* for "%u.%u%%" */
2019-03-13 08:12:52 +03:00
p + = scnprintf ( p , end - p , " %s%u.%u%%@%s+%u%s " , flushtype_str ,
2019-02-01 10:51:45 +03:00
this_len / 100 , this_len % 100 ,
div - > offset_relative_to_alignmask ?
" alignmask " : " " ,
div - > offset , this_len = = remaining ? " " : " , " ) ;
remaining - = this_len ;
div + + ;
} while ( remaining ) ;
return p ;
}
/* Generate a random testvec_config for fuzz testing */
static void generate_random_testvec_config ( struct testvec_config * cfg ,
char * name , size_t max_namelen )
{
char * p = name ;
char * const end = name + max_namelen ;
memset ( cfg , 0 , sizeof ( * cfg ) ) ;
cfg - > name = name ;
p + = scnprintf ( p , end - p , " random: " ) ;
if ( prandom_u32 ( ) % 2 = = 0 ) {
cfg - > inplace = true ;
p + = scnprintf ( p , end - p , " inplace " ) ;
}
if ( prandom_u32 ( ) % 2 = = 0 ) {
cfg - > req_flags | = CRYPTO_TFM_REQ_MAY_SLEEP ;
p + = scnprintf ( p , end - p , " may_sleep " ) ;
}
switch ( prandom_u32 ( ) % 4 ) {
case 0 :
cfg - > finalization_type = FINALIZATION_TYPE_FINAL ;
p + = scnprintf ( p , end - p , " use_final " ) ;
break ;
case 1 :
cfg - > finalization_type = FINALIZATION_TYPE_FINUP ;
p + = scnprintf ( p , end - p , " use_finup " ) ;
break ;
default :
cfg - > finalization_type = FINALIZATION_TYPE_DIGEST ;
p + = scnprintf ( p , end - p , " use_digest " ) ;
break ;
}
2019-03-13 08:12:52 +03:00
if ( ! ( cfg - > req_flags & CRYPTO_TFM_REQ_MAY_SLEEP ) & &
prandom_u32 ( ) % 2 = = 0 ) {
cfg - > nosimd = true ;
p + = scnprintf ( p , end - p , " nosimd " ) ;
}
2019-02-01 10:51:45 +03:00
p + = scnprintf ( p , end - p , " src_divs=[ " ) ;
p = generate_random_sgl_divisions ( cfg - > src_divs ,
ARRAY_SIZE ( cfg - > src_divs ) , p , end ,
( cfg - > finalization_type ! =
2019-03-13 08:12:52 +03:00
FINALIZATION_TYPE_DIGEST ) ,
cfg - > req_flags ) ;
2019-02-01 10:51:45 +03:00
p + = scnprintf ( p , end - p , " ] " ) ;
if ( ! cfg - > inplace & & prandom_u32 ( ) % 2 = = 0 ) {
p + = scnprintf ( p , end - p , " dst_divs=[ " ) ;
p = generate_random_sgl_divisions ( cfg - > dst_divs ,
ARRAY_SIZE ( cfg - > dst_divs ) ,
2019-03-13 08:12:52 +03:00
p , end , false ,
cfg - > req_flags ) ;
2019-02-01 10:51:45 +03:00
p + = scnprintf ( p , end - p , " ] " ) ;
}
if ( prandom_u32 ( ) % 2 = = 0 ) {
cfg - > iv_offset = 1 + ( prandom_u32 ( ) % MAX_ALGAPI_ALIGNMASK ) ;
p + = scnprintf ( p , end - p , " iv_offset=%u " , cfg - > iv_offset ) ;
}
WARN_ON_ONCE ( ! valid_testvec_config ( cfg ) ) ;
}
2019-03-13 08:12:47 +03:00
static void crypto_disable_simd_for_test ( void )
{
preempt_disable ( ) ;
__this_cpu_write ( crypto_simd_disabled_for_test , true ) ;
}
static void crypto_reenable_simd_for_test ( void )
{
__this_cpu_write ( crypto_simd_disabled_for_test , false ) ;
preempt_enable ( ) ;
}
# else /* !CONFIG_CRYPTO_MANAGER_EXTRA_TESTS */
static void crypto_disable_simd_for_test ( void )
{
}
static void crypto_reenable_simd_for_test ( void )
{
}
# endif /* !CONFIG_CRYPTO_MANAGER_EXTRA_TESTS */
2019-02-01 10:51:45 +03:00
2019-03-13 08:12:52 +03:00
static int do_ahash_op ( int ( * op ) ( struct ahash_request * req ) ,
struct ahash_request * req ,
struct crypto_wait * wait , bool nosimd )
{
int err ;
if ( nosimd )
crypto_disable_simd_for_test ( ) ;
err = op ( req ) ;
if ( nosimd )
crypto_reenable_simd_for_test ( ) ;
return crypto_wait_req ( err , wait ) ;
}
2019-02-01 10:51:48 +03:00
static int check_nonfinal_hash_op ( const char * op , int err ,
u8 * result , unsigned int digestsize ,
const char * driver , unsigned int vec_num ,
const struct testvec_config * cfg )
2018-01-16 17:26:13 +03:00
{
2019-02-01 10:51:48 +03:00
if ( err ) {
pr_err ( " alg: hash: %s %s() failed with err %d on test vector %u, cfg= \" %s \" \n " ,
driver , op , err , vec_num , cfg - > name ) ;
return err ;
2016-02-03 13:26:57 +03:00
}
2019-02-01 10:51:48 +03:00
if ( ! testmgr_is_poison ( result , digestsize ) ) {
pr_err ( " alg: hash: %s %s() used result buffer on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return - EINVAL ;
2018-01-16 17:26:13 +03:00
}
2019-02-01 10:51:48 +03:00
return 0 ;
2016-02-03 13:26:57 +03:00
}
2019-02-01 10:51:48 +03:00
static int test_hash_vec_cfg ( const char * driver ,
const struct hash_testvec * vec ,
unsigned int vec_num ,
const struct testvec_config * cfg ,
struct ahash_request * req ,
struct test_sglist * tsgl ,
u8 * hashstate )
2008-07-31 13:08:25 +04:00
{
2019-02-01 10:51:48 +03:00
struct crypto_ahash * tfm = crypto_ahash_reqtfm ( req ) ;
const unsigned int alignmask = crypto_ahash_alignmask ( tfm ) ;
const unsigned int digestsize = crypto_ahash_digestsize ( tfm ) ;
const unsigned int statesize = crypto_ahash_statesize ( tfm ) ;
const u32 req_flags = CRYPTO_TFM_REQ_MAY_BACKLOG | cfg - > req_flags ;
const struct test_sg_division * divs [ XBUFSIZE ] ;
DECLARE_CRYPTO_WAIT ( wait ) ;
struct kvec _input ;
struct iov_iter input ;
unsigned int i ;
struct scatterlist * pending_sgl ;
unsigned int pending_len ;
u8 result [ HASH_MAX_DIGESTSIZE + TESTMGR_POISON_LEN ] ;
int err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
/* Set the key, if specified */
if ( vec - > ksize ) {
err = crypto_ahash_setkey ( tfm , vec - > key , vec - > ksize ) ;
if ( err ) {
pr_err ( " alg: hash: %s setkey failed with err %d on test vector %u; flags=%#x \n " ,
driver , err , vec_num ,
crypto_ahash_get_flags ( tfm ) ) ;
return err ;
}
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
/* Build the scatterlist for the source data */
_input . iov_base = ( void * ) vec - > plaintext ;
_input . iov_len = vec - > psize ;
iov_iter_kvec ( & input , WRITE , & _input , 1 , vec - > psize ) ;
err = build_test_sglist ( tsgl , cfg - > src_divs , alignmask , vec - > psize ,
& input , divs ) ;
if ( err ) {
pr_err ( " alg: hash: %s: error preparing scatterlist for test vector %u, cfg= \" %s \" \n " ,
driver , vec_num , cfg - > name ) ;
return err ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:48 +03:00
/* Do the actual hashing */
2009-05-29 10:23:12 +04:00
2019-02-01 10:51:48 +03:00
testmgr_poison ( req - > __ctx , crypto_ahash_reqsize ( tfm ) ) ;
testmgr_poison ( result , digestsize + TESTMGR_POISON_LEN ) ;
2013-06-13 18:37:55 +04:00
2019-02-01 10:51:48 +03:00
if ( cfg - > finalization_type = = FINALIZATION_TYPE_DIGEST ) {
/* Just using digest() */
ahash_request_set_callback ( req , req_flags , crypto_req_done ,
& wait ) ;
ahash_request_set_crypt ( req , tsgl - > sgl , result , vec - > psize ) ;
2019-03-13 08:12:52 +03:00
err = do_ahash_op ( crypto_ahash_digest , req , & wait , cfg - > nosimd ) ;
2019-02-01 10:51:48 +03:00
if ( err ) {
pr_err ( " alg: hash: %s digest() failed with err %d on test vector %u, cfg= \" %s \" \n " ,
driver , err , vec_num , cfg - > name ) ;
return err ;
}
goto result_ready ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
/* Using init(), zero or more update(), then final() or finup() */
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
ahash_request_set_callback ( req , req_flags , crypto_req_done , & wait ) ;
ahash_request_set_crypt ( req , NULL , result , 0 ) ;
2019-03-13 08:12:52 +03:00
err = do_ahash_op ( crypto_ahash_init , req , & wait , cfg - > nosimd ) ;
2019-02-01 10:51:48 +03:00
err = check_nonfinal_hash_op ( " init " , err , result , digestsize ,
driver , vec_num , cfg ) ;
if ( err )
return err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
pending_sgl = NULL ;
pending_len = 0 ;
for ( i = 0 ; i < tsgl - > nents ; i + + ) {
if ( divs [ i ] - > flush_type ! = FLUSH_TYPE_NONE & &
pending_sgl ! = NULL ) {
/* update() with the pending data */
ahash_request_set_callback ( req , req_flags ,
crypto_req_done , & wait ) ;
ahash_request_set_crypt ( req , pending_sgl , result ,
pending_len ) ;
2019-03-13 08:12:52 +03:00
err = do_ahash_op ( crypto_ahash_update , req , & wait ,
divs [ i ] - > nosimd ) ;
2019-02-01 10:51:48 +03:00
err = check_nonfinal_hash_op ( " update " , err ,
result , digestsize ,
driver , vec_num , cfg ) ;
if ( err )
return err ;
pending_sgl = NULL ;
pending_len = 0 ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:48 +03:00
if ( divs [ i ] - > flush_type = = FLUSH_TYPE_REIMPORT ) {
/* Test ->export() and ->import() */
testmgr_poison ( hashstate + statesize ,
TESTMGR_POISON_LEN ) ;
err = crypto_ahash_export ( req , hashstate ) ;
err = check_nonfinal_hash_op ( " export " , err ,
result , digestsize ,
driver , vec_num , cfg ) ;
if ( err )
return err ;
if ( ! testmgr_is_poison ( hashstate + statesize ,
TESTMGR_POISON_LEN ) ) {
pr_err ( " alg: hash: %s export() overran state buffer on test vector %u, cfg= \" %s \" \n " ,
driver , vec_num , cfg - > name ) ;
return - EOVERFLOW ;
2008-07-31 13:08:25 +04:00
}
2018-07-01 10:02:35 +03:00
2019-02-01 10:51:48 +03:00
testmgr_poison ( req - > __ctx , crypto_ahash_reqsize ( tfm ) ) ;
err = crypto_ahash_import ( req , hashstate ) ;
err = check_nonfinal_hash_op ( " import " , err ,
result , digestsize ,
driver , vec_num , cfg ) ;
if ( err )
return err ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:48 +03:00
if ( pending_sgl = = NULL )
pending_sgl = & tsgl - > sgl [ i ] ;
pending_len + = tsgl - > sgl [ i ] . length ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
ahash_request_set_callback ( req , req_flags , crypto_req_done , & wait ) ;
ahash_request_set_crypt ( req , pending_sgl , result , pending_len ) ;
if ( cfg - > finalization_type = = FINALIZATION_TYPE_FINAL ) {
/* finish with update() and final() */
2019-03-13 08:12:52 +03:00
err = do_ahash_op ( crypto_ahash_update , req , & wait , cfg - > nosimd ) ;
2019-02-01 10:51:48 +03:00
err = check_nonfinal_hash_op ( " update " , err , result , digestsize ,
driver , vec_num , cfg ) ;
if ( err )
return err ;
2019-03-13 08:12:52 +03:00
err = do_ahash_op ( crypto_ahash_final , req , & wait , cfg - > nosimd ) ;
2019-02-01 10:51:48 +03:00
if ( err ) {
pr_err ( " alg: hash: %s final() failed with err %d on test vector %u, cfg= \" %s \" \n " ,
driver , err , vec_num , cfg - > name ) ;
return err ;
}
} else {
/* finish with finup() */
2019-03-13 08:12:52 +03:00
err = do_ahash_op ( crypto_ahash_finup , req , & wait , cfg - > nosimd ) ;
2019-02-01 10:51:48 +03:00
if ( err ) {
pr_err ( " alg: hash: %s finup() failed with err %d on test vector %u, cfg= \" %s \" \n " ,
driver , err , vec_num , cfg - > name ) ;
return err ;
2008-07-31 13:08:25 +04:00
}
}
2019-02-01 10:51:48 +03:00
result_ready :
/* Check that the algorithm produced the correct digest */
if ( memcmp ( result , vec - > digest , digestsize ) ! = 0 ) {
pr_err ( " alg: hash: %s test failed (wrong result) on test vector %u, cfg= \" %s \" \n " ,
driver , vec_num , cfg - > name ) ;
return - EINVAL ;
}
if ( ! testmgr_is_poison ( & result [ digestsize ] , TESTMGR_POISON_LEN ) ) {
pr_err ( " alg: hash: %s overran result buffer on test vector %u, cfg= \" %s \" \n " ,
driver , vec_num , cfg - > name ) ;
return - EOVERFLOW ;
}
2013-06-13 18:37:55 +04:00
2019-02-01 10:51:48 +03:00
return 0 ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
static int test_hash_vec ( const char * driver , const struct hash_testvec * vec ,
unsigned int vec_num , struct ahash_request * req ,
struct test_sglist * tsgl , u8 * hashstate )
{
unsigned int i ;
int err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:48 +03:00
for ( i = 0 ; i < ARRAY_SIZE ( default_hash_testvec_configs ) ; i + + ) {
err = test_hash_vec_cfg ( driver , vec , vec_num ,
& default_hash_testvec_configs [ i ] ,
req , tsgl , hashstate ) ;
if ( err )
return err ;
}
2014-08-08 15:27:50 +04:00
2019-02-01 10:51:48 +03:00
# ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
if ( ! noextratests ) {
struct testvec_config cfg ;
char cfgname [ TESTVEC_CONFIG_NAMELEN ] ;
2014-08-08 15:27:50 +04:00
2019-02-01 10:51:48 +03:00
for ( i = 0 ; i < fuzz_iterations ; i + + ) {
generate_random_testvec_config ( & cfg , cfgname ,
sizeof ( cfgname ) ) ;
err = test_hash_vec_cfg ( driver , vec , vec_num , & cfg ,
req , tsgl , hashstate ) ;
if ( err )
return err ;
2016-02-03 13:26:57 +03:00
}
}
2019-02-01 10:51:48 +03:00
# endif
return 0 ;
}
2016-02-03 13:26:57 +03:00
2019-02-01 10:51:48 +03:00
static int __alg_test_hash ( const struct hash_testvec * vecs ,
unsigned int num_vecs , const char * driver ,
u32 type , u32 mask )
{
struct crypto_ahash * tfm ;
struct ahash_request * req = NULL ;
struct test_sglist * tsgl = NULL ;
u8 * hashstate = NULL ;
unsigned int i ;
int err ;
2016-02-03 13:26:57 +03:00
2019-02-01 10:51:48 +03:00
tfm = crypto_alloc_ahash ( driver , type , mask ) ;
if ( IS_ERR ( tfm ) ) {
pr_err ( " alg: hash: failed to allocate transform for %s: %ld \n " ,
driver , PTR_ERR ( tfm ) ) ;
return PTR_ERR ( tfm ) ;
}
2016-02-03 13:26:57 +03:00
2019-02-01 10:51:48 +03:00
req = ahash_request_alloc ( tfm , GFP_KERNEL ) ;
if ( ! req ) {
pr_err ( " alg: hash: failed to allocate request for %s \n " ,
driver ) ;
err = - ENOMEM ;
goto out ;
}
2016-02-03 13:26:57 +03:00
2019-02-01 10:51:48 +03:00
tsgl = kmalloc ( sizeof ( * tsgl ) , GFP_KERNEL ) ;
if ( ! tsgl | | init_test_sglist ( tsgl ) ! = 0 ) {
pr_err ( " alg: hash: failed to allocate test buffers for %s \n " ,
driver ) ;
kfree ( tsgl ) ;
tsgl = NULL ;
err = - ENOMEM ;
goto out ;
}
2016-02-03 13:26:57 +03:00
2019-02-01 10:51:48 +03:00
hashstate = kmalloc ( crypto_ahash_statesize ( tfm ) + TESTMGR_POISON_LEN ,
GFP_KERNEL ) ;
if ( ! hashstate ) {
pr_err ( " alg: hash: failed to allocate hash state buffer for %s \n " ,
driver ) ;
err = - ENOMEM ;
goto out ;
}
2016-02-03 13:26:57 +03:00
2019-02-01 10:51:48 +03:00
for ( i = 0 ; i < num_vecs ; i + + ) {
err = test_hash_vec ( driver , & vecs [ i ] , i , req , tsgl , hashstate ) ;
if ( err )
2014-08-08 15:27:50 +04:00
goto out ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:48 +03:00
err = 0 ;
2008-07-31 13:08:25 +04:00
out :
2019-02-01 10:51:48 +03:00
kfree ( hashstate ) ;
if ( tsgl ) {
destroy_test_sglist ( tsgl ) ;
kfree ( tsgl ) ;
}
2008-07-31 13:08:25 +04:00
ahash_request_free ( req ) ;
2019-02-01 10:51:48 +03:00
crypto_free_ahash ( tfm ) ;
return err ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:48 +03:00
static int alg_test_hash ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask )
2013-06-13 18:37:55 +04:00
{
2019-02-01 10:51:48 +03:00
const struct hash_testvec * template = desc - > suite . hash . vecs ;
unsigned int tcount = desc - > suite . hash . count ;
unsigned int nr_unkeyed , nr_keyed ;
int err ;
2013-06-13 18:37:55 +04:00
2019-02-01 10:51:48 +03:00
/*
* For OPTIONAL_KEY algorithms , we have to do all the unkeyed tests
* first , before setting a key on the tfm . To make this easier , we
* require that the unkeyed test vectors ( if any ) are listed first .
*/
2013-06-13 18:37:55 +04:00
2019-02-01 10:51:48 +03:00
for ( nr_unkeyed = 0 ; nr_unkeyed < tcount ; nr_unkeyed + + ) {
if ( template [ nr_unkeyed ] . ksize )
break ;
}
for ( nr_keyed = 0 ; nr_unkeyed + nr_keyed < tcount ; nr_keyed + + ) {
if ( ! template [ nr_unkeyed + nr_keyed ] . ksize ) {
pr_err ( " alg: hash: test vectors for %s out of order, "
" unkeyed ones must come first \n " , desc - > alg ) ;
return - EINVAL ;
}
}
2013-06-13 18:37:55 +04:00
2019-02-01 10:51:48 +03:00
err = 0 ;
if ( nr_unkeyed ) {
err = __alg_test_hash ( template , nr_unkeyed , driver , type , mask ) ;
template + = nr_unkeyed ;
2013-06-13 18:37:55 +04:00
}
2019-02-01 10:51:48 +03:00
if ( ! err & & nr_keyed )
err = __alg_test_hash ( template , nr_keyed , driver , type , mask ) ;
return err ;
2013-06-13 18:37:55 +04:00
}
2019-02-01 10:51:47 +03:00
static int test_aead_vec_cfg ( const char * driver , int enc ,
const struct aead_testvec * vec ,
unsigned int vec_num ,
const struct testvec_config * cfg ,
struct aead_request * req ,
struct cipher_test_sglists * tsgls )
2008-07-31 13:08:25 +04:00
{
2019-02-01 10:51:47 +03:00
struct crypto_aead * tfm = crypto_aead_reqtfm ( req ) ;
const unsigned int alignmask = crypto_aead_alignmask ( tfm ) ;
const unsigned int ivsize = crypto_aead_ivsize ( tfm ) ;
const unsigned int authsize = vec - > clen - vec - > plen ;
const u32 req_flags = CRYPTO_TFM_REQ_MAY_BACKLOG | cfg - > req_flags ;
const char * op = enc ? " encryption " : " decryption " ;
DECLARE_CRYPTO_WAIT ( wait ) ;
u8 _iv [ 3 * ( MAX_ALGAPI_ALIGNMASK + 1 ) + MAX_IVLEN ] ;
u8 * iv = PTR_ALIGN ( & _iv [ 0 ] , 2 * ( MAX_ALGAPI_ALIGNMASK + 1 ) ) +
cfg - > iv_offset +
( cfg - > iv_offset_relative_to_alignmask ? alignmask : 0 ) ;
struct kvec input [ 2 ] ;
int err ;
2012-09-21 11:26:52 +04:00
2019-02-01 10:51:47 +03:00
/* Set the key */
if ( vec - > wk )
crypto_aead_set_flags ( tfm , CRYPTO_TFM_REQ_FORBID_WEAK_KEYS ) ;
2008-07-31 13:08:25 +04:00
else
2019-02-01 10:51:47 +03:00
crypto_aead_clear_flags ( tfm , CRYPTO_TFM_REQ_FORBID_WEAK_KEYS ) ;
err = crypto_aead_setkey ( tfm , vec - > key , vec - > klen ) ;
if ( err ) {
if ( vec - > fail ) /* expectedly failed to set key? */
return 0 ;
pr_err ( " alg: aead: %s setkey failed with err %d on test vector %u; flags=%#x \n " ,
driver , err , vec_num , crypto_aead_get_flags ( tfm ) ) ;
return err ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:47 +03:00
if ( vec - > fail ) {
pr_err ( " alg: aead: %s setkey unexpectedly succeeded on test vector %u \n " ,
driver , vec_num ) ;
return - EINVAL ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:47 +03:00
/* Set the authentication tag size */
err = crypto_aead_setauthsize ( tfm , authsize ) ;
if ( err ) {
pr_err ( " alg: aead: %s setauthsize failed with err %d on test vector %u \n " ,
driver , err , vec_num ) ;
return err ;
}
2013-11-28 17:11:18 +04:00
2019-02-01 10:51:47 +03:00
/* The IV must be copied to a buffer, as the algorithm may modify it */
if ( WARN_ON ( ivsize > MAX_IVLEN ) )
return - EINVAL ;
if ( vec - > iv )
memcpy ( iv , vec - > iv , ivsize ) ;
else
memset ( iv , 0 , ivsize ) ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
/* Build the src/dst scatterlists */
input [ 0 ] . iov_base = ( void * ) vec - > assoc ;
input [ 0 ] . iov_len = vec - > alen ;
input [ 1 ] . iov_base = enc ? ( void * ) vec - > ptext : ( void * ) vec - > ctext ;
input [ 1 ] . iov_len = enc ? vec - > plen : vec - > clen ;
err = build_cipher_test_sglists ( tsgls , cfg , alignmask ,
vec - > alen + ( enc ? vec - > plen :
vec - > clen ) ,
vec - > alen + ( enc ? vec - > clen :
vec - > plen ) ,
input , 2 ) ;
if ( err ) {
pr_err ( " alg: aead: %s %s: error preparing scatterlists for test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return err ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
/* Do the actual encryption or decryption */
testmgr_poison ( req - > __ctx , crypto_aead_reqsize ( tfm ) ) ;
aead_request_set_callback ( req , req_flags , crypto_req_done , & wait ) ;
aead_request_set_crypt ( req , tsgls - > src . sgl_ptr , tsgls - > dst . sgl_ptr ,
enc ? vec - > plen : vec - > clen , iv ) ;
aead_request_set_ad ( req , vec - > alen ) ;
2019-03-13 08:12:52 +03:00
if ( cfg - > nosimd )
crypto_disable_simd_for_test ( ) ;
err = enc ? crypto_aead_encrypt ( req ) : crypto_aead_decrypt ( req ) ;
if ( cfg - > nosimd )
crypto_reenable_simd_for_test ( ) ;
err = crypto_wait_req ( err , & wait ) ;
2019-02-01 10:51:47 +03:00
if ( err ) {
if ( err = = - EBADMSG & & vec - > novrfy )
return 0 ;
pr_err ( " alg: aead: %s %s failed with err %d on test vector %u, cfg= \" %s \" \n " ,
driver , op , err , vec_num , cfg - > name ) ;
return err ;
}
if ( vec - > novrfy ) {
pr_err ( " alg: aead: %s %s unexpectedly succeeded on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return - EINVAL ;
2019-02-01 10:51:50 +03:00
}
/* Check that the algorithm didn't overwrite things it shouldn't have */
if ( req - > cryptlen ! = ( enc ? vec - > plen : vec - > clen ) | |
req - > assoclen ! = vec - > alen | |
req - > iv ! = iv | |
req - > src ! = tsgls - > src . sgl_ptr | |
req - > dst ! = tsgls - > dst . sgl_ptr | |
crypto_aead_reqtfm ( req ) ! = tfm | |
req - > base . complete ! = crypto_req_done | |
req - > base . flags ! = req_flags | |
req - > base . data ! = & wait ) {
pr_err ( " alg: aead: %s %s corrupted request struct on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
if ( req - > cryptlen ! = ( enc ? vec - > plen : vec - > clen ) )
pr_err ( " alg: aead: changed 'req->cryptlen' \n " ) ;
if ( req - > assoclen ! = vec - > alen )
pr_err ( " alg: aead: changed 'req->assoclen' \n " ) ;
if ( req - > iv ! = iv )
pr_err ( " alg: aead: changed 'req->iv' \n " ) ;
if ( req - > src ! = tsgls - > src . sgl_ptr )
pr_err ( " alg: aead: changed 'req->src' \n " ) ;
if ( req - > dst ! = tsgls - > dst . sgl_ptr )
pr_err ( " alg: aead: changed 'req->dst' \n " ) ;
if ( crypto_aead_reqtfm ( req ) ! = tfm )
pr_err ( " alg: aead: changed 'req->base.tfm' \n " ) ;
if ( req - > base . complete ! = crypto_req_done )
pr_err ( " alg: aead: changed 'req->base.complete' \n " ) ;
if ( req - > base . flags ! = req_flags )
pr_err ( " alg: aead: changed 'req->base.flags' \n " ) ;
if ( req - > base . data ! = & wait )
pr_err ( " alg: aead: changed 'req->base.data' \n " ) ;
return - EINVAL ;
}
if ( is_test_sglist_corrupted ( & tsgls - > src ) ) {
pr_err ( " alg: aead: %s %s corrupted src sgl on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return - EINVAL ;
}
if ( tsgls - > dst . sgl_ptr ! = tsgls - > src . sgl & &
is_test_sglist_corrupted ( & tsgls - > dst ) ) {
pr_err ( " alg: aead: %s %s corrupted dst sgl on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return - EINVAL ;
2019-02-01 10:51:47 +03:00
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
/* Check for the correct output (ciphertext or plaintext) */
err = verify_correct_output ( & tsgls - > dst , enc ? vec - > ctext : vec - > ptext ,
enc ? vec - > clen : vec - > plen ,
vec - > alen , enc | | ! cfg - > inplace ) ;
if ( err = = - EOVERFLOW ) {
pr_err ( " alg: aead: %s %s overran dst buffer on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return err ;
}
if ( err ) {
pr_err ( " alg: aead: %s %s test failed (wrong result) on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return err ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
return 0 ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
static int test_aead_vec ( const char * driver , int enc ,
const struct aead_testvec * vec , unsigned int vec_num ,
struct aead_request * req ,
struct cipher_test_sglists * tsgls )
{
unsigned int i ;
int err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
if ( enc & & vec - > novrfy )
return 0 ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
for ( i = 0 ; i < ARRAY_SIZE ( default_cipher_testvec_configs ) ; i + + ) {
err = test_aead_vec_cfg ( driver , enc , vec , vec_num ,
& default_cipher_testvec_configs [ i ] ,
req , tsgls ) ;
if ( err )
return err ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
# ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
if ( ! noextratests ) {
struct testvec_config cfg ;
char cfgname [ TESTVEC_CONFIG_NAMELEN ] ;
2014-07-28 14:11:23 +04:00
2019-02-01 10:51:47 +03:00
for ( i = 0 ; i < fuzz_iterations ; i + + ) {
generate_random_testvec_config ( & cfg , cfgname ,
sizeof ( cfgname ) ) ;
err = test_aead_vec_cfg ( driver , enc , vec , vec_num ,
& cfg , req , tsgls ) ;
if ( err )
return err ;
2008-07-31 13:08:25 +04:00
}
}
2019-02-01 10:51:47 +03:00
# endif
return 0 ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
static int test_aead ( const char * driver , int enc ,
const struct aead_test_suite * suite ,
struct aead_request * req ,
struct cipher_test_sglists * tsgls )
{
unsigned int i ;
int err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:47 +03:00
for ( i = 0 ; i < suite - > count ; i + + ) {
err = test_aead_vec ( driver , enc , & suite - > vecs [ i ] , i , req ,
tsgls ) ;
if ( err )
return err ;
}
return 0 ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:47 +03:00
static int alg_test_aead ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask )
2012-09-21 11:26:52 +04:00
{
2019-02-01 10:51:47 +03:00
const struct aead_test_suite * suite = & desc - > suite . aead ;
struct crypto_aead * tfm ;
struct aead_request * req = NULL ;
struct cipher_test_sglists * tsgls = NULL ;
int err ;
2012-09-21 11:26:52 +04:00
2019-02-01 10:51:47 +03:00
if ( suite - > count < = 0 ) {
pr_err ( " alg: aead: empty test suite for %s \n " , driver ) ;
return - EINVAL ;
}
2012-09-21 11:26:52 +04:00
2019-02-01 10:51:47 +03:00
tfm = crypto_alloc_aead ( driver , type , mask ) ;
if ( IS_ERR ( tfm ) ) {
pr_err ( " alg: aead: failed to allocate transform for %s: %ld \n " ,
driver , PTR_ERR ( tfm ) ) ;
return PTR_ERR ( tfm ) ;
}
2013-06-13 18:37:50 +04:00
2019-02-01 10:51:47 +03:00
req = aead_request_alloc ( tfm , GFP_KERNEL ) ;
if ( ! req ) {
pr_err ( " alg: aead: failed to allocate request for %s \n " ,
driver ) ;
err = - ENOMEM ;
goto out ;
}
2013-06-13 18:37:50 +04:00
2019-02-01 10:51:47 +03:00
tsgls = alloc_cipher_test_sglists ( ) ;
if ( ! tsgls ) {
pr_err ( " alg: aead: failed to allocate test buffers for %s \n " ,
driver ) ;
err = - ENOMEM ;
goto out ;
2013-06-13 18:37:50 +04:00
}
2019-02-01 10:51:47 +03:00
err = test_aead ( driver , ENCRYPT , suite , req , tsgls ) ;
if ( err )
goto out ;
err = test_aead ( driver , DECRYPT , suite , req , tsgls ) ;
out :
free_cipher_test_sglists ( tsgls ) ;
aead_request_free ( req ) ;
crypto_free_aead ( tfm ) ;
return err ;
2012-09-21 11:26:52 +04:00
}
2008-08-17 11:01:56 +04:00
static int test_cipher ( struct crypto_cipher * tfm , int enc ,
2017-02-25 02:46:59 +03:00
const struct cipher_testvec * template ,
unsigned int tcount )
2008-08-17 11:01:56 +04:00
{
const char * algo = crypto_tfm_alg_driver_name ( crypto_cipher_tfm ( tfm ) ) ;
unsigned int i , j , k ;
char * q ;
const char * e ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
const char * input , * result ;
2008-08-17 11:01:56 +04:00
void * data ;
2009-05-06 10:15:47 +04:00
char * xbuf [ XBUFSIZE ] ;
int ret = - ENOMEM ;
if ( testmgr_alloc_buf ( xbuf ) )
goto out_nobuf ;
2008-08-17 11:01:56 +04:00
if ( enc = = ENCRYPT )
e = " encryption " ;
else
e = " decryption " ;
j = 0 ;
for ( i = 0 ; i < tcount ; i + + ) {
2016-08-25 16:15:01 +03:00
if ( fips_enabled & & template [ i ] . fips_skip )
continue ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
input = enc ? template [ i ] . ptext : template [ i ] . ctext ;
result = enc ? template [ i ] . ctext : template [ i ] . ptext ;
2008-08-17 11:01:56 +04:00
j + + ;
2009-05-29 10:05:42 +04:00
ret = - EINVAL ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
if ( WARN_ON ( template [ i ] . len > PAGE_SIZE ) )
2009-05-29 10:05:42 +04:00
goto out ;
2008-08-17 11:01:56 +04:00
data = xbuf [ 0 ] ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
memcpy ( data , input , template [ i ] . len ) ;
2008-08-17 11:01:56 +04:00
crypto_cipher_clear_flags ( tfm , ~ 0 ) ;
if ( template [ i ] . wk )
2019-01-19 09:48:00 +03:00
crypto_cipher_set_flags ( tfm , CRYPTO_TFM_REQ_FORBID_WEAK_KEYS ) ;
2008-08-17 11:01:56 +04:00
ret = crypto_cipher_setkey ( tfm , template [ i ] . key ,
template [ i ] . klen ) ;
2016-07-29 11:32:09 +03:00
if ( template [ i ] . fail = = ! ret ) {
2008-08-17 11:01:56 +04:00
printk ( KERN_ERR " alg: cipher: setkey failed "
" on test %d for %s: flags=%x \n " , j ,
algo , crypto_cipher_get_flags ( tfm ) ) ;
goto out ;
} else if ( ret )
continue ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
for ( k = 0 ; k < template [ i ] . len ;
2008-08-17 11:01:56 +04:00
k + = crypto_cipher_blocksize ( tfm ) ) {
if ( enc )
crypto_cipher_encrypt_one ( tfm , data + k ,
data + k ) ;
else
crypto_cipher_decrypt_one ( tfm , data + k ,
data + k ) ;
}
q = data ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
if ( memcmp ( q , result , template [ i ] . len ) ) {
2008-08-17 11:01:56 +04:00
printk ( KERN_ERR " alg: cipher: Test %d failed "
" on %s for %s \n " , j , e , algo ) ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
hexdump ( q , template [ i ] . len ) ;
2008-08-17 11:01:56 +04:00
ret = - EINVAL ;
goto out ;
}
}
ret = 0 ;
out :
2009-05-06 10:15:47 +04:00
testmgr_free_buf ( xbuf ) ;
out_nobuf :
2008-08-17 11:01:56 +04:00
return ret ;
}
2019-02-01 10:51:46 +03:00
static int test_skcipher_vec_cfg ( const char * driver , int enc ,
const struct cipher_testvec * vec ,
unsigned int vec_num ,
const struct testvec_config * cfg ,
struct skcipher_request * req ,
struct cipher_test_sglists * tsgls )
2008-07-31 13:08:25 +04:00
{
2019-02-01 10:51:46 +03:00
struct crypto_skcipher * tfm = crypto_skcipher_reqtfm ( req ) ;
const unsigned int alignmask = crypto_skcipher_alignmask ( tfm ) ;
const unsigned int ivsize = crypto_skcipher_ivsize ( tfm ) ;
const u32 req_flags = CRYPTO_TFM_REQ_MAY_BACKLOG | cfg - > req_flags ;
const char * op = enc ? " encryption " : " decryption " ;
DECLARE_CRYPTO_WAIT ( wait ) ;
u8 _iv [ 3 * ( MAX_ALGAPI_ALIGNMASK + 1 ) + MAX_IVLEN ] ;
u8 * iv = PTR_ALIGN ( & _iv [ 0 ] , 2 * ( MAX_ALGAPI_ALIGNMASK + 1 ) ) +
cfg - > iv_offset +
( cfg - > iv_offset_relative_to_alignmask ? alignmask : 0 ) ;
struct kvec input ;
int err ;
2012-09-21 11:26:47 +04:00
2019-02-01 10:51:46 +03:00
/* Set the key */
if ( vec - > wk )
crypto_skcipher_set_flags ( tfm , CRYPTO_TFM_REQ_FORBID_WEAK_KEYS ) ;
2008-07-31 13:08:25 +04:00
else
2019-02-01 10:51:46 +03:00
crypto_skcipher_clear_flags ( tfm ,
CRYPTO_TFM_REQ_FORBID_WEAK_KEYS ) ;
err = crypto_skcipher_setkey ( tfm , vec - > key , vec - > klen ) ;
if ( err ) {
if ( vec - > fail ) /* expectedly failed to set key? */
return 0 ;
pr_err ( " alg: skcipher: %s setkey failed with err %d on test vector %u; flags=%#x \n " ,
driver , err , vec_num , crypto_skcipher_get_flags ( tfm ) ) ;
return err ;
}
if ( vec - > fail ) {
pr_err ( " alg: skcipher: %s setkey unexpectedly succeeded on test vector %u \n " ,
driver , vec_num ) ;
return - EINVAL ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:46 +03:00
/* The IV must be copied to a buffer, as the algorithm may modify it */
if ( ivsize ) {
if ( WARN_ON ( ivsize > MAX_IVLEN ) )
return - EINVAL ;
2019-02-14 11:03:51 +03:00
if ( vec - > generates_iv & & ! enc )
memcpy ( iv , vec - > iv_out , ivsize ) ;
else if ( vec - > iv )
2019-02-01 10:51:46 +03:00
memcpy ( iv , vec - > iv , ivsize ) ;
2008-07-31 13:08:25 +04:00
else
2019-02-01 10:51:46 +03:00
memset ( iv , 0 , ivsize ) ;
} else {
if ( vec - > generates_iv ) {
pr_err ( " alg: skcipher: %s has ivsize=0 but test vector %u generates IV! \n " ,
driver , vec_num ) ;
return - EINVAL ;
2015-06-16 12:46:46 +03:00
}
2019-02-01 10:51:46 +03:00
iv = NULL ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:46 +03:00
/* Build the src/dst scatterlists */
input . iov_base = enc ? ( void * ) vec - > ptext : ( void * ) vec - > ctext ;
input . iov_len = vec - > len ;
err = build_cipher_test_sglists ( tsgls , cfg , alignmask ,
vec - > len , vec - > len , & input , 1 ) ;
if ( err ) {
pr_err ( " alg: skcipher: %s %s: error preparing scatterlists for test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return err ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
/* Do the actual encryption or decryption */
testmgr_poison ( req - > __ctx , crypto_skcipher_reqsize ( tfm ) ) ;
skcipher_request_set_callback ( req , req_flags , crypto_req_done , & wait ) ;
skcipher_request_set_crypt ( req , tsgls - > src . sgl_ptr , tsgls - > dst . sgl_ptr ,
vec - > len , iv ) ;
2019-03-13 08:12:52 +03:00
if ( cfg - > nosimd )
crypto_disable_simd_for_test ( ) ;
err = enc ? crypto_skcipher_encrypt ( req ) : crypto_skcipher_decrypt ( req ) ;
if ( cfg - > nosimd )
crypto_reenable_simd_for_test ( ) ;
err = crypto_wait_req ( err , & wait ) ;
2019-02-01 10:51:46 +03:00
if ( err ) {
pr_err ( " alg: skcipher: %s %s failed with err %d on test vector %u, cfg= \" %s \" \n " ,
driver , op , err , vec_num , cfg - > name ) ;
return err ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:49 +03:00
/* Check that the algorithm didn't overwrite things it shouldn't have */
if ( req - > cryptlen ! = vec - > len | |
req - > iv ! = iv | |
req - > src ! = tsgls - > src . sgl_ptr | |
req - > dst ! = tsgls - > dst . sgl_ptr | |
crypto_skcipher_reqtfm ( req ) ! = tfm | |
req - > base . complete ! = crypto_req_done | |
req - > base . flags ! = req_flags | |
req - > base . data ! = & wait ) {
pr_err ( " alg: skcipher: %s %s corrupted request struct on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
if ( req - > cryptlen ! = vec - > len )
pr_err ( " alg: skcipher: changed 'req->cryptlen' \n " ) ;
if ( req - > iv ! = iv )
pr_err ( " alg: skcipher: changed 'req->iv' \n " ) ;
if ( req - > src ! = tsgls - > src . sgl_ptr )
pr_err ( " alg: skcipher: changed 'req->src' \n " ) ;
if ( req - > dst ! = tsgls - > dst . sgl_ptr )
pr_err ( " alg: skcipher: changed 'req->dst' \n " ) ;
if ( crypto_skcipher_reqtfm ( req ) ! = tfm )
pr_err ( " alg: skcipher: changed 'req->base.tfm' \n " ) ;
if ( req - > base . complete ! = crypto_req_done )
pr_err ( " alg: skcipher: changed 'req->base.complete' \n " ) ;
if ( req - > base . flags ! = req_flags )
pr_err ( " alg: skcipher: changed 'req->base.flags' \n " ) ;
if ( req - > base . data ! = & wait )
pr_err ( " alg: skcipher: changed 'req->base.data' \n " ) ;
return - EINVAL ;
}
if ( is_test_sglist_corrupted ( & tsgls - > src ) ) {
pr_err ( " alg: skcipher: %s %s corrupted src sgl on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return - EINVAL ;
}
if ( tsgls - > dst . sgl_ptr ! = tsgls - > src . sgl & &
is_test_sglist_corrupted ( & tsgls - > dst ) ) {
pr_err ( " alg: skcipher: %s %s corrupted dst sgl on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return - EINVAL ;
}
2019-02-01 10:51:46 +03:00
/* Check for the correct output (ciphertext or plaintext) */
err = verify_correct_output ( & tsgls - > dst , enc ? vec - > ctext : vec - > ptext ,
vec - > len , 0 , true ) ;
if ( err = = - EOVERFLOW ) {
pr_err ( " alg: skcipher: %s %s overran dst buffer on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return err ;
}
if ( err ) {
pr_err ( " alg: skcipher: %s %s test failed (wrong result) on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
return err ;
}
2012-09-21 11:26:47 +04:00
2019-02-01 10:51:46 +03:00
/* If applicable, check that the algorithm generated the correct IV */
2019-02-14 11:03:51 +03:00
if ( vec - > iv_out & & memcmp ( iv , vec - > iv_out , ivsize ) ! = 0 ) {
2019-02-01 10:51:46 +03:00
pr_err ( " alg: skcipher: %s %s test failed (wrong output IV) on test vector %u, cfg= \" %s \" \n " ,
driver , op , vec_num , cfg - > name ) ;
hexdump ( iv , ivsize ) ;
return - EINVAL ;
}
2012-09-21 11:26:47 +04:00
2019-02-01 10:51:46 +03:00
return 0 ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
static int test_skcipher_vec ( const char * driver , int enc ,
const struct cipher_testvec * vec ,
unsigned int vec_num ,
struct skcipher_request * req ,
struct cipher_test_sglists * tsgls )
{
unsigned int i ;
int err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
if ( fips_enabled & & vec - > fips_skip )
return 0 ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
for ( i = 0 ; i < ARRAY_SIZE ( default_cipher_testvec_configs ) ; i + + ) {
err = test_skcipher_vec_cfg ( driver , enc , vec , vec_num ,
& default_cipher_testvec_configs [ i ] ,
req , tsgls ) ;
if ( err )
return err ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
# ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
if ( ! noextratests ) {
struct testvec_config cfg ;
char cfgname [ TESTVEC_CONFIG_NAMELEN ] ;
for ( i = 0 ; i < fuzz_iterations ; i + + ) {
generate_random_testvec_config ( & cfg , cfgname ,
sizeof ( cfgname ) ) ;
err = test_skcipher_vec_cfg ( driver , enc , vec , vec_num ,
& cfg , req , tsgls ) ;
if ( err )
return err ;
2008-07-31 13:08:25 +04:00
}
}
2019-02-01 10:51:46 +03:00
# endif
return 0 ;
}
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
static int test_skcipher ( const char * driver , int enc ,
const struct cipher_test_suite * suite ,
struct skcipher_request * req ,
struct cipher_test_sglists * tsgls )
{
unsigned int i ;
int err ;
2008-07-31 13:08:25 +04:00
2019-02-01 10:51:46 +03:00
for ( i = 0 ; i < suite - > count ; i + + ) {
err = test_skcipher_vec ( driver , enc , & suite - > vecs [ i ] , i , req ,
tsgls ) ;
if ( err )
return err ;
}
return 0 ;
2008-07-31 13:08:25 +04:00
}
2019-02-01 10:51:46 +03:00
static int alg_test_skcipher ( const struct alg_test_desc * desc ,
const char * driver , u32 type , u32 mask )
2012-09-21 11:26:47 +04:00
{
2019-02-01 10:51:46 +03:00
const struct cipher_test_suite * suite = & desc - > suite . cipher ;
struct crypto_skcipher * tfm ;
struct skcipher_request * req = NULL ;
struct cipher_test_sglists * tsgls = NULL ;
int err ;
2012-09-21 11:26:47 +04:00
2019-02-01 10:51:46 +03:00
if ( suite - > count < = 0 ) {
pr_err ( " alg: skcipher: empty test suite for %s \n " , driver ) ;
return - EINVAL ;
}
2012-09-21 11:26:47 +04:00
2019-02-01 10:51:46 +03:00
tfm = crypto_alloc_skcipher ( driver , type , mask ) ;
if ( IS_ERR ( tfm ) ) {
pr_err ( " alg: skcipher: failed to allocate transform for %s: %ld \n " ,
driver , PTR_ERR ( tfm ) ) ;
return PTR_ERR ( tfm ) ;
}
2013-06-13 18:37:45 +04:00
2019-02-01 10:51:46 +03:00
req = skcipher_request_alloc ( tfm , GFP_KERNEL ) ;
if ( ! req ) {
pr_err ( " alg: skcipher: failed to allocate request for %s \n " ,
driver ) ;
err = - ENOMEM ;
goto out ;
}
2013-06-13 18:37:45 +04:00
2019-02-01 10:51:46 +03:00
tsgls = alloc_cipher_test_sglists ( ) ;
if ( ! tsgls ) {
pr_err ( " alg: skcipher: failed to allocate test buffers for %s \n " ,
driver ) ;
err = - ENOMEM ;
goto out ;
2013-06-13 18:37:45 +04:00
}
2019-02-01 10:51:46 +03:00
err = test_skcipher ( driver , ENCRYPT , suite , req , tsgls ) ;
if ( err )
goto out ;
err = test_skcipher ( driver , DECRYPT , suite , req , tsgls ) ;
out :
free_cipher_test_sglists ( tsgls ) ;
skcipher_request_free ( req ) ;
crypto_free_skcipher ( tfm ) ;
return err ;
2012-09-21 11:26:47 +04:00
}
2017-02-25 02:46:59 +03:00
static int test_comp ( struct crypto_comp * tfm ,
const struct comp_testvec * ctemplate ,
const struct comp_testvec * dtemplate ,
int ctcount , int dtcount )
2008-07-31 13:08:25 +04:00
{
const char * algo = crypto_tfm_alg_driver_name ( crypto_comp_tfm ( tfm ) ) ;
2018-04-11 21:28:32 +03:00
char * output , * decomp_output ;
2008-07-31 13:08:25 +04:00
unsigned int i ;
int ret ;
2018-04-11 21:28:32 +03:00
output = kmalloc ( COMP_BUF_SIZE , GFP_KERNEL ) ;
if ( ! output )
return - ENOMEM ;
decomp_output = kmalloc ( COMP_BUF_SIZE , GFP_KERNEL ) ;
if ( ! decomp_output ) {
kfree ( output ) ;
return - ENOMEM ;
}
2008-07-31 13:08:25 +04:00
for ( i = 0 ; i < ctcount ; i + + ) {
2009-03-29 11:44:19 +04:00
int ilen ;
unsigned int dlen = COMP_BUF_SIZE ;
2008-07-31 13:08:25 +04:00
2018-10-07 14:58:10 +03:00
memset ( output , 0 , COMP_BUF_SIZE ) ;
memset ( decomp_output , 0 , COMP_BUF_SIZE ) ;
2008-07-31 13:08:25 +04:00
ilen = ctemplate [ i ] . inlen ;
ret = crypto_comp_compress ( tfm , ctemplate [ i ] . input ,
2018-04-11 21:28:32 +03:00
ilen , output , & dlen ) ;
2008-07-31 13:08:25 +04:00
if ( ret ) {
printk ( KERN_ERR " alg: comp: compression failed "
" on test %d for %s: ret=%d \n " , i + 1 , algo ,
- ret ) ;
goto out ;
}
2018-04-11 21:28:32 +03:00
ilen = dlen ;
dlen = COMP_BUF_SIZE ;
ret = crypto_comp_decompress ( tfm , output ,
ilen , decomp_output , & dlen ) ;
if ( ret ) {
pr_err ( " alg: comp: compression failed: decompress: on test %d for %s failed: ret=%d \n " ,
i + 1 , algo , - ret ) ;
goto out ;
}
if ( dlen ! = ctemplate [ i ] . inlen ) {
2008-11-28 15:51:28 +03:00
printk ( KERN_ERR " alg: comp: Compression test %d "
" failed for %s: output len = %d \n " , i + 1 , algo ,
dlen ) ;
ret = - EINVAL ;
goto out ;
}
2018-04-11 21:28:32 +03:00
if ( memcmp ( decomp_output , ctemplate [ i ] . input ,
ctemplate [ i ] . inlen ) ) {
pr_err ( " alg: comp: compression failed: output differs: on test %d for %s \n " ,
i + 1 , algo ) ;
hexdump ( decomp_output , dlen ) ;
2008-07-31 13:08:25 +04:00
ret = - EINVAL ;
goto out ;
}
}
for ( i = 0 ; i < dtcount ; i + + ) {
2009-03-29 11:44:19 +04:00
int ilen ;
unsigned int dlen = COMP_BUF_SIZE ;
2008-07-31 13:08:25 +04:00
2018-10-07 14:58:10 +03:00
memset ( decomp_output , 0 , COMP_BUF_SIZE ) ;
2008-07-31 13:08:25 +04:00
ilen = dtemplate [ i ] . inlen ;
ret = crypto_comp_decompress ( tfm , dtemplate [ i ] . input ,
2018-04-11 21:28:32 +03:00
ilen , decomp_output , & dlen ) ;
2008-07-31 13:08:25 +04:00
if ( ret ) {
printk ( KERN_ERR " alg: comp: decompression failed "
" on test %d for %s: ret=%d \n " , i + 1 , algo ,
- ret ) ;
goto out ;
}
2008-11-28 15:51:28 +03:00
if ( dlen ! = dtemplate [ i ] . outlen ) {
printk ( KERN_ERR " alg: comp: Decompression test %d "
" failed for %s: output len = %d \n " , i + 1 , algo ,
dlen ) ;
ret = - EINVAL ;
goto out ;
}
2018-04-11 21:28:32 +03:00
if ( memcmp ( decomp_output , dtemplate [ i ] . output , dlen ) ) {
2008-07-31 13:08:25 +04:00
printk ( KERN_ERR " alg: comp: Decompression test %d "
" failed for %s \n " , i + 1 , algo ) ;
2018-04-11 21:28:32 +03:00
hexdump ( decomp_output , dlen ) ;
2008-07-31 13:08:25 +04:00
ret = - EINVAL ;
goto out ;
}
}
ret = 0 ;
out :
2018-04-11 21:28:32 +03:00
kfree ( decomp_output ) ;
kfree ( output ) ;
2008-07-31 13:08:25 +04:00
return ret ;
}
2017-02-25 02:46:59 +03:00
static int test_acomp ( struct crypto_acomp * tfm ,
2018-04-11 21:28:32 +03:00
const struct comp_testvec * ctemplate ,
2017-02-25 02:46:59 +03:00
const struct comp_testvec * dtemplate ,
int ctcount , int dtcount )
2016-10-21 15:19:54 +03:00
{
const char * algo = crypto_tfm_alg_driver_name ( crypto_acomp_tfm ( tfm ) ) ;
unsigned int i ;
2017-04-19 16:27:18 +03:00
char * output , * decomp_out ;
2016-10-21 15:19:54 +03:00
int ret ;
struct scatterlist src , dst ;
struct acomp_req * req ;
2017-10-18 10:00:43 +03:00
struct crypto_wait wait ;
2016-10-21 15:19:54 +03:00
2016-11-23 21:24:35 +03:00
output = kmalloc ( COMP_BUF_SIZE , GFP_KERNEL ) ;
if ( ! output )
return - ENOMEM ;
2017-04-19 16:27:18 +03:00
decomp_out = kmalloc ( COMP_BUF_SIZE , GFP_KERNEL ) ;
if ( ! decomp_out ) {
kfree ( output ) ;
return - ENOMEM ;
}
2016-10-21 15:19:54 +03:00
for ( i = 0 ; i < ctcount ; i + + ) {
unsigned int dlen = COMP_BUF_SIZE ;
int ilen = ctemplate [ i ] . inlen ;
2016-12-21 23:32:54 +03:00
void * input_vec ;
2016-10-21 15:19:54 +03:00
2016-12-30 23:12:00 +03:00
input_vec = kmemdup ( ctemplate [ i ] . input , ilen , GFP_KERNEL ) ;
2016-12-21 23:32:54 +03:00
if ( ! input_vec ) {
ret = - ENOMEM ;
goto out ;
}
2016-11-23 21:24:35 +03:00
memset ( output , 0 , dlen ) ;
2017-10-18 10:00:43 +03:00
crypto_init_wait ( & wait ) ;
2016-12-21 23:32:54 +03:00
sg_init_one ( & src , input_vec , ilen ) ;
2016-10-21 15:19:54 +03:00
sg_init_one ( & dst , output , dlen ) ;
req = acomp_request_alloc ( tfm ) ;
if ( ! req ) {
pr_err ( " alg: acomp: request alloc failed for %s \n " ,
algo ) ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
ret = - ENOMEM ;
goto out ;
}
acomp_request_set_params ( req , & src , & dst , ilen , dlen ) ;
acomp_request_set_callback ( req , CRYPTO_TFM_REQ_MAY_BACKLOG ,
2017-10-18 10:00:43 +03:00
crypto_req_done , & wait ) ;
2016-10-21 15:19:54 +03:00
2017-10-18 10:00:43 +03:00
ret = crypto_wait_req ( crypto_acomp_compress ( req ) , & wait ) ;
2016-10-21 15:19:54 +03:00
if ( ret ) {
pr_err ( " alg: acomp: compression failed on test %d for %s: ret=%d \n " ,
i + 1 , algo , - ret ) ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
goto out ;
}
2017-04-19 16:27:18 +03:00
ilen = req - > dlen ;
dlen = COMP_BUF_SIZE ;
sg_init_one ( & src , output , ilen ) ;
sg_init_one ( & dst , decomp_out , dlen ) ;
2017-10-18 10:00:43 +03:00
crypto_init_wait ( & wait ) ;
2017-04-19 16:27:18 +03:00
acomp_request_set_params ( req , & src , & dst , ilen , dlen ) ;
2017-10-18 10:00:43 +03:00
ret = crypto_wait_req ( crypto_acomp_decompress ( req ) , & wait ) ;
2017-04-19 16:27:18 +03:00
if ( ret ) {
pr_err ( " alg: acomp: compression failed on test %d for %s: ret=%d \n " ,
i + 1 , algo , - ret ) ;
kfree ( input_vec ) ;
acomp_request_free ( req ) ;
goto out ;
}
if ( req - > dlen ! = ctemplate [ i ] . inlen ) {
2016-10-21 15:19:54 +03:00
pr_err ( " alg: acomp: Compression test %d failed for %s: output len = %d \n " ,
i + 1 , algo , req - > dlen ) ;
ret = - EINVAL ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
goto out ;
}
2017-04-19 16:27:18 +03:00
if ( memcmp ( input_vec , decomp_out , req - > dlen ) ) {
2016-10-21 15:19:54 +03:00
pr_err ( " alg: acomp: Compression test %d failed for %s \n " ,
i + 1 , algo ) ;
hexdump ( output , req - > dlen ) ;
ret = - EINVAL ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
goto out ;
}
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
}
for ( i = 0 ; i < dtcount ; i + + ) {
unsigned int dlen = COMP_BUF_SIZE ;
int ilen = dtemplate [ i ] . inlen ;
2016-12-21 23:32:54 +03:00
void * input_vec ;
2016-12-30 23:12:00 +03:00
input_vec = kmemdup ( dtemplate [ i ] . input , ilen , GFP_KERNEL ) ;
2016-12-21 23:32:54 +03:00
if ( ! input_vec ) {
ret = - ENOMEM ;
goto out ;
}
2016-10-21 15:19:54 +03:00
2016-11-23 21:24:35 +03:00
memset ( output , 0 , dlen ) ;
2017-10-18 10:00:43 +03:00
crypto_init_wait ( & wait ) ;
2016-12-21 23:32:54 +03:00
sg_init_one ( & src , input_vec , ilen ) ;
2016-10-21 15:19:54 +03:00
sg_init_one ( & dst , output , dlen ) ;
req = acomp_request_alloc ( tfm ) ;
if ( ! req ) {
pr_err ( " alg: acomp: request alloc failed for %s \n " ,
algo ) ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
ret = - ENOMEM ;
goto out ;
}
acomp_request_set_params ( req , & src , & dst , ilen , dlen ) ;
acomp_request_set_callback ( req , CRYPTO_TFM_REQ_MAY_BACKLOG ,
2017-10-18 10:00:43 +03:00
crypto_req_done , & wait ) ;
2016-10-21 15:19:54 +03:00
2017-10-18 10:00:43 +03:00
ret = crypto_wait_req ( crypto_acomp_decompress ( req ) , & wait ) ;
2016-10-21 15:19:54 +03:00
if ( ret ) {
pr_err ( " alg: acomp: decompression failed on test %d for %s: ret=%d \n " ,
i + 1 , algo , - ret ) ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
goto out ;
}
if ( req - > dlen ! = dtemplate [ i ] . outlen ) {
pr_err ( " alg: acomp: Decompression test %d failed for %s: output len = %d \n " ,
i + 1 , algo , req - > dlen ) ;
ret = - EINVAL ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
goto out ;
}
if ( memcmp ( output , dtemplate [ i ] . output , req - > dlen ) ) {
pr_err ( " alg: acomp: Decompression test %d failed for %s \n " ,
i + 1 , algo ) ;
hexdump ( output , req - > dlen ) ;
ret = - EINVAL ;
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
goto out ;
}
2016-12-21 23:32:54 +03:00
kfree ( input_vec ) ;
2016-10-21 15:19:54 +03:00
acomp_request_free ( req ) ;
}
ret = 0 ;
out :
2017-04-19 16:27:18 +03:00
kfree ( decomp_out ) ;
2016-11-23 21:24:35 +03:00
kfree ( output ) ;
2016-10-21 15:19:54 +03:00
return ret ;
}
2017-02-25 02:46:59 +03:00
static int test_cprng ( struct crypto_rng * tfm ,
const struct cprng_testvec * template ,
2009-05-04 15:44:50 +04:00
unsigned int tcount )
{
const char * algo = crypto_tfm_alg_driver_name ( crypto_rng_tfm ( tfm ) ) ;
2009-10-27 14:04:42 +03:00
int err = 0 , i , j , seedsize ;
2009-05-04 15:44:50 +04:00
u8 * seed ;
char result [ 32 ] ;
seedsize = crypto_rng_seedsize ( tfm ) ;
seed = kmalloc ( seedsize , GFP_KERNEL ) ;
if ( ! seed ) {
printk ( KERN_ERR " alg: cprng: Failed to allocate seed space "
" for %s \n " , algo ) ;
return - ENOMEM ;
}
for ( i = 0 ; i < tcount ; i + + ) {
memset ( result , 0 , 32 ) ;
memcpy ( seed , template [ i ] . v , template [ i ] . vlen ) ;
memcpy ( seed + template [ i ] . vlen , template [ i ] . key ,
template [ i ] . klen ) ;
memcpy ( seed + template [ i ] . vlen + template [ i ] . klen ,
template [ i ] . dt , template [ i ] . dtlen ) ;
err = crypto_rng_reset ( tfm , seed , seedsize ) ;
if ( err ) {
printk ( KERN_ERR " alg: cprng: Failed to reset rng "
" for %s \n " , algo ) ;
goto out ;
}
for ( j = 0 ; j < template [ i ] . loops ; j + + ) {
err = crypto_rng_get_bytes ( tfm , result ,
template [ i ] . rlen ) ;
2015-03-10 19:00:36 +03:00
if ( err < 0 ) {
2009-05-04 15:44:50 +04:00
printk ( KERN_ERR " alg: cprng: Failed to obtain "
" the correct amount of random data for "
2015-03-10 19:00:36 +03:00
" %s (requested %d) \n " , algo ,
template [ i ] . rlen ) ;
2009-05-04 15:44:50 +04:00
goto out ;
}
}
err = memcmp ( result , template [ i ] . result ,
template [ i ] . rlen ) ;
if ( err ) {
printk ( KERN_ERR " alg: cprng: Test %d failed for %s \n " ,
i , algo ) ;
hexdump ( result , template [ i ] . rlen ) ;
err = - EINVAL ;
goto out ;
}
}
out :
kfree ( seed ) ;
return err ;
}
2008-07-31 13:08:25 +04:00
static int alg_test_cipher ( const struct alg_test_desc * desc ,
const char * driver , u32 type , u32 mask )
{
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
const struct cipher_test_suite * suite = & desc - > suite . cipher ;
2008-08-17 11:01:56 +04:00
struct crypto_cipher * tfm ;
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
int err ;
2008-07-31 13:08:25 +04:00
2016-11-22 15:08:31 +03:00
tfm = crypto_alloc_cipher ( driver , type , mask ) ;
2008-07-31 13:08:25 +04:00
if ( IS_ERR ( tfm ) ) {
printk ( KERN_ERR " alg: cipher: Failed to load transform for "
" %s: %ld \n " , driver , PTR_ERR ( tfm ) ) ;
return PTR_ERR ( tfm ) ;
}
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
err = test_cipher ( tfm , ENCRYPT , suite - > vecs , suite - > count ) ;
if ( ! err )
err = test_cipher ( tfm , DECRYPT , suite - > vecs , suite - > count ) ;
2008-07-31 13:08:25 +04:00
2008-08-17 11:01:56 +04:00
crypto_free_cipher ( tfm ) ;
return err ;
}
2008-07-31 13:08:25 +04:00
static int alg_test_comp ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask )
{
2016-10-21 15:19:54 +03:00
struct crypto_comp * comp ;
struct crypto_acomp * acomp ;
2008-07-31 13:08:25 +04:00
int err ;
2016-10-21 15:19:54 +03:00
u32 algo_type = type & CRYPTO_ALG_TYPE_ACOMPRESS_MASK ;
if ( algo_type = = CRYPTO_ALG_TYPE_ACOMPRESS ) {
acomp = crypto_alloc_acomp ( driver , type , mask ) ;
if ( IS_ERR ( acomp ) ) {
pr_err ( " alg: acomp: Failed to load transform for %s: %ld \n " ,
driver , PTR_ERR ( acomp ) ) ;
return PTR_ERR ( acomp ) ;
}
err = test_acomp ( acomp , desc - > suite . comp . comp . vecs ,
desc - > suite . comp . decomp . vecs ,
desc - > suite . comp . comp . count ,
desc - > suite . comp . decomp . count ) ;
crypto_free_acomp ( acomp ) ;
} else {
comp = crypto_alloc_comp ( driver , type , mask ) ;
if ( IS_ERR ( comp ) ) {
pr_err ( " alg: comp: Failed to load transform for %s: %ld \n " ,
driver , PTR_ERR ( comp ) ) ;
return PTR_ERR ( comp ) ;
}
2008-07-31 13:08:25 +04:00
2016-10-21 15:19:54 +03:00
err = test_comp ( comp , desc - > suite . comp . comp . vecs ,
desc - > suite . comp . decomp . vecs ,
desc - > suite . comp . comp . count ,
desc - > suite . comp . decomp . count ) ;
2008-07-31 13:08:25 +04:00
2016-10-21 15:19:54 +03:00
crypto_free_comp ( comp ) ;
}
2008-07-31 13:08:25 +04:00
return err ;
}
2008-11-07 09:58:52 +03:00
static int alg_test_crc32c ( const struct alg_test_desc * desc ,
const char * driver , u32 type , u32 mask )
{
struct crypto_shash * tfm ;
2019-01-10 23:17:55 +03:00
__le32 val ;
2008-11-07 09:58:52 +03:00
int err ;
err = alg_test_hash ( desc , driver , type , mask ) ;
if ( err )
2019-01-24 07:57:35 +03:00
return err ;
2008-11-07 09:58:52 +03:00
2016-11-22 15:08:31 +03:00
tfm = crypto_alloc_shash ( driver , type , mask ) ;
2008-11-07 09:58:52 +03:00
if ( IS_ERR ( tfm ) ) {
2019-01-24 07:57:35 +03:00
if ( PTR_ERR ( tfm ) = = - ENOENT ) {
/*
* This crc32c implementation is only available through
* ahash API , not the shash API , so the remaining part
* of the test is not applicable to it .
*/
return 0 ;
}
2008-11-07 09:58:52 +03:00
printk ( KERN_ERR " alg: crc32c: Failed to load transform for %s: "
" %ld \n " , driver , PTR_ERR ( tfm ) ) ;
2019-01-24 07:57:35 +03:00
return PTR_ERR ( tfm ) ;
2008-11-07 09:58:52 +03:00
}
do {
2012-07-02 15:48:30 +04:00
SHASH_DESC_ON_STACK ( shash , tfm ) ;
u32 * ctx = ( u32 * ) shash_desc_ctx ( shash ) ;
2008-11-07 09:58:52 +03:00
2012-07-02 15:48:30 +04:00
shash - > tfm = tfm ;
shash - > flags = 0 ;
2008-11-07 09:58:52 +03:00
2019-01-10 23:17:55 +03:00
* ctx = 420553207 ;
2012-07-02 15:48:30 +04:00
err = crypto_shash_final ( shash , ( u8 * ) & val ) ;
2008-11-07 09:58:52 +03:00
if ( err ) {
printk ( KERN_ERR " alg: crc32c: Operation failed for "
" %s: %d \n " , driver , err ) ;
break ;
}
2019-01-10 23:17:55 +03:00
if ( val ! = cpu_to_le32 ( ~ 420553207 ) ) {
pr_err ( " alg: crc32c: Test failed for %s: %u \n " ,
driver , le32_to_cpu ( val ) ) ;
2008-11-07 09:58:52 +03:00
err = - EINVAL ;
}
} while ( 0 ) ;
crypto_free_shash ( tfm ) ;
return err ;
}
2009-05-04 15:44:50 +04:00
static int alg_test_cprng ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask )
{
struct crypto_rng * rng ;
int err ;
2016-11-22 15:08:31 +03:00
rng = crypto_alloc_rng ( driver , type , mask ) ;
2009-05-04 15:44:50 +04:00
if ( IS_ERR ( rng ) ) {
printk ( KERN_ERR " alg: cprng: Failed to load transform for %s: "
" %ld \n " , driver , PTR_ERR ( rng ) ) ;
return PTR_ERR ( rng ) ;
}
err = test_cprng ( rng , desc - > suite . cprng . vecs , desc - > suite . cprng . count ) ;
crypto_free_rng ( rng ) ;
return err ;
}
2014-05-31 19:25:36 +04:00
2017-02-25 02:46:59 +03:00
static int drbg_cavs_test ( const struct drbg_testvec * test , int pr ,
2014-05-31 19:25:36 +04:00
const char * driver , u32 type , u32 mask )
{
int ret = - EAGAIN ;
struct crypto_rng * drng ;
struct drbg_test_data test_data ;
struct drbg_string addtl , pers , testentropy ;
unsigned char * buf = kzalloc ( test - > expectedlen , GFP_KERNEL ) ;
if ( ! buf )
return - ENOMEM ;
2016-11-22 15:08:31 +03:00
drng = crypto_alloc_rng ( driver , type , mask ) ;
2014-05-31 19:25:36 +04:00
if ( IS_ERR ( drng ) ) {
2014-07-29 23:47:56 +04:00
printk ( KERN_ERR " alg: drbg: could not allocate DRNG handle for "
2014-05-31 19:25:36 +04:00
" %s \n " , driver ) ;
kzfree ( buf ) ;
return - ENOMEM ;
}
test_data . testentropy = & testentropy ;
drbg_string_fill ( & testentropy , test - > entropy , test - > entropylen ) ;
drbg_string_fill ( & pers , test - > pers , test - > perslen ) ;
ret = crypto_drbg_reset_test ( drng , & pers , & test_data ) ;
if ( ret ) {
printk ( KERN_ERR " alg: drbg: Failed to reset rng \n " ) ;
goto outbuf ;
}
drbg_string_fill ( & addtl , test - > addtla , test - > addtllen ) ;
if ( pr ) {
drbg_string_fill ( & testentropy , test - > entpra , test - > entprlen ) ;
ret = crypto_drbg_get_bytes_addtl_test ( drng ,
buf , test - > expectedlen , & addtl , & test_data ) ;
} else {
ret = crypto_drbg_get_bytes_addtl ( drng ,
buf , test - > expectedlen , & addtl ) ;
}
2015-03-10 19:00:36 +03:00
if ( ret < 0 ) {
2014-07-29 23:47:56 +04:00
printk ( KERN_ERR " alg: drbg: could not obtain random data for "
2014-05-31 19:25:36 +04:00
" driver %s \n " , driver ) ;
goto outbuf ;
}
drbg_string_fill ( & addtl , test - > addtlb , test - > addtllen ) ;
if ( pr ) {
drbg_string_fill ( & testentropy , test - > entprb , test - > entprlen ) ;
ret = crypto_drbg_get_bytes_addtl_test ( drng ,
buf , test - > expectedlen , & addtl , & test_data ) ;
} else {
ret = crypto_drbg_get_bytes_addtl ( drng ,
buf , test - > expectedlen , & addtl ) ;
}
2015-03-10 19:00:36 +03:00
if ( ret < 0 ) {
2014-07-29 23:47:56 +04:00
printk ( KERN_ERR " alg: drbg: could not obtain random data for "
2014-05-31 19:25:36 +04:00
" driver %s \n " , driver ) ;
goto outbuf ;
}
ret = memcmp ( test - > expected , buf , test - > expectedlen ) ;
outbuf :
crypto_free_rng ( drng ) ;
kzfree ( buf ) ;
return ret ;
}
static int alg_test_drbg ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask )
{
int err = 0 ;
int pr = 0 ;
int i = 0 ;
2017-02-25 02:46:59 +03:00
const struct drbg_testvec * template = desc - > suite . drbg . vecs ;
2014-05-31 19:25:36 +04:00
unsigned int tcount = desc - > suite . drbg . count ;
if ( 0 = = memcmp ( driver , " drbg_pr_ " , 8 ) )
pr = 1 ;
for ( i = 0 ; i < tcount ; i + + ) {
err = drbg_cavs_test ( & template [ i ] , pr , driver , type , mask ) ;
if ( err ) {
printk ( KERN_ERR " alg: drbg: Test %d failed for %s \n " ,
i , driver ) ;
err = - EINVAL ;
break ;
}
}
return err ;
}
2017-02-25 02:46:59 +03:00
static int do_test_kpp ( struct crypto_kpp * tfm , const struct kpp_testvec * vec ,
2016-06-22 19:49:14 +03:00
const char * alg )
{
struct kpp_request * req ;
void * input_buf = NULL ;
void * output_buf = NULL ;
2017-05-30 17:52:49 +03:00
void * a_public = NULL ;
void * a_ss = NULL ;
void * shared_secret = NULL ;
2017-10-18 10:00:43 +03:00
struct crypto_wait wait ;
2016-06-22 19:49:14 +03:00
unsigned int out_len_max ;
int err = - ENOMEM ;
struct scatterlist src , dst ;
req = kpp_request_alloc ( tfm , GFP_KERNEL ) ;
if ( ! req )
return err ;
2017-10-18 10:00:43 +03:00
crypto_init_wait ( & wait ) ;
2016-06-22 19:49:14 +03:00
err = crypto_kpp_set_secret ( tfm , vec - > secret , vec - > secret_size ) ;
if ( err < 0 )
goto free_req ;
out_len_max = crypto_kpp_maxsize ( tfm ) ;
output_buf = kzalloc ( out_len_max , GFP_KERNEL ) ;
if ( ! output_buf ) {
err = - ENOMEM ;
goto free_req ;
}
/* Use appropriate parameter as base */
kpp_request_set_input ( req , NULL , 0 ) ;
sg_init_one ( & dst , output_buf , out_len_max ) ;
kpp_request_set_output ( req , & dst , out_len_max ) ;
kpp_request_set_callback ( req , CRYPTO_TFM_REQ_MAY_BACKLOG ,
2017-10-18 10:00:43 +03:00
crypto_req_done , & wait ) ;
2016-06-22 19:49:14 +03:00
2017-05-30 17:52:49 +03:00
/* Compute party A's public key */
2017-10-18 10:00:43 +03:00
err = crypto_wait_req ( crypto_kpp_generate_public_key ( req ) , & wait ) ;
2016-06-22 19:49:14 +03:00
if ( err ) {
2017-05-30 17:52:49 +03:00
pr_err ( " alg: %s: Party A: generate public key test failed. err %d \n " ,
2016-06-22 19:49:14 +03:00
alg , err ) ;
goto free_output ;
}
2017-05-30 17:52:49 +03:00
if ( vec - > genkey ) {
/* Save party A's public key */
2019-01-29 03:01:18 +03:00
a_public = kmemdup ( sg_virt ( req - > dst ) , out_len_max , GFP_KERNEL ) ;
2017-05-30 17:52:49 +03:00
if ( ! a_public ) {
err = - ENOMEM ;
goto free_output ;
}
} else {
/* Verify calculated public key */
if ( memcmp ( vec - > expected_a_public , sg_virt ( req - > dst ) ,
vec - > expected_a_public_size ) ) {
pr_err ( " alg: %s: Party A: generate public key test failed. Invalid output \n " ,
alg ) ;
err = - EINVAL ;
goto free_output ;
}
2016-06-22 19:49:14 +03:00
}
/* Calculate shared secret key by using counter part (b) public key. */
2019-01-29 03:01:18 +03:00
input_buf = kmemdup ( vec - > b_public , vec - > b_public_size , GFP_KERNEL ) ;
2016-06-22 19:49:14 +03:00
if ( ! input_buf ) {
err = - ENOMEM ;
goto free_output ;
}
sg_init_one ( & src , input_buf , vec - > b_public_size ) ;
sg_init_one ( & dst , output_buf , out_len_max ) ;
kpp_request_set_input ( req , & src , vec - > b_public_size ) ;
kpp_request_set_output ( req , & dst , out_len_max ) ;
kpp_request_set_callback ( req , CRYPTO_TFM_REQ_MAY_BACKLOG ,
2017-10-18 10:00:43 +03:00
crypto_req_done , & wait ) ;
err = crypto_wait_req ( crypto_kpp_compute_shared_secret ( req ) , & wait ) ;
2016-06-22 19:49:14 +03:00
if ( err ) {
2017-05-30 17:52:49 +03:00
pr_err ( " alg: %s: Party A: compute shared secret test failed. err %d \n " ,
2016-06-22 19:49:14 +03:00
alg , err ) ;
goto free_all ;
}
2017-05-30 17:52:49 +03:00
if ( vec - > genkey ) {
/* Save the shared secret obtained by party A */
2019-01-29 03:01:18 +03:00
a_ss = kmemdup ( sg_virt ( req - > dst ) , vec - > expected_ss_size , GFP_KERNEL ) ;
2017-05-30 17:52:49 +03:00
if ( ! a_ss ) {
err = - ENOMEM ;
goto free_all ;
}
/*
* Calculate party B ' s shared secret by using party A ' s
* public key .
*/
err = crypto_kpp_set_secret ( tfm , vec - > b_secret ,
vec - > b_secret_size ) ;
if ( err < 0 )
goto free_all ;
sg_init_one ( & src , a_public , vec - > expected_a_public_size ) ;
sg_init_one ( & dst , output_buf , out_len_max ) ;
kpp_request_set_input ( req , & src , vec - > expected_a_public_size ) ;
kpp_request_set_output ( req , & dst , out_len_max ) ;
kpp_request_set_callback ( req , CRYPTO_TFM_REQ_MAY_BACKLOG ,
2017-10-18 10:00:43 +03:00
crypto_req_done , & wait ) ;
err = crypto_wait_req ( crypto_kpp_compute_shared_secret ( req ) ,
& wait ) ;
2017-05-30 17:52:49 +03:00
if ( err ) {
pr_err ( " alg: %s: Party B: compute shared secret failed. err %d \n " ,
alg , err ) ;
goto free_all ;
}
shared_secret = a_ss ;
} else {
shared_secret = ( void * ) vec - > expected_ss ;
}
2016-06-22 19:49:14 +03:00
/*
* verify shared secret from which the user will derive
* secret key by executing whatever hash it has chosen
*/
2017-05-30 17:52:49 +03:00
if ( memcmp ( shared_secret , sg_virt ( req - > dst ) ,
2016-06-22 19:49:14 +03:00
vec - > expected_ss_size ) ) {
pr_err ( " alg: %s: compute shared secret test failed. Invalid output \n " ,
alg ) ;
err = - EINVAL ;
}
free_all :
2017-05-30 17:52:49 +03:00
kfree ( a_ss ) ;
2016-06-22 19:49:14 +03:00
kfree ( input_buf ) ;
free_output :
2017-05-30 17:52:49 +03:00
kfree ( a_public ) ;
2016-06-22 19:49:14 +03:00
kfree ( output_buf ) ;
free_req :
kpp_request_free ( req ) ;
return err ;
}
static int test_kpp ( struct crypto_kpp * tfm , const char * alg ,
2017-02-25 02:46:59 +03:00
const struct kpp_testvec * vecs , unsigned int tcount )
2016-06-22 19:49:14 +03:00
{
int ret , i ;
for ( i = 0 ; i < tcount ; i + + ) {
ret = do_test_kpp ( tfm , vecs + + , alg ) ;
if ( ret ) {
pr_err ( " alg: %s: test failed on vector %d, err=%d \n " ,
alg , i + 1 , ret ) ;
return ret ;
}
}
return 0 ;
}
static int alg_test_kpp ( const struct alg_test_desc * desc , const char * driver ,
u32 type , u32 mask )
{
struct crypto_kpp * tfm ;
int err = 0 ;
2016-11-22 15:08:31 +03:00
tfm = crypto_alloc_kpp ( driver , type , mask ) ;
2016-06-22 19:49:14 +03:00
if ( IS_ERR ( tfm ) ) {
pr_err ( " alg: kpp: Failed to load tfm for %s: %ld \n " ,
driver , PTR_ERR ( tfm ) ) ;
return PTR_ERR ( tfm ) ;
}
if ( desc - > suite . kpp . vecs )
err = test_kpp ( tfm , desc - > alg , desc - > suite . kpp . vecs ,
desc - > suite . kpp . count ) ;
crypto_free_kpp ( tfm ) ;
return err ;
}
2019-04-11 18:51:17 +03:00
static u8 * test_pack_u32 ( u8 * dst , u32 val )
{
memcpy ( dst , & val , sizeof ( val ) ) ;
return dst + sizeof ( val ) ;
}
2016-06-29 14:32:20 +03:00
static int test_akcipher_one ( struct crypto_akcipher * tfm ,
2017-02-25 02:46:59 +03:00
const struct akcipher_testvec * vecs )
2015-06-16 20:31:06 +03:00
{
2016-05-05 11:42:49 +03:00
char * xbuf [ XBUFSIZE ] ;
2015-06-16 20:31:06 +03:00
struct akcipher_request * req ;
void * outbuf_enc = NULL ;
void * outbuf_dec = NULL ;
2017-10-18 10:00:43 +03:00
struct crypto_wait wait ;
2015-06-16 20:31:06 +03:00
unsigned int out_len_max , out_len = 0 ;
int err = - ENOMEM ;
crypto: akcipher - new verify API for public key algorithms
Previous akcipher .verify() just `decrypts' (using RSA encrypt which is
using public key) signature to uncover message hash, which was then
compared in upper level public_key_verify_signature() with the expected
hash value, which itself was never passed into verify().
This approach was incompatible with EC-DSA family of algorithms,
because, to verify a signature EC-DSA algorithm also needs a hash value
as input; then it's used (together with a signature divided into halves
`r||s') to produce a witness value, which is then compared with `r' to
determine if the signature is correct. Thus, for EC-DSA, nor
requirements of .verify() itself, nor its output expectations in
public_key_verify_signature() wasn't sufficient.
Make improved .verify() call which gets hash value as input and produce
complete signature check without any output besides status.
Now for the top level verification only crypto_akcipher_verify() needs
to be called and its return value inspected.
Make sure that `digest' is in kmalloc'd memory (in place of `output`) in
{public,tpm}_key_verify_signature() as insisted by Herbert Xu, and will
be changed in the following commit.
Cc: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Reviewed-by: Denis Kenzior <denkenz@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-04-11 18:51:15 +03:00
struct scatterlist src , dst , src_tab [ 3 ] ;
2019-01-07 20:54:27 +03:00
const char * m , * c ;
unsigned int m_size , c_size ;
const char * op ;
2019-04-11 18:51:17 +03:00
u8 * key , * ptr ;
2015-06-16 20:31:06 +03:00
2016-05-05 11:42:49 +03:00
if ( testmgr_alloc_buf ( xbuf ) )
return err ;
2015-06-16 20:31:06 +03:00
req = akcipher_request_alloc ( tfm , GFP_KERNEL ) ;
if ( ! req )
2016-05-05 11:42:49 +03:00
goto free_xbuf ;
2015-06-16 20:31:06 +03:00
2017-10-18 10:00:43 +03:00
crypto_init_wait ( & wait ) ;
2015-06-16 20:31:06 +03:00
2019-04-11 18:51:17 +03:00
key = kmalloc ( vecs - > key_len + sizeof ( u32 ) * 2 + vecs - > param_len ,
GFP_KERNEL ) ;
if ( ! key )
goto free_xbuf ;
memcpy ( key , vecs - > key , vecs - > key_len ) ;
ptr = key + vecs - > key_len ;
ptr = test_pack_u32 ( ptr , vecs - > algo ) ;
ptr = test_pack_u32 ( ptr , vecs - > param_len ) ;
memcpy ( ptr , vecs - > params , vecs - > param_len ) ;
2015-10-08 19:26:55 +03:00
if ( vecs - > public_key_vec )
2019-04-11 18:51:17 +03:00
err = crypto_akcipher_set_pub_key ( tfm , key , vecs - > key_len ) ;
2015-10-08 19:26:55 +03:00
else
2019-04-11 18:51:17 +03:00
err = crypto_akcipher_set_priv_key ( tfm , key , vecs - > key_len ) ;
2015-10-08 19:26:55 +03:00
if ( err )
2015-06-16 20:31:06 +03:00
goto free_req ;
2019-01-07 20:54:27 +03:00
/*
* First run test which do not require a private key , such as
* encrypt or verify .
*/
crypto: akcipher - new verify API for public key algorithms
Previous akcipher .verify() just `decrypts' (using RSA encrypt which is
using public key) signature to uncover message hash, which was then
compared in upper level public_key_verify_signature() with the expected
hash value, which itself was never passed into verify().
This approach was incompatible with EC-DSA family of algorithms,
because, to verify a signature EC-DSA algorithm also needs a hash value
as input; then it's used (together with a signature divided into halves
`r||s') to produce a witness value, which is then compared with `r' to
determine if the signature is correct. Thus, for EC-DSA, nor
requirements of .verify() itself, nor its output expectations in
public_key_verify_signature() wasn't sufficient.
Make improved .verify() call which gets hash value as input and produce
complete signature check without any output besides status.
Now for the top level verification only crypto_akcipher_verify() needs
to be called and its return value inspected.
Make sure that `digest' is in kmalloc'd memory (in place of `output`) in
{public,tpm}_key_verify_signature() as insisted by Herbert Xu, and will
be changed in the following commit.
Cc: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Reviewed-by: Denis Kenzior <denkenz@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-04-11 18:51:15 +03:00
err = - ENOMEM ;
out_len_max = crypto_akcipher_maxsize ( tfm ) ;
2015-06-16 20:31:06 +03:00
outbuf_enc = kzalloc ( out_len_max , GFP_KERNEL ) ;
if ( ! outbuf_enc )
goto free_req ;
2019-01-07 20:54:27 +03:00
if ( ! vecs - > siggen_sigver_test ) {
m = vecs - > m ;
m_size = vecs - > m_size ;
c = vecs - > c ;
c_size = vecs - > c_size ;
op = " encrypt " ;
} else {
/* Swap args so we could keep plaintext (digest)
* in vecs - > m , and cooked signature in vecs - > c .
*/
m = vecs - > c ; /* signature */
m_size = vecs - > c_size ;
c = vecs - > m ; /* digest */
c_size = vecs - > m_size ;
op = " verify " ;
}
2016-05-05 11:42:49 +03:00
2019-01-07 20:54:27 +03:00
if ( WARN_ON ( m_size > PAGE_SIZE ) )
goto free_all ;
memcpy ( xbuf [ 0 ] , m , m_size ) ;
2016-05-05 11:42:49 +03:00
crypto: akcipher - new verify API for public key algorithms
Previous akcipher .verify() just `decrypts' (using RSA encrypt which is
using public key) signature to uncover message hash, which was then
compared in upper level public_key_verify_signature() with the expected
hash value, which itself was never passed into verify().
This approach was incompatible with EC-DSA family of algorithms,
because, to verify a signature EC-DSA algorithm also needs a hash value
as input; then it's used (together with a signature divided into halves
`r||s') to produce a witness value, which is then compared with `r' to
determine if the signature is correct. Thus, for EC-DSA, nor
requirements of .verify() itself, nor its output expectations in
public_key_verify_signature() wasn't sufficient.
Make improved .verify() call which gets hash value as input and produce
complete signature check without any output besides status.
Now for the top level verification only crypto_akcipher_verify() needs
to be called and its return value inspected.
Make sure that `digest' is in kmalloc'd memory (in place of `output`) in
{public,tpm}_key_verify_signature() as insisted by Herbert Xu, and will
be changed in the following commit.
Cc: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Reviewed-by: Denis Kenzior <denkenz@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-04-11 18:51:15 +03:00
sg_init_table ( src_tab , 3 ) ;
2016-05-05 11:42:49 +03:00
sg_set_buf ( & src_tab [ 0 ] , xbuf [ 0 ] , 8 ) ;
2019-01-07 20:54:27 +03:00
sg_set_buf ( & src_tab [ 1 ] , xbuf [ 0 ] + 8 , m_size - 8 ) ;
crypto: akcipher - new verify API for public key algorithms
Previous akcipher .verify() just `decrypts' (using RSA encrypt which is
using public key) signature to uncover message hash, which was then
compared in upper level public_key_verify_signature() with the expected
hash value, which itself was never passed into verify().
This approach was incompatible with EC-DSA family of algorithms,
because, to verify a signature EC-DSA algorithm also needs a hash value
as input; then it's used (together with a signature divided into halves
`r||s') to produce a witness value, which is then compared with `r' to
determine if the signature is correct. Thus, for EC-DSA, nor
requirements of .verify() itself, nor its output expectations in
public_key_verify_signature() wasn't sufficient.
Make improved .verify() call which gets hash value as input and produce
complete signature check without any output besides status.
Now for the top level verification only crypto_akcipher_verify() needs
to be called and its return value inspected.
Make sure that `digest' is in kmalloc'd memory (in place of `output`) in
{public,tpm}_key_verify_signature() as insisted by Herbert Xu, and will
be changed in the following commit.
Cc: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Reviewed-by: Denis Kenzior <denkenz@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-04-11 18:51:15 +03:00
if ( vecs - > siggen_sigver_test ) {
if ( WARN_ON ( c_size > PAGE_SIZE ) )
goto free_all ;
memcpy ( xbuf [ 1 ] , c , c_size ) ;
sg_set_buf ( & src_tab [ 2 ] , xbuf [ 1 ] , c_size ) ;
akcipher_request_set_crypt ( req , src_tab , NULL , m_size , c_size ) ;
} else {
sg_init_one ( & dst , outbuf_enc , out_len_max ) ;
akcipher_request_set_crypt ( req , src_tab , & dst , m_size ,
out_len_max ) ;
}
2015-06-16 20:31:06 +03:00
akcipher_request_set_callback ( req , CRYPTO_TFM_REQ_MAY_BACKLOG ,
2017-10-18 10:00:43 +03:00
crypto_req_done , & wait ) ;
2015-06-16 20:31:06 +03:00
2017-10-18 10:00:43 +03:00
err = crypto_wait_req ( vecs - > siggen_sigver_test ?
2019-01-07 20:54:27 +03:00
/* Run asymmetric signature verification */
crypto_akcipher_verify ( req ) :
2017-10-18 10:00:43 +03:00
/* Run asymmetric encrypt */
crypto_akcipher_encrypt ( req ) , & wait ) ;
2015-06-16 20:31:06 +03:00
if ( err ) {
2019-01-07 20:54:27 +03:00
pr_err ( " alg: akcipher: %s test failed. err %d \n " , op , err ) ;
2015-06-16 20:31:06 +03:00
goto free_all ;
}
crypto: akcipher - new verify API for public key algorithms
Previous akcipher .verify() just `decrypts' (using RSA encrypt which is
using public key) signature to uncover message hash, which was then
compared in upper level public_key_verify_signature() with the expected
hash value, which itself was never passed into verify().
This approach was incompatible with EC-DSA family of algorithms,
because, to verify a signature EC-DSA algorithm also needs a hash value
as input; then it's used (together with a signature divided into halves
`r||s') to produce a witness value, which is then compared with `r' to
determine if the signature is correct. Thus, for EC-DSA, nor
requirements of .verify() itself, nor its output expectations in
public_key_verify_signature() wasn't sufficient.
Make improved .verify() call which gets hash value as input and produce
complete signature check without any output besides status.
Now for the top level verification only crypto_akcipher_verify() needs
to be called and its return value inspected.
Make sure that `digest' is in kmalloc'd memory (in place of `output`) in
{public,tpm}_key_verify_signature() as insisted by Herbert Xu, and will
be changed in the following commit.
Cc: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Reviewed-by: Denis Kenzior <denkenz@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-04-11 18:51:15 +03:00
if ( ! vecs - > siggen_sigver_test ) {
if ( req - > dst_len ! = c_size ) {
pr_err ( " alg: akcipher: %s test failed. Invalid output len \n " ,
op ) ;
err = - EINVAL ;
goto free_all ;
}
/* verify that encrypted message is equal to expected */
if ( memcmp ( c , outbuf_enc , c_size ) ! = 0 ) {
pr_err ( " alg: akcipher: %s test failed. Invalid output \n " ,
op ) ;
hexdump ( outbuf_enc , c_size ) ;
err = - EINVAL ;
goto free_all ;
}
2015-06-16 20:31:06 +03:00
}
2019-01-07 20:54:27 +03:00
/*
* Don ' t invoke ( decrypt or sign ) test which require a private key
* for vectors with only a public key .
*/
2015-06-16 20:31:06 +03:00
if ( vecs - > public_key_vec ) {
err = 0 ;
goto free_all ;
}
outbuf_dec = kzalloc ( out_len_max , GFP_KERNEL ) ;
if ( ! outbuf_dec ) {
err = - ENOMEM ;
goto free_all ;
}
2016-05-05 11:42:49 +03:00
2019-01-07 20:54:27 +03:00
op = vecs - > siggen_sigver_test ? " sign " : " decrypt " ;
if ( WARN_ON ( c_size > PAGE_SIZE ) )
2016-05-05 11:42:49 +03:00
goto free_all ;
2019-01-07 20:54:27 +03:00
memcpy ( xbuf [ 0 ] , c , c_size ) ;
2016-05-05 11:42:49 +03:00
2019-01-07 20:54:27 +03:00
sg_init_one ( & src , xbuf [ 0 ] , c_size ) ;
2015-10-08 19:26:55 +03:00
sg_init_one ( & dst , outbuf_dec , out_len_max ) ;
2017-10-18 10:00:43 +03:00
crypto_init_wait ( & wait ) ;
2019-01-07 20:54:27 +03:00
akcipher_request_set_crypt ( req , & src , & dst , c_size , out_len_max ) ;
2015-06-16 20:31:06 +03:00
2017-10-18 10:00:43 +03:00
err = crypto_wait_req ( vecs - > siggen_sigver_test ?
2019-01-07 20:54:27 +03:00
/* Run asymmetric signature generation */
crypto_akcipher_sign ( req ) :
2017-10-18 10:00:43 +03:00
/* Run asymmetric decrypt */
crypto_akcipher_decrypt ( req ) , & wait ) ;
2015-06-16 20:31:06 +03:00
if ( err ) {
2019-01-07 20:54:27 +03:00
pr_err ( " alg: akcipher: %s test failed. err %d \n " , op , err ) ;
2015-06-16 20:31:06 +03:00
goto free_all ;
}
out_len = req - > dst_len ;
2019-01-07 20:54:27 +03:00
if ( out_len < m_size ) {
pr_err ( " alg: akcipher: %s test failed. Invalid output len %u \n " ,
op , out_len ) ;
2015-06-16 20:31:06 +03:00
err = - EINVAL ;
goto free_all ;
}
/* verify that decrypted message is equal to the original msg */
2019-01-07 20:54:27 +03:00
if ( memchr_inv ( outbuf_dec , 0 , out_len - m_size ) | |
memcmp ( m , outbuf_dec + out_len - m_size , m_size ) ) {
pr_err ( " alg: akcipher: %s test failed. Invalid output \n " , op ) ;
2016-06-29 14:32:20 +03:00
hexdump ( outbuf_dec , out_len ) ;
2015-06-16 20:31:06 +03:00
err = - EINVAL ;
}
free_all :
kfree ( outbuf_dec ) ;
kfree ( outbuf_enc ) ;
free_req :
akcipher_request_free ( req ) ;
2019-04-11 18:51:17 +03:00
kfree ( key ) ;
2016-05-05 11:42:49 +03:00
free_xbuf :
testmgr_free_buf ( xbuf ) ;
2015-06-16 20:31:06 +03:00
return err ;
}
2016-06-29 14:32:20 +03:00
static int test_akcipher ( struct crypto_akcipher * tfm , const char * alg ,
2017-02-25 02:46:59 +03:00
const struct akcipher_testvec * vecs ,
unsigned int tcount )
2015-06-16 20:31:06 +03:00
{
2016-07-18 13:20:10 +03:00
const char * algo =
crypto_tfm_alg_driver_name ( crypto_akcipher_tfm ( tfm ) ) ;
2015-06-16 20:31:06 +03:00
int ret , i ;
for ( i = 0 ; i < tcount ; i + + ) {
2016-06-29 14:32:20 +03:00
ret = test_akcipher_one ( tfm , vecs + + ) ;
if ( ! ret )
continue ;
2015-06-16 20:31:06 +03:00
2016-07-18 13:20:10 +03:00
pr_err ( " alg: akcipher: test %d failed for %s, err=%d \n " ,
i + 1 , algo , ret ) ;
2016-06-29 14:32:20 +03:00
return ret ;
}
2015-06-16 20:31:06 +03:00
return 0 ;
}
static int alg_test_akcipher ( const struct alg_test_desc * desc ,
const char * driver , u32 type , u32 mask )
{
struct crypto_akcipher * tfm ;
int err = 0 ;
2016-11-22 15:08:31 +03:00
tfm = crypto_alloc_akcipher ( driver , type , mask ) ;
2015-06-16 20:31:06 +03:00
if ( IS_ERR ( tfm ) ) {
pr_err ( " alg: akcipher: Failed to load tfm for %s: %ld \n " ,
driver , PTR_ERR ( tfm ) ) ;
return PTR_ERR ( tfm ) ;
}
if ( desc - > suite . akcipher . vecs )
err = test_akcipher ( tfm , desc - > alg , desc - > suite . akcipher . vecs ,
desc - > suite . akcipher . count ) ;
crypto_free_akcipher ( tfm ) ;
return err ;
}
2009-12-23 14:45:20 +03:00
static int alg_test_null ( const struct alg_test_desc * desc ,
const char * driver , u32 type , u32 mask )
{
return 0 ;
}
2017-01-12 16:40:39 +03:00
# define __VECS(tv) { .vecs = tv, .count = ARRAY_SIZE(tv) }
2008-07-31 13:08:25 +04:00
/* Please keep this list sorted by algorithm name. */
static const struct alg_test_desc alg_test_descs [ ] = {
{
crypto: adiantum - add Adiantum support
Add support for the Adiantum encryption mode. Adiantum was designed by
Paul Crowley and is specified by our paper:
Adiantum: length-preserving encryption for entry-level processors
(https://eprint.iacr.org/2018/720.pdf)
See our paper for full details; this patch only provides an overview.
Adiantum is a tweakable, length-preserving encryption mode designed for
fast and secure disk encryption, especially on CPUs without dedicated
crypto instructions. Adiantum encrypts each sector using the XChaCha12
stream cipher, two passes of an ε-almost-∆-universal (εA∆U) hash
function, and an invocation of the AES-256 block cipher on a single
16-byte block. On CPUs without AES instructions, Adiantum is much
faster than AES-XTS; for example, on ARM Cortex-A7, on 4096-byte sectors
Adiantum encryption is about 4 times faster than AES-256-XTS encryption,
and decryption about 5 times faster.
Adiantum is a specialization of the more general HBSH construction. Our
earlier proposal, HPolyC, was also a HBSH specialization, but it used a
different εA∆U hash function, one based on Poly1305 only. Adiantum's
εA∆U hash function, which is based primarily on the "NH" hash function
like that used in UMAC (RFC4418), is about twice as fast as HPolyC's;
consequently, Adiantum is about 20% faster than HPolyC.
This speed comes with no loss of security: Adiantum is provably just as
secure as HPolyC, in fact slightly *more* secure. Like HPolyC,
Adiantum's security is reducible to that of XChaCha12 and AES-256,
subject to a security bound. XChaCha12 itself has a security reduction
to ChaCha12. Therefore, one need not "trust" Adiantum; one need only
trust ChaCha12 and AES-256. Note that the εA∆U hash function is only
used for its proven combinatorical properties so cannot be "broken".
Adiantum is also a true wide-block encryption mode, so flipping any
plaintext bit in the sector scrambles the entire ciphertext, and vice
versa. No other such mode is available in the kernel currently; doing
the same with XTS scrambles only 16 bytes. Adiantum also supports
arbitrary-length tweaks and naturally supports any length input >= 16
bytes without needing "ciphertext stealing".
For the stream cipher, Adiantum uses XChaCha12 rather than XChaCha20 in
order to make encryption feasible on the widest range of devices.
Although the 20-round variant is quite popular, the best known attacks
on ChaCha are on only 7 rounds, so ChaCha12 still has a substantial
security margin; in fact, larger than AES-256's. 12-round Salsa20 is
also the eSTREAM recommendation. For the block cipher, Adiantum uses
AES-256, despite it having a lower security margin than XChaCha12 and
needing table lookups, due to AES's extensive adoption and analysis
making it the obvious first choice. Nevertheless, for flexibility this
patch also permits the "adiantum" template to be instantiated with
XChaCha20 and/or with an alternate block cipher.
We need Adiantum support in the kernel for use in dm-crypt and fscrypt,
where currently the only other suitable options are block cipher modes
such as AES-XTS. A big problem with this is that many low-end mobile
devices (e.g. Android Go phones sold primarily in developing countries,
as well as some smartwatches) still have CPUs that lack AES
instructions, e.g. ARM Cortex-A7. Sadly, AES-XTS encryption is much too
slow to be viable on these devices. We did find that some "lightweight"
block ciphers are fast enough, but these suffer from problems such as
not having much cryptanalysis or being too controversial.
The ChaCha stream cipher has excellent performance but is insecure to
use directly for disk encryption, since each sector's IV is reused each
time it is overwritten. Even restricting the threat model to offline
attacks only isn't enough, since modern flash storage devices don't
guarantee that "overwrites" are really overwrites, due to wear-leveling.
Adiantum avoids this problem by constructing a
"tweakable super-pseudorandom permutation"; this is the strongest
possible security model for length-preserving encryption.
Of course, storing random nonces along with the ciphertext would be the
ideal solution. But doing that with existing hardware and filesystems
runs into major practical problems; in most cases it would require data
journaling (like dm-integrity) which severely degrades performance.
Thus, for now length-preserving encryption is still needed.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-11-17 04:26:31 +03:00
. alg = " adiantum(xchacha12,aes) " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = __VECS ( adiantum_xchacha12_aes_tv_template )
} ,
} , {
. alg = " adiantum(xchacha20,aes) " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = __VECS ( adiantum_xchacha20_aes_tv_template )
} ,
} , {
2018-05-11 15:12:50 +03:00
. alg = " aegis128 " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aegis128_tv_template )
2018-05-11 15:12:50 +03:00
}
} , {
. alg = " aegis128l " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aegis128l_tv_template )
2018-05-11 15:12:50 +03:00
}
} , {
. alg = " aegis256 " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aegis256_tv_template )
2018-05-11 15:12:50 +03:00
}
} , {
2009-05-04 15:46:29 +04:00
. alg = " ansi_cprng " ,
. test = alg_test_cprng ,
. suite = {
2017-01-12 16:40:39 +03:00
. cprng = __VECS ( ansi_cprng_aes_tv_template )
2009-05-04 15:46:29 +04:00
}
2014-03-14 19:46:51 +04:00
} , {
. alg = " authenc(hmac(md5),ecb(cipher_null)) " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_md5_ecb_cipher_null_tv_template )
2014-03-14 19:46:51 +04:00
}
2012-07-03 20:16:54 +04:00
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha1),cbc(aes)) " ,
2012-07-03 20:16:54 +04:00
. test = alg_test_aead ,
2017-06-28 14:09:07 +03:00
. fips_allowed = 1 ,
2012-07-03 20:16:54 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha1_aes_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha1),cbc(des)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha1_des_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha1),cbc(des3_ede)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha1_des3_ede_cbc_tv_temp )
2012-07-03 20:16:54 +04:00
}
2016-02-06 13:53:07 +03:00
} , {
. alg = " authenc(hmac(sha1),ctr(aes)) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2014-03-14 19:46:51 +04:00
} , {
. alg = " authenc(hmac(sha1),ecb(cipher_null)) " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha1_ecb_cipher_null_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
2016-02-19 15:34:28 +03:00
} , {
. alg = " authenc(hmac(sha1),rfc3686(ctr(aes))) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha224),cbc(des)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha224_des_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha224),cbc(des3_ede)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha224_des3_ede_cbc_tv_temp )
2014-03-14 19:46:51 +04:00
}
2012-07-03 20:16:54 +04:00
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha256),cbc(aes)) " ,
2012-07-03 20:16:54 +04:00
. test = alg_test_aead ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
2012-07-03 20:16:54 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha256_aes_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha256),cbc(des)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha256_des_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha256),cbc(des3_ede)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha256_des3_ede_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
2016-02-06 13:53:07 +03:00
} , {
. alg = " authenc(hmac(sha256),ctr(aes)) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2016-02-19 15:34:28 +03:00
} , {
. alg = " authenc(hmac(sha256),rfc3686(ctr(aes))) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha384),cbc(des)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha384_des_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha384),cbc(des3_ede)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha384_des3_ede_cbc_tv_temp )
2012-07-03 20:16:54 +04:00
}
2016-02-06 13:53:07 +03:00
} , {
. alg = " authenc(hmac(sha384),ctr(aes)) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2016-02-19 15:34:28 +03:00
} , {
. alg = " authenc(hmac(sha384),rfc3686(ctr(aes))) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2012-07-03 20:16:54 +04:00
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha512),cbc(aes)) " ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
2012-07-03 20:16:54 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha512_aes_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha512),cbc(des)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha512_des_cbc_tv_temp )
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
}
} , {
2015-07-30 12:53:23 +03:00
. alg = " authenc(hmac(sha512),cbc(des3_ede)) " ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. test = alg_test_aead ,
2016-02-05 16:23:33 +03:00
. fips_allowed = 1 ,
crypto: testmgr - add aead cbc des, des3_ede tests
Test vectors were taken from existing test for
CBC(DES3_EDE). Associated data has been added to test vectors.
HMAC computed with Crypto++ has been used. Following algos have
been covered.
(a) "authenc(hmac(sha1),cbc(des))"
(b) "authenc(hmac(sha1),cbc(des3_ede))"
(c) "authenc(hmac(sha224),cbc(des))"
(d) "authenc(hmac(sha224),cbc(des3_ede))"
(e) "authenc(hmac(sha256),cbc(des))"
(f) "authenc(hmac(sha256),cbc(des3_ede))"
(g) "authenc(hmac(sha384),cbc(des))"
(h) "authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg <vakul@freescale.com>
[NiteshNarayanLal@freescale.com: added hooks for the missing algorithms test and tested the patch]
Signed-off-by: Nitesh Lal <NiteshNarayanLal@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2014-05-21 15:39:08 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( hmac_sha512_des3_ede_cbc_tv_temp )
2012-07-03 20:16:54 +04:00
}
2016-02-06 13:53:07 +03:00
} , {
. alg = " authenc(hmac(sha512),ctr(aes)) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2016-02-19 15:34:28 +03:00
} , {
. alg = " authenc(hmac(sha512),rfc3686(ctr(aes))) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2009-05-04 15:46:29 +04:00
} , {
2008-07-31 13:08:25 +04:00
. alg = " cbc(aes) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_cbc_tv_template )
} ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " cbc(anubis) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( anubis_cbc_tv_template )
} ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " cbc(blowfish) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( bf_cbc_tv_template )
} ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " cbc(camellia) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( camellia_cbc_tv_template )
} ,
2012-07-11 21:37:21 +04:00
} , {
. alg = " cbc(cast5) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast5_cbc_tv_template )
} ,
2012-07-11 21:38:29 +04:00
} , {
. alg = " cbc(cast6) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast6_cbc_tv_template )
} ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " cbc(des) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( des_cbc_tv_template )
} ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " cbc(des3_ede) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( des3_ede_cbc_tv_template )
} ,
2018-04-23 10:25:14 +03:00
} , {
/* Same as cbc(aes) except the key is stored in
* hardware secure memory which we reference by index
*/
. alg = " cbc(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2011-10-18 01:02:53 +04:00
} , {
. alg = " cbc(serpent) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( serpent_cbc_tv_template )
} ,
2018-09-20 16:18:38 +03:00
} , {
. alg = " cbc(sm4) " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = __VECS ( sm4_cbc_tv_template )
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " cbc(twofish) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tf_cbc_tv_template )
} ,
2017-02-03 17:49:35 +03:00
} , {
. alg = " cbcmac(aes) " ,
. fips_allowed = 1 ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( aes_cbcmac_tv_template )
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " ccm(aes) " ,
. test = alg_test_aead ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aes_ccm_tv_template )
2008-07-31 13:08:25 +04:00
}
2018-10-20 02:01:53 +03:00
} , {
. alg = " cfb(aes) " ,
. test = alg_test_skcipher ,
. fips_allowed = 1 ,
. suite = {
. cipher = __VECS ( aes_cfb_tv_template )
} ,
2015-06-01 14:43:57 +03:00
} , {
. alg = " chacha20 " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( chacha20_tv_template )
} ,
2013-04-08 11:48:44 +04:00
} , {
. alg = " cmac(aes) " ,
2015-08-19 09:42:07 +03:00
. fips_allowed = 1 ,
2013-04-08 11:48:44 +04:00
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( aes_cmac128_tv_template )
2013-04-08 11:48:44 +04:00
}
} , {
. alg = " cmac(des3_ede) " ,
2015-08-19 09:42:07 +03:00
. fips_allowed = 1 ,
2013-04-08 11:48:44 +04:00
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( des3_ede_cmac64_tv_template )
2013-04-08 11:48:44 +04:00
}
2013-04-07 17:43:56 +04:00
} , {
. alg = " compress_null " ,
. test = alg_test_null ,
2015-05-04 12:00:17 +03:00
} , {
. alg = " crc32 " ,
. test = alg_test_hash ,
2019-01-25 12:31:47 +03:00
. fips_allowed = 1 ,
2015-05-04 12:00:17 +03:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( crc32_tv_template )
2015-05-04 12:00:17 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " crc32c " ,
2008-11-07 09:58:52 +03:00
. test = alg_test_crc32c ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( crc32c_tv_template )
2008-07-31 13:08:25 +04:00
}
2013-09-07 06:56:26 +04:00
} , {
. alg = " crct10dif " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( crct10dif_tv_template )
2013-09-07 06:56:26 +04:00
}
2009-05-06 13:29:17 +04:00
} , {
. alg = " ctr(aes) " ,
. test = alg_test_skcipher ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2009-05-06 13:29:17 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_ctr_tv_template )
2009-05-06 13:29:17 +04:00
}
2011-10-11 00:03:03 +04:00
} , {
. alg = " ctr(blowfish) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( bf_ctr_tv_template )
2011-10-11 00:03:03 +04:00
}
2012-03-05 22:26:21 +04:00
} , {
. alg = " ctr(camellia) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( camellia_ctr_tv_template )
2012-03-05 22:26:21 +04:00
}
2012-07-11 21:37:21 +04:00
} , {
. alg = " ctr(cast5) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast5_ctr_tv_template )
2012-07-11 21:37:21 +04:00
}
2012-07-11 21:38:29 +04:00
} , {
. alg = " ctr(cast6) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast6_ctr_tv_template )
2012-07-11 21:38:29 +04:00
}
2012-10-20 15:53:07 +04:00
} , {
. alg = " ctr(des) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( des_ctr_tv_template )
2012-10-20 15:53:07 +04:00
}
2012-10-20 15:53:12 +04:00
} , {
. alg = " ctr(des3_ede) " ,
. test = alg_test_skcipher ,
2017-03-20 23:28:05 +03:00
. fips_allowed = 1 ,
2012-10-20 15:53:12 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( des3_ede_ctr_tv_template )
2012-10-20 15:53:12 +04:00
}
2018-04-23 10:25:14 +03:00
} , {
/* Same as ctr(aes) except the key is stored in
* hardware secure memory which we reference by index
*/
. alg = " ctr(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2011-10-18 01:02:53 +04:00
} , {
. alg = " ctr(serpent) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( serpent_ctr_tv_template )
2011-10-18 01:02:53 +04:00
}
2018-09-20 16:18:38 +03:00
} , {
. alg = " ctr(sm4) " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = __VECS ( sm4_ctr_tv_template )
}
2011-10-11 00:03:12 +04:00
} , {
. alg = " ctr(twofish) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tf_ctr_tv_template )
2011-10-11 00:03:12 +04:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " cts(cbc(aes)) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2018-11-04 13:05:24 +03:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cts_mode_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " deflate " ,
. test = alg_test_comp ,
2012-12-06 13:16:28 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
. comp = {
2017-01-12 16:40:39 +03:00
. comp = __VECS ( deflate_comp_tv_template ) ,
. decomp = __VECS ( deflate_decomp_tv_template )
2008-07-31 13:08:25 +04:00
}
}
2016-06-22 19:49:14 +03:00
} , {
. alg = " dh " ,
. test = alg_test_kpp ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. kpp = __VECS ( dh_tv_template )
2016-06-22 19:49:14 +03:00
}
2013-04-07 17:43:56 +04:00
} , {
. alg = " digest_null " ,
. test = alg_test_null ,
2014-05-31 19:25:36 +04:00
} , {
. alg = " drbg_nopr_ctr_aes128 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_nopr_ctr_aes128_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
. alg = " drbg_nopr_ctr_aes192 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_nopr_ctr_aes192_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
. alg = " drbg_nopr_ctr_aes256 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_nopr_ctr_aes256_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
/*
* There is no need to specifically test the DRBG with every
* backend cipher - - covered by drbg_nopr_hmac_sha256 test
*/
. alg = " drbg_nopr_hmac_sha1 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_nopr_hmac_sha256 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_nopr_hmac_sha256_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
/* covered by drbg_nopr_hmac_sha256 test */
. alg = " drbg_nopr_hmac_sha384 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_nopr_hmac_sha512 " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
} , {
. alg = " drbg_nopr_sha1 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_nopr_sha256 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_nopr_sha256_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
/* covered by drbg_nopr_sha256 test */
. alg = " drbg_nopr_sha384 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_nopr_sha512 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_ctr_aes128 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_pr_ctr_aes128_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
/* covered by drbg_pr_ctr_aes128 test */
. alg = " drbg_pr_ctr_aes192 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_ctr_aes256 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_hmac_sha1 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_hmac_sha256 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_pr_hmac_sha256_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
/* covered by drbg_pr_hmac_sha256 test */
. alg = " drbg_pr_hmac_sha384 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_hmac_sha512 " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
} , {
. alg = " drbg_pr_sha1 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_sha256 " ,
. test = alg_test_drbg ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. drbg = __VECS ( drbg_pr_sha256_tv_template )
2014-05-31 19:25:36 +04:00
}
} , {
/* covered by drbg_pr_sha256 test */
. alg = " drbg_pr_sha384 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
} , {
. alg = " drbg_pr_sha512 " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " ecb(aes) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(anubis) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( anubis_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(arc4) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( arc4_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(blowfish) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( bf_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(camellia) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( camellia_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(cast5) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast5_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(cast6) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast6_tv_template )
2008-07-31 13:08:25 +04:00
}
2013-04-07 17:43:56 +04:00
} , {
. alg = " ecb(cipher_null) " ,
. test = alg_test_null ,
2017-04-21 14:03:06 +03:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " ecb(des) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( des_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(des3_ede) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( des3_ede_tv_template )
2008-07-31 13:08:25 +04:00
}
2013-01-19 15:31:36 +04:00
} , {
. alg = " ecb(fcrypt) " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. vecs = fcrypt_pcbc_tv_template ,
. count = 1
2013-01-19 15:31:36 +04:00
}
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " ecb(khazad) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( khazad_tv_template )
2008-07-31 13:08:25 +04:00
}
2018-05-11 11:04:06 +03:00
} , {
/* Same as ecb(aes) except the key is stored in
* hardware secure memory which we reference by index
*/
. alg = " ecb(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " ecb(seed) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( seed_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(serpent) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( serpent_tv_template )
2008-07-31 13:08:25 +04:00
}
2018-03-06 12:44:43 +03:00
} , {
. alg = " ecb(sm4) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( sm4_tv_template )
2018-03-06 12:44:43 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " ecb(tea) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tea_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(tnepres) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tnepres_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(twofish) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tf_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(xeta) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( xeta_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " ecb(xtea) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( xtea_tv_template )
2008-07-31 13:08:25 +04:00
}
2016-06-22 19:49:15 +03:00
} , {
. alg = " ecdh " ,
. test = alg_test_kpp ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. kpp = __VECS ( ecdh_tv_template )
2016-06-22 19:49:15 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " gcm(aes) " ,
. test = alg_test_aead ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aes_gcm_tv_template )
2008-07-31 13:08:25 +04:00
}
2009-11-23 15:23:04 +03:00
} , {
. alg = " ghash " ,
. test = alg_test_hash ,
crypto: testmgr - mark ghash as fips_allowed
A self-test failure in fips mode means a panic. Well, gcm(aes)
self-tests currently fail in fips mode, as gcm is dependent on ghash,
which semi-recently got self-test vectors added, but wasn't marked as a
fips_allowed algorithm. Because of gcm's dependence on what is now seen
as a non-fips_allowed algorithm, its self-tests refuse to run.
Previously, ghash got a pass in fips mode, due to the lack of any test
vectors at all, and thus gcm self-tests were able to run. After this
patch, a 'modprobe tcrypt mode=35' no longer panics in fips mode, and
successful self-test of gcm(aes) is reported.
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2011-01-29 07:14:35 +03:00
. fips_allowed = 1 ,
2009-11-23 15:23:04 +03:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( ghash_tv_template )
2009-11-23 15:23:04 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " hmac(md5) " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_md5_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " hmac(rmd128) " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_rmd128_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " hmac(rmd160) " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_rmd160_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " hmac(sha1) " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha1_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " hmac(sha224) " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha224_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " hmac(sha256) " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha256_tv_template )
2008-07-31 13:08:25 +04:00
}
2016-07-01 08:46:54 +03:00
} , {
. alg = " hmac(sha3-224) " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha3_224_tv_template )
2016-07-01 08:46:54 +03:00
}
} , {
. alg = " hmac(sha3-256) " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha3_256_tv_template )
2016-07-01 08:46:54 +03:00
}
} , {
. alg = " hmac(sha3-384) " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha3_384_tv_template )
2016-07-01 08:46:54 +03:00
}
} , {
. alg = " hmac(sha3-512) " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha3_512_tv_template )
2016-07-01 08:46:54 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " hmac(sha384) " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha384_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " hmac(sha512) " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( hmac_sha512_tv_template )
2008-07-31 13:08:25 +04:00
}
2018-11-07 00:00:03 +03:00
} , {
. alg = " hmac(streebog256) " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( hmac_streebog256_tv_template )
}
} , {
. alg = " hmac(streebog512) " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( hmac_streebog512_tv_template )
}
2015-05-25 16:10:20 +03:00
} , {
. alg = " jitterentropy_rng " ,
. fips_allowed = 1 ,
. test = alg_test_null ,
2015-09-21 21:59:56 +03:00
} , {
. alg = " kw(aes) " ,
. test = alg_test_skcipher ,
. fips_allowed = 1 ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_kw_tv_template )
2015-09-21 21:59:56 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " lrw(aes) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_lrw_tv_template )
2008-07-31 13:08:25 +04:00
}
2012-03-05 22:26:21 +04:00
} , {
. alg = " lrw(camellia) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( camellia_lrw_tv_template )
2012-03-05 22:26:21 +04:00
}
2012-07-11 21:38:29 +04:00
} , {
. alg = " lrw(cast6) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast6_lrw_tv_template )
2012-07-11 21:38:29 +04:00
}
2011-10-18 14:32:34 +04:00
} , {
. alg = " lrw(serpent) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( serpent_lrw_tv_template )
2011-10-18 14:32:34 +04:00
}
2011-10-18 14:32:50 +04:00
} , {
. alg = " lrw(twofish) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tf_lrw_tv_template )
2011-10-18 14:32:50 +04:00
}
2014-08-22 12:44:36 +04:00
} , {
. alg = " lz4 " ,
. test = alg_test_comp ,
. fips_allowed = 1 ,
. suite = {
. comp = {
2017-01-12 16:40:39 +03:00
. comp = __VECS ( lz4_comp_tv_template ) ,
. decomp = __VECS ( lz4_decomp_tv_template )
2014-08-22 12:44:36 +04:00
}
}
} , {
. alg = " lz4hc " ,
. test = alg_test_comp ,
. fips_allowed = 1 ,
. suite = {
. comp = {
2017-01-12 16:40:39 +03:00
. comp = __VECS ( lz4hc_comp_tv_template ) ,
. decomp = __VECS ( lz4hc_decomp_tv_template )
2014-08-22 12:44:36 +04:00
}
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " lzo " ,
. test = alg_test_comp ,
2012-12-06 13:16:28 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
. comp = {
2017-01-12 16:40:39 +03:00
. comp = __VECS ( lzo_comp_tv_template ) ,
. decomp = __VECS ( lzo_decomp_tv_template )
2008-07-31 13:08:25 +04:00
}
}
} , {
. alg = " md4 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( md4_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " md5 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( md5_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " michael_mic " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( michael_mic_tv_template )
2008-07-31 13:08:25 +04:00
}
2018-05-11 15:19:10 +03:00
} , {
. alg = " morus1280 " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( morus1280_tv_template )
2018-05-11 15:19:10 +03:00
}
} , {
. alg = " morus640 " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( morus640_tv_template )
2018-05-11 15:19:10 +03:00
}
2018-11-17 04:26:29 +03:00
} , {
. alg = " nhpoly1305 " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( nhpoly1305_tv_template )
}
2011-05-04 09:04:10 +04:00
} , {
. alg = " ofb(aes) " ,
. test = alg_test_skcipher ,
. fips_allowed = 1 ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_ofb_tv_template )
2011-05-04 09:04:10 +04:00
}
2018-04-23 10:25:14 +03:00
} , {
/* Same as ofb(aes) except the key is stored in
* hardware secure memory which we reference by index
*/
. alg = " ofb(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " pcbc(fcrypt) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( fcrypt_pcbc_tv_template )
2008-07-31 13:08:25 +04:00
}
2017-06-13 00:27:51 +03:00
} , {
. alg = " pkcs1pad(rsa,sha224) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
} , {
. alg = " pkcs1pad(rsa,sha256) " ,
. test = alg_test_akcipher ,
. fips_allowed = 1 ,
. suite = {
. akcipher = __VECS ( pkcs1pad_rsa_tv_template )
}
} , {
. alg = " pkcs1pad(rsa,sha384) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
} , {
. alg = " pkcs1pad(rsa,sha512) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2015-06-01 14:43:59 +03:00
} , {
. alg = " poly1305 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( poly1305_tv_template )
2015-06-01 14:43:59 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " rfc3686(ctr(aes)) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_ctr_rfc3686_tv_template )
2008-07-31 13:08:25 +04:00
}
2009-05-04 15:23:40 +04:00
} , {
2015-07-09 02:17:34 +03:00
. alg = " rfc4106(gcm(aes)) " ,
2010-11-04 22:02:04 +03:00
. test = alg_test_aead ,
2015-01-23 20:42:15 +03:00
. fips_allowed = 1 ,
2010-11-04 22:02:04 +03:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aes_gcm_rfc4106_tv_template )
2010-11-04 22:02:04 +03:00
}
} , {
2015-07-14 11:53:22 +03:00
. alg = " rfc4309(ccm(aes)) " ,
2009-05-04 15:23:40 +04:00
. test = alg_test_aead ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2009-05-04 15:23:40 +04:00
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aes_ccm_rfc4309_tv_template )
2009-05-04 15:23:40 +04:00
}
2013-04-07 17:43:51 +04:00
} , {
2015-06-16 08:54:24 +03:00
. alg = " rfc4543(gcm(aes)) " ,
2013-04-07 17:43:51 +04:00
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( aes_gcm_rfc4543_tv_template )
2013-04-07 17:43:51 +04:00
}
2015-06-01 14:44:01 +03:00
} , {
. alg = " rfc7539(chacha20,poly1305) " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( rfc7539_tv_template )
2015-06-01 14:44:01 +03:00
}
2015-06-01 14:44:03 +03:00
} , {
. alg = " rfc7539esp(chacha20,poly1305) " ,
. test = alg_test_aead ,
. suite = {
crypto: testmgr - unify the AEAD encryption and decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for AEADs. That's massively redundant, since usually the decryption
tests are identical to the encryption tests, just with the input/result
swapped. And for some algorithms it was forgotten to add decryption
test vectors, so for them currently only encryption is being tested.
Therefore, eliminate the redundancy by removing the AEAD decryption test
vectors and updating testmgr to test both AEAD encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each aead_testvec now has a 'ptext' (plaintext), 'plen'
(plaintext length), 'ctext' (ciphertext), and 'clen' (ciphertext length)
instead of an 'input', 'ilen', 'result', and 'rlen'. "Ciphertext" here
refers to the full ciphertext, including the authentication tag.
For now the scatterlist divisions are just given for the plaintext
length, not also the ciphertext length. For decryption, the last
scatterlist element is just extended by the authentication tag length.
In total, this removes over 5000 lines from testmgr.h, with no reduction
in test coverage since prior patches already copied the few unique
decryption test vectors into the encryption test vectors.
The testmgr.h portion of this patch was automatically generated using
the following awk script, except that I also manually updated the
definition of 'struct aead_testvec' and fixed the location of the
comment describing the AEGIS-128 test vectors.
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct aead_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct aead_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC {
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.ilen[[:space:]]*=/, ".plen\t=")
sub(/\.rlen[[:space:]]*=/, ".clen\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 1235 insertions(+), 6491 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-01-14 02:32:28 +03:00
. aead = __VECS ( rfc7539esp_tv_template )
2015-06-01 14:44:03 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " rmd128 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( rmd128_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " rmd160 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( rmd160_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " rmd256 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( rmd256_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " rmd320 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( rmd320_tv_template )
2008-07-31 13:08:25 +04:00
}
2015-06-16 20:31:06 +03:00
} , {
. alg = " rsa " ,
. test = alg_test_akcipher ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. akcipher = __VECS ( rsa_tv_template )
2015-06-16 20:31:06 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " salsa20 " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( salsa20_stream_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " sha1 " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha1_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " sha224 " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha224_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " sha256 " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha256_tv_template )
2008-07-31 13:08:25 +04:00
}
2016-06-17 08:00:36 +03:00
} , {
. alg = " sha3-224 " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha3_224_tv_template )
2016-06-17 08:00:36 +03:00
}
} , {
. alg = " sha3-256 " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha3_256_tv_template )
2016-06-17 08:00:36 +03:00
}
} , {
. alg = " sha3-384 " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha3_384_tv_template )
2016-06-17 08:00:36 +03:00
}
} , {
. alg = " sha3-512 " ,
. test = alg_test_hash ,
. fips_allowed = 1 ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha3_512_tv_template )
2016-06-17 08:00:36 +03:00
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " sha384 " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha384_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " sha512 " ,
. test = alg_test_hash ,
2009-05-15 09:16:03 +04:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( sha512_tv_template )
2008-07-31 13:08:25 +04:00
}
2017-08-21 13:51:29 +03:00
} , {
. alg = " sm3 " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( sm3_tv_template )
}
2018-11-07 00:00:03 +03:00
} , {
. alg = " streebog256 " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( streebog256_tv_template )
}
} , {
. alg = " streebog512 " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( streebog512_tv_template )
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " tgr128 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( tgr128_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " tgr160 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( tgr160_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " tgr192 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( tgr192_tv_template )
2008-07-31 13:08:25 +04:00
}
2018-06-18 20:22:39 +03:00
} , {
. alg = " vmac64(aes) " ,
. test = alg_test_hash ,
. suite = {
. hash = __VECS ( vmac64_aes_tv_template )
}
2008-07-31 13:08:25 +04:00
} , {
. alg = " wp256 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( wp256_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " wp384 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( wp384_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " wp512 " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( wp512_tv_template )
2008-07-31 13:08:25 +04:00
}
} , {
. alg = " xcbc(aes) " ,
. test = alg_test_hash ,
. suite = {
2017-01-12 16:40:39 +03:00
. hash = __VECS ( aes_xcbc128_tv_template )
2008-07-31 13:08:25 +04:00
}
crypto: chacha - add XChaCha12 support
Now that the generic implementation of ChaCha20 has been refactored to
allow varying the number of rounds, add support for XChaCha12, which is
the XSalsa construction applied to ChaCha12. ChaCha12 is one of the
three ciphers specified by the original ChaCha paper
(https://cr.yp.to/chacha/chacha-20080128.pdf: "ChaCha, a variant of
Salsa20"), alongside ChaCha8 and ChaCha20. ChaCha12 is faster than
ChaCha20 but has a lower, but still large, security margin.
We need XChaCha12 support so that it can be used in the Adiantum
encryption mode, which enables disk/file encryption on low-end mobile
devices where AES-XTS is too slow as the CPUs lack AES instructions.
We'd prefer XChaCha20 (the more popular variant), but it's too slow on
some of our target devices, so at least in some cases we do need the
XChaCha12-based version. In more detail, the problem is that Adiantum
is still much slower than we're happy with, and encryption still has a
quite noticeable effect on the feel of low-end devices. Users and
vendors push back hard against encryption that degrades the user
experience, which always risks encryption being disabled entirely. So
we need to choose the fastest option that gives us a solid margin of
security, and here that's XChaCha12. The best known attack on ChaCha
breaks only 7 rounds and has 2^235 time complexity, so ChaCha12's
security margin is still better than AES-256's. Much has been learned
about cryptanalysis of ARX ciphers since Salsa20 was originally designed
in 2005, and it now seems we can be comfortable with a smaller number of
rounds. The eSTREAM project also suggests the 12-round version of
Salsa20 as providing the best balance among the different variants:
combining very good performance with a "comfortable margin of security".
Note that it would be trivial to add vanilla ChaCha12 in addition to
XChaCha12. However, it's unneeded for now and therefore is omitted.
As discussed in the patch that introduced XChaCha20 support, I
considered splitting the code into separate chacha-common, chacha20,
xchacha20, and xchacha12 modules, so that these algorithms could be
enabled/disabled independently. However, since nearly all the code is
shared anyway, I ultimately decided there would have been little benefit
to the added complexity.
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Martin Willi <martin@strongswan.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-11-17 04:26:22 +03:00
} , {
. alg = " xchacha12 " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = __VECS ( xchacha12_tv_template )
} ,
crypto: chacha20-generic - add XChaCha20 support
Add support for the XChaCha20 stream cipher. XChaCha20 is the
application of the XSalsa20 construction
(https://cr.yp.to/snuffle/xsalsa-20081128.pdf) to ChaCha20 rather than
to Salsa20. XChaCha20 extends ChaCha20's nonce length from 64 bits (or
96 bits, depending on convention) to 192 bits, while provably retaining
ChaCha20's security. XChaCha20 uses the ChaCha20 permutation to map the
key and first 128 nonce bits to a 256-bit subkey. Then, it does the
ChaCha20 stream cipher with the subkey and remaining 64 bits of nonce.
We need XChaCha support in order to add support for the Adiantum
encryption mode. Note that to meet our performance requirements, we
actually plan to primarily use the variant XChaCha12. But we believe
it's wise to first add XChaCha20 as a baseline with a higher security
margin, in case there are any situations where it can be used.
Supporting both variants is straightforward.
Since XChaCha20's subkey differs for each request, XChaCha20 can't be a
template that wraps ChaCha20; that would require re-keying the
underlying ChaCha20 for every request, which wouldn't be thread-safe.
Instead, we make XChaCha20 its own top-level algorithm which calls the
ChaCha20 streaming implementation internally.
Similar to the existing ChaCha20 implementation, we define the IV to be
the nonce and stream position concatenated together. This allows users
to seek to any position in the stream.
I considered splitting the code into separate chacha20-common, chacha20,
and xchacha20 modules, so that chacha20 and xchacha20 could be
enabled/disabled independently. However, since nearly all the code is
shared anyway, I ultimately decided there would have been little benefit
to the added complexity of separate modules.
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Martin Willi <martin@strongswan.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-11-17 04:26:20 +03:00
} , {
. alg = " xchacha20 " ,
. test = alg_test_skcipher ,
. suite = {
. cipher = __VECS ( xchacha20_tv_template )
} ,
2008-07-31 13:08:25 +04:00
} , {
. alg = " xts(aes) " ,
2008-08-17 11:01:56 +04:00
. test = alg_test_skcipher ,
2011-01-29 07:14:01 +03:00
. fips_allowed = 1 ,
2008-07-31 13:08:25 +04:00
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( aes_xts_tv_template )
2008-07-31 13:08:25 +04:00
}
2012-03-05 22:26:21 +04:00
} , {
. alg = " xts(camellia) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( camellia_xts_tv_template )
2012-03-05 22:26:21 +04:00
}
2012-07-11 21:38:29 +04:00
} , {
. alg = " xts(cast6) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( cast6_xts_tv_template )
2012-07-11 21:38:29 +04:00
}
2018-05-11 11:04:06 +03:00
} , {
/* Same as xts(aes) except the key is stored in
* hardware secure memory which we reference by index
*/
. alg = " xts(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2011-10-18 14:33:17 +04:00
} , {
. alg = " xts(serpent) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( serpent_xts_tv_template )
2011-10-18 14:33:17 +04:00
}
2011-10-18 14:33:33 +04:00
} , {
. alg = " xts(twofish) " ,
. test = alg_test_skcipher ,
. suite = {
crypto: testmgr - eliminate redundant decryption test vectors
Currently testmgr has separate encryption and decryption test vectors
for symmetric ciphers. That's massively redundant, since with few
exceptions (mostly mistakes, apparently), all decryption tests are
identical to the encryption tests, just with the input/result flipped.
Therefore, eliminate the redundancy by removing the decryption test
vectors and updating testmgr to test both encryption and decryption
using what used to be the encryption test vectors. Naming is adjusted
accordingly: each cipher_testvec now has a 'ptext' (plaintext), 'ctext'
(ciphertext), and 'len' instead of an 'input', 'result', 'ilen', and
'rlen'. Note that it was always the case that 'ilen == rlen'.
AES keywrap ("kw(aes)") is special because its IV is generated by the
encryption. Previously this was handled by specifying 'iv_out' for
encryption and 'iv' for decryption. To make it work cleanly with only
one set of test vectors, put the IV in 'iv', remove 'iv_out', and add a
boolean that indicates that the IV is generated by the encryption.
In total, this removes over 10000 lines from testmgr.h, with no
reduction in test coverage since prior patches already copied the few
unique decryption test vectors into the encryption test vectors.
This covers all algorithms that used 'struct cipher_testvec', e.g. any
block cipher in the ECB, CBC, CTR, XTS, LRW, CTS-CBC, PCBC, OFB, or
keywrap modes, and Salsa20 and ChaCha20. No change is made to AEAD
tests, though we probably can eliminate a similar redundancy there too.
The testmgr.h portion of this patch was automatically generated using
the following awk script, with some slight manual fixups on top (updated
'struct cipher_testvec' definition, updated a few comments, and fixed up
the AES keywrap test vectors):
BEGIN { OTHER = 0; ENCVEC = 1; DECVEC = 2; DECVEC_TAIL = 3; mode = OTHER }
/^static const struct cipher_testvec.*_enc_/ { sub("_enc", ""); mode = ENCVEC }
/^static const struct cipher_testvec.*_dec_/ { mode = DECVEC }
mode == ENCVEC && !/\.ilen[[:space:]]*=/ {
sub(/\.input[[:space:]]*=$/, ".ptext =")
sub(/\.input[[:space:]]*=/, ".ptext\t=")
sub(/\.result[[:space:]]*=$/, ".ctext =")
sub(/\.result[[:space:]]*=/, ".ctext\t=")
sub(/\.rlen[[:space:]]*=/, ".len\t=")
print
}
mode == DECVEC_TAIL && /[^[:space:]]/ { mode = OTHER }
mode == OTHER { print }
mode == ENCVEC && /^};/ { mode = OTHER }
mode == DECVEC && /^};/ { mode = DECVEC_TAIL }
Note that git's default diff algorithm gets confused by the testmgr.h
portion of this patch, and reports too many lines added and removed.
It's better viewed with 'git diff --minimal' (or 'git show --minimal'),
which reports "2 files changed, 919 insertions(+), 11723 deletions(-)".
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2018-05-21 08:50:29 +03:00
. cipher = __VECS ( tf_xts_tv_template )
2011-10-18 14:33:33 +04:00
}
2018-05-11 11:04:06 +03:00
} , {
. alg = " xts4096(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
} , {
. alg = " xts512(paes) " ,
. test = alg_test_null ,
. fips_allowed = 1 ,
2017-04-21 23:54:30 +03:00
} , {
. alg = " zlib-deflate " ,
. test = alg_test_comp ,
. fips_allowed = 1 ,
. suite = {
. comp = {
. comp = __VECS ( zlib_deflate_comp_tv_template ) ,
. decomp = __VECS ( zlib_deflate_decomp_tv_template )
}
}
2018-03-30 22:14:53 +03:00
} , {
. alg = " zstd " ,
. test = alg_test_comp ,
. fips_allowed = 1 ,
. suite = {
. comp = {
. comp = __VECS ( zstd_comp_tv_template ) ,
. decomp = __VECS ( zstd_decomp_tv_template )
}
}
2008-07-31 13:08:25 +04:00
}
} ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
static void alg_check_test_descs_order ( void )
2013-06-13 18:37:40 +04:00
{
int i ;
for ( i = 1 ; i < ARRAY_SIZE ( alg_test_descs ) ; i + + ) {
int diff = strcmp ( alg_test_descs [ i - 1 ] . alg ,
alg_test_descs [ i ] . alg ) ;
if ( WARN_ON ( diff > 0 ) ) {
pr_warn ( " testmgr: alg_test_descs entries in wrong order: '%s' before '%s' \n " ,
alg_test_descs [ i - 1 ] . alg ,
alg_test_descs [ i ] . alg ) ;
}
if ( WARN_ON ( diff = = 0 ) ) {
pr_warn ( " testmgr: duplicate alg_test_descs entry: '%s' \n " ,
alg_test_descs [ i ] . alg ) ;
}
}
}
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
static void alg_check_testvec_configs ( void )
{
2019-02-01 10:51:46 +03:00
int i ;
for ( i = 0 ; i < ARRAY_SIZE ( default_cipher_testvec_configs ) ; i + + )
WARN_ON ( ! valid_testvec_config (
& default_cipher_testvec_configs [ i ] ) ) ;
2019-02-01 10:51:48 +03:00
for ( i = 0 ; i < ARRAY_SIZE ( default_hash_testvec_configs ) ; i + + )
WARN_ON ( ! valid_testvec_config (
& default_hash_testvec_configs [ i ] ) ) ;
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
}
static void testmgr_onetime_init ( void )
{
alg_check_test_descs_order ( ) ;
alg_check_testvec_configs ( ) ;
2019-02-01 10:51:44 +03:00
# ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
pr_warn ( " alg: extra crypto tests enabled. This is intended for developer use only. \n " ) ;
# endif
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
}
2008-08-17 11:01:56 +04:00
static int alg_find_test ( const char * alg )
2008-07-31 13:08:25 +04:00
{
int start = 0 ;
int end = ARRAY_SIZE ( alg_test_descs ) ;
while ( start < end ) {
int i = ( start + end ) / 2 ;
int diff = strcmp ( alg_test_descs [ i ] . alg , alg ) ;
if ( diff > 0 ) {
end = i ;
continue ;
}
if ( diff < 0 ) {
start = i + 1 ;
continue ;
}
2008-08-17 11:01:56 +04:00
return i ;
}
return - 1 ;
}
int alg_test ( const char * driver , const char * alg , u32 type , u32 mask )
{
int i ;
2009-07-02 12:32:12 +04:00
int j ;
2008-10-12 16:36:51 +04:00
int rc ;
2008-08-17 11:01:56 +04:00
2016-05-03 12:00:17 +03:00
if ( ! fips_enabled & & notests ) {
printk_once ( KERN_INFO " alg: self-tests disabled \n " ) ;
return 0 ;
}
crypto: testmgr - add testvec_config struct and helper functions
Crypto algorithms must produce the same output for the same input
regardless of data layout, i.e. how the src and dst scatterlists are
divided into chunks and how each chunk is aligned. Request flags such
as CRYPTO_TFM_REQ_MAY_SLEEP must not affect the result either.
However, testing of this currently has many gaps. For example,
individual algorithms are responsible for providing their own chunked
test vectors. But many don't bother to do this or test only one or two
cases, providing poor test coverage. Also, other things such as
misaligned IVs and CRYPTO_TFM_REQ_MAY_SLEEP are never tested at all.
Test code is also duplicated between the chunked and non-chunked cases,
making it difficult to make other improvements.
To improve the situation, this patch series basically moves the chunk
descriptions into the testmgr itself so that they are shared by all
algorithms. However, it's done in an extensible way via a new struct
'testvec_config', which describes not just the scaled chunk lengths but
also all other aspects of the crypto operation besides the data itself
such as the buffer alignments, the request flags, whether the operation
is in-place or not, the IV alignment, and for hash algorithms when to
do each update() and when to use finup() vs. final() vs. digest().
Then, this patch series makes skcipher, aead, and hash algorithms be
tested against a list of default testvec_configs, replacing the current
test code. This improves overall test coverage, without reducing test
performance too much. Note that the test vectors themselves are not
changed, except for removing the chunk lists.
This series also adds randomized fuzz tests, enabled by a new kconfig
option intended for developer use only, where skcipher, aead, and hash
algorithms are tested against many randomly generated testvec_configs.
This provides much more comprehensive test coverage.
These improved tests have already exposed many bugs.
To start it off, this initial patch adds the testvec_config and various
helper functions that will be used by the skcipher, aead, and hash test
code that will be converted to use the new testvec_config framework.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-02-01 10:51:43 +03:00
DO_ONCE ( testmgr_onetime_init ) ;
2013-06-13 18:37:40 +04:00
2008-08-17 11:01:56 +04:00
if ( ( type & CRYPTO_ALG_TYPE_MASK ) = = CRYPTO_ALG_TYPE_CIPHER ) {
char nalg [ CRYPTO_MAX_ALG_NAME ] ;
if ( snprintf ( nalg , sizeof ( nalg ) , " ecb(%s) " , alg ) > =
sizeof ( nalg ) )
return - ENAMETOOLONG ;
i = alg_find_test ( nalg ) ;
if ( i < 0 )
goto notest ;
2009-05-15 09:17:05 +04:00
if ( fips_enabled & & ! alg_test_descs [ i ] . fips_allowed )
goto non_fips_alg ;
2009-05-04 15:49:23 +04:00
rc = alg_test_cipher ( alg_test_descs + i , driver , type , mask ) ;
goto test_done ;
2008-07-31 13:08:25 +04:00
}
2008-08-17 11:01:56 +04:00
i = alg_find_test ( alg ) ;
2009-07-02 12:32:12 +04:00
j = alg_find_test ( driver ) ;
if ( i < 0 & & j < 0 )
2008-08-17 11:01:56 +04:00
goto notest ;
2009-07-02 12:32:12 +04:00
if ( fips_enabled & & ( ( i > = 0 & & ! alg_test_descs [ i ] . fips_allowed ) | |
( j > = 0 & & ! alg_test_descs [ j ] . fips_allowed ) ) )
2009-05-15 09:17:05 +04:00
goto non_fips_alg ;
2009-07-02 12:32:12 +04:00
rc = 0 ;
if ( i > = 0 )
rc | = alg_test_descs [ i ] . test ( alg_test_descs + i , driver ,
type , mask ) ;
2013-07-18 19:57:07 +04:00
if ( j > = 0 & & j ! = i )
2009-07-02 12:32:12 +04:00
rc | = alg_test_descs [ j ] . test ( alg_test_descs + j , driver ,
type , mask ) ;
2009-05-04 15:49:23 +04:00
test_done :
2019-03-31 23:09:14 +03:00
if ( rc & & ( fips_enabled | | panic_on_fail ) )
panic ( " alg: self-tests for %s (%s) failed in %s mode! \n " ,
driver , alg , fips_enabled ? " fips " : " panic_on_fail " ) ;
2008-10-12 16:36:51 +04:00
2009-05-04 15:51:17 +04:00
if ( fips_enabled & & ! rc )
2014-10-06 19:37:54 +04:00
pr_info ( " alg: self-tests for %s (%s) passed \n " , driver , alg ) ;
2009-05-04 15:51:17 +04:00
2008-10-12 16:36:51 +04:00
return rc ;
2008-08-17 11:01:56 +04:00
notest :
2008-07-31 13:08:25 +04:00
printk ( KERN_INFO " alg: No test for %s (%s) \n " , alg , driver ) ;
return 0 ;
2009-05-15 09:17:05 +04:00
non_fips_alg :
return - EINVAL ;
2008-07-31 13:08:25 +04:00
}
2010-06-03 14:53:43 +04:00
2010-08-06 05:40:28 +04:00
# endif /* CONFIG_CRYPTO_MANAGER_DISABLE_TESTS */
2010-06-03 14:53:43 +04:00
2008-07-31 13:08:25 +04:00
EXPORT_SYMBOL_GPL ( alg_test ) ;